[Lldb-commits] [PATCH] D53917: [lldb] Fix race condition in framework installation

2018-10-30 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
smeenai added a reviewer: xiaobai.
Herald added a subscriber: mgorny.

We need the install-liblldb-stripped target to also depend on the
llvm-framework target in order for the installation to be guaranteed to
behave as intended. I believe this is simply a typo.


https://reviews.llvm.org/D53917

Files:
  cmake/modules/AddLLDB.cmake


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -79,7 +79,7 @@
 # framework, so it must rely on the framework being fully built first.
 if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
   add_dependencies(install-${name} lldb-framework)
-  add_dependencies(install-lldb-framework-stripped lldb-framework)
+  add_dependencies(install-${name}-stripped lldb-framework)
 endif()
   endif()
 endif()


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -79,7 +79,7 @@
 # framework, so it must rely on the framework being fully built first.
 if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
   add_dependencies(install-${name} lldb-framework)
-  add_dependencies(install-lldb-framework-stripped lldb-framework)
+  add_dependencies(install-${name}-stripped lldb-framework)
 endif()
   endif()
 endif()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53917: [lldb] Fix race condition in framework installation

2018-10-31 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345711: [lldb] Fix race condition in framework 
installation (authored by smeenai, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53917?vs=171854&id=171884#toc

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53917

Files:
  cmake/modules/AddLLDB.cmake


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -79,7 +79,7 @@
 # framework, so it must rely on the framework being fully built first.
 if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
   add_dependencies(install-${name} lldb-framework)
-  add_dependencies(install-lldb-framework-stripped lldb-framework)
+  add_dependencies(install-${name}-stripped lldb-framework)
 endif()
   endif()
 endif()


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -79,7 +79,7 @@
 # framework, so it must rely on the framework being fully built first.
 if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
   add_dependencies(install-${name} lldb-framework)
-  add_dependencies(install-lldb-framework-stripped lldb-framework)
+  add_dependencies(install-${name}-stripped lldb-framework)
 endif()
   endif()
 endif()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

2018-06-27 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

This is definitely trivial enough to just go through post-commit review :) (As 
in, just commit it directly without going through Phabricator.)


Repository:
  rL LLVM

https://reviews.llvm.org/D48620



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

2018-08-28 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
smeenai added reviewers: beanz, davide, xiaobai.

GNU sed and BSD sed have a different command-line syntax for in-place
editing, and the current form of the script would only work with BSD
sed. The easiest way to get cross-platform behavior is to specify a
backup suffix and then just delete the backup file at the end. (BSD sed
is the default on macOS, but it's possible to acquire GNU coreutils and
have your `sed` be GNU sed even on macOS; I'm aware it's not officially
supported in any capacity, but it's easy enough to support here.)

An alternative would be using `perl -p -i -e` instead of `sed -i`, but I
figured it was best to make the minimal working change.


https://reviews.llvm.org/D51374

Files:
  scripts/framework-header-fix.sh


Index: scripts/framework-header-fix.sh
===
--- scripts/framework-header-fix.sh
+++ scripts/framework-header-fix.sh
@@ -2,12 +2,13 @@
 # Usage: framework-header-fix.sh  
 for file in `find $1 -name "*.h"`
 do
-  sed -i '' 's/\(#include\)[ ]*"lldb\/\(API\/\)\{0,1\}\(.*\)"/\1 /1' 
"$file"
-  sed -i '' 's|/1' "$file"
+  sed -i.bak 's|Index: scripts/framework-header-fix.sh
===
--- scripts/framework-header-fix.sh
+++ scripts/framework-header-fix.sh
@@ -2,12 +2,13 @@
 # Usage: framework-header-fix.sh  
 for file in `find $1 -name "*.h"`
 do
-  sed -i '' 's/\(#include\)[ ]*"lldb\/\(API\/\)\{0,1\}\(.*\)"/\1 /1' "$file"
-  sed -i '' 's|/1' "$file"
+  sed -i.bak 's|___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

2018-08-28 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340885: [LLDB] Fix script to work with GNU sed (authored 
by smeenai, committed by ).
Herald added a subscriber: abidh.

Changed prior to commit:
  https://reviews.llvm.org/D51374?vs=162928&id=162988#toc

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51374

Files:
  scripts/framework-header-fix.sh


Index: scripts/framework-header-fix.sh
===
--- scripts/framework-header-fix.sh
+++ scripts/framework-header-fix.sh
@@ -2,12 +2,13 @@
 # Usage: framework-header-fix.sh  
 for file in `find $1 -name "*.h"`
 do
-  sed -i '' 's/\(#include\)[ ]*"lldb\/\(API\/\)\{0,1\}\(.*\)"/\1 /1' 
"$file"
-  sed -i '' 's|/1' "$file"
+  sed -i.bak 's|Index: scripts/framework-header-fix.sh
===
--- scripts/framework-header-fix.sh
+++ scripts/framework-header-fix.sh
@@ -2,12 +2,13 @@
 # Usage: framework-header-fix.sh  
 for file in `find $1 -name "*.h"`
 do
-  sed -i '' 's/\(#include\)[ ]*"lldb\/\(API\/\)\{0,1\}\(.*\)"/\1 /1' "$file"
-  sed -i '' 's|/1' "$file"
+  sed -i.bak 's|___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41099: [lldb] Switch to add_llvm_install_targets

2017-12-11 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
Herald added a subscriber: mgorny.

This adds the install-*-stripped targets to LLDB, which are required for
the install-distribution-stripped option. We also need to create some
install-*-stripped targets manually, which are modeled after their
corresponding install-* targets.


https://reviews.llvm.org/D41099

Files:
  cmake/modules/AddLLDB.cmake


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -66,11 +66,8 @@
   ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
   endif()
   if (NOT CMAKE_CONFIGURATION_TYPES)
-add_custom_target(install-${name}
-  DEPENDS ${name}
-  COMMAND "${CMAKE_COMMAND}"
-  -DCMAKE_INSTALL_COMPONENT=${name}
-  -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+add_llvm_install_targets(install-${name}
+ DEPENDS ${name})
   endif()
 endif()
   endif()
@@ -121,6 +118,8 @@
   if(ARG_GENERATE_INSTALL)
 add_custom_target(install-${name} DEPENDS ${name})
 add_dependencies(install-liblldb ${name})
+add_custom_target(install-${name}-stripped DEPENDS ${name})
+add_dependencies(install-liblldb-stripped ${name})
   endif()
 else()
   set_target_properties(${name} PROPERTIES
@@ -134,11 +133,8 @@
   COMPONENT ${name}
   RUNTIME DESTINATION bin)
 if (NOT CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(install-${name}
-DEPENDS ${name}
-COMMAND "${CMAKE_COMMAND}"
--DCMAKE_INSTALL_COMPONENT=${name}
--P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+  add_llvm_install_targets(install-${name}
+   DEPENDS ${name})
 endif()
   endif()
 


Index: cmake/modules/AddLLDB.cmake
===
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -66,11 +66,8 @@
   ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
   endif()
   if (NOT CMAKE_CONFIGURATION_TYPES)
-add_custom_target(install-${name}
-  DEPENDS ${name}
-  COMMAND "${CMAKE_COMMAND}"
-  -DCMAKE_INSTALL_COMPONENT=${name}
-  -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+add_llvm_install_targets(install-${name}
+ DEPENDS ${name})
   endif()
 endif()
   endif()
@@ -121,6 +118,8 @@
   if(ARG_GENERATE_INSTALL)
 add_custom_target(install-${name} DEPENDS ${name})
 add_dependencies(install-liblldb ${name})
+add_custom_target(install-${name}-stripped DEPENDS ${name})
+add_dependencies(install-liblldb-stripped ${name})
   endif()
 else()
   set_target_properties(${name} PROPERTIES
@@ -134,11 +133,8 @@
   COMPONENT ${name}
   RUNTIME DESTINATION bin)
 if (NOT CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(install-${name}
-DEPENDS ${name}
-COMMAND "${CMAKE_COMMAND}"
--DCMAKE_INSTALL_COMPONENT=${name}
--P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+  add_llvm_install_targets(install-${name}
+   DEPENDS ${name})
 endif()
   endif()
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41099: [lldb] Switch to add_llvm_install_targets

2017-12-11 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320443: [lldb] Switch to add_llvm_install_targets (authored 
by smeenai).

Repository:
  rL LLVM

https://reviews.llvm.org/D41099

Files:
  lldb/trunk/cmake/modules/AddLLDB.cmake


Index: lldb/trunk/cmake/modules/AddLLDB.cmake
===
--- lldb/trunk/cmake/modules/AddLLDB.cmake
+++ lldb/trunk/cmake/modules/AddLLDB.cmake
@@ -66,11 +66,8 @@
   ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
   endif()
   if (NOT CMAKE_CONFIGURATION_TYPES)
-add_custom_target(install-${name}
-  DEPENDS ${name}
-  COMMAND "${CMAKE_COMMAND}"
-  -DCMAKE_INSTALL_COMPONENT=${name}
-  -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+add_llvm_install_targets(install-${name}
+ DEPENDS ${name})
   endif()
 endif()
   endif()
@@ -121,6 +118,8 @@
   if(ARG_GENERATE_INSTALL)
 add_custom_target(install-${name} DEPENDS ${name})
 add_dependencies(install-liblldb ${name})
+add_custom_target(install-${name}-stripped DEPENDS ${name})
+add_dependencies(install-liblldb-stripped ${name})
   endif()
 else()
   set_target_properties(${name} PROPERTIES
@@ -134,11 +133,8 @@
   COMPONENT ${name}
   RUNTIME DESTINATION bin)
 if (NOT CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(install-${name}
-DEPENDS ${name}
-COMMAND "${CMAKE_COMMAND}"
--DCMAKE_INSTALL_COMPONENT=${name}
--P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+  add_llvm_install_targets(install-${name}
+   DEPENDS ${name})
 endif()
   endif()
 


Index: lldb/trunk/cmake/modules/AddLLDB.cmake
===
--- lldb/trunk/cmake/modules/AddLLDB.cmake
+++ lldb/trunk/cmake/modules/AddLLDB.cmake
@@ -66,11 +66,8 @@
   ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX})
   endif()
   if (NOT CMAKE_CONFIGURATION_TYPES)
-add_custom_target(install-${name}
-  DEPENDS ${name}
-  COMMAND "${CMAKE_COMMAND}"
-  -DCMAKE_INSTALL_COMPONENT=${name}
-  -P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+add_llvm_install_targets(install-${name}
+ DEPENDS ${name})
   endif()
 endif()
   endif()
@@ -121,6 +118,8 @@
   if(ARG_GENERATE_INSTALL)
 add_custom_target(install-${name} DEPENDS ${name})
 add_dependencies(install-liblldb ${name})
+add_custom_target(install-${name}-stripped DEPENDS ${name})
+add_dependencies(install-liblldb-stripped ${name})
   endif()
 else()
   set_target_properties(${name} PROPERTIES
@@ -134,11 +133,8 @@
   COMPONENT ${name}
   RUNTIME DESTINATION bin)
 if (NOT CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(install-${name}
-DEPENDS ${name}
-COMMAND "${CMAKE_COMMAND}"
--DCMAKE_INSTALL_COMPONENT=${name}
--P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
+  add_llvm_install_targets(install-${name}
+   DEPENDS ${name})
 endif()
   endif()
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

2019-01-28 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

The amount of duplicated and out-of-date documentation makes me sad, but this 
is an awesome effort to clean that up.




Comment at: 
lldb/packages/Python/lldbsuite/test/functionalities/command_source/TestCommandSource.py:4
-
-See also http://llvm.org/viewvc/llvm-project?view=rev&revision=109673.
 """

Would you want to link to the corresponding GitHub commit?



Comment at: 
lldb/packages/Python/lldbsuite/test/lang/objc/objc-optimized/TestObjcOptimized.py:4
 
-http://llvm.org/viewvc/llvm-project?rev=126973&view=rev
 Fixed a bug in the expression parser where the 'this'

Same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57330/new/

https://reviews.llvm.org/D57330



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

2019-01-29 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D57330#1375913 , @mehdi_amini wrote:

> In D57330#1375096 , @labath wrote:
>
> > This is not an full out-of-source build, since the build folder is still a 
> > subfolder of the repo root
>
>
> My definition of what qualify an "out-of-source" build is that the build 
> process won't touch anything outside of the build directory: i.e. the build 
> directory itself is hermetic, self-contained, and can be destroyed without 
> impacting anything else.
>  (I agree with you that polluting `git status` is annoying, and personally I 
> usually have my build directories in parallel with the repo).


You can avoid the `git status` pollution by adding the build directory to 
`.git/info/exclude`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57330/new/

https://reviews.llvm.org/D57330



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

2019-01-29 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D57330#1376069 , @mehdi_amini wrote:

> > You can avoid the git status pollution by adding the build directory to 
> > .git/info/exclude.
>
> Good to know! Should we include this in the doc?


I can put that change up fore review. It probably makes most sense to add it to 
www/get_started.html? There's lots of different places which document building, 
but that seems like the canonical one.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57330/new/

https://reviews.llvm.org/D57330



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

2022-01-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: JDevlieghere.

This doesn't seem like a correct revert.

What command are you using to generate this? `git revert` is what you should be 
using, e.g.

  git revert 640beb38e7710b939b3cfb3f4c54accc694b1d30

You should also edit the commit message afterwards (`git commit --amend`) to 
explain why you're reverting the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116547/new/

https://reviews.llvm.org/D116547

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

2022-01-05 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.
Herald added a subscriber: JDevlieghere.

I believe you landed the wrong commit. 
rG859ebca744e634dcc89a2294ffa41574f947bd62 
 looks 
like the previous versions of this diff, where lots of extraneous changes were 
made. Could you please revert and land the correct commit? Feel free to ask for 
assistance if you need it :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115960/new/

https://reviews.llvm.org/D115960

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

2022-07-22 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D130309#3673365 , @thakis wrote:

> Still broken on windows for me: http://45.33.8.238/win/62911/step_4.txt

Seeing the same errors here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130309/new/

https://reviews.llvm.org/D130309

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

2022-07-27 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D130549#3683423 , @clayborg wrote:

> Ping. This was accepted before but I had Buildbot issues. Those should all be 
> resolved in this updated patch after a revert.

Sorry for the delay. I can confirm this builds correctly for Windows now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130549/new/

https://reviews.llvm.org/D130549

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

2022-07-28 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

FWIW, I've usually seen people just recommit directly instead of going through 
another review. Accepting this since it was already reviewed last time and the 
only changes are buildbot fixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130549/new/

https://reviews.llvm.org/D130549

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

2022-12-07 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

This is breaking our build setup. It causes e.g. the Clang resource headers to 
be installed to `lib64/clang` instead of `lib/clang`. Given this and the other 
breakages, can we revert for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130586/new/

https://reviews.llvm.org/D130586

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

2021-05-25 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a subscriber: sgraenitz.
smeenai added a comment.
This revision is now accepted and ready to land.

Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO.

LGTM. Do you need this to be committed for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103124/new/

https://reviews.llvm.org/D103124

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

2021-05-26 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG969eefd98e0f: [lldb] add LLDB_SKIP_DSYM option (authored by 
rmaz, committed by smeenai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103124/new/

https://reviews.llvm.org/D103124

Files:
  lldb/cmake/modules/AddLLDB.cmake
  lldb/cmake/modules/LLDBConfig.cmake


Index: lldb/cmake/modules/LLDBConfig.cmake
===
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -65,6 +65,7 @@
 option(LLDB_NO_INSTALL_DEFAULT_RPATH "Disable default RPATH settings in 
binaries" OFF)
 option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver for testing 
(Darwin only)." OFF)
 option(LLDB_SKIP_STRIP "Whether to skip stripping of binaries when installing 
lldb." OFF)
+option(LLDB_SKIP_DSYM "Whether to skip generating a dSYM when installing 
lldb." OFF)
 
 if (LLDB_USE_SYSTEM_DEBUGSERVER)
   # The custom target for the system debugserver has no install target, so we
Index: lldb/cmake/modules/AddLLDB.cmake
===
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -276,19 +276,21 @@
   endif()
 
   # Generate dSYM
-  set(dsym_name ${output_name}.dSYM)
-  if(is_framework)
-set(dsym_name ${output_name}.framework.dSYM)
-  endif()
-  if(LLDB_DEBUGINFO_INSTALL_PREFIX)
-# This makes the path absolute, so we must respect DESTDIR.
-set(dsym_name 
"\$ENV\{DESTDIR\}${LLDB_DEBUGINFO_INSTALL_PREFIX}/${dsym_name}")
-  endif()
+  if(NOT LLDB_SKIP_DSYM)
+set(dsym_name ${output_name}.dSYM)
+if(is_framework)
+  set(dsym_name ${output_name}.framework.dSYM)
+endif()
+if(LLDB_DEBUGINFO_INSTALL_PREFIX)
+  # This makes the path absolute, so we must respect DESTDIR.
+  set(dsym_name 
"\$ENV\{DESTDIR\}${LLDB_DEBUGINFO_INSTALL_PREFIX}/${dsym_name}")
+endif()
 
-  set(buildtree_name ${buildtree_dir}/${bundle_subdir}${output_name})
-  install(CODE "message(STATUS \"Externalize debuginfo: ${dsym_name}\")" 
COMPONENT ${name})
-  install(CODE "execute_process(COMMAND xcrun dsymutil -o=${dsym_name} 
${buildtree_name})"
-  COMPONENT ${name})
+set(buildtree_name ${buildtree_dir}/${bundle_subdir}${output_name})
+install(CODE "message(STATUS \"Externalize debuginfo: ${dsym_name}\")" 
COMPONENT ${name})
+install(CODE "execute_process(COMMAND xcrun dsymutil -o=${dsym_name} 
${buildtree_name})"
+COMPONENT ${name})
+  endif()
 
   if(NOT LLDB_SKIP_STRIP)
 # Strip distribution binary with -ST (removing debug symbol table entries 
and


Index: lldb/cmake/modules/LLDBConfig.cmake
===
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -65,6 +65,7 @@
 option(LLDB_NO_INSTALL_DEFAULT_RPATH "Disable default RPATH settings in binaries" OFF)
 option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver for testing (Darwin only)." OFF)
 option(LLDB_SKIP_STRIP "Whether to skip stripping of binaries when installing lldb." OFF)
+option(LLDB_SKIP_DSYM "Whether to skip generating a dSYM when installing lldb." OFF)
 
 if (LLDB_USE_SYSTEM_DEBUGSERVER)
   # The custom target for the system debugserver has no install target, so we
Index: lldb/cmake/modules/AddLLDB.cmake
===
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -276,19 +276,21 @@
   endif()
 
   # Generate dSYM
-  set(dsym_name ${output_name}.dSYM)
-  if(is_framework)
-set(dsym_name ${output_name}.framework.dSYM)
-  endif()
-  if(LLDB_DEBUGINFO_INSTALL_PREFIX)
-# This makes the path absolute, so we must respect DESTDIR.
-set(dsym_name "\$ENV\{DESTDIR\}${LLDB_DEBUGINFO_INSTALL_PREFIX}/${dsym_name}")
-  endif()
+  if(NOT LLDB_SKIP_DSYM)
+set(dsym_name ${output_name}.dSYM)
+if(is_framework)
+  set(dsym_name ${output_name}.framework.dSYM)
+endif()
+if(LLDB_DEBUGINFO_INSTALL_PREFIX)
+  # This makes the path absolute, so we must respect DESTDIR.
+  set(dsym_name "\$ENV\{DESTDIR\}${LLDB_DEBUGINFO_INSTALL_PREFIX}/${dsym_name}")
+endif()
 
-  set(buildtree_name ${buildtree_dir}/${bundle_subdir}${output_name})
-  install(CODE "message(STATUS \"Externalize debuginfo: ${dsym_name}\")" COMPONENT ${name})
-  install(CODE "execute_process(COMMAND xcrun dsymutil -o=${dsym_name} ${buildtree_name})"
-  COMPONENT ${name})
+set(buildtree_name ${buildtree_dir}/${bundle_subdir}${output_name})
+install(CODE "message(STATUS \"Externalize debuginfo: ${dsym_name}\")" COMPONENT ${name})
+install(CODE "execute_process(COMMAND xcrun dsymutil -o=${dsym_name} ${buildtree_name})"
+COMPONENT ${name})
+  endif()
 
   if(NOT LLDB_SKIP_STRIP)
 # Strip distribution binary with -ST (removing debug

[Lldb-commits] [PATCH] D74996: [arcconfig] Delete subproject arcconfigs

2020-02-23 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
smeenai added reviewers: jyknight, phosek, rnk.
Herald added a reviewer: bollu.
Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, LLVM.
Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, 
lldb-commits, Sanitizers, cfe-commits.

>From 
>https://secure.phabricator.com/book/phabricator/article/arcanist_new_project/:

> An .arcconfig file is a JSON file which you check into your project's root.

I've done some experimentation, and it looks like the subproject
.arcconfigs just get ignored, as the documentation says. Given that
we're fully on the monorepo now, it's safe to remove them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74996

Files:
  clang-tools-extra/.arcconfig
  clang/.arcconfig
  compiler-rt/.arcconfig
  debuginfo-tests/.arcconfig
  libcxx/.arcconfig
  libcxxabi/.arcconfig
  libunwind/.arcconfig
  lld/.arcconfig
  lldb/.arcconfig
  llvm/.arcconfig
  openmp/.arcconfig
  parallel-libs/.arcconfig
  polly/.arcconfig
  pstl/.arcconfig

Index: pstl/.arcconfig
===
--- pstl/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "PSTL", 
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: polly/.arcconfig
===
--- polly/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "PLO",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: parallel-libs/.arcconfig
===
--- parallel-libs/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "project_id" : "parallel-libs",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: openmp/.arcconfig
===
--- openmp/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "OMP",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: llvm/.arcconfig
===
--- llvm/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "L",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: lldb/.arcconfig
===
--- lldb/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "project_id" : "lldb",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: lld/.arcconfig
===
--- lld/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "LLD",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libunwind/.arcconfig
===
--- libunwind/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "UNW",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libcxxabi/.arcconfig
===
--- libcxxabi/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CXXA",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libcxx/.arcconfig
===
--- libcxx/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CXX",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: debuginfo-tests/.arcconfig
===
--- debuginfo-tests/.arcconfig
+++ /dev/null
@@ -1,3 +0,0 @@
-{
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: compiler-rt/.arcconfig
===
--- compiler-rt/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CRT",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: clang/.arcconfig
===
--- clang/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "C",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: clang-tools-extra/.arcconfig
===
--- clang-tools-extra/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CTE",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D74996: [arcconfig] Delete subproject arcconfigs

2020-02-24 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs 
(authored by smeenai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74996/new/

https://reviews.llvm.org/D74996

Files:
  clang-tools-extra/.arcconfig
  clang/.arcconfig
  compiler-rt/.arcconfig
  debuginfo-tests/.arcconfig
  libcxx/.arcconfig
  libcxxabi/.arcconfig
  libunwind/.arcconfig
  lld/.arcconfig
  lldb/.arcconfig
  llvm/.arcconfig
  openmp/.arcconfig
  parallel-libs/.arcconfig
  polly/.arcconfig
  pstl/.arcconfig

Index: pstl/.arcconfig
===
--- pstl/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "PSTL", 
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: polly/.arcconfig
===
--- polly/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "PLO",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: parallel-libs/.arcconfig
===
--- parallel-libs/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "project_id" : "parallel-libs",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: openmp/.arcconfig
===
--- openmp/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "OMP",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: llvm/.arcconfig
===
--- llvm/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "L",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: lldb/.arcconfig
===
--- lldb/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "project_id" : "lldb",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: lld/.arcconfig
===
--- lld/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "LLD",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libunwind/.arcconfig
===
--- libunwind/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "UNW",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libcxxabi/.arcconfig
===
--- libcxxabi/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CXXA",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: libcxx/.arcconfig
===
--- libcxx/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CXX",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: debuginfo-tests/.arcconfig
===
--- debuginfo-tests/.arcconfig
+++ /dev/null
@@ -1,3 +0,0 @@
-{
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: compiler-rt/.arcconfig
===
--- compiler-rt/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CRT",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: clang/.arcconfig
===
--- clang/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "C",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
Index: clang-tools-extra/.arcconfig
===
--- clang-tools-extra/.arcconfig
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "repository.callsign" : "CTE",
-  "conduit_uri" : "https://reviews.llvm.org/";
-}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

2021-02-22 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

My understanding of the issue is that, with the runtimes build, the `cxx` 
target will get created after we process LLDB's build files. The `TARGET cxx` 
check here will therefore fail, but the `cxx` target will end up existing 
later, and CMake is perfectly fine adding a dependency to a target that gets 
created later, so the failing check is spurious. The `libcxx IN_LIST 
LLVM_ENABLE_RUNTIMES` is basically a proxy for "the `cxx` target doesn't exist 
right now but will exist later". Could you add an explanation of the issue to 
the summary or the code comment?

(Note that if you change a commit message locally, `arc diff` won't update the 
summary of this review by default ... you'll need `arc diff --verbatim` to make 
it update the summary.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97227/new/

https://reviews.llvm.org/D97227

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

2021-02-22 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM. Do you have commit access?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97227/new/

https://reviews.llvm.org/D97227

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

2021-02-22 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG389955c69a3b: [lldb] add check for libcxx runtime (authored 
by rmaz, committed by smeenai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97227/new/

https://reviews.llvm.org/D97227

Files:
  lldb/test/CMakeLists.txt


Index: lldb/test/CMakeLists.txt
===
--- lldb/test/CMakeLists.txt
+++ lldb/test/CMakeLists.txt
@@ -106,7 +106,7 @@
 else()
   # We require libcxx for the test suite, so if we aren't building it,
   # try to provide a helpful error about how to resolve the situation.
-  if(NOT TARGET cxx)
+  if(NOT TARGET cxx AND NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
 if(LLVM_ENABLE_PROJECTS STREQUAL "")
   # If `LLVM_ENABLE_PROJECTS` is not being used (implying that we are
   # using the old layout), suggest checking it out.
@@ -118,8 +118,9 @@
   # If `LLVM_ENABLE_PROJECTS` is being used, suggest adding it.
   message(FATAL_ERROR
 "LLDB test suite requires libc++, but it is currently disabled. "
-"Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or disable tests "
-"via `LLDB_INCLUDE_TESTS=OFF`.")
+"Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or "
+"`LLVM_ENABLE_RUNTIMES`, or disable tests via "
+"`LLDB_INCLUDE_TESTS=OFF`.")
 endif()
   endif()
   add_lldb_test_dependency(cxx)


Index: lldb/test/CMakeLists.txt
===
--- lldb/test/CMakeLists.txt
+++ lldb/test/CMakeLists.txt
@@ -106,7 +106,7 @@
 else()
   # We require libcxx for the test suite, so if we aren't building it,
   # try to provide a helpful error about how to resolve the situation.
-  if(NOT TARGET cxx)
+  if(NOT TARGET cxx AND NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
 if(LLVM_ENABLE_PROJECTS STREQUAL "")
   # If `LLVM_ENABLE_PROJECTS` is not being used (implying that we are
   # using the old layout), suggest checking it out.
@@ -118,8 +118,9 @@
   # If `LLVM_ENABLE_PROJECTS` is being used, suggest adding it.
   message(FATAL_ERROR
 "LLDB test suite requires libc++, but it is currently disabled. "
-"Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or disable tests "
-"via `LLDB_INCLUDE_TESTS=OFF`.")
+"Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or "
+"`LLVM_ENABLE_RUNTIMES`, or disable tests via "
+"`LLDB_INCLUDE_TESTS=OFF`.")
 endif()
   endif()
   add_lldb_test_dependency(cxx)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

2021-02-26 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added inline comments.



Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147
+  add_custom_command(TARGET liblldb POST_BUILD
+COMMAND ${CMAKE_COMMAND} -E create_symlink
+Versions/Current/XPCServices
+${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
+COMMENT "LLDB.framework: create symlink XPCServices"
+  )

This bit appears to have been introduced by this revision, without any 
equivalent existing before. This is causing issues for us when we build an LLDB 
framework in LLVM 12, because `Versions/Current/XPCServices` doesn't exist, so 
the created symlink is dangling. Is there some other target which should be 
creating that directory? (This is the only instance of `XPCServices` I see in 
LLDB's build.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85770/new/

https://reviews.llvm.org/D85770

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

2021-03-01 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
smeenai added reviewers: vsk, JDevlieghere.
Herald added a subscriber: mgorny.
smeenai requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This is a downstream change that was accidentally included upstream.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97701

Files:
  lldb/cmake/modules/LLDBFramework.cmake


Index: lldb/cmake/modules/LLDBFramework.cmake
===
--- lldb/cmake/modules/LLDBFramework.cmake
+++ lldb/cmake/modules/LLDBFramework.cmake
@@ -124,16 +124,6 @@
   )
 endif()
 
-# IOS framework bundles are flat
-if(NOT APPLE_EMBEDDED)
-  add_custom_command(TARGET liblldb POST_BUILD
-COMMAND ${CMAKE_COMMAND} -E create_symlink
-Versions/Current/XPCServices
-${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
-COMMENT "LLDB.framework: create symlink XPCServices"
-  )
-endif()
-
 # Add an rpath pointing to the directory where LLDB.framework is installed.
 # This allows frameworks (relying on @rpath) to be installed in the same 
folder and found at runtime.
 set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH


Index: lldb/cmake/modules/LLDBFramework.cmake
===
--- lldb/cmake/modules/LLDBFramework.cmake
+++ lldb/cmake/modules/LLDBFramework.cmake
@@ -124,16 +124,6 @@
   )
 endif()
 
-# IOS framework bundles are flat
-if(NOT APPLE_EMBEDDED)
-  add_custom_command(TARGET liblldb POST_BUILD
-COMMAND ${CMAKE_COMMAND} -E create_symlink
-Versions/Current/XPCServices
-${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
-COMMENT "LLDB.framework: create symlink XPCServices"
-  )
-endif()
-
 # Add an rpath pointing to the directory where LLDB.framework is installed.
 # This allows frameworks (relying on @rpath) to be installed in the same folder and found at runtime.
 set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

2021-03-01 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added inline comments.



Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147
+  add_custom_command(TARGET liblldb POST_BUILD
+COMMAND ${CMAKE_COMMAND} -E create_symlink
+Versions/Current/XPCServices
+${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
+COMMENT "LLDB.framework: create symlink XPCServices"
+  )

vsk wrote:
> smeenai wrote:
> > This bit appears to have been introduced by this revision, without any 
> > equivalent existing before. This is causing issues for us when we build an 
> > LLDB framework in LLVM 12, because `Versions/Current/XPCServices` doesn't 
> > exist, so the created symlink is dangling. Is there some other target which 
> > should be creating that directory? (This is the only instance of 
> > `XPCServices` I see in LLDB's build.)
> Thanks for catching this. I'm curious how you spotted this. It looks like we 
> do have a target that sets up this directory, but that it's not upstream. It 
> should be safe to remove this; we can reapply the change downstream if that 
> happens.
There's a part of our build/distribution infrastructure which checksums the 
built directory, and it failed for LLVM 12 because it tried to follow the 
dangling symlink. I put up D97701 to remove this; thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85770/new/

https://reviews.llvm.org/D85770

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

2021-03-01 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG015d78a25e51: [lldb] Remove XPCServices symlinking (authored 
by smeenai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97701/new/

https://reviews.llvm.org/D97701

Files:
  lldb/cmake/modules/LLDBFramework.cmake


Index: lldb/cmake/modules/LLDBFramework.cmake
===
--- lldb/cmake/modules/LLDBFramework.cmake
+++ lldb/cmake/modules/LLDBFramework.cmake
@@ -124,16 +124,6 @@
   )
 endif()
 
-# IOS framework bundles are flat
-if(NOT APPLE_EMBEDDED)
-  add_custom_command(TARGET liblldb POST_BUILD
-COMMAND ${CMAKE_COMMAND} -E create_symlink
-Versions/Current/XPCServices
-${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
-COMMENT "LLDB.framework: create symlink XPCServices"
-  )
-endif()
-
 # Add an rpath pointing to the directory where LLDB.framework is installed.
 # This allows frameworks (relying on @rpath) to be installed in the same 
folder and found at runtime.
 set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH


Index: lldb/cmake/modules/LLDBFramework.cmake
===
--- lldb/cmake/modules/LLDBFramework.cmake
+++ lldb/cmake/modules/LLDBFramework.cmake
@@ -124,16 +124,6 @@
   )
 endif()
 
-# IOS framework bundles are flat
-if(NOT APPLE_EMBEDDED)
-  add_custom_command(TARGET liblldb POST_BUILD
-COMMAND ${CMAKE_COMMAND} -E create_symlink
-Versions/Current/XPCServices
-${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
-COMMENT "LLDB.framework: create symlink XPCServices"
-  )
-endif()
-
 # Add an rpath pointing to the directory where LLDB.framework is installed.
 # This allows frameworks (relying on @rpath) to be installed in the same folder and found at runtime.
 set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

2021-03-02 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

Is this rebased on main? The LLD for Mach-O changes look like they belong to a 
different diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97786/new/

https://reviews.llvm.org/D97786

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D102889: [lldb] Match test dependencies name to other LLVM projects.

2021-05-21 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5e327785da36: [lldb] Match test dependencies name to other 
LLVM projects. (authored by drodriguez, committed by smeenai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102889/new/

https://reviews.llvm.org/D102889

Files:
  lldb/test/API/CMakeLists.txt
  lldb/test/CMakeLists.txt
  lldb/test/Shell/CMakeLists.txt
  lldb/test/Unit/CMakeLists.txt
  lldb/utils/lldb-dotest/CMakeLists.txt
  lldb/utils/lldb-repro/CMakeLists.txt

Index: lldb/utils/lldb-repro/CMakeLists.txt
===
--- lldb/utils/lldb-repro/CMakeLists.txt
+++ lldb/utils/lldb-repro/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_custom_target(lldb-repro)
-add_dependencies(lldb-repro lldb-test-deps)
+add_dependencies(lldb-repro lldb-test-depends)
 set_target_properties(lldb-repro PROPERTIES FOLDER "lldb utils")
 
 # Generate lldb-repro Python script for each build mode.
Index: lldb/utils/lldb-dotest/CMakeLists.txt
===
--- lldb/utils/lldb-dotest/CMakeLists.txt
+++ lldb/utils/lldb-dotest/CMakeLists.txt
@@ -1,6 +1,6 @@
 # Make lldb-dotest a custom target.
 add_custom_target(lldb-dotest)
-add_dependencies(lldb-dotest lldb-test-deps)
+add_dependencies(lldb-dotest lldb-test-depends)
 set_target_properties(lldb-dotest PROPERTIES FOLDER "lldb utils")
 
 get_property(LLDB_DOTEST_ARGS GLOBAL PROPERTY LLDB_DOTEST_ARGS_PROPERTY)
Index: lldb/test/Unit/CMakeLists.txt
===
--- lldb/test/Unit/CMakeLists.txt
+++ lldb/test/Unit/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_custom_target(lldb-unit-test-deps)
-add_dependencies(lldb-unit-test-deps lldb-test-deps)
+add_dependencies(lldb-unit-test-deps lldb-test-depends)
 
 add_lit_testsuites(LLDB-UNIT
   ${CMAKE_CURRENT_SOURCE_DIR}
Index: lldb/test/Shell/CMakeLists.txt
===
--- lldb/test/Shell/CMakeLists.txt
+++ lldb/test/Shell/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_custom_target(lldb-shell-test-deps)
-add_dependencies(lldb-shell-test-deps lldb-test-deps)
+add_dependencies(lldb-shell-test-deps lldb-test-depends)
 
 add_lit_testsuites(LLDB-SHELL
   ${CMAKE_CURRENT_SOURCE_DIR}
Index: lldb/test/CMakeLists.txt
===
--- lldb/test/CMakeLists.txt
+++ lldb/test/CMakeLists.txt
@@ -31,12 +31,16 @@
 string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TOOLS_DIR ${LLVM_RUNTIME_OUTPUT_INTDIR})
 
 # Create a custom target to track test dependencies.
+add_custom_target(lldb-test-depends)
+set_target_properties(lldb-test-depends PROPERTIES FOLDER "lldb misc")
+
+# Create an alias for the legacy name of lldb-test-depends
 add_custom_target(lldb-test-deps)
-set_target_properties(lldb-test-deps PROPERTIES FOLDER "lldb misc")
+add_dependencies(lldb-test-deps lldb-test-depends)
 
 function(add_lldb_test_dependency)
   foreach(dependency ${ARGN})
-add_dependencies(lldb-test-deps ${dependency})
+add_dependencies(lldb-test-depends ${dependency})
   endforeach()
 endfunction(add_lldb_test_dependency)
 
@@ -201,7 +205,7 @@
   ${CMAKE_CURRENT_BINARY_DIR}/Shell
   PARAMS "lldb-run-with-repro=capture"
   EXCLUDE_FROM_CHECK_ALL
-  DEPENDS lldb-test-deps)
+  DEPENDS lldb-test-depends)
 
 # Add a lit test suite that runs the API & shell test by replaying a
 # reproducer.
@@ -211,7 +215,7 @@
   ${CMAKE_CURRENT_BINARY_DIR}/Shell
   PARAMS "lldb-run-with-repro=replay"
   EXCLUDE_FROM_CHECK_ALL
-  DEPENDS lldb-test-deps)
+  DEPENDS lldb-test-depends)
 add_dependencies(check-lldb-reproducers check-lldb-reproducers-capture)
 
 if(LLDB_BUILT_STANDALONE)
Index: lldb/test/API/CMakeLists.txt
===
--- lldb/test/API/CMakeLists.txt
+++ lldb/test/API/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_custom_target(lldb-api-test-deps)
-add_dependencies(lldb-api-test-deps lldb-test-deps)
+add_dependencies(lldb-api-test-deps lldb-test-depends)
 
 add_lit_testsuites(LLDB-API
   ${CMAKE_CURRENT_SOURCE_DIR}
@@ -17,7 +17,7 @@
 COMMENT "${comment}"
 USES_TERMINAL
 )
-  add_dependencies(${name} lldb-test-deps)
+  add_dependencies(${name} lldb-test-depends)
 endfunction()
 
 # The default architecture with which to compile test executables is the
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai updated this revision to Diff 188988.
smeenai added a comment.

Release notes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58791/new/

https://reviews.llvm.org/D58791

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/test/CMakeLists.txt
  clang/cmake/caches/Apple-stage2.cmake
  clang/cmake/caches/BaremetalARM.cmake
  clang/cmake/caches/DistributionExample-stage2.cmake
  clang/cmake/caches/Fuchsia-stage2.cmake
  clang/cmake/modules/AddClang.cmake
  clang/docs/LibTooling.rst
  clang/docs/ReleaseNotes.rst
  clang/examples/clang-interpreter/CMakeLists.txt
  clang/lib/Headers/CMakeLists.txt
  clang/test/CMakeLists.txt
  clang/tools/driver/CMakeLists.txt
  clang/tools/libclang/CMakeLists.txt
  compiler-rt/test/CMakeLists.txt
  lldb/cmake/modules/LLDBFramework.cmake
  lldb/lldb.xcodeproj/project.pbxproj
  lldb/scripts/Xcode/package-clang-headers.py
  lldb/scripts/Xcode/package-clang-resource-headers.py
  llvm/docs/Docker.rst
  llvm/runtimes/CMakeLists.txt
  llvm/utils/docker/build_docker_image.sh
  openmp/cmake/OpenMPTesting.cmake

Index: openmp/cmake/OpenMPTesting.cmake
===
--- openmp/cmake/OpenMPTesting.cmake
+++ openmp/cmake/OpenMPTesting.cmake
@@ -167,7 +167,7 @@
 add_lit_testsuite(${target}
   ${comment}
   ${ARG_UNPARSED_ARGUMENTS}
-  DEPENDS clang clang-headers FileCheck ${ARG_DEPENDS}
+  DEPENDS clang clang-resource-headers FileCheck ${ARG_DEPENDS}
   ARGS ${ARG_ARGS}
 )
   endif()
Index: llvm/utils/docker/build_docker_image.sh
===
--- llvm/utils/docker/build_docker_image.sh
+++ llvm/utils/docker/build_docker_image.sh
@@ -55,7 +55,7 @@
 
 For example, running:
 $ build_docker_image.sh -s debian8 -d mydocker/debian8-clang -t latest \ 
-  -p clang -i install-clang -i install-clang-headers
+  -p clang -i install-clang -i install-clang-resource-headers
 will produce two docker images:
 mydocker/debian8-clang-build:latest - an intermediate image used to compile
   clang.
@@ -66,12 +66,12 @@
 
 To get a 2-stage clang build, you could use this command:
 $ ./build_docker_image.sh -s debian8 -d mydocker/clang-debian8 -t "latest" \ 
--p clang -i stage2-install-clang -i stage2-install-clang-headers \ 
+-p clang -i stage2-install-clang -i stage2-install-clang-resource-headers \ 
 -- \ 
 -DLLVM_TARGETS_TO_BUILD=Native -DCMAKE_BUILD_TYPE=Release \ 
 -DBOOTSTRAP_CMAKE_BUILD_TYPE=Release \ 
 -DCLANG_ENABLE_BOOTSTRAP=ON \ 
--DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-headers"
+-DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-resource-headers"
 EOF
 }
 
Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -273,11 +273,11 @@
   if(compiler_rt_path)
 if(NOT LLVM_BUILTIN_TARGETS)
   builtin_default_target(${compiler_rt_path}
-DEPENDS clang-headers)
+DEPENDS clang-resource-headers)
 else()
   if("default" IN_LIST LLVM_BUILTIN_TARGETS)
 builtin_default_target(${compiler_rt_path}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 list(REMOVE_ITEM LLVM_BUILTIN_TARGETS "default")
   else()
 add_custom_target(builtins)
@@ -287,7 +287,7 @@
 
   foreach(target ${LLVM_BUILTIN_TARGETS})
 builtin_register_target(${compiler_rt_path} ${target}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 
 add_dependencies(builtins builtins-${target})
 add_dependencies(install-builtins install-builtins-${target})
Index: llvm/docs/Docker.rst
===
--- llvm/docs/Docker.rst
+++ llvm/docs/Docker.rst
@@ -79,7 +79,7 @@
 ./llvm/utils/docker/build_docker_image.sh \
 	--source debian8 \
 	--docker-repository clang-debian8 --docker-tag "staging" \
-	-p clang -i install-clang -i install-clang-headers \
+	-p clang -i install-clang -i install-clang-resource-headers \
 	-- \
 	-DCMAKE_BUILD_TYPE=Release
 
@@ -95,11 +95,11 @@
 ./build_docker_image.sh \
 	--source debian8 \
 	--docker-repository clang-debian8 --docker-tag "staging" \
-	-p clang -i stage2-install-clang -i stage2-install-clang-headers \
+	-p clang -i stage2-install-clang -i stage2-install-clang-resource-headers \
 	-- \
 	-DLLVM_TARGETS_TO_BUILD=Native -DCMAKE_BUILD_TYPE=Release \
 	-DBOOTSTRAP_CMAKE_BUILD_TYPE=Release \
-	-DCLANG_ENABLE_BOOTSTRAP=ON -DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-headers"
+	-DCLANG_ENABLE_BOOTSTRAP=ON -DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-resource-headers"
 	
 This will produce a new image ``clang-debian8:staging`` from the latest
 upstream revision.
@@ -165,7 +165,7 @@
 ./llvm/utils/docker/build_docker_image.sh \
 	-s

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D58791#1415496 , @tstellar wrote:

> This looks good, but could you also add an entry in the ReleaseNotes for this.


Will do – thanks for the reminder :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58791/new/

https://reviews.llvm.org/D58791



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL355340: [build] Rename clang-headers to 
clang-resource-headers (authored by smeenai, committed by ).
Herald added a subscriber: delcypher.

Changed prior to commit:
  https://reviews.llvm.org/D58791?vs=189014&id=189195#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58791/new/

https://reviews.llvm.org/D58791

Files:
  cfe/trunk/cmake/caches/Apple-stage2.cmake
  cfe/trunk/cmake/caches/BaremetalARM.cmake
  cfe/trunk/cmake/caches/DistributionExample-stage2.cmake
  cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
  cfe/trunk/cmake/modules/AddClang.cmake
  cfe/trunk/docs/LibTooling.rst
  cfe/trunk/docs/ReleaseNotes.rst
  cfe/trunk/examples/clang-interpreter/CMakeLists.txt
  cfe/trunk/lib/Headers/CMakeLists.txt
  cfe/trunk/test/CMakeLists.txt
  cfe/trunk/tools/driver/CMakeLists.txt
  cfe/trunk/tools/libclang/CMakeLists.txt
  clang-tools-extra/trunk/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/trunk/test/CMakeLists.txt
  compiler-rt/trunk/test/CMakeLists.txt
  lldb/trunk/cmake/modules/LLDBFramework.cmake
  lldb/trunk/lldb.xcodeproj/project.pbxproj
  lldb/trunk/scripts/Xcode/package-clang-headers.py
  lldb/trunk/scripts/Xcode/package-clang-resource-headers.py
  lldb/trunk/source/API/CMakeLists.txt
  llvm/trunk/docs/Docker.rst
  llvm/trunk/runtimes/CMakeLists.txt
  llvm/trunk/utils/docker/build_docker_image.sh
  openmp/trunk/cmake/OpenMPTesting.cmake

Index: cfe/trunk/cmake/modules/AddClang.cmake
===
--- cfe/trunk/cmake/modules/AddClang.cmake
+++ cfe/trunk/cmake/modules/AddClang.cmake
@@ -133,7 +133,7 @@
   endif()
 
   add_clang_executable(${name} ${ARGN})
-  add_dependencies(${name} clang-headers)
+  add_dependencies(${name} clang-resource-headers)
 
   if (CLANG_BUILD_TOOLS)
 if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
Index: cfe/trunk/cmake/caches/BaremetalARM.cmake
===
--- cfe/trunk/cmake/caches/BaremetalARM.cmake
+++ cfe/trunk/cmake/caches/BaremetalARM.cmake
@@ -41,7 +41,7 @@
 set(LLVM_DISTRIBUTION_COMPONENTS
   clang
   lld
-  clang-headers
+  clang-resource-headers
   builtins-armv6m-none-eabi
   builtins-armv7m-none-eabi
   builtins-armv7em-none-eabi
Index: cfe/trunk/cmake/caches/Apple-stage2.cmake
===
--- cfe/trunk/cmake/caches/Apple-stage2.cmake
+++ cfe/trunk/cmake/caches/Apple-stage2.cmake
@@ -60,7 +60,7 @@
   clang
   LTO
   clang-format
-  clang-headers
+  clang-resource-headers
   cxx-headers
   ${LLVM_TOOLCHAIN_TOOLS}
   CACHE STRING "")
Index: cfe/trunk/cmake/caches/DistributionExample-stage2.cmake
===
--- cfe/trunk/cmake/caches/DistributionExample-stage2.cmake
+++ cfe/trunk/cmake/caches/DistributionExample-stage2.cmake
@@ -23,7 +23,7 @@
   clang
   LTO
   clang-format
-  clang-headers
+  clang-resource-headers
   builtins
   runtimes
   ${LLVM_TOOLCHAIN_TOOLS}
Index: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
===
--- cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
+++ cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
@@ -167,7 +167,7 @@
   LTO
   clang-apply-replacements
   clang-format
-  clang-headers
+  clang-resource-headers
   clang-include-fixer
   clang-refactor
   clang-tidy
Index: cfe/trunk/test/CMakeLists.txt
===
--- cfe/trunk/test/CMakeLists.txt
+++ cfe/trunk/test/CMakeLists.txt
@@ -46,7 +46,7 @@
 endif ()
 
 list(APPEND CLANG_TEST_DEPS
-  clang clang-headers
+  clang clang-resource-headers
   clang-format
   c-index-test diagtool
   clang-tblgen
Index: cfe/trunk/examples/clang-interpreter/CMakeLists.txt
===
--- cfe/trunk/examples/clang-interpreter/CMakeLists.txt
+++ cfe/trunk/examples/clang-interpreter/CMakeLists.txt
@@ -16,7 +16,7 @@
   )
 
 add_dependencies(clang-interpreter
-  clang-headers
+  clang-resource-headers
   )
 
 target_link_libraries(clang-interpreter
Index: cfe/trunk/lib/Headers/CMakeLists.txt
===
--- cfe/trunk/lib/Headers/CMakeLists.txt
+++ cfe/trunk/lib/Headers/CMakeLists.txt
@@ -157,8 +157,8 @@
 # Generate arm_fp16.h
 clang_generate_header(-gen-arm-fp16 arm_fp16.td arm_fp16.h)
 
-add_custom_target(clang-headers ALL DEPENDS ${out_files})
-set_target_properties(clang-headers PROPERTIES
+add_custom_target(clang-resource-headers ALL DEPENDS ${out_files})
+set_target_properties(clang-resource-headers PROPERTIES
   FOLDER "Misc"
   RUNTIME_OUTPUT_DIRECTORY "${output_dir}")
 
@@ -167,10 +167,10 @@
 install(
   DIRECTORY ${output_dir}
   DESTINATION ${header_install_dir}
-  COMPONENT clang-headers)
+  COMPONENT clang-resource-headers)
 
 if (N

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

I added an entry to the release notes. The release notes change only covers the 
changes in this diff. My plan is to land this, wait for a few days (so that 
users of the target get broken in an obvious way), and then add the new 
install-clang-headers target (for installing the API headers); I'll update the 
release notes again as part of that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58791/new/

https://reviews.llvm.org/D58791



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai created this revision.
smeenai added reviewers: beanz, phosek, tstellar, rnk, dim.
Herald added subscribers: openmp-commits, Sanitizers, jdoerfert, javed.absar, 
mgorny.
Herald added a reviewer: serge-sans-paille.
Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM.

The current install-clang-headers target installs clang's resource
directory headers. This is different from the install-llvm-headers
target, which installs LLVM's API headers. We want to introduce the
corresponding target to clang, and the natural name for that new target
would be install-clang-headers. Rename the existing target to
install-clang-resource-headers to free up the install-clang-headers name
for the new target, following the discussion on cfe-dev [1].

I didn't find any bots on zorg referencing install-clang-headers. I'll
send out another PSA to cfe-dev to accompany this rename.

[1] http://lists.llvm.org/pipermail/cfe-dev/2019-February/061365.html


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58791

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/test/CMakeLists.txt
  clang/cmake/caches/Apple-stage2.cmake
  clang/cmake/caches/BaremetalARM.cmake
  clang/cmake/caches/DistributionExample-stage2.cmake
  clang/cmake/caches/Fuchsia-stage2.cmake
  clang/cmake/modules/AddClang.cmake
  clang/docs/LibTooling.rst
  clang/examples/clang-interpreter/CMakeLists.txt
  clang/lib/Headers/CMakeLists.txt
  clang/test/CMakeLists.txt
  clang/tools/driver/CMakeLists.txt
  clang/tools/libclang/CMakeLists.txt
  compiler-rt/test/CMakeLists.txt
  lldb/cmake/modules/LLDBFramework.cmake
  lldb/lldb.xcodeproj/project.pbxproj
  lldb/scripts/Xcode/package-clang-headers.py
  lldb/scripts/Xcode/package-clang-resource-headers.py
  llvm/docs/Docker.rst
  llvm/runtimes/CMakeLists.txt
  llvm/utils/docker/build_docker_image.sh
  openmp/cmake/OpenMPTesting.cmake

Index: openmp/cmake/OpenMPTesting.cmake
===
--- openmp/cmake/OpenMPTesting.cmake
+++ openmp/cmake/OpenMPTesting.cmake
@@ -167,7 +167,7 @@
 add_lit_testsuite(${target}
   ${comment}
   ${ARG_UNPARSED_ARGUMENTS}
-  DEPENDS clang clang-headers FileCheck ${ARG_DEPENDS}
+  DEPENDS clang clang-resource-headers FileCheck ${ARG_DEPENDS}
   ARGS ${ARG_ARGS}
 )
   endif()
Index: llvm/utils/docker/build_docker_image.sh
===
--- llvm/utils/docker/build_docker_image.sh
+++ llvm/utils/docker/build_docker_image.sh
@@ -55,7 +55,7 @@
 
 For example, running:
 $ build_docker_image.sh -s debian8 -d mydocker/debian8-clang -t latest \ 
-  -p clang -i install-clang -i install-clang-headers
+  -p clang -i install-clang -i install-clang-resource-headers
 will produce two docker images:
 mydocker/debian8-clang-build:latest - an intermediate image used to compile
   clang.
@@ -66,12 +66,12 @@
 
 To get a 2-stage clang build, you could use this command:
 $ ./build_docker_image.sh -s debian8 -d mydocker/clang-debian8 -t "latest" \ 
--p clang -i stage2-install-clang -i stage2-install-clang-headers \ 
+-p clang -i stage2-install-clang -i stage2-install-clang-resource-headers \ 
 -- \ 
 -DLLVM_TARGETS_TO_BUILD=Native -DCMAKE_BUILD_TYPE=Release \ 
 -DBOOTSTRAP_CMAKE_BUILD_TYPE=Release \ 
 -DCLANG_ENABLE_BOOTSTRAP=ON \ 
--DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-headers"
+-DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-resource-headers"
 EOF
 }
 
Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -273,11 +273,11 @@
   if(compiler_rt_path)
 if(NOT LLVM_BUILTIN_TARGETS)
   builtin_default_target(${compiler_rt_path}
-DEPENDS clang-headers)
+DEPENDS clang-resource-headers)
 else()
   if("default" IN_LIST LLVM_BUILTIN_TARGETS)
 builtin_default_target(${compiler_rt_path}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 list(REMOVE_ITEM LLVM_BUILTIN_TARGETS "default")
   else()
 add_custom_target(builtins)
@@ -287,7 +287,7 @@
 
   foreach(target ${LLVM_BUILTIN_TARGETS})
 builtin_register_target(${compiler_rt_path} ${target}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 
 add_dependencies(builtins builtins-${target})
 add_dependencies(install-builtins install-builtins-${target})
Index: llvm/docs/Docker.rst
===
--- llvm/docs/Docker.rst
+++ llvm/docs/Docker.rst
@@ -79,7 +79,7 @@
 ./llvm/utils/docker/build_docker_image.sh \
 	--source debian8 \
 	--docker-repository clang-debian8 --docker-tag "staging" \
-	-p clang -i install-clang -i install-clang-headers \
+	-p clang -i install-clang -i install-clang-resource-headers \
 	-- \
 	-DCMAKE_BUI

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

2019-10-04 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai updated this revision to Diff 189014.
smeenai added a comment.

Rebase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58791/new/

https://reviews.llvm.org/D58791

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/test/CMakeLists.txt
  clang/cmake/caches/Apple-stage2.cmake
  clang/cmake/caches/BaremetalARM.cmake
  clang/cmake/caches/DistributionExample-stage2.cmake
  clang/cmake/caches/Fuchsia-stage2.cmake
  clang/cmake/modules/AddClang.cmake
  clang/docs/LibTooling.rst
  clang/docs/ReleaseNotes.rst
  clang/examples/clang-interpreter/CMakeLists.txt
  clang/lib/Headers/CMakeLists.txt
  clang/test/CMakeLists.txt
  clang/tools/driver/CMakeLists.txt
  clang/tools/libclang/CMakeLists.txt
  compiler-rt/test/CMakeLists.txt
  lldb/cmake/modules/LLDBFramework.cmake
  lldb/lldb.xcodeproj/project.pbxproj
  lldb/scripts/Xcode/package-clang-headers.py
  lldb/scripts/Xcode/package-clang-resource-headers.py
  lldb/source/API/CMakeLists.txt
  llvm/docs/Docker.rst
  llvm/runtimes/CMakeLists.txt
  llvm/utils/docker/build_docker_image.sh
  openmp/cmake/OpenMPTesting.cmake

Index: openmp/cmake/OpenMPTesting.cmake
===
--- openmp/cmake/OpenMPTesting.cmake
+++ openmp/cmake/OpenMPTesting.cmake
@@ -167,7 +167,7 @@
 add_lit_testsuite(${target}
   ${comment}
   ${ARG_UNPARSED_ARGUMENTS}
-  DEPENDS clang clang-headers FileCheck ${ARG_DEPENDS}
+  DEPENDS clang clang-resource-headers FileCheck ${ARG_DEPENDS}
   ARGS ${ARG_ARGS}
 )
   endif()
Index: llvm/utils/docker/build_docker_image.sh
===
--- llvm/utils/docker/build_docker_image.sh
+++ llvm/utils/docker/build_docker_image.sh
@@ -55,7 +55,7 @@
 
 For example, running:
 $ build_docker_image.sh -s debian8 -d mydocker/debian8-clang -t latest \ 
-  -p clang -i install-clang -i install-clang-headers
+  -p clang -i install-clang -i install-clang-resource-headers
 will produce two docker images:
 mydocker/debian8-clang-build:latest - an intermediate image used to compile
   clang.
@@ -66,12 +66,12 @@
 
 To get a 2-stage clang build, you could use this command:
 $ ./build_docker_image.sh -s debian8 -d mydocker/clang-debian8 -t "latest" \ 
--p clang -i stage2-install-clang -i stage2-install-clang-headers \ 
+-p clang -i stage2-install-clang -i stage2-install-clang-resource-headers \ 
 -- \ 
 -DLLVM_TARGETS_TO_BUILD=Native -DCMAKE_BUILD_TYPE=Release \ 
 -DBOOTSTRAP_CMAKE_BUILD_TYPE=Release \ 
 -DCLANG_ENABLE_BOOTSTRAP=ON \ 
--DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-headers"
+-DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-resource-headers"
 EOF
 }
 
Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -273,11 +273,11 @@
   if(compiler_rt_path)
 if(NOT LLVM_BUILTIN_TARGETS)
   builtin_default_target(${compiler_rt_path}
-DEPENDS clang-headers)
+DEPENDS clang-resource-headers)
 else()
   if("default" IN_LIST LLVM_BUILTIN_TARGETS)
 builtin_default_target(${compiler_rt_path}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 list(REMOVE_ITEM LLVM_BUILTIN_TARGETS "default")
   else()
 add_custom_target(builtins)
@@ -287,7 +287,7 @@
 
   foreach(target ${LLVM_BUILTIN_TARGETS})
 builtin_register_target(${compiler_rt_path} ${target}
-  DEPENDS clang-headers)
+  DEPENDS clang-resource-headers)
 
 add_dependencies(builtins builtins-${target})
 add_dependencies(install-builtins install-builtins-${target})
Index: llvm/docs/Docker.rst
===
--- llvm/docs/Docker.rst
+++ llvm/docs/Docker.rst
@@ -79,7 +79,7 @@
 ./llvm/utils/docker/build_docker_image.sh \
 	--source debian8 \
 	--docker-repository clang-debian8 --docker-tag "staging" \
-	-p clang -i install-clang -i install-clang-headers \
+	-p clang -i install-clang -i install-clang-resource-headers \
 	-- \
 	-DCMAKE_BUILD_TYPE=Release
 
@@ -95,11 +95,11 @@
 ./build_docker_image.sh \
 	--source debian8 \
 	--docker-repository clang-debian8 --docker-tag "staging" \
-	-p clang -i stage2-install-clang -i stage2-install-clang-headers \
+	-p clang -i stage2-install-clang -i stage2-install-clang-resource-headers \
 	-- \
 	-DLLVM_TARGETS_TO_BUILD=Native -DCMAKE_BUILD_TYPE=Release \
 	-DBOOTSTRAP_CMAKE_BUILD_TYPE=Release \
-	-DCLANG_ENABLE_BOOTSTRAP=ON -DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-headers"
+	-DCLANG_ENABLE_BOOTSTRAP=ON -DCLANG_BOOTSTRAP_TARGETS="install-clang;install-clang-resource-headers"
 	
 This will produce a new image ``clang-debian8:staging`` from the latest
 upstream revision.
@@ -165,7 +165,7 @@
 ./llvm/utils/docker/bu

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

2019-11-07 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

I agree on not getting into the business of installing Python ourselves, but 
there's also the rpath issue. The Windows case is different because you just 
put all your DLLs in the same directory (or some other directory in your PATH) 
and you're done. With macOS, you have to specify an rpath for liblldb to be 
able to find the Python framework. It'd be really nice to support adding 
additional rpaths in the build system itself (it could be a more generic 
mechanism; it doesn't have to be Python-specific). CMake does offer 
`CMAKE_INSTALL_RPATH`, but that applies to every single target. You could also 
use install_name_tool after building to modify the rpath, but that feels like a 
kludge.

How would people feel about a patch that just adds the ability to set 
additional rpaths on liblldb?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

2019-11-08 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D69931#1739063 , @beanz wrote:

> It is a bit gross that Python does an @rpath install name, that is generally 
> against convention. I can see adding an option to add rpaths to liblldb 
> making sense. I certainly agree LLDB shouldn't be in the business of 
> packaging transitive dependencies.
>
> In a broader sense, Frameworks are dylibs. They can have all the same rpath 
> magic that a dylib has. When you link a macho, the static linker pulls the 
> install_name from each dylib you link against and embeds those as the dylibs 
> to load. Since Python 3.7's install_name is @rpath based, it means that the 
> dynamic linker will look for it in all the @rpath-relative locations 
> specified by liblldb when linking. The proposed path in this patch, `-rpath 
> "@loader_path/../../../"`, uses the @loader_path expansion which is the 
> directory containing the binary that the load command is in (in this case 
> liblldb's directory). Popping 3 directories up from that is likely not sane 
> in most build configurations, but if it works for you meh...


The assumption here is that you'd have a directory layout like the following:

  |- LLDB.framework
|- Versions
  |- A
|- LLDB
  |- Python3.framework
|- Versions
  |- 3.7
|- Python3

`Python3`'s install name is `@rpath/Python3.framework/Versions/3.7/Python3`, so 
by adding `-rpath "@loader_path/../../.."` to `LLDB`, you make @labath's 
request work:

In D69931#1738285 , @labath wrote:

> Is it possible to do something like that with the framework build too? I.e., 
> set the rpath of the LLDB.framework so that it searches for dependencies next 
> to the framework itself? Then you'd just need to drop the python framework 
> next to lldb...


The assumption, of course, is that LLDB is being built as a framework as well, 
but I believe that's the standard setup on Darwin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

2019-11-11 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

Commit message needs to be updated.




Comment at: lldb/cmake/modules/LLDBFramework.cmake:124
+
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH

You may wanna add the reason for this to the comment as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

2019-11-11 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added inline comments.



Comment at: lldb/cmake/modules/LLDBFramework.cmake:124
+
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH

smeenai wrote:
> You may wanna add the reason for this to the comment as well.
Doesn't need to be super detailed ... even just adding something like "so that 
we can find any frameworks installed beside it" should be enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

2019-11-11 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.

LGTM




Comment at: lldb/cmake/modules/LLDBFramework.cmake:125
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+# This allows frameworks (relying on @rpath) to be installed in the same 
folder and found at runtime.
+set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH

Nit: 80 columns


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69931/new/

https://reviews.llvm.org/D69931



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

2020-04-24 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

With the newer minimum CMake version, we can eliminate a bunch of the policy 
settings as well, but that can be a follow-up (especially given this isn't 
gonna ship for a few months).

(Another followup would be to add a `max` version to our 
`cmake_minimum_required`, to streamline policy settings even further. See 
https://cmake.org/cmake/help/latest/command/cmake_policy.html for details.)




Comment at: llvm/docs/CMakePrimer.rst:57
 
-   cmake_minimum_required(VERSION 3.2)
+   cmake_minimum_required(VERSION 3.15)
project(HelloWorld)

Is the higher minimum here for future-proofing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78648/new/

https://reviews.llvm.org/D78648



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-09 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added inline comments.



Comment at: lld/test/lit.site.cfg.py.in:16
 config.target_triple = "@TARGET_TRIPLE@"
-config.python_executable = "@Python3_EXECUTABLE@"
-config.have_zlib = @HAVE_LIBZ@
+config.python_executable = "@PYTHON_EXECUTABLE@"
+config.have_zlib = @LLVM_ENABLE_ZLIB@

This seems like an unintended/unrelated change.



Comment at: llvm/cmake/config-ix.cmake:506
 
-if (LLVM_ENABLE_ZLIB )
-  # Check if zlib is available in the system.
-  if ( NOT HAVE_ZLIB_H OR NOT HAVE_LIBZ )
-set(LLVM_ENABLE_ZLIB 0)
+if(LLVM_ENABLE_ZLIB)
+  if(LLVM_ENABLE_ZLIB STREQUAL FORCE_ON)

How come you're moving this out of the MSan check block? Isn't that a behavior 
change?



Comment at: llvm/lib/Support/CMakeLists.txt:207
+  get_filename_component(zlib_library ${zlib_library} NAME)
+  if(CMAKE_STATIC_LIBRARY_PREFIX AND
+ zlib_library MATCHES 
"^${CMAKE_STATIC_LIBRARY_PREFIX}.*${CMAKE_STATIC_LIBRARY_SUFFIX}$")

Even if there's no prefix, wouldn't you still wanna strip the suffix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-17 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.

Requesting changes to remove from my review queue while the above comments are 
being addressed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-07-17 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Oops, missed that I'd become a blocking reviewer for this (cos of requesting 
changes before).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

2020-01-07 Thread Shoaib Meenai via Phabricator via lldb-commits 
smeenai added a comment.

In D70764#1803559 , @raj.khem wrote:

> this is now in master, and I am seeing build failures in cross-building 
> clang, e.g. when building clang for arm on a x86_64 host. its resorting to 
> finding, libz from buildhost instead of target sysroot ( using --sysroot) and 
> failing in link step. e.g.
>
> FAILED: bin/llvm-config
>  ...
>   -o bin/llvm-config  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMSupport.a  
> /usr/lib/libz.so  -lrt  -ldl  -ltinfo  -lm  lib/libLLVMDemangle.a
>  ...
>
> aarch64-yoe-linux-musl/aarch64-yoe-linux-musl-ld: /usr/lib/libz.so: error 
> adding symbols: file in wrong format
>  clang-10: error: linker command failed with exit code 1 (use -v to see 
> invocation)
>
> you can see that its adding /usr/lib/libz.so to linker cmdline while cross 
> linking.


Have you set `CMAKE_SYSROOT` appropriately?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70764/new/

https://reviews.llvm.org/D70764



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits