[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

[Sam Clegg via lldb-commits]

@@ -99,15 +99,15 @@ class InputChunk {
   // the beginning of the output section this chunk was assigned to.
   int32_t outSecOff = 0;
 
-  uint8_t sectionKind : 3;
+  uint32_t sectionKind : 3;

sbc100 wrote:

Can you explain why `uint32_t` is better than `uint8_t` here?

https://github.com/llvm/llvm-project/pull/140493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

[Sam Clegg via lldb-commits]

@@ -99,15 +99,15 @@ class InputChunk {
   // the beginning of the output section this chunk was assigned to.
   int32_t outSecOff = 0;
 
-  uint8_t sectionKind : 3;
+  uint32_t sectionKind : 3;

sbc100 wrote:

(Perhaps some background in the PR description would be useful).

https://github.com/llvm/llvm-project/pull/140493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

[Sam Clegg via lldb-commits]

@@ -99,15 +99,15 @@ class InputChunk {
   // the beginning of the output section this chunk was assigned to.
   int32_t outSecOff = 0;
 
-  uint8_t sectionKind : 3;
+  uint32_t sectionKind : 3;

sbc100 wrote:

By MS ABI I assume you mean mircrosoft?  

I guess this is not actually a regression on non-MS compilers since the bit 
width means that type does not actually impact the size in the struct?

https://github.com/llvm/llvm-project/pull/140493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits