[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added inline comments.



Comment at: 
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
 IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
 ArrayRef current_tids) {
-  IntelPTProcessTraceUP trace(new IntelPTPerThreadProcessTrace(request));
+  std::unique_ptr trace(
+  new IntelPTPerThreadProcessTrace(request));

@wallace, @jj10306

We are getting build errors here on CentOS/GNU 7.3.1:

```
/llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:
 In static member function 'static 
llvm::Expected
 > lldb_private::process_linux::IntelPTPerThreadProcessTrace::Start(const 
lldb_private::TraceIntelPTStartRequest&, llvm::ArrayRef)':
/llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:65:10:
 error: could not convert 'trace' from 
'std::unique_ptr' to 
'llvm::Expected
 >'
   return trace;
  ^
```

Can you please fix this?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127456/new/

https://reviews.llvm.org/D127456

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added inline comments.



Comment at: 
lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59
+Expected>
 IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request,
 ArrayRef current_tids) {
-  IntelPTProcessTraceUP trace(new IntelPTPerThreadProcessTrace(request));
+  std::unique_ptr trace(
+  new IntelPTPerThreadProcessTrace(request));

wallace wrote:
> max-kudr wrote:
> > @wallace, @jj10306
> > 
> > We are getting build errors here on CentOS/GNU 7.3.1:
> > 
> > ```
> > /llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:
> >  In static member function 'static 
> > llvm::Expected
> >  > lldb_private::process_linux::IntelPTPerThreadProcessTrace::Start(const 
> > lldb_private::TraceIntelPTStartRequest&, llvm::ArrayRef > int>)':
> > /llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:65:10:
> >  error: could not convert 'trace' from 
> > 'std::unique_ptr'
> >  to 
> > 'llvm::Expected
> >  >'
> >return trace;
> >   ^
> > ```
> > 
> > Can you please fix this?
> > 
> Hi Max, I'm aware of this issue because it was reported by someone else. 
> Sadly I wasn't able to install that toolchain on my centos machine (I don't 
> manage it) so I can't reproduce the issue to make sure I can fix it. This 
> issue doesn't happen with other toolchains.
> 
> So, I would like to ask for your help to try to fix it. I think the fix might 
> be something as simple as doing
> 
> return std::move(trace)
> or perhaps something like
> 
> return 
> Expected>(std::move(trace));
> At this point I can only rely on you to make sure this is properly fixed
Hi Walter (@wallace),

Thank you for following up and proposing fix. I checked and confirm that the 
code below fixes the issue

```
return std::move(trace)
```

Would you please push this fix to the repository? Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127456/new/

https://reviews.llvm.org/D127456

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr accepted this revision.
max-kudr added a comment.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83772/new/

https://reviews.llvm.org/D83772



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

@JDevlieghere This change is is failing LLDB Windows buildbot 
 since build 18051 
. Can 
you please fix that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85235/new/

https://reviews.llvm.org/D85235

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85235/new/

https://reviews.llvm.org/D85235

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85970: [lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

LLDB Windows buildbot  
is failing after last commit: Build 18298 
.

Please revert or fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85970/new/

https://reviews.llvm.org/D85970

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

Hi @mib, Windows buildbot is broken after this commit. Please fix or revert.

Failed Tests (2):

  lldb-api :: commands/platform/basic/TestPlatformCommand.py
  lldb-api :: commands/platform/basic/TestPlatformPython.py

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/test/logs/stdio

http://lab.llvm.org:8011/buildslaves/win-py3-buildbot


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86667/new/

https://reviews.llvm.org/D86667

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added inline comments.



Comment at: lldb/test/API/commands/platform/basic/myshell.c:11
+
+#ifdef WIN32
+  char *cmd_opt = "/C";

mib wrote:
> @max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but 
> IIUC the macro should be `_WIN32`), explaining the failure, I'll send a fix 
> now.
Yes, at least `_WIN32` is used in clang. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86667/new/

https://reviews.llvm.org/D86667

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D80308: [lldb] Enable C++14 when evaluating expressions in a C++14 frame

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

Hello,

I suppose this commit broke Windows LLDB tests 
(http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16486 -> logs: 
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16486/steps/test/logs/stdio).
 Can you please fix or rollback it?

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80308/new/

https://reviews.llvm.org/D80308



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

This broke LLDB tests on Windows Build Bot 
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13415

Can you please fix it or revert it? Thank you!

  Failing Tests (4):
  lldb-api :: 
commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
  lldb-api :: functionalities/postmortem/minidump-new/TestMiniDumpNew.py
  lldb-api :: python_api/thread/TestThreadAPI.py
  lldb-shell :: Driver/TestConvenienceVariables.test
  
Expected Passes: 1381
Expected Failures  : 10
Unsupported Tests  : 541
Unexpected Failures: 4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73303/new/

https://reviews.llvm.org/D73303



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

[Max Kudryavtsev via Phabricator via lldb-commits]

max-kudr added a comment.

There is Windows Build Bot failure 
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13427. Can you 
please fix or revert it?

  Cannot open include file: 
'Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.h': No such file or 
directory


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72751/new/

https://reviews.llvm.org/D72751



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits