[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-20 Thread Leonardo Bianconi via Phabricator via lldb-commits
lbianc added a comment.

@davide Are you sure this is the correct patch? This one was not merged yet.
Could you give more details about the issue? Is it related with one of our 
changes?


https://reviews.llvm.org/D44472



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-20 Thread Leonardo Bianconi via Phabricator via lldb-commits
lbianc added a comment.

@davide, I think the error is the variable number, as this is the only command 
in the test case, could you just change from

  # Do anonymous symbols work?
  self.expect("expression ((char**)environ)[0]",
  startstr="(char *) $1 = 0x")

to

  # Do anonymous symbols work?
  self.expect("expression ((char**)environ)[0]",
  startstr="(char *) $0 = 0x")

and check if it works?


https://reviews.llvm.org/D44472



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-20 Thread Leonardo Bianconi via Phabricator via lldb-commits
lbianc added a comment.

@davide Let me know if you need that I change it on my diff or any other help.


https://reviews.llvm.org/D44472



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-20 Thread Leonardo Bianconi via Phabricator via lldb-commits
lbianc added a comment.

Yes, I'm running Linux and this test was not working for me, so as discussion 
above, it was separated to be executed on non Linux and Windows, but the 
variable number got wrong. Sorry for that.


https://reviews.llvm.org/D44472



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits