[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl created 
https://github.com/llvm/llvm-project/pull/99323

verbose_trap.test, added in #80368, fails on some Windows bots.
See https://lab.llvm.org/buildbot/#/builders/141/builds/808.


>From f57dd945e6c2e4d4b3d5a97b2ed05418d91902ac Mon Sep 17 00:00:00 2001
From: Leandro Lupori 
Date: Wed, 17 Jul 2024 10:12:11 -0300
Subject: [PATCH] [lldb] Disable verbose_trap.test on Windows

verbose_trap.test, added in #80368, fails on some Windows bots.
See https://lab.llvm.org/buildbot/#/builders/141/builds/808.
---
 lldb/test/Shell/Recognizer/verbose_trap.test | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lldb/test/Shell/Recognizer/verbose_trap.test 
b/lldb/test/Shell/Recognizer/verbose_trap.test
index 45ef84bef611f..dafab7bdea688 100644
--- a/lldb/test/Shell/Recognizer/verbose_trap.test
+++ b/lldb/test/Shell/Recognizer/verbose_trap.test
@@ -1,3 +1,5 @@
+# UNSUPPORTED: system-windows
+#
 # RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out 
-DVERBOSE_TRAP_TEST_CATEGORY=\"Foo\" -DVERBOSE_TRAP_TEST_MESSAGE=\"Bar\"
 # RUN: %lldb -b -s %s %t.out | FileCheck %s --check-prefixes=CHECK,CHECK-BOTH
 #

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

2024-07-17 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl created 
https://github.com/llvm/llvm-project/pull/99357

libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that
maps to printf on Windows. Include stdio.h to avoid linker errors
on Windows.
See https://lab.llvm.org/buildbot/#/builders/141/builds/853


>From 9d34bd13ee92b1bb1eacac522c6167cbf607f0fa Mon Sep 17 00:00:00 2001
From: Leandro Lupori 
Date: Wed, 17 Jul 2024 14:08:47 -0300
Subject: [PATCH] [lldb][test] Fix simulator test for std::unique_ptr

libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that
maps to printf on Windows. Include stdio.h to avoid linker errors
on Windows.
See https://lab.llvm.org/buildbot/#/builders/141/builds/853
---
 .../data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp| 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
 
b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
index 08324e24f9cc4..a6bfaa3febebb 100644
--- 
a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
+++ 
b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
@@ -1,5 +1,7 @@
 #include 
 
+#include 
+
 namespace std {
 namespace __lldb {
 template  struct default_delete {

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits 

luporl wrote:

Test added in #98330.

https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits 

luporl wrote:

Merging to fix https://lab.llvm.org/buildbot/#/builders/141/builds/853, which 
has been broken for over 36 hours.

https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

2024-07-17 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBSaveCoreOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-19 Thread Leandro Lupori via lldb-commits 

luporl wrote:

lldb-aarch64-windows is still failing: 
https://lab.llvm.org/buildbot/#/builders/141/builds/912

https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCoreOptions] Fix TestProcessSaveCore (PR #99692)

2024-07-22 Thread Leandro Lupori via lldb-commits 

luporl wrote:

@Jlalond Thanks for the fix.

https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b58dd92 - [lldb-vscode] Skip restart tests on ARM

2023-05-12 Thread Leandro Lupori via lldb-commits 

Author: Leandro Lupori
Date: 2023-05-12T13:52:17-03:00
New Revision: b58dd9230e655feb0d904b8095f113a4f0246cbf

URL: 
https://github.com/llvm/llvm-project/commit/b58dd9230e655feb0d904b8095f113a4f0246cbf
DIFF: 
https://github.com/llvm/llvm-project/commit/b58dd9230e655feb0d904b8095f113a4f0246cbf.diff

LOG: [lldb-vscode] Skip restart tests on ARM

These tests always time out on ARM buildbot. Disabling them for
now, until https://github.com/llvm/llvm-project/issues/62684 is
fixed.

Added: 


Modified: 
lldb/test/API/tools/lldb-vscode/restart/TestVSCode_restart_runInTerminal.py

Removed: 




diff  --git 
a/lldb/test/API/tools/lldb-vscode/restart/TestVSCode_restart_runInTerminal.py 
b/lldb/test/API/tools/lldb-vscode/restart/TestVSCode_restart_runInTerminal.py
index f250e014cfe3d..48931f4e1bb5c 100644
--- 
a/lldb/test/API/tools/lldb-vscode/restart/TestVSCode_restart_runInTerminal.py
+++ 
b/lldb/test/API/tools/lldb-vscode/restart/TestVSCode_restart_runInTerminal.py
@@ -24,6 +24,7 @@ def isTestSupported(self):
 
 @skipIfWindows
 @skipIfRemote
+@skipIf(archs=["arm"]) # Always times out on buildbot
 def test_basic_functionality(self):
 '''
 Test basic restarting functionality when the process is running in
@@ -58,6 +59,7 @@ def test_basic_functionality(self):
 
 @skipIfWindows
 @skipIfRemote
+@skipIf(archs=["arm"]) # Always times out on buildbot
 def test_stopOnEntry(self):
 '''
 Check that stopOnEntry works correctly when using runInTerminal.



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-08 Thread Leandro Lupori via lldb-commits 

luporl wrote:

It seems this broke the lldb-aarch64-windows buildbot:
https://lab.llvm.org/buildbot/#/builders/219/builds/6801

https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-08 Thread Leandro Lupori via lldb-commits 

luporl wrote:

@medismailben Yes, it did break that bot.
https://lab.llvm.org/buildbot/#/builders/219/builds/6786 is the first build 
that includes your commit and when `Expr/TestIRMemoryMapWindows.test` started 
failing.
https://lab.llvm.org/buildbot/#/builders/219/builds/6785 is a build failure 
that was fixed by 
https://github.com/llvm/llvm-project/commit/3267cd3fa10651b46e9d1ce66940301e784c0533.

To confirm it, I've forced builds of particular revisions. 
https://lab.llvm.org/buildbot/#/builders/219/builds/6800 is right before your 
commit and passes and https://lab.llvm.org/buildbot/#/builders/219/builds/6801 
adds only your commit and fails.

https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-09 Thread Leandro Lupori via lldb-commits 

luporl wrote:

Thanks for the fix.

https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

2024-11-22 Thread Leandro Lupori via lldb-commits 

luporl wrote:

It looks like this broke lldb-aarch64-windows: 
https://lab.llvm.org/buildbot/#/builders/141/builds/4061

```
FAIL: lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c (1581 of 2048)
 TEST 'lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c' 
FAILED 
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 8
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe 
--target=specify-a-target-or-use-a-_host-substitution 
--target=aarch64-pc-windows-msvc 
-fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell
 -O3 -gdwarf 
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c
 -o 
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp
# executed command: 
'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe' 
--target=specify-a-target-or-use-a-_host-substitution 
--target=aarch64-pc-windows-msvc 
'-fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell'
 -O3 -gdwarf 
'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c'
 -o 
'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp'
# .---command stderr
# | clang: warning: argument unused during compilation: 
'-fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell'
 [-Wunused-command-line-argument]
# `-
# RUN: at line 9
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\lldb.exe --no-lldbinit 
-S 
C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet
 
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp
-o "b 25"-o "r"-o "p/x array[2]"-b | 
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\filecheck.exe 
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c
# executed command: 
'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\lldb.exe' 
--no-lldbinit -S 
'C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet'
 
'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp'
 -o 'b 25' -o r -o 'p/x array[2]' -b
# .---command stderr
# | error: No selected frame to use to find the default file.
# | error: No file supplied and no default file available.
# `-
# error: command failed with exit status: 1
# executed command: 
'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\filecheck.exe' 
'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c'
# .---command stderr
# | 
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c:15:11:
 error: CHECK: expected string not found in input
# | // CHECK: (lldb) p/x array[2]
# |   ^
# | :1:1: note: scanning from here
# | (lldb) command source -s 0 
'C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet'
# | ^
# | :6:1: note: possible intended match here
# | (lldb) b 25
...
```

Can you please take a look?

https://github.com/llvm/llvm-project/pull/117168
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] DW_OP_piece-O3.c: XFAIL on AArch64 Windows (PR #117355)

2024-11-22 Thread Leandro Lupori via lldb-commits 


@@ -5,9 +5,10 @@
 // DW_AT_type  (0x0032 "char[5]")
 // DW_AT_location  (DW_OP_piece 0x2, DW_OP_addrx 0x0, 
DW_OP_piece 0x1)
 
+// XFAIL: target=aarch64-pc-windows-{{.*}}

luporl wrote:

It's better to just skip the test on windows:
`// UNSUPPORTED: system-windows`

https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] DW_OP_piece-O3.c: XFAIL on AArch64 Windows (PR #117355)

2024-11-22 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl edited 
https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] DW_OP_piece-O3.c: Disable on Windows (PR #117355)

2024-11-22 Thread Leandro Lupori via lldb-commits 

https://github.com/luporl approved this pull request.

This fixes the failure for WoA, thanks.

https://github.com/llvm/llvm-project/pull/117355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #120457)

2025-01-08 Thread Leandro Lupori via lldb-commits 

luporl wrote:

> LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` 
> running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 
> "test".
> 
> Full details are available at: 
> https://lab.llvm.org/buildbot/#/builders/141/builds/5258
> Here is the relevant piece of the build log for the reference

Hi. `lldb-aarch64-windows` has been broken for some time. Are there any plans 
to fix or revert this PR?

https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support ordered patterns in lldbtest.expect (PR #131475)

2025-03-18 Thread Leandro Lupori via lldb-commits 

luporl wrote:

This change broke https://lab.llvm.org/buildbot/#/builders/141/builds/7116.

`functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py` 
passes when I revert this change.
Can you please take a look?


https://github.com/llvm/llvm-project/pull/131475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-24 Thread Leandro Lupori via lldb-commits 

luporl wrote:

It seems this broke lldb-aarch64-windows bot: 
https://lab.llvm.org/buildbot/#/builders/141/builds/8149

https://github.com/llvm/llvm-project/pull/132783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits