[Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

[Jonathan Meier via lldb-commits]

jonathanmeier created this revision.
jonathanmeier added a reviewer: zturner.
jonathanmeier added a subscriber: lldb-commits.

CMake allows case sensitive folder naming when setting the folder property of a 
target. However MSBuild doesn't like that. It complains about having two 
projects named the same when trying to compile the solution and aborts. 
(Solution file error MSB5004: The solution file has two projects named "lldb 
tests")

In lldb/unittests/CMakeLists.txt a folder "LLDB tests" is defined and in 
lldb/lit/CMakeLists.txt a folder "lldb tests" is defined.

Renaming "lldb tests" to "LLDB tests" in lldb/lit/CMakeLists.txt fixes the 
problem.

http://reviews.llvm.org/D16150

Files:
  lit/CMakeLists.txt

Index: lit/CMakeLists.txt
===
--- lit/CMakeLists.txt
+++ lit/CMakeLists.txt
@@ -33,4 +33,4 @@
   DEPENDS ${LLDB_TEST_DEPS}
   )
 
-set_target_properties(check-lldb-unit PROPERTIES FOLDER "lldb tests")
+set_target_properties(check-lldb-unit PROPERTIES FOLDER "LLDB tests")


Index: lit/CMakeLists.txt
===
--- lit/CMakeLists.txt
+++ lit/CMakeLists.txt
@@ -33,4 +33,4 @@
   DEPENDS ${LLDB_TEST_DEPS}
   )
 
-set_target_properties(check-lldb-unit PROPERTIES FOLDER "lldb tests")
+set_target_properties(check-lldb-unit PROPERTIES FOLDER "LLDB tests")
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

[Jonathan Meier via lldb-commits]

jonathanmeier added a comment.

Could you please commit that for me? I don't have write access to the 
repository.


http://reviews.llvm.org/D16150



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits