[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

[Isuru Fernando via Phabricator via lldb-commits]

isuruf created this revision.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
isuruf added a reviewer: LLDB.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77842

Files:
  lldb/cmake/modules/FindPythonInterpAndLibs.cmake


Index: lldb/cmake/modules/FindPythonInterpAndLibs.cmake
===
--- lldb/cmake/modules/FindPythonInterpAndLibs.cmake
+++ lldb/cmake/modules/FindPythonInterpAndLibs.cmake
@@ -11,7 +11,7 @@
   if (SWIG_FOUND)
 if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
   # Use PYTHON_HOME as a hint to find Python 3.
-  set(Python3_ROOT_DIR PYTHON_HOME)
+  set(Python3_ROOT_DIR "${PYTHON_HOME}")
   find_package(Python3 COMPONENTS Interpreter Development)
   if (Python3_FOUND AND Python3_Interpreter_FOUND)
 set(PYTHON_LIBRARIES ${Python3_LIBRARIES})


Index: lldb/cmake/modules/FindPythonInterpAndLibs.cmake
===
--- lldb/cmake/modules/FindPythonInterpAndLibs.cmake
+++ lldb/cmake/modules/FindPythonInterpAndLibs.cmake
@@ -11,7 +11,7 @@
   if (SWIG_FOUND)
 if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
   # Use PYTHON_HOME as a hint to find Python 3.
-  set(Python3_ROOT_DIR PYTHON_HOME)
+  set(Python3_ROOT_DIR "${PYTHON_HOME}")
   find_package(Python3 COMPONENTS Interpreter Development)
   if (Python3_FOUND AND Python3_Interpreter_FOUND)
 set(PYTHON_LIBRARIES ${Python3_LIBRARIES})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

[Isuru Fernando via Phabricator via lldb-commits]

isuruf added a comment.

The intention of the code is to set the variable `Python3_ROOT_DIR` to the 
value of the variable `PYTHON_HOME`, but it was using just the string 
`"PYTHON_HOME"` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77842/new/

https://reviews.llvm.org/D77842



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

[Isuru Fernando via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG664fda72eaa3: Fix setting Python3_ROOT_DIR on Windows 
(authored by isuruf).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77842/new/

https://reviews.llvm.org/D77842

Files:
  lldb/cmake/modules/FindPythonInterpAndLibs.cmake


Index: lldb/cmake/modules/FindPythonInterpAndLibs.cmake
===
--- lldb/cmake/modules/FindPythonInterpAndLibs.cmake
+++ lldb/cmake/modules/FindPythonInterpAndLibs.cmake
@@ -11,7 +11,7 @@
   if (SWIG_FOUND)
 if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
   # Use PYTHON_HOME as a hint to find Python 3.
-  set(Python3_ROOT_DIR PYTHON_HOME)
+  set(Python3_ROOT_DIR "${PYTHON_HOME}")
   find_package(Python3 COMPONENTS Interpreter Development)
   if (Python3_FOUND AND Python3_Interpreter_FOUND)
 set(PYTHON_LIBRARIES ${Python3_LIBRARIES})


Index: lldb/cmake/modules/FindPythonInterpAndLibs.cmake
===
--- lldb/cmake/modules/FindPythonInterpAndLibs.cmake
+++ lldb/cmake/modules/FindPythonInterpAndLibs.cmake
@@ -11,7 +11,7 @@
   if (SWIG_FOUND)
 if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
   # Use PYTHON_HOME as a hint to find Python 3.
-  set(Python3_ROOT_DIR PYTHON_HOME)
+  set(Python3_ROOT_DIR "${PYTHON_HOME}")
   find_package(Python3 COMPONENTS Interpreter Development)
   if (Python3_FOUND AND Python3_Interpreter_FOUND)
 set(PYTHON_LIBRARIES ${Python3_LIBRARIES})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits