[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-25 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev created this revision.
vasilyev added a reviewer: LLVM.
vasilyev added projects: LLVM, LLDB test suite on simulator.
vasilyev requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The tests expect the debugger steps into the function, not the string 
constructor. But that depends on the compiler. Thus, with "ssas" the tests are 
failing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99331

Files:
  lldb/test/API/functionalities/inline-stepping/calling.cpp


Index: lldb/test/API/functionalities/inline-stepping/calling.cpp
===
--- lldb/test/API/functionalities/inline-stepping/calling.cpp
+++ lldb/test/API/functionalities/inline-stepping/calling.cpp
@@ -129,8 +129,12 @@
 
 function_to_call (); // Make sure debug info for this function gets 
generated.
 
-max_value(123, 456);// Call max_value 
template
-max_value(std::string("abc"), std::string("0022")); // Call max_value 
specialized
+max_value(123, 456); // Call max_value template
+
+std::string s1 = "aba";
+std::string s2 = "0022";
+
+max_value(s1, s2);  // Call max_value specialized
 
 return 0;// About to return from main.
 }


Index: lldb/test/API/functionalities/inline-stepping/calling.cpp
===
--- lldb/test/API/functionalities/inline-stepping/calling.cpp
+++ lldb/test/API/functionalities/inline-stepping/calling.cpp
@@ -129,8 +129,12 @@
 
 function_to_call (); // Make sure debug info for this function gets generated.
 
-max_value(123, 456);// Call max_value template
-max_value(std::string("abc"), std::string("0022")); // Call max_value specialized
+max_value(123, 456); // Call max_value template
+
+std::string s1 = "aba";
+std::string s2 = "0022";
+
+max_value(s1, s2);  // Call max_value specialized
 
 return 0;// About to return from main.
 }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-29 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev added a comment.

Thanks for the comments! You are right, this is indeed fixed by 
https://github.com/llvm/llvm-project/commit/352f16db87f583ec7f55f8028647b5fd8616111f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99331/new/

https://reviews.llvm.org/D99331

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-29 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev abandoned this revision.
vasilyev added a comment.

Resolved


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99331/new/

https://reviews.llvm.org/D99331

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits