[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints
JDevlieghere added a comment. It appears there are many similar calls in this file, can you update those as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I was just asking for comments on the two constructors, but having them elsewhere is nice too. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h:29-31 +// This class is used to restrict the range of ports that +// platform created debugserver/gdbserver processes will +// communicate on. This looks like a class-level comment. Could you also say a few words about what the constructor does specifically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91634/new/ https://reviews.llvm.org/D91634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
