[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). mgorny wrote: > krytarowski wrote: > > Please add `uint32_t tlsbase;`. > To what purpose? It's not being used anywhere. Consistency with amd64 AND we will want to make use of it in future and present as a 'tlsbase' register or anything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin
mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). krytarowski wrote: > mgorny wrote: > > krytarowski wrote: > > > Please add `uint32_t tlsbase;`. > > To what purpose? It's not being used anywhere. > Consistency with amd64 AND we will want to make use of it in future and > present as a 'tlsbase' register or anything. The only reason I didn't remove it from amd64 is because I don't believe it's worth the effort. I'm against proactively adding undocumented features, especially given how much time I've spent trying to figure out what those structures were doing. We can add it when we start using it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). mgorny wrote: > krytarowski wrote: > > mgorny wrote: > > > krytarowski wrote: > > > > Please add `uint32_t tlsbase;`. > > > To what purpose? It's not being used anywhere. > > Consistency with amd64 AND we will want to make use of it in future and > > present as a 'tlsbase' register or anything. > The only reason I didn't remove it from amd64 is because I don't believe it's > worth the effort. I'm against proactively adding undocumented features, > especially given how much time I've spent trying to figure out what those > structures were doing. We can add it when we start using it. This was discussed when we were adding amd64 fields and it was decided to add tlsbase. Please add it here too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi
mstorsjo created this revision.
mstorsjo added reviewers: labath, amccarth.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
This fixes building for mingw with BUILD_SHARED_LIBS. In static builds, the
psapi dependency gets linked in transitively from Support, but when linking
Support dynamically, it's revealed that these components also need linking
against psapi.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D73839
Files:
lldb/source/Host/CMakeLists.txt
lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
Index: lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
===
--- lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
+++ lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
@@ -29,6 +29,7 @@
lldbTarget
ws2_32
rpcrt4
+psapi
LINK_COMPONENTS
Support
)
Index: lldb/source/Host/CMakeLists.txt
===
--- lldb/source/Host/CMakeLists.txt
+++ lldb/source/Host/CMakeLists.txt
@@ -161,6 +161,9 @@
if (LLDB_ENABLE_LZMA)
list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES})
endif()
+if (WIN32)
+ list(APPEND LLDB_SYSTEM_LIBS psapi)
+endif ()
if (LLDB_ENABLE_LIBEDIT)
list(APPEND LLDB_LIBEDIT_LIBS ${LibEdit_LIBRARIES})
Index: lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
===
--- lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
+++ lldb/source/Plugins/Process/Windows/Common/CMakeLists.txt
@@ -29,6 +29,7 @@
lldbTarget
ws2_32
rpcrt4
+psapi
LINK_COMPONENTS
Support
)
Index: lldb/source/Host/CMakeLists.txt
===
--- lldb/source/Host/CMakeLists.txt
+++ lldb/source/Host/CMakeLists.txt
@@ -161,6 +161,9 @@
if (LLDB_ENABLE_LZMA)
list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES})
endif()
+if (WIN32)
+ list(APPEND LLDB_SYSTEM_LIBS psapi)
+endif ()
if (LLDB_ENABLE_LIBEDIT)
list(APPEND LLDB_LIBEDIT_LIBS ${LibEdit_LIBRARIES})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). krytarowski wrote: > mgorny wrote: > > krytarowski wrote: > > > mgorny wrote: > > > > krytarowski wrote: > > > > > Please add `uint32_t tlsbase;`. > > > > To what purpose? It's not being used anywhere. > > > Consistency with amd64 AND we will want to make use of it in future and > > > present as a 'tlsbase' register or anything. > > The only reason I didn't remove it from amd64 is because I don't believe > > it's worth the effort. I'm against proactively adding undocumented > > features, especially given how much time I've spent trying to figure out > > what those structures were doing. We can add it when we start using it. > This was discussed when we were adding amd64 fields and it was decided to add > tlsbase. Please add it here too. Also there is now ptrace(2) API ready (`PT_LWPSTATUS`) to read tlsbase and I wish I saw its support in LLDB sooner than later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73802/new/ https://reviews.llvm.org/D73802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
