[Lldb-commits] [PATCH] D56068: Use reference only for DW_FORM_ref*

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

btw, I have a patch for the same bug here: D55991 



Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56068/new/

https://reviews.llvm.org/D56068



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added inline comments.



Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:620
+  case DW_FORM_ref_sig8:
+  case DW_FORM_GNU_ref_alt:
+return die_offset;

clayborg wrote:
> Not sure that this is, but if it isn't an absolute .debug_info offset, then 
> we shouldn't return it here
It is DWZ's reference from main debug file into shared DWZ common file - 
implemented by pending D40474.
I agree it needs more complicated handling than this implementation so it 
should not be here.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55991/new/

https://reviews.llvm.org/D55991



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D56068: Use reference only for DW_FORM_ref*

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil abandoned this revision.
jankratochvil added a comment.

It is a duplicate of D55991 .


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56068/new/

https://reviews.llvm.org/D56068



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits