[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-06 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn added a comment.

Changing title as it looks like this is not a Windows-only problem: 
https://github.com/rust-lang/rust/issues/54126.

The above illustrates why I think this needs to be fixed: Right now LLDB cannot 
be installed correctly unless the installer can preserve symlinks.  Merely 
making a copy of LLDB files will break it, unless one is extra careful to use 
symlink-preserving copy, and I am not even sure what tool could be used on 
Windows to copy it correctly.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52404



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-06 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Sorry for the delay. I *think* this should be fine, but with these things its 
hard to tell whether it won't break someone's build/release setup. However, it 
does solve a real problem (I've hit this issue myself a couple of times on 
windows), so I think we should give it a try.

It might be good to note that this will only ever make a difference if one is 
using swig>=3.0.11.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52404



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits