[Lldb-commits] [lldb] r343769 - Re-commit r343500 "Fix build with GCC < 5.0 (PR39131)"
Author: tkrasnukha Date: Thu Oct 4 04:39:55 2018 New Revision: 343769 URL: http://llvm.org/viewvc/llvm-project?rev=343769&view=rev Log: Re-commit r343500 "Fix build with GCC < 5.0 (PR39131)" Occasionally didn't commit actual fix the first time. Modified: lldb/trunk/source/Commands/CommandObjectType.cpp Modified: lldb/trunk/source/Commands/CommandObjectType.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectType.cpp?rev=343769&r1=343768&r2=343769&view=diff == --- lldb/trunk/source/Commands/CommandObjectType.cpp (original) +++ lldb/trunk/source/Commands/CommandObjectType.cpp Thu Oct 4 04:39:55 2018 @@ -1013,6 +1013,14 @@ public: "type format clear", "Delete all existing format styles.") {} }; + +static constexpr OptionDefinition g_type_formatter_list_options[] = { + // clang-format off + {LLDB_OPT_SET_1, false, "category-regex", 'w', OptionParser::eRequiredArgument, nullptr, {}, 0, eArgTypeName, "Only show categories matching this filter."}, + {LLDB_OPT_SET_2, false, "language", 'l', OptionParser::eRequiredArgument, nullptr, {}, 0, eArgTypeLanguage, "Only show the category for a specific language."} + // clang-format on +}; + template class CommandObjectTypeFormatterList : public CommandObjectParsed { typedef typename FormatterType::SharedPointer FormatterSharedPointer; @@ -1055,13 +1063,7 @@ class CommandObjectTypeFormatterList : p } llvm::ArrayRef GetDefinitions() override { - static constexpr OptionDefinition g_option_table[] { - // clang-format off -{LLDB_OPT_SET_1, false, "category-regex", 'w', OptionParser::eRequiredArgument, nullptr, {}, 0, eArgTypeName, "Only show categories matching this filter."}, -{LLDB_OPT_SET_2, false, "language", 'l', OptionParser::eRequiredArgument, nullptr, {}, 0, eArgTypeLanguage, "Only show the category for a specific language."} - // clang-format on - }; - return llvm::ArrayRef(g_option_table); + return llvm::makeArrayRef(g_type_formatter_list_options); } // Instance variables to hold the values for command options. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D52884: Fix typos.
brucem created this revision. brucem added a reviewer: lldb-commits. Herald added subscribers: ki.stfu, srhines. https://reviews.llvm.org/D52884 Files: include/lldb/Utility/ConstString.h packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py source/Host/common/MainLoop.cpp source/Host/posix/ProcessLauncherPosixFork.cpp source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-vscode/JSONUtils.h tools/lldb-vscode/LLDBUtils.h tools/lldb-vscode/README.md tools/lldb-vscode/lldb-vscode.cpp unittests/Core/BroadcasterTest.cpp unittests/Core/ListenerTest.cpp utils/sync-source/README.txt www/python_reference/epydoc.css Index: www/python_reference/epydoc.css === --- www/python_reference/epydoc.css +++ www/python_reference/epydoc.css @@ -176,7 +176,7 @@ font-family: monospace; } /* Variable values - * - In the 'variable details' sections, each varaible's value is + * - In the 'variable details' sections, each variable's value is * listed in a 'pre.variable' box. The width of this box is * restricted to 80 chars; if the value's repr is longer than * this it will be wrapped, using a backslash marked with Index: utils/sync-source/README.txt === --- utils/sync-source/README.txt +++ utils/sync-source/README.txt @@ -97,7 +97,7 @@ # option. # # Below, I have transfer of the lldb dir skip everything -# rooted at "/llvm" below the the lldb dir. This is +# rooted at "/llvm" below the lldb dir. This is # because we want the source OS X lldb to move to # a destination of {some-dest-root}/llvm/tools/lldb, and # not have the OS-X-inverted llvm copy over with the lldb Index: unittests/Core/ListenerTest.cpp === --- unittests/Core/ListenerTest.cpp +++ unittests/Core/ListenerTest.cpp @@ -21,7 +21,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, @@ -58,7 +58,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, Index: unittests/Core/BroadcasterTest.cpp === --- unittests/Core/BroadcasterTest.cpp +++ unittests/Core/BroadcasterTest.cpp @@ -24,7 +24,7 @@ Broadcaster broadcaster(nullptr, "test-broadcaster"); std::chrono::seconds timeout(0); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener1_sp = Listener::MakeListener("test-listener1"); const uint32_t event_mask1 = 1; EXPECT_EQ(event_mask1, Index: tools/lldb-vscode/lldb-vscode.cpp === --- tools/lldb-vscode/lldb-vscode.cpp +++ tools/lldb-vscode/lldb-vscode.cpp @@ -152,7 +152,7 @@ } //-- -// Send a thread stopped event for all threads as lons as the process +// Send a thread stopped event for all threads as long as the process // is stopped. //-- void SendThreadStoppedEvent() { @@ -191,7 +191,7 @@ if (g_vsc.focus_tid == LLDB_INVALID_THREAD_ID) g_vsc.focus_tid = first_tid_with_reason; - // If no threads stopped with a reaspon, then report the first one so + // If no threads stopped with a reason, then report the first one so // we at least let the UI know we stopped. if (num_threads_with_reason == 0) { lldb::SBThread thread = process.GetThreadAtIndex(0); @@ -324,7 +324,7 @@ } //-- -// All events from a the debugger, target, process, thread and frames are +// All events from the debugger, target, process, thread and frames are // received in this function that runs in its own thread. We are using a // "FILE *" to output packets back to VS Code and they hav
[Lldb-commits] [PATCH] D52884: Fix typos.
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This looks all good to me. I'm a bit worried about the changes to AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely on this specific field name anywhere in our code. https://reviews.llvm.org/D52884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function
shafik updated this revision to Diff 168389. shafik marked 6 inline comments as done. shafik added a comment. Addressing comments and fixing a bug in ThreadPlanStepThrough.cpp where I would overwrite the result of objc_runtime. https://reviews.llvm.org/D52851 Files: include/lldb/Target/CPPLanguageRuntime.h packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/Makefile packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/main.cpp source/Target/CPPLanguageRuntime.cpp source/Target/ThreadPlanStepThrough.cpp Index: source/Target/ThreadPlanStepThrough.cpp === --- source/Target/ThreadPlanStepThrough.cpp +++ source/Target/ThreadPlanStepThrough.cpp @@ -13,6 +13,7 @@ // Project includes #include "lldb/Target/ThreadPlanStepThrough.h" #include "lldb/Breakpoint/Breakpoint.h" +#include "lldb/Target/CPPLanguageRuntime.h" #include "lldb/Target/DynamicLoader.h" #include "lldb/Target/ObjCLanguageRuntime.h" #include "lldb/Target/Process.h" @@ -95,6 +96,13 @@ if (objc_runtime) m_sub_plan_sp = objc_runtime->GetStepThroughTrampolinePlan(m_thread, m_stop_others); + +CPPLanguageRuntime *cpp_runtime = +m_thread.GetProcess()->GetCPPLanguageRuntime(); + +if (!m_sub_plan_sp.get() && cpp_runtime) + m_sub_plan_sp = + cpp_runtime->GetStepThroughTrampolinePlan(m_thread, m_stop_others); } Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP)); Index: source/Target/CPPLanguageRuntime.cpp === --- source/Target/CPPLanguageRuntime.cpp +++ source/Target/CPPLanguageRuntime.cpp @@ -26,6 +26,7 @@ #include "lldb/Target/SectionLoadList.h" #include "lldb/Target/StackFrame.h" #include "lldb/Target/ThreadPlanRunToAddress.h" +#include "lldb/Target/ThreadPlanStepInRange.h" using namespace lldb; using namespace lldb_private; @@ -158,7 +159,6 @@ // We do this by find the first < and , and extracting in between. // // This covers the case of the lambda known at compile time. - // size_t first_open_angle_bracket = vtable_name.find('<') + 1; size_t first_comma = vtable_name.find_first_of(','); @@ -262,3 +262,77 @@ return optional_info; } + +lldb::ThreadPlanSP +CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread &thread, + bool stop_others) { + ThreadPlanSP ret_plan_sp; + + lldb::addr_t curr_pc = thread.GetRegisterContext()->GetPC(); + + TargetSP target_sp(thread.CalculateTarget()); + + if (target_sp->GetSectionLoadList().IsEmpty()) +return ret_plan_sp; + + Address pc_addr_resolved; + SymbolContext sc; + Symbol *symbol; + + if (!target_sp->GetSectionLoadList().ResolveLoadAddress(curr_pc, + pc_addr_resolved)) +return ret_plan_sp; + + target_sp->GetImages().ResolveSymbolContextForAddress( + pc_addr_resolved, eSymbolContextEverything, sc); + symbol = sc.symbol; + + if (symbol == nullptr) +return ret_plan_sp; + + llvm::StringRef function_name(symbol->GetName().GetCString()); + + // Handling the case where we are attempting to step into std::function. + // Currently due to the the: + // + //target.process.thread.step-avoid-regexp + // + // setting we will currenly step right out of standard library code. + // + // The new behavior will be that we will attempt to obtain the wrapped + // callable via FindLibCppStdFunctionCallableInfo() and if we find it we + // will return a ThreadPlanRunToAddress to the callable. Therefore we will + // step into the wrapped callable. + // + bool found_expected_start_string = + function_name.startswith("std::__1::function<"); + + if (!found_expected_start_string) +return ret_plan_sp; + + AddressRange range_of_curr_func; + sc.GetAddressRange(eSymbolContextEverything, 0, false, range_of_curr_func); + + StackFrameSP frame = thread.GetStackFrameAtIndex(0); + + if (frame) { +ValueObjectSP value_sp = frame->FindVariable(ConstString("this")); + +CPPLanguageRuntime::LibCppStdFunctionCallableInfo callable_info = +FindLibCppStdFunctionCallableInfo(value_sp); + +if (callable_info.callable_case != LibCppStdFunctionCallableCase::Invalid && +value_sp->GetValueIsValid()) { + ret_plan_sp.reset(new ThreadPlanRunToAddress( + thread, callable_info.callable_address, stop_others)); + return ret_plan_sp; +} else { + ret_plan_sp.reset(new ThreadPlanStepInRange(thread, range_of_curr_func, + sc, eOnlyThisThread, + eLazyBoolYes, eLazyBoolYes)); + return ret_plan_sp; +} + } + + return ret_plan_sp; +} Index: packages/Python/lldbsuite/t
[Lldb-commits] [lldb] r343825 - Fix typos.
Author: brucem Date: Thu Oct 4 15:33:39 2018 New Revision: 343825 URL: http://llvm.org/viewvc/llvm-project?rev=343825&view=rev Log: Fix typos. Reviewers: lldb-commits Subscribers: srhines, ki.stfu Differential Revision: https://reviews.llvm.org/D52884 Modified: lldb/trunk/include/lldb/Utility/ConstString.h lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/trunk/source/Host/common/MainLoop.cpp lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp lldb/trunk/tools/lldb-mi/MICmnResources.cpp lldb/trunk/tools/lldb-vscode/JSONUtils.h lldb/trunk/tools/lldb-vscode/LLDBUtils.h lldb/trunk/tools/lldb-vscode/README.md lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp lldb/trunk/unittests/Core/BroadcasterTest.cpp lldb/trunk/unittests/Core/ListenerTest.cpp lldb/trunk/utils/sync-source/README.txt lldb/trunk/www/python_reference/epydoc.css Modified: lldb/trunk/include/lldb/Utility/ConstString.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/ConstString.h?rev=343825&r1=343824&r2=343825&view=diff == --- lldb/trunk/include/lldb/Utility/ConstString.h (original) +++ lldb/trunk/include/lldb/Utility/ConstString.h Thu Oct 4 15:33:39 2018 @@ -253,7 +253,7 @@ public: //-- /// Clear this object's state. /// - /// Clear any contained string and reset the value to the an empty string + /// Clear any contained string and reset the value to the empty string /// value. //-- void Clear() { m_string = nullptr; } Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py?rev=343825&r1=343824&r2=343825&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py Thu Oct 4 15:33:39 2018 @@ -907,7 +907,7 @@ def main(): '--vscode', type='string', dest='vscode_path', -help=('The path to the a command line program that implements the ' +help=('The path to the command line program that implements the ' 'Visual Studio Code Debug Adaptor protocol.'), default=None) Modified: lldb/trunk/source/Host/common/MainLoop.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/MainLoop.cpp?rev=343825&r1=343824&r2=343825&view=diff == --- lldb/trunk/source/Host/common/MainLoop.cpp (original) +++ lldb/trunk/source/Host/common/MainLoop.cpp Thu Oct 4 15:33:39 2018 @@ -309,7 +309,7 @@ MainLoop::RegisterSignal(int signo, cons g_signal_flags[signo] = 0; // Even if using kqueue, the signal handler will still be invoked, so it's - // important to replace it with our "bening" handler. + // important to replace it with our "benign" handler. int ret = sigaction(signo, &new_action, &info.old_action); assert(ret == 0 && "sigaction failed"); @@ -321,7 +321,7 @@ MainLoop::RegisterSignal(int signo, cons #endif // If we're using kqueue, the signal needs to be unblocked in order to - // recieve it. If using pselect/ppoll, we need to block it, and later unblock + // receive it. If using pselect/ppoll, we need to block it, and later unblock // it as a part of the system call. ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK, &new_action.sa_mask, &old_set); Modified: lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp?rev=343825&r1=343824&r2=343825&view=diff == --- lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp (original) +++ lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp Thu Oct 4 15:33:39 2018 @@ -157,7 +157,7 @@ static void LLVM_ATTRIBUTE_NORETURN Chil #if defined(__linux__) if (errno == ETXTBSY) { -// On android M and earlier we can get this error because the adb deamon +// On android M and earlier we can get this error because the adb daemon // can hold a write handle on the executable even after it has finished
[Lldb-commits] [PATCH] D52884: Fix typos.
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343825: Fix typos. (authored by brucem, committed by ). Changed prior to commit: https://reviews.llvm.org/D52884?vs=168279&id=168398#toc Repository: rL LLVM https://reviews.llvm.org/D52884 Files: include/lldb/Utility/ConstString.h packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py source/Host/common/MainLoop.cpp source/Host/posix/ProcessLauncherPosixFork.cpp source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-vscode/JSONUtils.h tools/lldb-vscode/LLDBUtils.h tools/lldb-vscode/README.md tools/lldb-vscode/lldb-vscode.cpp unittests/Core/BroadcasterTest.cpp unittests/Core/ListenerTest.cpp utils/sync-source/README.txt www/python_reference/epydoc.css Index: unittests/Core/BroadcasterTest.cpp === --- unittests/Core/BroadcasterTest.cpp +++ unittests/Core/BroadcasterTest.cpp @@ -24,7 +24,7 @@ Broadcaster broadcaster(nullptr, "test-broadcaster"); std::chrono::seconds timeout(0); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener1_sp = Listener::MakeListener("test-listener1"); const uint32_t event_mask1 = 1; EXPECT_EQ(event_mask1, Index: unittests/Core/ListenerTest.cpp === --- unittests/Core/ListenerTest.cpp +++ unittests/Core/ListenerTest.cpp @@ -21,7 +21,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, @@ -58,7 +58,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, Index: utils/sync-source/README.txt === --- utils/sync-source/README.txt +++ utils/sync-source/README.txt @@ -97,7 +97,7 @@ # option. # # Below, I have transfer of the lldb dir skip everything -# rooted at "/llvm" below the the lldb dir. This is +# rooted at "/llvm" below the lldb dir. This is # because we want the source OS X lldb to move to # a destination of {some-dest-root}/llvm/tools/lldb, and # not have the OS-X-inverted llvm copy over with the lldb Index: tools/lldb-mi/MICmnResources.cpp === --- tools/lldb-mi/MICmnResources.cpp +++ tools/lldb-mi/MICmnResources.cpp @@ -78,7 +78,7 @@ "and a custom plugin.\nThe custom plugin is not necessary to operate " "the MI Driver."}, {IDE_MI_APP_ARG_USAGE, "\nMI driver usage:\n\n\tlldb-mi [--longOption] " - "[-s hortOption] [executeable]\n\n[] = optional " + "[-s hortOption] [executable]\n\n[] = optional " "argument."}, {IDE_MI_APP_ARG_HELP, "-h\n--help\n\tPrints out usage information for " "the MI debugger. Exit the MI\n\tDriver " Index: tools/lldb-vscode/LLDBUtils.h === --- tools/lldb-vscode/LLDBUtils.h +++ tools/lldb-vscode/LLDBUtils.h @@ -27,7 +27,7 @@ /// /// @param[in] prefix /// A string that will be printed into \a strm prior to emitting -/// the prmopt + command and command output. Can be NULL. +/// the prompt + command and command output. Can be NULL. /// /// @param[in] commands /// An array of LLDB commands to execute. @@ -48,7 +48,7 @@ /// /// @param[in] prefix /// A string that will be printed into \a strm prior to emitting -/// the prmopt + command and command output. Can be NULL. +/// the prompt + command and command output. Can be NULL. /// /// @param[in] commands /// An array of LLDB commands to execute. Index: tools/lldb-vscode/JSONUtils.h === --- tools/lldb-vscode/JSONUtils.h +++ tools/lldb-vscode/JSONUtils.h @@ -379,7 +379,7 @@ /// object: /// "name" - the name of the variable /// "value" -
[Lldb-commits] [PATCH] D52884: Fix typos.
This revision was automatically updated to reflect the committed changes. Closed by commit rL343825: Fix typos. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52884 Files: lldb/trunk/include/lldb/Utility/ConstString.h lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/trunk/source/Host/common/MainLoop.cpp lldb/trunk/source/Host/posix/ProcessLauncherPosixFork.cpp lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp lldb/trunk/tools/lldb-mi/MICmnResources.cpp lldb/trunk/tools/lldb-vscode/JSONUtils.h lldb/trunk/tools/lldb-vscode/LLDBUtils.h lldb/trunk/tools/lldb-vscode/README.md lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp lldb/trunk/unittests/Core/BroadcasterTest.cpp lldb/trunk/unittests/Core/ListenerTest.cpp lldb/trunk/utils/sync-source/README.txt lldb/trunk/www/python_reference/epydoc.css Index: lldb/trunk/unittests/Core/BroadcasterTest.cpp === --- lldb/trunk/unittests/Core/BroadcasterTest.cpp +++ lldb/trunk/unittests/Core/BroadcasterTest.cpp @@ -24,7 +24,7 @@ Broadcaster broadcaster(nullptr, "test-broadcaster"); std::chrono::seconds timeout(0); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener1_sp = Listener::MakeListener("test-listener1"); const uint32_t event_mask1 = 1; EXPECT_EQ(event_mask1, Index: lldb/trunk/unittests/Core/ListenerTest.cpp === --- lldb/trunk/unittests/Core/ListenerTest.cpp +++ lldb/trunk/unittests/Core/ListenerTest.cpp @@ -21,7 +21,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, @@ -58,7 +58,7 @@ EventSP event_sp; Broadcaster broadcaster(nullptr, "test-broadcaster"); - // Create a listener, sign it up, make sure it recieves an event. + // Create a listener, sign it up, make sure it receives an event. ListenerSP listener_sp = Listener::MakeListener("test-listener"); const uint32_t event_mask = 1; ASSERT_EQ(event_mask, Index: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp === --- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp +++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp @@ -2449,7 +2449,7 @@ // If all of the indexed ISA variables are set, then its possible that this // ISA is indexed, and we should first try to get its value using the index. - // Note, we check these varaibles first as the ObjC runtime will set at least + // Note, we check these variables first as the ObjC runtime will set at least // one of their values to 0 if they aren't needed. if (m_objc_debug_indexed_isa_magic_mask && m_objc_debug_indexed_isa_magic_value && @@ -2536,7 +2536,7 @@ return false; } - // Definately not an indexed ISA, so try to use a mask to extract the pointer + // Definitely not an indexed ISA, so try to use a mask to extract the pointer // from the ISA. if ((isa & m_objc_debug_isa_magic_mask) == m_objc_debug_isa_magic_value) { ret_isa = isa & m_objc_debug_isa_class_mask; Index: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp === --- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp +++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp @@ -80,7 +80,7 @@ void *super_ptr; \n\ }; \n\ struct __lldb_objc_super { \n\ -void *reciever; \n\ +void *receiver; \n\ struct __lldb_objc_class *class_ptr; \n\ }; \n\ struct __lldb_msg_ref {
[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)
vsk added a comment. Ping? https://reviews.llvm.org/D50155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits