[Lldb-commits] [lldb] r340151 - [NFC] Minor update to comment
Author: aleksandr.urakov Date: Sun Aug 19 22:59:27 2018 New Revision: 340151 URL: http://llvm.org/viewvc/llvm-project?rev=340151&view=rev Log: [NFC] Minor update to comment Update comment after rLLDB339994 Differential Revision: https://reviews.llvm.org/D49980 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=340151&r1=340150&r2=340151&view=diff == --- lldb/trunk/source/Symbol/ClangASTContext.cpp (original) +++ lldb/trunk/source/Symbol/ClangASTContext.cpp Sun Aug 19 22:59:27 2018 @@ -6738,7 +6738,7 @@ CompilerType ClangASTContext::GetChildCo } } -// Setting this to UINT32_MAX to make sure we don't compute it +// Setting this to INT32_MAX to make sure we don't compute it // twice... bit_offset = INT32_MAX; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D50677: Remove manual byte counting from Opcode::Dump
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB https://reviews.llvm.org/D50677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r339974 - Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
On Fri, Aug 17, 2018 at 2:36 AM Stephane Sezer via lldb-commits wrote: > > Author: sas > Date: Thu Aug 16 17:35:47 2018 > New Revision: 339974 > > URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev > Log: > Add a relocation for R_AARCH64_ABS32 in ObjectFileELF > > Summary: > .rela.debug_info relocations are being done via > ObjectFileELF::ApplyRelocations for aarch64. Currently, the switch case > that iterates over the relocation type is only implemented for a few > different types and `assert(false)`es over the rest. > > Implement the relocation for R_AARCH64_ABS32 in ApplyRelocations > > Reviewers: sas, xiaobai, javed.absar, espindola > > Reviewed By: sas > > Subscribers: emaste, arichardson, kristof.beyls > > Differential Revision: https://reviews.llvm.org/D50369 > > Change by Nathan Lanza > This change should be unit testable, can you please give it a shot? Alternatively, you can probably use `lldb-test`, but maybe that requires some infrastructure to be written that's not there yet and I think it's not fair to ask you to write it. -- Davide ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
