[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.
teemperor created this revision.
teemperor added a reviewer: vsk.
Herald added a subscriber: mgorny.
We can optimize and refactor some of the classes in RangeMap.h, but first
we should have some tests for all the data structures in there. This adds a
first
batch of tests for the Range class itself.
There are some unexpected results happening when mixing invalid and valid
ranges, so
I added some FIXME's for that in the tests.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50620
Files:
unittests/Core/CMakeLists.txt
unittests/Core/RangeTest.cpp
Index: unittests/Core/RangeTest.cpp
===
--- /dev/null
+++ unittests/Core/RangeTest.cpp
@@ -0,0 +1,333 @@
+//===-- RangeTest.cpp *- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "lldb/Core/RangeMap.h"
+
+#include
+#include
+
+#include "gtest/gtest.h"
+
+using namespace lldb;
+using namespace lldb_private;
+
+TEST(RangeTest, SizeTypes) {
+ Range r;
+ static_assert(std::is_same::value,
+"RangeBase type is not equal to the given one.");
+ static_assert(std::is_same::value,
+"RangeEnd type is not equal to the given one.");
+ static_assert(std::is_same::value,
+"Size type is not equal to the given one.");
+}
+
+typedef Range RangeT;
+
+TEST(RangeTest, DefaultConstructor) {
+ RangeT r;
+ EXPECT_FALSE(r.IsValid());
+ EXPECT_EQ(0U, r.GetByteSize());
+ EXPECT_EQ(0U, r.GetRangeBase());
+ EXPECT_EQ(0U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Constructor) {
+ RangeT r(3, 5);
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(5U, r.GetByteSize());
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Copy) {
+ RangeT orig(3, 5);
+ RangeT r = orig;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(5U, r.GetByteSize());
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Clear) {
+ RangeT r(3, 5);
+ r.Clear();
+ EXPECT_TRUE(r == RangeT());
+}
+
+TEST(RangeTest, ClearWithStarAddress) {
+ RangeT r(3, 5);
+ r.Clear(4);
+ EXPECT_TRUE(r == RangeT(4, 0));
+}
+
+TEST(RangeTest, SetRangeBase) {
+ RangeT r(3, 5);
+ r.SetRangeBase(6);
+ EXPECT_EQ(6U, r.GetRangeBase());
+ EXPECT_EQ(11U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, Slide) {
+ RangeT r(3, 5);
+ r.Slide(1);
+ EXPECT_EQ(4U, r.GetRangeBase());
+ EXPECT_EQ(9U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+
+ r.Slide(2);
+ EXPECT_EQ(6U, r.GetRangeBase());
+ EXPECT_EQ(11U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, SlideZero) {
+ RangeT r(3, 5);
+ r.Slide(0);
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, ContainsAddr) {
+ RangeT r(3, 5);
+ EXPECT_FALSE(r.Contains(0));
+ EXPECT_FALSE(r.Contains(1));
+ EXPECT_FALSE(r.Contains(2));
+ EXPECT_TRUE(r.Contains(3));
+ EXPECT_TRUE(r.Contains(4));
+ EXPECT_TRUE(r.Contains(5));
+ EXPECT_TRUE(r.Contains(6));
+ EXPECT_TRUE(r.Contains(7));
+ EXPECT_FALSE(r.Contains(8));
+ EXPECT_FALSE(r.Contains(9));
+ EXPECT_FALSE(r.Contains(10));
+}
+
+TEST(RangeTest, ContainsAddrInvalid) {
+ RangeT r;
+ EXPECT_FALSE(r.Contains(0));
+ EXPECT_FALSE(r.Contains(1));
+ EXPECT_FALSE(r.Contains(2));
+ EXPECT_FALSE(r.Contains(3));
+ EXPECT_FALSE(r.Contains(4));
+}
+
+TEST(RangeTest, ContainsEndInclusive) {
+ RangeT r(3, 5);
+ EXPECT_FALSE(r.ContainsEndInclusive(0));
+ EXPECT_FALSE(r.ContainsEndInclusive(1));
+ EXPECT_FALSE(r.ContainsEndInclusive(2));
+ EXPECT_TRUE(r.ContainsEndInclusive(3));
+ EXPECT_TRUE(r.ContainsEndInclusive(4));
+ EXPECT_TRUE(r.ContainsEndInclusive(5));
+ EXPECT_TRUE(r.ContainsEndInclusive(6));
+ EXPECT_TRUE(r.ContainsEndInclusive(7));
+ EXPECT_TRUE(r.ContainsEndInclusive(8));
+ EXPECT_FALSE(r.ContainsEndInclusive(9));
+ EXPECT_FALSE(r.ContainsEndInclusive(10));
+}
+
+TEST(RangeTest, ContainsEndInclusiveInvalid) {
+ RangeT r;
+ // FIXME: This is probably not intended.
+ EXPECT_TRUE(r.ContainsEndInclusive(0));
+
+ EXPECT_FALSE(r.ContainsEndInclusive(1));
+ EXPECT_FALSE(r.ContainsEndInclusive(2));
+}
+
+TEST(RangeTest, ContainsRange) {
+ RangeT r(3, 5);
+
+ // Range always contains itself.
+ EXPECT_TRUE(r.Contains(r));
+ // Invalid range.
+ EXPECT_FALSE(r.Contains(RangeT()));
+ // Range starts and ends before.
+ EXPECT_FALSE(r.Contains(RangeT(0, 3)));
+ // Range starts before but contains beginning.
+ EXPECT_FALSE(r.Contains(RangeT(0, 4)));
+ // Range starts before but contains beginning and more.
+ EXPECT_FALSE(r.Contains(RangeT(0, 5)));
+ // Range starts before and contains the other.
+ EXPECT_FALSE(r.Co
[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.
teemperor added a comment. (Also we maybe might want to merge the functionalities of Range and VMRange in the future). Repository: rLLDB LLDB https://reviews.llvm.org/D50620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.
teemperor updated this revision to Diff 160286.
teemperor added a comment.
- Fixed typo in CMakeLists
https://reviews.llvm.org/D50620
Files:
unittests/Core/CMakeLists.txt
unittests/Core/RangeTest.cpp
Index: unittests/Core/RangeTest.cpp
===
--- /dev/null
+++ unittests/Core/RangeTest.cpp
@@ -0,0 +1,333 @@
+//===-- RangeTest.cpp *- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "lldb/Core/RangeMap.h"
+
+#include
+#include
+
+#include "gtest/gtest.h"
+
+using namespace lldb;
+using namespace lldb_private;
+
+TEST(RangeTest, SizeTypes) {
+ Range r;
+ static_assert(std::is_same::value,
+"RangeBase type is not equal to the given one.");
+ static_assert(std::is_same::value,
+"RangeEnd type is not equal to the given one.");
+ static_assert(std::is_same::value,
+"Size type is not equal to the given one.");
+}
+
+typedef Range RangeT;
+
+TEST(RangeTest, DefaultConstructor) {
+ RangeT r;
+ EXPECT_FALSE(r.IsValid());
+ EXPECT_EQ(0U, r.GetByteSize());
+ EXPECT_EQ(0U, r.GetRangeBase());
+ EXPECT_EQ(0U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Constructor) {
+ RangeT r(3, 5);
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(5U, r.GetByteSize());
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Copy) {
+ RangeT orig(3, 5);
+ RangeT r = orig;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(5U, r.GetByteSize());
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+}
+
+TEST(RangeTest, Clear) {
+ RangeT r(3, 5);
+ r.Clear();
+ EXPECT_TRUE(r == RangeT());
+}
+
+TEST(RangeTest, ClearWithStarAddress) {
+ RangeT r(3, 5);
+ r.Clear(4);
+ EXPECT_TRUE(r == RangeT(4, 0));
+}
+
+TEST(RangeTest, SetRangeBase) {
+ RangeT r(3, 5);
+ r.SetRangeBase(6);
+ EXPECT_EQ(6U, r.GetRangeBase());
+ EXPECT_EQ(11U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, Slide) {
+ RangeT r(3, 5);
+ r.Slide(1);
+ EXPECT_EQ(4U, r.GetRangeBase());
+ EXPECT_EQ(9U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+
+ r.Slide(2);
+ EXPECT_EQ(6U, r.GetRangeBase());
+ EXPECT_EQ(11U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, SlideZero) {
+ RangeT r(3, 5);
+ r.Slide(0);
+ EXPECT_EQ(3U, r.GetRangeBase());
+ EXPECT_EQ(8U, r.GetRangeEnd());
+ EXPECT_EQ(5U, r.GetByteSize());
+}
+
+TEST(RangeTest, ContainsAddr) {
+ RangeT r(3, 5);
+ EXPECT_FALSE(r.Contains(0));
+ EXPECT_FALSE(r.Contains(1));
+ EXPECT_FALSE(r.Contains(2));
+ EXPECT_TRUE(r.Contains(3));
+ EXPECT_TRUE(r.Contains(4));
+ EXPECT_TRUE(r.Contains(5));
+ EXPECT_TRUE(r.Contains(6));
+ EXPECT_TRUE(r.Contains(7));
+ EXPECT_FALSE(r.Contains(8));
+ EXPECT_FALSE(r.Contains(9));
+ EXPECT_FALSE(r.Contains(10));
+}
+
+TEST(RangeTest, ContainsAddrInvalid) {
+ RangeT r;
+ EXPECT_FALSE(r.Contains(0));
+ EXPECT_FALSE(r.Contains(1));
+ EXPECT_FALSE(r.Contains(2));
+ EXPECT_FALSE(r.Contains(3));
+ EXPECT_FALSE(r.Contains(4));
+}
+
+TEST(RangeTest, ContainsEndInclusive) {
+ RangeT r(3, 5);
+ EXPECT_FALSE(r.ContainsEndInclusive(0));
+ EXPECT_FALSE(r.ContainsEndInclusive(1));
+ EXPECT_FALSE(r.ContainsEndInclusive(2));
+ EXPECT_TRUE(r.ContainsEndInclusive(3));
+ EXPECT_TRUE(r.ContainsEndInclusive(4));
+ EXPECT_TRUE(r.ContainsEndInclusive(5));
+ EXPECT_TRUE(r.ContainsEndInclusive(6));
+ EXPECT_TRUE(r.ContainsEndInclusive(7));
+ EXPECT_TRUE(r.ContainsEndInclusive(8));
+ EXPECT_FALSE(r.ContainsEndInclusive(9));
+ EXPECT_FALSE(r.ContainsEndInclusive(10));
+}
+
+TEST(RangeTest, ContainsEndInclusiveInvalid) {
+ RangeT r;
+ // FIXME: This is probably not intended.
+ EXPECT_TRUE(r.ContainsEndInclusive(0));
+
+ EXPECT_FALSE(r.ContainsEndInclusive(1));
+ EXPECT_FALSE(r.ContainsEndInclusive(2));
+}
+
+TEST(RangeTest, ContainsRange) {
+ RangeT r(3, 5);
+
+ // Range always contains itself.
+ EXPECT_TRUE(r.Contains(r));
+ // Invalid range.
+ EXPECT_FALSE(r.Contains(RangeT()));
+ // Range starts and ends before.
+ EXPECT_FALSE(r.Contains(RangeT(0, 3)));
+ // Range starts before but contains beginning.
+ EXPECT_FALSE(r.Contains(RangeT(0, 4)));
+ // Range starts before but contains beginning and more.
+ EXPECT_FALSE(r.Contains(RangeT(0, 5)));
+ // Range starts before and contains the other.
+ EXPECT_FALSE(r.Contains(RangeT(0, 9)));
+ // Range is fully inside.
+ EXPECT_TRUE(r.Contains(RangeT(4, 3)));
+ // Range has same start, but not as large.
+ EXPECT_TRUE(r.Contains(RangeT(3, 4)));
+ // Range has same end, but starts earlier.
+ EXPECT_TRUE(r.Contains(RangeT(4, 4)));
+ // Range starts inside, but stops after the end of r.
+ EXPECT_FALSE(r.Contains(Ra
