[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==
aleksandr.urakov added a comment. Thank you! It builds well on Windows with this patch for me. Can you commit this, please? I have no commit access. https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r336483 - Fix build on Windows with SDK build version >= 17134.
Author: tkrasnukha Date: Sat Jul 7 07:58:13 2018 New Revision: 336483 URL: http://llvm.org/viewvc/llvm-project?rev=336483&view=rev Log: Fix build on Windows with SDK build version >= 17134. Platform.h doesn't define signal() and SIGINT since commit r263858. Code was compiled successfully because signal.h didn't have "ifndef" include guard in previous versions of Windows SDK. Now it does. Modified: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp Modified: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriverMain.cpp?rev=336483&r1=336482&r2=336483&view=diff == --- lldb/trunk/tools/lldb-mi/MIDriverMain.cpp (original) +++ lldb/trunk/tools/lldb-mi/MIDriverMain.cpp Sat Jul 7 07:58:13 2018 @@ -26,11 +26,6 @@ // MICmdBase.h / .cpp // MICmdCmd.h / .cpp -#if defined(_MSC_VER) -#define _INC_SIGNAL // Stop window's signal.h being included - -// CODETAG_IOR_SIGNALS -#endif // _MSC_VER - // Third party headers: #include "lldb/API/SBHostOS.h" #include ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r336494 - Add LLDB_API to SBAddress's operator==.
Author: apolyakov Date: Sat Jul 7 11:54:44 2018 New Revision: 336494 URL: http://llvm.org/viewvc/llvm-project?rev=336494&view=rev Log: Add LLDB_API to SBAddress's operator==. Summary: Add LLDB_API to SBAddress's operator== to fix lldb-mi build on Windows. Patch by Aleksandr Urakov! Differential Revision: https://reviews.llvm.org/D49006 Modified: lldb/trunk/include/lldb/API/SBAddress.h Modified: lldb/trunk/include/lldb/API/SBAddress.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBAddress.h?rev=336494&r1=336493&r2=336494&view=diff == --- lldb/trunk/include/lldb/API/SBAddress.h (original) +++ lldb/trunk/include/lldb/API/SBAddress.h Sat Jul 7 11:54:44 2018 @@ -101,7 +101,7 @@ protected: const lldb_private::Address *operator->() const; - friend bool operator==(const SBAddress &lhs, const SBAddress &rhs); + friend bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); lldb_private::Address *get(); @@ -117,7 +117,7 @@ private: std::unique_ptr m_opaque_ap; }; -bool operator==(const SBAddress &lhs, const SBAddress &rhs); +bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); } // namespace lldb ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==
This revision was automatically updated to reflect the committed changes. Closed by commit rL336494: Add LLDB_API to SBAddress's operator==. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49006?vs=154360&id=154498#toc Repository: rL LLVM https://reviews.llvm.org/D49006 Files: lldb/trunk/include/lldb/API/SBAddress.h Index: lldb/trunk/include/lldb/API/SBAddress.h === --- lldb/trunk/include/lldb/API/SBAddress.h +++ lldb/trunk/include/lldb/API/SBAddress.h @@ -101,7 +101,7 @@ const lldb_private::Address *operator->() const; - friend bool operator==(const SBAddress &lhs, const SBAddress &rhs); + friend bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); lldb_private::Address *get(); @@ -117,7 +117,7 @@ std::unique_ptr m_opaque_ap; }; -bool operator==(const SBAddress &lhs, const SBAddress &rhs); +bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); } // namespace lldb Index: lldb/trunk/include/lldb/API/SBAddress.h === --- lldb/trunk/include/lldb/API/SBAddress.h +++ lldb/trunk/include/lldb/API/SBAddress.h @@ -101,7 +101,7 @@ const lldb_private::Address *operator->() const; - friend bool operator==(const SBAddress &lhs, const SBAddress &rhs); + friend bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); lldb_private::Address *get(); @@ -117,7 +117,7 @@ std::unique_ptr m_opaque_ap; }; -bool operator==(const SBAddress &lhs, const SBAddress &rhs); +bool LLDB_API operator==(const SBAddress &lhs, const SBAddress &rhs); } // namespace lldb ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
