[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64
alexandreyy added a comment. Hi @labath . Could you please commit this patch? https://reviews.llvm.org/D44472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44738: Add a test for setting the load address of a module with differing physical/virtual addresses
owenpshaw accepted this revision. owenpshaw added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks! https://reviews.llvm.org/D44738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
tromey updated this revision to Diff 139616.
tromey added a comment.
Add unit test
https://reviews.llvm.org/D44693
Files:
source/Core/Scalar.cpp
unittests/Core/ScalarTest.cpp
Index: unittests/Core/ScalarTest.cpp
===
--- unittests/Core/ScalarTest.cpp
+++ unittests/Core/ScalarTest.cpp
@@ -132,3 +132,11 @@
EXPECT_EQ(std::to_string(std::numeric_limits::max()),
ScalarGetValue(std::numeric_limits::max()));
}
+
+TEST(ScalarTest, Division) {
+ Scalar lhs(5.0);
+ Scalar rhs(2.0);
+ Scalar r = lhs / rhs;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(r, Scalar(2.5));
+}
Index: source/Core/Scalar.cpp
===
--- source/Core/Scalar.cpp
+++ source/Core/Scalar.cpp
@@ -2266,7 +2266,7 @@
case Scalar::e_float:
case Scalar::e_double:
case Scalar::e_long_double:
- if (b->m_float.isZero()) {
+ if (!b->m_float.isZero()) {
result.m_float = a->m_float / b->m_float;
return result;
}
Index: unittests/Core/ScalarTest.cpp
===
--- unittests/Core/ScalarTest.cpp
+++ unittests/Core/ScalarTest.cpp
@@ -132,3 +132,11 @@
EXPECT_EQ(std::to_string(std::numeric_limits::max()),
ScalarGetValue(std::numeric_limits::max()));
}
+
+TEST(ScalarTest, Division) {
+ Scalar lhs(5.0);
+ Scalar rhs(2.0);
+ Scalar r = lhs / rhs;
+ EXPECT_TRUE(r.IsValid());
+ EXPECT_EQ(r, Scalar(2.5));
+}
Index: source/Core/Scalar.cpp
===
--- source/Core/Scalar.cpp
+++ source/Core/Scalar.cpp
@@ -2266,7 +2266,7 @@
case Scalar::e_float:
case Scalar::e_double:
case Scalar::e_long_double:
- if (b->m_float.isZero()) {
+ if (!b->m_float.isZero()) {
result.m_float = a->m_float / b->m_float;
return result;
}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44613: Support template template parameters
friss updated this revision to Diff 139619.
friss added a comment.
Use LLVM macro for fallthrough
https://reviews.llvm.org/D44613
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/template/TestTemplateArgs.py
packages/Python/lldbsuite/test/lang/cpp/template/main.cpp
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
source/Symbol/ClangASTContext.cpp
Index: source/Symbol/ClangASTContext.cpp
===
--- source/Symbol/ClangASTContext.cpp
+++ source/Symbol/ClangASTContext.cpp
@@ -1482,6 +1482,29 @@
return class_template_decl;
}
+TemplateTemplateParmDecl *
+ClangASTContext::CreateTemplateTemplateParmDecl(const char *template_name) {
+ ASTContext *ast = getASTContext();
+
+ auto *decl_ctx = ast->getTranslationUnitDecl();
+
+ IdentifierInfo &identifier_info = ast->Idents.get(template_name);
+ llvm::SmallVector template_param_decls;
+
+ ClangASTContext::TemplateParameterInfos template_param_infos;
+ TemplateParameterList *template_param_list = CreateTemplateParameterList(
+ ast, template_param_infos, template_param_decls);
+
+ // LLDB needs to create those decls only to be able to display a
+ // type that includes a template template argument. Only the name
+ // matters for this purpose, so we use dummy values for the other
+ // characterisitcs of the type.
+ return TemplateTemplateParmDecl::Create(
+ *ast, decl_ctx, SourceLocation(),
+ /*Depth*/ 0, /*Position*/ 0,
+ /*IsParameterPack*/ false, &identifier_info, template_param_list);
+}
+
ClassTemplateSpecializationDecl *
ClangASTContext::CreateClassTemplateSpecializationDecl(
DeclContext *decl_ctx, ClassTemplateDecl *class_template_decl, int kind,
Index: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
===
--- source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -41,6 +41,7 @@
#include "clang/AST/CXXInheritance.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclObjC.h"
+#include "clang/AST/DeclTemplate.h"
#include
#include
@@ -2021,6 +2022,7 @@
const DWARFDIE &die,
ClangASTContext::TemplateParameterInfos &template_param_infos) {
const dw_tag_t tag = die.Tag();
+ bool is_template_template_argument = false;
switch (tag) {
case DW_TAG_GNU_template_parameter_pack: {
@@ -2036,11 +2038,15 @@
}
return true;
}
+ case DW_TAG_GNU_template_template_param:
+is_template_template_argument = true;
+LLVM_FALLTHROUGH;
case DW_TAG_template_type_parameter:
case DW_TAG_template_value_parameter: {
DWARFAttributes attributes;
const size_t num_attributes = die.GetAttributes(attributes);
const char *name = nullptr;
+const char *template_name = nullptr;
CompilerType clang_type;
uint64_t uval64 = 0;
bool uval64_valid = false;
@@ -2055,6 +2061,11 @@
name = form_value.AsCString();
break;
+case DW_AT_GNU_template_name:
+ if (attributes.ExtractFormValueAtIndex(i, form_value))
+template_name = form_value.AsCString();
+ break;
+
case DW_AT_type:
if (attributes.ExtractFormValueAtIndex(i, form_value)) {
Type *lldb_type = die.ResolveTypeUID(DIERef(form_value));
@@ -2078,7 +2089,7 @@
if (!clang_type)
clang_type = m_ast.GetBasicType(eBasicTypeVoid);
- if (clang_type) {
+ if (!is_template_template_argument) {
bool is_signed = false;
if (name && name[0])
template_param_infos.names.push_back(name);
@@ -2098,7 +2109,10 @@
clang::TemplateArgument(ClangUtil::GetQualType(clang_type)));
}
} else {
-return false;
+auto *tplt_type = m_ast.CreateTemplateTemplateParmDecl(template_name);
+template_param_infos.names.push_back(name);
+template_param_infos.args.push_back(
+clang::TemplateArgument(clang::TemplateName(tplt_type)));
}
}
}
@@ -2125,6 +2139,7 @@
case DW_TAG_template_type_parameter:
case DW_TAG_template_value_parameter:
case DW_TAG_GNU_template_parameter_pack:
+case DW_TAG_GNU_template_template_param:
ParseTemplateDIE(die, template_param_infos);
break;
Index: packages/Python/lldbsuite/test/lang/cpp/template/main.cpp
===
--- packages/Python/lldbsuite/test/lang/cpp/template/main.cpp
+++ packages/Python/lldbsuite/test/lang/cpp/template/main.cpp
@@ -6,6 +6,7 @@
// License. See LICENSE.TXT for details.
//
//===--===//
+#include
template
class TestObj
@@ -62,11 +63,17 @@
}
};
+template struct T1 { FLOAT f = 1.5; };
+template struct T2 { FLOAT f = 2.5; int i = 42; };
+template class ...Args> class
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
davide accepted this revision. davide added a comment. LGTM, thanks. Do you have commit access or you need somebody to commit this on your behalf? https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar
tromey added a comment. In https://reviews.llvm.org/D44693#1046925, @davide wrote: > LGTM, thanks. Do you have commit access or you need somebody to commit this > on your behalf? I do not have commit access. https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328365 - Log ObjC Runtime messages only in verbose mode
Author: adrian Date: Fri Mar 23 13:17:39 2018 New Revision: 328365 URL: http://llvm.org/viewvc/llvm-project?rev=328365&view=rev Log: Log ObjC Runtime messages only in verbose mode Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp?rev=328365&r1=328364&r2=328365&view=diff == --- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (original) +++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Fri Mar 23 13:17:39 2018 @@ -1440,8 +1440,8 @@ uint32_t AppleObjCRuntimeV2::ParseClassI //uint32_t hash; //} __attribute__((__packed__)); - Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_PROCESS | LIBLLDB_LOG_TYPES)); - + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_TYPES +| LLDB_LOG_OPTION_VERBOSE)); uint32_t num_parsed = 0; // Iterate through all ClassInfo structures ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328368 - [Command] Remove dead code for the syntax command.
Author: davide
Date: Fri Mar 23 13:58:05 2018
New Revision: 328368
URL: http://llvm.org/viewvc/llvm-project?rev=328368&view=rev
Log:
[Command] Remove dead code for the syntax command.
I'm going to add a new commend so I figured I could do
some spring cleaning.
Removed:
lldb/trunk/source/Commands/CommandObjectSyntax.cpp
lldb/trunk/source/Commands/CommandObjectSyntax.h
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Commands/CMakeLists.txt
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328368&r1=328367&r2=328368&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 13:58:05 2018
@@ -396,7 +396,6 @@
2689002313353DDE00698AC0 /* CommandObjectScript.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 26BC7E3D10F1B84700F91463 /*
CommandObjectScript.cpp */; };
2689002413353DDE00698AC0 /* CommandObjectSettings.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 26BC7E4010F1B84700F91463 /*
CommandObjectSettings.cpp */; };
2689002513353DDE00698AC0 /* CommandObjectSource.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 26BC7E4210F1B84700F91463 /*
CommandObjectSource.cpp */; };
- 2689002613353DDE00698AC0 /* CommandObjectSyntax.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 26BC7E4510F1B84700F91463 /*
CommandObjectSyntax.cpp */; };
2689002713353DDE00698AC0 /* CommandObjectTarget.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 269416AD119A024800FF2715 /*
CommandObjectTarget.cpp */; };
2689002813353DDE00698AC0 /* CommandObjectThread.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 26BC7E4610F1B84700F91463 /*
CommandObjectThread.cpp */; };
2689002913353DDE00698AC0 /* CommandObjectVersion.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = B296983412C2FB2B002D92C3 /*
CommandObjectVersion.cpp */; };
@@ -2114,7 +2113,6 @@
26BC7D2410F1B76300F91463 /* CommandObjectScript.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectScript.h; path = source/Interpreter/CommandObjectScript.h;
sourceTree = ""; };
26BC7D2710F1B76300F91463 /* CommandObjectSettings.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectSettings.h; path = source/Commands/CommandObjectSettings.h;
sourceTree = ""; };
26BC7D2910F1B76300F91463 /* CommandObjectSource.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectSource.h; path = source/Commands/CommandObjectSource.h; sourceTree
= ""; };
- 26BC7D2C10F1B76300F91463 /* CommandObjectSyntax.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectSyntax.h; path = source/Commands/CommandObjectSyntax.h; sourceTree
= ""; };
26BC7D2D10F1B76300F91463 /* CommandObjectThread.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectThread.h; path = source/Commands/CommandObjectThread.h; sourceTree
= ""; };
26BC7D5010F1B77400F91463 /* Address.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
Address.h; path = include/lldb/Core/Address.h; sourceTree = ""; };
26BC7D5110F1B77400F91463 /* AddressRange.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
AddressRange.h; path = include/lldb/Core/AddressRange.h; sourceTree =
""; };
@@ -2197,7 +2195,6 @@
26BC7E3D10F1B84700F91463 /* CommandObjectScript.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectScript.cpp; path =
source/Interpreter/CommandObjectScript.cpp; sourceTree = ""; };
26BC7E4010F1B84700F91463 /* CommandObjectSettings.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectSettings.cpp; path =
source/Commands/CommandObjectSettings.cpp; sourceTree = ""; };
26BC7E4210F1B84700F91463 /* CommandObjectSource.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectSource.cpp; path = source/Commands/CommandObjectSource.cpp;
sourceTree = ""; };
- 26BC7E4510F1B84700F91463 /* CommandObjectSyntax.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectSyntax.cpp; path = source/Commands/CommandObjectSyntax.cpp;
sourceTree = ""; };
26BC7E4610F1B
[Lldb-commits] [lldb] r328370 - [Commands] Remove dead code for unused `args` command.
Author: davide
Date: Fri Mar 23 14:04:34 2018
New Revision: 328370
URL: http://llvm.org/viewvc/llvm-project?rev=328370&view=rev
Log:
[Commands] Remove dead code for unused `args` command.
It wasn't even registered.
(lldb) apropos args
No commands found pertaining to 'args'. Try 'help' to see
a complete list of debugger commands.
Removed:
lldb/trunk/source/Commands/CommandObjectArgs.cpp
lldb/trunk/source/Commands/CommandObjectArgs.h
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328370&r1=328369&r2=328370&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 14:04:34 2018
@@ -379,7 +379,6 @@
2689000F13353DB600698AC0 /* StoppointLocation.cpp in Sources */
= {isa = PBXBuildFile; fileRef = 26BC7E1710F1B83100F91463 /*
StoppointLocation.cpp */; };
2689001113353DB600698AC0 /* Watchpoint.cpp in Sources */ = {isa
= PBXBuildFile; fileRef = 26BC7E1810F1B83100F91463 /* Watchpoint.cpp */; };
2689001213353DDE00698AC0 /* CommandObjectApropos.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 4CA9637911B6E99A00780E28 /*
CommandObjectApropos.cpp */; };
- 2689001313353DDE00698AC0 /* CommandObjectArgs.cpp in Sources */
= {isa = PBXBuildFile; fileRef = 499F381F11A5B3F300F5CE02 /*
CommandObjectArgs.cpp */; };
2689001413353DDE00698AC0 /* CommandObjectBreakpoint.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 26BC7E2D10F1B84700F91463 /*
CommandObjectBreakpoint.cpp */; };
2689001513353DDE00698AC0 /* CommandObjectBreakpointCommand.cpp
in Sources */ = {isa = PBXBuildFile; fileRef = 9A42976211861AA600FE05CD /*
CommandObjectBreakpointCommand.cpp */; };
2689001613353DDE00698AC0 /* CommandObjectCommands.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 4C5DBBC611E3FEC60035160F /*
CommandObjectCommands.cpp */; };
@@ -2510,8 +2509,6 @@
4987FB1C1F30EC6000E5C17D /* SBProcessInfo.i */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.c.preprocessed; path = SBProcessInfo.i; sourceTree = ""; };
4987FB1E1F30EC7E00E5C17D /* SBProcessInfo.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = SBProcessInfo.cpp; path = source/API/SBProcessInfo.cpp; sourceTree =
""; };
4987FB201F30EC9900E5C17D /* SBProcessInfo.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
SBProcessInfo.h; path = include/lldb/API/SBProcessInfo.h; sourceTree =
""; };
- 499F381E11A5B3F300F5CE02 /* CommandObjectArgs.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectArgs.h; path = source/Commands/CommandObjectArgs.h; sourceTree =
""; };
- 499F381F11A5B3F300F5CE02 /* CommandObjectArgs.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectArgs.cpp; path = source/Commands/CommandObjectArgs.cpp;
sourceTree = ""; };
49A1CAC11430E21D00306AC9 /* ExpressionSourceCode.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
ExpressionSourceCode.h; path = include/lldb/Expression/ExpressionSourceCode.h;
sourceTree = ""; };
49A1CAC31430E8BD00306AC9 /* ExpressionSourceCode.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = ExpressionSourceCode.cpp; path =
source/Expression/ExpressionSourceCode.cpp; sourceTree = ""; };
49A8A39F11D568A300AD3B68 /* ASTResultSynthesizer.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = ASTResultSynthesizer.cpp; path =
ExpressionParser/Clang/ASTResultSynthesizer.cpp; sourceTree = ""; };
@@ -5170,8 +5167,6 @@
children = (
4CA9637A11B6E99A00780E28 /*
CommandObjectApropos.h */,
4CA9637911B6E99A00780E28 /*
CommandObjectApropos.cpp */,
- 499F381E11A5B3F300F5CE02 /* CommandObjectArgs.h
*/,
- 499F381F11A5B3F300F5CE02 /*
CommandObjectArgs.cpp */,
26BC7D1410F1B76300F91463 /*
CommandObjectBreakpoint.h */,
26BC7E2D10F1B84700F91463 /*
CommandObjectBreakpoint.cpp */,
9A42976111861A9F00FE05CD /*
CommandObjectBreakpointCommand.h */,
@@ -7529,7 +7524,6 @@
AE44FB4C1BB4BB540033EB62 /*
GoFormatterFunctions.cpp in Sources
[Lldb-commits] [lldb] r328373 - [CMakeLists] Update file list after recent changes.
Author: davide Date: Fri Mar 23 14:21:17 2018 New Revision: 328373 URL: http://llvm.org/viewvc/llvm-project?rev=328373&view=rev Log: [CMakeLists] Update file list after recent changes. Modified: lldb/trunk/source/Commands/CMakeLists.txt Modified: lldb/trunk/source/Commands/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CMakeLists.txt?rev=328373&r1=328372&r2=328373&view=diff == --- lldb/trunk/source/Commands/CMakeLists.txt (original) +++ lldb/trunk/source/Commands/CMakeLists.txt Fri Mar 23 14:21:17 2018 @@ -1,7 +1,6 @@ add_lldb_library(lldbCommands CommandCompletions.cpp CommandObjectApropos.cpp - CommandObjectArgs.cpp CommandObjectBreakpoint.cpp CommandObjectBreakpointCommand.cpp CommandObjectBugreport.cpp ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328374 - Change the darwin-debug target to build the standard
Author: jmolenda
Date: Fri Mar 23 14:37:19 2018
New Revision: 328374
URL: http://llvm.org/viewvc/llvm-project?rev=328374&view=rev
Log:
Change the darwin-debug target to build the standard
archs.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328374&r1=328373&r2=328374&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 14:37:19 2018
@@ -8341,14 +8341,8 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
- "ARCHS[sdk=iphoneos*]" = (
- arm64,
- armv7,
- );
- "ARCHS[sdk=macosx*]" = (
- x86_64,
- i386,
- );
+ "ARCHS[sdk=iphoneos*]" = "$(ARCHS_STANDARD)";
+ "ARCHS[sdk=macosx*]" = "$(ARCHS_STANDARD)";
CLANG_CXX_LANGUAGE_STANDARD = "c++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_WARN_BOOL_CONVERSION = YES;
@@ -8438,8 +8432,8 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
- "ARCHS[sdk=iphoneos*]" = arm64;
- "ARCHS[sdk=macosx*]" =
"$(ARCHS_STANDARD_64_BIT)";
+ "ARCHS[sdk=iphoneos*]" = "$(ARCHS_STANDARD)";
+ "ARCHS[sdk=macosx*]" = "$(ARCHS_STANDARD)";
CLANG_CXX_LANGUAGE_STANDARD = "c++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_WARN_BOOL_CONVERSION = YES;
@@ -9386,11 +9380,8 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
- "ARCHS[sdk=iphoneos*]" = arm64;
- "ARCHS[sdk=macosx*]" = (
- x86_64,
- i386,
- );
+ "ARCHS[sdk=iphoneos*]" = "$(ARCHS_STANDARD)";
+ "ARCHS[sdk=macosx*]" = "$(ARCHS_STANDARD)";
CLANG_CXX_LANGUAGE_STANDARD = "c++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_WARN_BOOL_CONVERSION = YES;
@@ -10098,14 +10089,8 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
- "ARCHS[sdk=iphoneos*]" = (
- armv7,
- arm64,
- );
- "ARCHS[sdk=macosx*]" = (
- x86_64,
- i386,
- );
+ "ARCHS[sdk=iphoneos*]" = "$(ARCHS_STANDARD)";
+ "ARCHS[sdk=macosx*]" = "$(ARCHS_STANDARD)";
CLANG_CXX_LANGUAGE_STANDARD = "c++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_WARN_BOOL_CONVERSION = YES;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328378 - [Commands] Add a (currently empty) `stats` command.
Author: davide
Date: Fri Mar 23 14:55:48 2018
New Revision: 328378
URL: http://llvm.org/viewvc/llvm-project?rev=328378&view=rev
Log:
[Commands] Add a (currently empty) `stats` command.
This one will be used to print statistics about lldb sessions
(including, e.g. number of expression evaluation succeeded or
failed). I decided to commit the skeleton first so that we have
a clean reference on how a command should be implemented.
My future commits are going to populate this command and test
it.
Added:
lldb/trunk/source/Commands/CommandObjectStats.cpp
lldb/trunk/source/Commands/CommandObjectStats.h
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Commands/CMakeLists.txt
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328378&r1=328377&r2=328378&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 14:55:48 2018
@@ -765,6 +765,8 @@
4CF52AF8142829390051E832 /* SBFileSpecList.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 4CF52AF7142829390051E832 /* SBFileSpecList.cpp
*/; };
54067BF11DF2041B00749AA5 /* UBSanRuntime.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 54067BEC1DF2034B00749AA5 /* UBSanRuntime.cpp */;
};
6B74D89B200696BB0074051B /* Environment.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 22DC561920064C9600A7E9E8 /* Environment.cpp */;
};
+ 6B8894792065AE5D002E5C59 /* CommandObjectStats.h in CopyFiles
*/ = {isa = PBXBuildFile; fileRef = 6B8894772065AE5C002E5C59 /*
CommandObjectStats.h */; };
+ 6B88947A2065AE5D002E5C59 /* CommandObjectStats.cpp in CopyFiles
*/ = {isa = PBXBuildFile; fileRef = 6B8894782065AE5C002E5C59 /*
CommandObjectStats.cpp */; };
6D0F61431C80AAAE00A4ECEE /* JavaASTContext.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 6D0F61411C8000A4ECEE /* JavaASTContext.cpp
*/; };
6D0F61481C80AAD600A4ECEE /* DWARFASTParserJava.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 6D0F61441C80AACF00A4ECEE /*
DWARFASTParserJava.cpp */; };
6D0F614E1C80AB0700A4ECEE /* JavaLanguageRuntime.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 6D0F614A1C80AB0400A4ECEE /*
JavaLanguageRuntime.cpp */; };
@@ -1266,6 +1268,8 @@
dstPath = "$(DEVELOPER_INSTALL_DIR)/usr/share/man/man1";
dstSubfolderSpec = 0;
files = (
+ 6B88947A2065AE5D002E5C59 /*
CommandObjectStats.cpp in CopyFiles */,
+ 6B8894792065AE5D002E5C59 /*
CommandObjectStats.h in CopyFiles */,
7F94D7182040A13A006EE3EA /* CleanUpTest.cpp in
CopyFiles */,
AF90106515AB7D3600FF120D /* lldb.1 in CopyFiles
*/,
);
@@ -2667,6 +2671,8 @@
69A01E1C1236C5D400C660B5 /* Host.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = Host.cpp; sourceTree = ""; };
69A01E1F1236C5D400C660B5 /* Symbols.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = Symbols.cpp; sourceTree = ""; };
6B74D89C2006972D0074051B /* Environment.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
Environment.h; path = include/lldb/Utility/Environment.h; sourceTree =
""; };
+ 6B8894772065AE5C002E5C59 /* CommandObjectStats.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
CommandObjectStats.h; path = source/Commands/CommandObjectStats.h; sourceTree =
""; };
+ 6B8894782065AE5C002E5C59 /* CommandObjectStats.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CommandObjectStats.cpp; path = source/Commands/CommandObjectStats.cpp;
sourceTree = ""; };
6D0F613C1C80AA8900A4ECEE /* DebugMacros.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
DebugMacros.h; path = include/lldb/Symbol/DebugMacros.h; sourceTree =
""; };
6D0F613D1C80AA8900A4ECEE /* JavaASTContext.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
JavaASTContext.h; path = include/lldb/Symbol/JavaASTContext.h; sourceTree =
""; };
6D0F61411C8000A4ECEE /* JavaASTContext.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = JavaASTContext.cpp; path = source/Symbol/JavaASTContext.cpp; sourceTree
= ""; };
@@ -5165,6 +5171,8 @@
26BC7D0D10F1
[Lldb-commits] [lldb] r328382 - Put CommandObjectStats.cpp in lldb-core target, remove CommandObjectStats.h from targets.
Author: jmolenda
Date: Fri Mar 23 15:50:23 2018
New Revision: 328382
URL: http://llvm.org/viewvc/llvm-project?rev=328382&view=rev
Log:
Put CommandObjectStats.cpp in lldb-core target, remove CommandObjectStats.h
from targets.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328382&r1=328381&r2=328382&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 15:50:23 2018
@@ -765,7 +765,6 @@
4CF52AF8142829390051E832 /* SBFileSpecList.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 4CF52AF7142829390051E832 /* SBFileSpecList.cpp
*/; };
54067BF11DF2041B00749AA5 /* UBSanRuntime.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 54067BEC1DF2034B00749AA5 /* UBSanRuntime.cpp */;
};
6B74D89B200696BB0074051B /* Environment.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 22DC561920064C9600A7E9E8 /* Environment.cpp */;
};
- 6B8894792065AE5D002E5C59 /* CommandObjectStats.h in CopyFiles
*/ = {isa = PBXBuildFile; fileRef = 6B8894772065AE5C002E5C59 /*
CommandObjectStats.h */; };
6B88947A2065AE5D002E5C59 /* CommandObjectStats.cpp in CopyFiles
*/ = {isa = PBXBuildFile; fileRef = 6B8894782065AE5C002E5C59 /*
CommandObjectStats.cpp */; };
6D0F61431C80AAAE00A4ECEE /* JavaASTContext.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 6D0F61411C8000A4ECEE /* JavaASTContext.cpp
*/; };
6D0F61481C80AAD600A4ECEE /* DWARFASTParserJava.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 6D0F61441C80AACF00A4ECEE /*
DWARFASTParserJava.cpp */; };
@@ -1018,6 +1017,7 @@
AF9FF1F71FAA79FE00474976 /* LibCxxQueue.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = AF9FF1F61FAA79FE00474976 /* LibCxxQueue.cpp */;
};
AFAFD80A1E57E1B90017A14F /* ModuleCacheTest.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = AFAFD8091E57E1B90017A14F /* ModuleCacheTest.cpp
*/; };
AFB3D2801AC262AB003B4B30 /* MICmdCmdGdbShow.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = AFB3D27E1AC262AB003B4B30 /* MICmdCmdGdbShow.cpp
*/; };
+ AFB6B9ED2065BBE90047661E /* CommandObjectStats.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 6B8894782065AE5C002E5C59 /*
CommandObjectStats.cpp */; };
AFC234091AF85CE100CDE8B6 /* CommandObjectLanguage.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = AFC234061AF85CE000CDE8B6 /*
CommandObjectLanguage.cpp */; };
AFC2DCE71E6E2ED000283714 /* FastDemangle.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = AFC2DCE61E6E2ED000283714 /* FastDemangle.cpp */;
};
AFC2DCE91E6E2F2C00283714 /* Baton.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = AFC2DCE81E6E2F2C00283714 /* Baton.cpp */; };
@@ -1269,7 +1269,6 @@
dstSubfolderSpec = 0;
files = (
6B88947A2065AE5D002E5C59 /*
CommandObjectStats.cpp in CopyFiles */,
- 6B8894792065AE5D002E5C59 /*
CommandObjectStats.h in CopyFiles */,
7F94D7182040A13A006EE3EA /* CleanUpTest.cpp in
CopyFiles */,
AF90106515AB7D3600FF120D /* lldb.1 in CopyFiles
*/,
);
@@ -5171,8 +5170,6 @@
26BC7D0D10F1B71D00F91463 /* Commands */ = {
isa = PBXGroup;
children = (
- 6B8894782065AE5C002E5C59 /*
CommandObjectStats.cpp */,
- 6B8894772065AE5C002E5C59 /*
CommandObjectStats.h */,
4CA9637A11B6E99A00780E28 /*
CommandObjectApropos.h */,
4CA9637911B6E99A00780E28 /*
CommandObjectApropos.cpp */,
26BC7D1410F1B76300F91463 /*
CommandObjectBreakpoint.h */,
@@ -5215,6 +5212,8 @@
26BC7E4010F1B84700F91463 /*
CommandObjectSettings.cpp */,
26BC7D2910F1B76300F91463 /*
CommandObjectSource.h */,
26BC7E4210F1B84700F91463 /*
CommandObjectSource.cpp */,
+ 6B8894782065AE5C002E5C59 /*
CommandObjectStats.cpp */,
+ 6B8894772065AE5C002E5C59 /*
CommandObjectStats.h */,
269416AE119A024800FF2715 /*
CommandObjectTarget.h */,
269416AD119A024800FF2715 /*
CommandObjectTarget.cpp */,
26BC7D2D10F1B76300F91463 /*
CommandObjectThread.h */,
@@ -8042,6 +8041,7 @@
B2462247141AD37D00F3D409 /*
OptionGroupWatchpoint.cpp in Sourc
[Lldb-commits] [lldb] r328383 - Remove CommandObjectStats.cpp & CleanUpTest.cpp from
Author: jmolenda Date: Fri Mar 23 16:32:16 2018 New Revision: 328383 URL: http://llvm.org/viewvc/llvm-project?rev=328383&view=rev Log: Remove CommandObjectStats.cpp & CleanUpTest.cpp from installing in the man page directory. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=328383&r1=328382&r2=328383&view=diff == --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original) +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 23 16:32:16 2018 @@ -1268,8 +1268,6 @@ dstPath = "$(DEVELOPER_INSTALL_DIR)/usr/share/man/man1"; dstSubfolderSpec = 0; files = ( - 6B88947A2065AE5D002E5C59 /* CommandObjectStats.cpp in CopyFiles */, - 7F94D7182040A13A006EE3EA /* CleanUpTest.cpp in CopyFiles */, AF90106515AB7D3600FF120D /* lldb.1 in CopyFiles */, ); runOnlyForDeploymentPostprocessing = 1; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328389 - Add support for __attribute__(trivial_abi).
Author: jingham
Date: Fri Mar 23 16:44:52 2018
New Revision: 328389
URL: http://llvm.org/viewvc/llvm-project?rev=328389&view=rev
Log:
Add support for __attribute__(trivial_abi).
,
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/Makefile
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/main.cpp
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/decorators.py?rev=328389&r1=328388&r2=328389&view=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/decorators.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/decorators.py Fri Mar 23 16:44:52
2018
@@ -652,6 +652,19 @@ def skipIfTargetAndroid(api_levels=None,
api_levels,
archs))
+def skipUnlessSupportedTypeAttribute(attr):
+"""Decorate the item to skip test unless Clang supports type
__attribute__(attr)."""
+def compiler_doesnt_support_struct_attribute(self):
+compiler_path = self.getCompiler()
+compiler = os.path.basename(compiler_path)
+f = tempfile.NamedTemporaryFile()
+cmd = "echo 'struct __attribute__((%s)) Test {};' | %s -x c++ -c -o %s
- ; exit" % (attr, compiler_path, f.name)
+p = subprocess.Popen(cmd, shell=True, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
+test_result = p.stderr.read()
+if attr in test_result:
+return "Compiler does not support attribute %s"%(attr)
+return None
+return skipTestIfFn(compiler_doesnt_support_struct_attribute)
def skipUnlessThreadSanitizer(func):
"""Decorate the item to skip test unless Clang -fsanitize=thread is
supported."""
Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/Makefile
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/Makefile?rev=328389&view=auto
==
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/Makefile
(added)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/Makefile Fri
Mar 23 16:44:52 2018
@@ -0,0 +1,5 @@
+LEVEL = ../../../make
+
+CXX_SOURCES := main.cpp
+
+include $(LEVEL)/Makefile.rules
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py?rev=328389&view=auto
==
---
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
(added)
+++
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
Fri Mar 23 16:44:52 2018
@@ -0,0 +1,75 @@
+"""
+Test that we work properly with classes with the trivial_abi attribute
+"""
+
+from __future__ import print_function
+
+
+import os
+import time
+import re
+import lldb
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import decorators
+
+class TestTrivialABI(TestBase):
+
+mydir = TestBase.compute_mydir(__file__)
+
+NO_DEBUG_INFO_TESTCASE = True
+
+@decorators.skipUnlessSupportedTypeAttribute("trivial_abi")
+def test_call_trivial(self):
+"""Test that we can print a variable & call a function with a trivial
ABI class."""
+self.build()
+self.main_source_file = lldb.SBFileSpec("main.cpp")
+self.expr_test(True)
+
+@decorators.skipUnlessSupportedTypeAttribute("trivial_abi")
+@decorators.expectedFailureAll(bugnumber="llvm.org/pr36870")
+def test_call_nontrivial(self):
+"""Test that we can print a variable & call a function on the same
class w/o the trivial ABI marker."""
+self.build()
+self.main_source_file = lldb.SBFileSpec("main.cpp")
+self.expr_test(False)
+
+def setUp(self):
+# Call super's setUp().
+TestBase.setUp(self)
+
+def check_value(self, test_var, ivar_value):
+self.assertTrue(test_var.GetError().Success(), "Invalid valobj:
%s"%(test_var.GetError().GetCString()))
+ivar = test_var.GetChildMemberWithName("ivar")
+self.assertTrue(test_var.GetError().Success(), "Failed to fetch ivar")
+self.assertEqual(ivar_value, ivar.GetValueAsSigned(), "Got the right
value for ivar")
+
+def check_frame(self, thread):
+frame = thread.frames[0]
+inVal_var = frame.FindVariable("inVal")
+
