[Lldb-commits] [PATCH] D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC]
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323064: [modules] Fix missing includes/typo in LLDB's
includes. [NFC] (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42340?vs=130784&id=130800#toc
Repository:
rL LLVM
https://reviews.llvm.org/D42340
Files:
lldb/trunk/include/lldb/Core/LoadedModuleInfoList.h
lldb/trunk/include/lldb/Core/ThreadSafeDenseSet.h
lldb/trunk/include/lldb/Core/ThreadSafeValue.h
lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
lldb/trunk/include/lldb/Target/ProcessStructReader.h
lldb/trunk/include/lldb/Utility/AnsiTerminal.h
lldb/trunk/include/lldb/Utility/SharedCluster.h
Index: lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
===
--- lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
+++ lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
@@ -13,6 +13,7 @@
#include "lldb/lldb-forward.h"
+#include "lldb/DataFormatters/TypeSynthetic.h"
#include "lldb/Target/ExecutionContext.h"
#include "lldb/Utility/ConstString.h"
Index: lldb/trunk/include/lldb/Utility/SharedCluster.h
===
--- lldb/trunk/include/lldb/Utility/SharedCluster.h
+++ lldb/trunk/include/lldb/Utility/SharedCluster.h
@@ -15,6 +15,8 @@
#include "llvm/ADT/SmallPtrSet.h"
+#include
+
namespace lldb_private {
namespace imp {
Index: lldb/trunk/include/lldb/Utility/AnsiTerminal.h
===
--- lldb/trunk/include/lldb/Utility/AnsiTerminal.h
+++ lldb/trunk/include/lldb/Utility/AnsiTerminal.h
@@ -50,6 +50,7 @@
#define ANSI_1_CTRL(ctrl1) "\033["##ctrl1 ANSI_ESC_END
#define ANSI_2_CTRL(ctrl1, ctrl2) "\033["##ctrl1 ";"##ctrl2 ANSI_ESC_END
+#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
Index: lldb/trunk/include/lldb/Core/LoadedModuleInfoList.h
===
--- lldb/trunk/include/lldb/Core/LoadedModuleInfoList.h
+++ lldb/trunk/include/lldb/Core/LoadedModuleInfoList.h
@@ -13,10 +13,13 @@
// C Includes
// C++ Includes
+#include
#include
// Other libraries and framework includes
+#include "lldb/lldb-defines.h"
#include "lldb/lldb-private-forward.h"
+#include "lldb/lldb-types.h"
namespace lldb_private {
class LoadedModuleInfoList {
Index: lldb/trunk/include/lldb/Core/ThreadSafeValue.h
===
--- lldb/trunk/include/lldb/Core/ThreadSafeValue.h
+++ lldb/trunk/include/lldb/Core/ThreadSafeValue.h
@@ -17,6 +17,7 @@
// Other libraries and framework includes
// Project includes
+#include "lldb/lldb-defines.h"
namespace lldb_private {
Index: lldb/trunk/include/lldb/Core/ThreadSafeDenseSet.h
===
--- lldb/trunk/include/lldb/Core/ThreadSafeDenseSet.h
+++ lldb/trunk/include/lldb/Core/ThreadSafeDenseSet.h
@@ -46,7 +46,7 @@
}
void Clear() {
-stds::lock_guard<_MutexType> guard(m_mutex);
+std::lock_guard<_MutexType> guard(m_mutex);
m_set.clear();
}
Index: lldb/trunk/include/lldb/Target/ProcessStructReader.h
===
--- lldb/trunk/include/lldb/Target/ProcessStructReader.h
+++ lldb/trunk/include/lldb/Target/ProcessStructReader.h
@@ -16,6 +16,7 @@
#include "lldb/Symbol/CompilerType.h"
#include "lldb/Target/Process.h"
#include "lldb/Utility/ConstString.h"
+#include "lldb/Utility/DataBufferHeap.h"
#include "lldb/Utility/DataExtractor.h"
#include "lldb/Utility/Status.h"
Index: lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
===
--- lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
+++ lldb/trunk/include/lldb/DataFormatters/VectorIterator.h
@@ -13,6 +13,7 @@
#include "lldb/lldb-forward.h"
+#include "lldb/DataFormatters/TypeSynthetic.h"
#include "lldb/Target/ExecutionContext.h"
#include "lldb/Utility/ConstString.h"
Index: lldb/trunk/include/lldb/Utility/SharedCluster.h
===
--- lldb/trunk/include/lldb/Utility/SharedCluster.h
+++ lldb/trunk/include/lldb/Utility/SharedCluster.h
@@ -15,6 +15,8 @@
#include "llvm/ADT/SmallPtrSet.h"
+#include
+
namespace lldb_private {
namespace imp {
Index: lldb/trunk/include/lldb/Utility/AnsiTerminal.h
===
--- lldb/trunk/include/lldb/Utility/AnsiTerminal.h
+++ lldb/trunk/include/lldb/Utility/AnsiTerminal.h
@@ -50,6 +50,7 @@
#define ANSI_1_CTRL(ctrl1) "\033["##ctrl1 ANSI_ESC_END
#define ANSI_2_CTRL(ctrl1, ctrl2) "\033["##ctrl1 ";"##ctrl2 ANSI_ESC_END
+#include "llvm/ADT/ArrayRef.h"
#include "llv
[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"
jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. Cleanup needless+missing `#include "DWARFCompileUnit.h"` for split of DWARFCompileUnit to DWARFUnit as discussed in https://reviews.llvm.org/D40466. https://reviews.llvm.org/D42355 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h source/Plugins/SymbolFile/DWARF/NameToDIE.cpp Index: source/Plugins/SymbolFile/DWARF/NameToDIE.cpp === --- source/Plugins/SymbolFile/DWARF/NameToDIE.cpp +++ source/Plugins/SymbolFile/DWARF/NameToDIE.cpp @@ -14,7 +14,6 @@ #include "lldb/Utility/Stream.h" #include "lldb/Utility/StreamString.h" -#include "DWARFCompileUnit.h" #include "DWARFDebugInfo.h" #include "DWARFDebugInfoEntry.h" #include "SymbolFileDWARF.h" Index: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h === --- source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h +++ source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h @@ -13,6 +13,7 @@ #include #include +#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "SymbolFileDWARF.h" #include "lldb/Core/STLUtils.h" Index: source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h === --- source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h +++ source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h @@ -4,7 +4,6 @@ #define SymbolFileDWARF_DWARFASTParserOCaml_h_ #include "DWARFASTParser.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDebugInfo.h" #include "DWARFDefines.h" Index: source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp === --- source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp +++ source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp @@ -10,7 +10,6 @@ #include "DWARFASTParserGo.h" #include "DWARFASTParserGo.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDIECollection.h" #include "DWARFDebugInfo.h" Index: source/Plugins/SymbolFile/DWARF/NameToDIE.cpp === --- source/Plugins/SymbolFile/DWARF/NameToDIE.cpp +++ source/Plugins/SymbolFile/DWARF/NameToDIE.cpp @@ -14,7 +14,6 @@ #include "lldb/Utility/Stream.h" #include "lldb/Utility/StreamString.h" -#include "DWARFCompileUnit.h" #include "DWARFDebugInfo.h" #include "DWARFDebugInfoEntry.h" #include "SymbolFileDWARF.h" Index: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h === --- source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h +++ source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h @@ -13,6 +13,7 @@ #include #include +#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "SymbolFileDWARF.h" #include "lldb/Core/STLUtils.h" Index: source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h === --- source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h +++ source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h @@ -4,7 +4,6 @@ #define SymbolFileDWARF_DWARFASTParserOCaml_h_ #include "DWARFASTParser.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDebugInfo.h" #include "DWARFDefines.h" Index: source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp === --- source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp +++ source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp @@ -10,7 +10,6 @@ #include "DWARFASTParserGo.h" #include "DWARFASTParserGo.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDIECollection.h" #include "DWARFDebugInfo.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r323069 - Clean up #include "DWARFCompileUnit.h"
Author: jankratochvil Date: Sun Jan 21 10:03:17 2018 New Revision: 323069 URL: http://llvm.org/viewvc/llvm-project?rev=323069&view=rev Log: Clean up #include "DWARFCompileUnit.h" Clean up needless+missing #include "DWARFCompileUnit.h" for split of DWARFCompileUnit to DWARFUnit as discussed in D40466. Differential revision: https://reviews.llvm.org/D42355 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp?rev=323069&r1=323068&r2=323069&view=diff == --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp Sun Jan 21 10:03:17 2018 @@ -10,7 +10,6 @@ #include "DWARFASTParserGo.h" #include "DWARFASTParserGo.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDIECollection.h" #include "DWARFDebugInfo.h" Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h?rev=323069&r1=323068&r2=323069&view=diff == --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h Sun Jan 21 10:03:17 2018 @@ -4,7 +4,6 @@ #define SymbolFileDWARF_DWARFASTParserOCaml_h_ #include "DWARFASTParser.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDebugInfo.h" #include "DWARFDefines.h" Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h?rev=323069&r1=323068&r2=323069&view=diff == --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h Sun Jan 21 10:03:17 2018 @@ -13,6 +13,7 @@ #include #include +#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "SymbolFileDWARF.h" #include "lldb/Core/STLUtils.h" Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp?rev=323069&r1=323068&r2=323069&view=diff == --- lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp Sun Jan 21 10:03:17 2018 @@ -14,7 +14,6 @@ #include "lldb/Utility/Stream.h" #include "lldb/Utility/StreamString.h" -#include "DWARFCompileUnit.h" #include "DWARFDebugInfo.h" #include "DWARFDebugInfoEntry.h" #include "SymbolFileDWARF.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42355: Cleanup #include "DWARFCompileUnit.h"
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323069: Clean up #include "DWARFCompileUnit.h" (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42355?vs=130815&id=130816#toc Repository: rL LLVM https://reviews.llvm.org/D42355 Files: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp @@ -14,7 +14,6 @@ #include "lldb/Utility/Stream.h" #include "lldb/Utility/StreamString.h" -#include "DWARFCompileUnit.h" #include "DWARFDebugInfo.h" #include "DWARFDebugInfoEntry.h" #include "SymbolFileDWARF.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h @@ -13,6 +13,7 @@ #include #include +#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "SymbolFileDWARF.h" #include "lldb/Core/STLUtils.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp @@ -10,7 +10,6 @@ #include "DWARFASTParserGo.h" #include "DWARFASTParserGo.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDIECollection.h" #include "DWARFDebugInfo.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h @@ -4,7 +4,6 @@ #define SymbolFileDWARF_DWARFASTParserOCaml_h_ #include "DWARFASTParser.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDebugInfo.h" #include "DWARFDefines.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp @@ -14,7 +14,6 @@ #include "lldb/Utility/Stream.h" #include "lldb/Utility/StreamString.h" -#include "DWARFCompileUnit.h" #include "DWARFDebugInfo.h" #include "DWARFDebugInfoEntry.h" #include "SymbolFileDWARF.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h @@ -13,6 +13,7 @@ #include #include +#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "SymbolFileDWARF.h" #include "lldb/Core/STLUtils.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp @@ -10,7 +10,6 @@ #include "DWARFASTParserGo.h" #include "DWARFASTParserGo.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDIECollection.h" #include "DWARFDebugInfo.h" Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h === --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserOCaml.h @@ -4,7 +4,6 @@ #define SymbolFileDWARF_DWARFASTParserOCaml_h_ #include "DWARFASTParser.h" -#include "DWARFCompileUnit.h" #include "DWARFDIE.h" #include "DWARFDebugInfo.h" #include "DWARFDefines.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString
davide added a comment. I'll be happy to review all your patch set tomorrow, Raphael. Do you mind to add me as reviewer so I don't lose track of your work? https://reviews.llvm.org/D42348 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Trivial fixes like this don't need to be reviewed, you can just commit them. Thanks for your work btw! https://reviews.llvm.org/D42345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest
zturner added a comment. Same as with the last one. For obviously correct bug fixes like this, just commit them. As an aside, `make_unique` will make this a bit shorter so it fits on one line. e.g. `auto reg_interface = llvm::make_unique(arch);` https://reviews.llvm.org/D42347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D42336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323075: Make loop counter unsigned in
SymbolFilePDB::GetCompileUnitIndex (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42345?vs=130794&id=130831#toc
Repository:
rL LLVM
https://reviews.llvm.org/D42345
Files:
lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
Index: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
@@ -211,7 +211,7 @@
if (!results_up)
return;
auto uid = pdb_compiland->getSymIndexId();
- for (int cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
+ for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
auto compiland_up = results_up->getChildAtIndex(cu_idx);
if (!compiland_up)
continue;
Index: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
===
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
@@ -211,7 +211,7 @@
if (!results_up)
return;
auto uid = pdb_compiland->getSymIndexId();
- for (int cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
+ for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
auto compiland_up = results_up->getChildAtIndex(cu_idx);
if (!compiland_up)
continue;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r323075 - Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex
Author: teemperor
Date: Sun Jan 21 22:56:09 2018
New Revision: 323075
URL: http://llvm.org/viewvc/llvm-project?rev=323075&view=rev
Log:
Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex
Summary: This fixes a clang warning.
Reviewers: zturner
Reviewed By: zturner
Subscribers: zturner, lldb-commits
Differential Revision: https://reviews.llvm.org/D42345
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp?rev=323075&r1=323074&r2=323075&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Sun Jan 21
22:56:09 2018
@@ -211,7 +211,7 @@ void SymbolFilePDB::GetCompileUnitIndex(
if (!results_up)
return;
auto uid = pdb_compiland->getSymIndexId();
- for (int cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
+ for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
auto compiland_up = results_up->getChildAtIndex(cu_idx);
if (!compiland_up)
continue;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r323076 - Fix memory leaks in TestArm64InstEmulation
Author: teemperor
Date: Sun Jan 21 23:22:13 2018
New Revision: 323076
URL: http://llvm.org/viewvc/llvm-project?rev=323076&view=rev
Log:
Fix memory leaks in TestArm64InstEmulation
Summary: We never delete the created instances, so those test fail with the
memory sanitizer.
Reviewers: jasonmolenda
Reviewed By: jasonmolenda
Subscribers: aemerson, javed.absar, kristof.beyls, lldb-commits
Differential Revision: https://reviews.llvm.org/D42336
Modified:
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
Modified:
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp?rev=323076&r1=323075&r2=323076&view=diff
==
---
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
(original)
+++
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
Sun Jan 21 23:22:13 2018
@@ -56,9 +56,9 @@ void TestArm64InstEmulation::TearDownTes
TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -152,9 +152,9 @@ TEST_F(TestArm64InstEmulation, TestSimpl
TEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -314,9 +314,9 @@ TEST_F(TestArm64InstEmulation, TestMediu
TEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -409,9 +409,9 @@ TEST_F(TestArm64InstEmulation, TestFrame
TEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -511,9 +511,9 @@ TEST_F(TestArm64InstEmulation, TestRegis
TEST_F(TestArm64InstEmulation, TestRegisterDoubleSpills) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D42336: Fix memory leaks in TestArm64InstEmulation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323076: Fix memory leaks in TestArm64InstEmulation (authored
by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42336?vs=130777&id=130835#toc
Repository:
rL LLVM
https://reviews.llvm.org/D42336
Files:
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
Index:
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
===
--- lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
+++ lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
@@ -56,9 +56,9 @@
TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -152,9 +152,9 @@
TEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -314,9 +314,9 @@
TEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -409,9 +409,9 @@
TEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -511,9 +511,9 @@
TEST_F(TestArm64InstEmulation, TestRegisterDoubleSpills) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
Index: lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
===
--- lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
+++ lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp
@@ -56,9 +56,9 @@
TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -152,9 +152,9 @@
TEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -314,9 +314,9 @@
TEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -409,9 +409,9 @@
TEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp;
@@ -511,9 +511,9 @@
TEST_F(TestArm64InstEmulation, TestRegisterDoubleSpills) {
ArchSpec arch("arm64-apple-ios10");
- UnwindAssemblyInstEmulation *engine =
+ std::unique_ptr engine(
static_cast(
- UnwindAssemblyInstEmulation::CreateInstance(arch));
+ UnwindAssemblyInstEmulation::CreateI
