date:20170818

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

2017-08-18 Thread Gustavo Serra Scalet via Phabricator via lldb-commits

gut added a comment.

Can I please get some review on this?

ps: check comments on phabricator as it was not being published on lldb-commits 
mailing list.


https://reviews.llvm.org/D36804



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

2017-08-18 Thread Michał Górny via Phabricator via lldb-commits

mgorny created this revision.
mgorny added a project: LLDB.

Add explicit linkage to the necessary system libraries in the Host
library. Otherwise, the library fails to build with -Wl,--as-needed.
The system libraries ended up being listed on the linker command-line
before the static libraries needing them, resulting in --as-needed
stripping them.

Listing the dependent libraries explicitly is the canonical way of
declaring libraries in CMake. It guarantees that the system library
dependencies will be correctly propagated to reverse dependencies.

The code used to link libraries reuses existing EXTRA_LIBS variable,
copying code from other parts of LLDB. We might eventually remove
the direct use of system libraries in the programs; however, I would
prefer if we focused on fixing the build regressions in 5.0 branch
first, and went further after the release.


Repository:
  rL LLVM

https://reviews.llvm.org/D36885

Files:
  source/Host/CMakeLists.txt


Index: source/Host/CMakeLists.txt
===
--- source/Host/CMakeLists.txt
+++ source/Host/CMakeLists.txt
@@ -156,9 +156,23 @@
   endif()
 endif()
 
+set(EXTRA_LIBS)
 if (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
- set(EXTRA_LIBS kvm)
+  list(APPEND EXTRA_LIBS kvm)
 endif ()
+if (APPLE)
+  list(APPEND EXTRA_LIBS xml2)
+else ()
+  if (LIBXML2_FOUND)
+list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES})
+  endif()
+endif ()
+if (HAVE_LIBDL)
+  list(APPEND EXTRA_LIBS ${CMAKE_DL_LIBS})
+endif()
+if (NOT LLDB_DISABLE_LIBEDIT)
+  list(APPEND EXTRA_LIBS edit)
+endif()
 
 add_lldb_library(lldbHost
   ${HOST_SOURCES}


Index: source/Host/CMakeLists.txt
===
--- source/Host/CMakeLists.txt
+++ source/Host/CMakeLists.txt
@@ -156,9 +156,23 @@
   endif()
 endif()
 
+set(EXTRA_LIBS)
 if (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
- set(EXTRA_LIBS kvm)
+  list(APPEND EXTRA_LIBS kvm)
 endif ()
+if (APPLE)
+  list(APPEND EXTRA_LIBS xml2)
+else ()
+  if (LIBXML2_FOUND)
+list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES})
+  endif()
+endif ()
+if (HAVE_LIBDL)
+  list(APPEND EXTRA_LIBS ${CMAKE_DL_LIBS})
+endif()
+if (NOT LLDB_DISABLE_LIBEDIT)
+  list(APPEND EXTRA_LIBS edit)
+endif()
 
 add_lldb_library(lldbHost
   ${HOST_SOURCES}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

2017-08-18 Thread Michał Górny via Phabricator via lldb-commits

mgorny created this revision.
mgorny added a project: LLDB.

The Process/gdb-remote test now requires the LLVMTestingSupport library
that is not installed by LLVM. As a result, when doing an out-of-source
build it fails being unable to find the library. To solve that, build
a local copy of the library when building LLDB with unittests and LLVM
sources available. This is based on how we deal with bundled gtest
sources.


Repository:
  rL LLVM

https://reviews.llvm.org/D36886

Files:
  unittests/CMakeLists.txt


Index: unittests/CMakeLists.txt
===
--- unittests/CMakeLists.txt
+++ unittests/CMakeLists.txt
@@ -19,6 +19,12 @@
   if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest AND NOT TARGET gtest)
 add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/unittest utils/unittest)
   endif()
+  # LLVMTestingSupport library is needed for Process/gdb-remote.
+  if (EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
+  AND NOT TARGET LLVMTestingSupport)
+add_subdirectory(${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
+  lib/Testing/Support)
+  endif()
 endif()
 
 function(add_lldb_unittest test_name)


Index: unittests/CMakeLists.txt
===
--- unittests/CMakeLists.txt
+++ unittests/CMakeLists.txt
@@ -19,6 +19,12 @@
   if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest AND NOT TARGET gtest)
 add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/unittest utils/unittest)
   endif()
+  # LLVMTestingSupport library is needed for Process/gdb-remote.
+  if (EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
+  AND NOT TARGET LLVMTestingSupport)
+add_subdirectory(${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
+  lib/Testing/Support)
+  endif()
 endif()
 
 function(add_lldb_unittest test_name)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r311207 - Commiting Christopher Brook's patch for

2017-08-18 Thread Jason Molenda via lldb-commits

Author: jmolenda
Date: Fri Aug 18 15:57:59 2017
New Revision: 311207

URL: http://llvm.org/viewvc/llvm-project?rev=311207&view=rev
Log:
Commiting Christopher Brook's patch for

"Prevent negative chars from being sign-extended into isprint and isspace which 
take and int and crash if the int is negative"

https://reviews.llvm.org/D36620

Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

Modified: 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp?rev=311207&r1=311206&r2=311207&view=diff
==
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp 
(original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Fri 
Aug 18 15:57:59 2017
@@ -815,7 +815,8 @@ GDBRemoteCommunication::CheckForPacket(c
 // checksum
 if (m_bytes[0] == '$' && total_length > 4) {
   for (size_t i = 0; !binary && i < total_length; ++i) {
-if (isprint(m_bytes[i]) == 0 && isspace(m_bytes[i]) == 0) {
+unsigned char c = m_bytes[i];
+if (isprint(c) == 0 && isspace(c) == 0) {
   binary = true;
 }
   }


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

2017-08-18 Thread Jason Molenda via Phabricator via lldb-commits

jasonmolenda closed this revision.
jasonmolenda added a comment.

Sendingsource/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
Transmitting file data .done
Committing transaction...
Committed revision 311207.


https://reviews.llvm.org/D36620



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

2017-08-18 Thread Zachary Turner via Phabricator via lldb-commits

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

Seems fine to me, beanz?


Repository:
  rL LLVM

https://reviews.llvm.org/D36886



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

2017-08-18 Thread Zachary Turner via Phabricator via lldb-commits

zturner added inline comments.



Comment at: source/Host/CMakeLists.txt:166-168
+  if (LIBXML2_FOUND)
+list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES})
+  endif()

Even if libxml is found, that doesn't mean the build is configured to use it, 
does it?  Correct me if I'm wrong.  if "libxml exists" is the same as "i want 
to use libxml" then this seems fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D36885



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

[Lldb-commits] [lldb] r311207 - Commiting Christopher Brook's patch for

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

7 matches

Site Navigation

Mail list logo

Footer information