[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

[Michał Górny via Phabricator via lldb-commits]

mgorny reopened this revision.
mgorny added a reviewer: chapuni.
mgorny added a subscriber: chapuni.
mgorny added a comment.
This revision is now accepted and ready to land.

Well, @chapuni disagrees on https://reviews.llvm.org/D36211. Which way should 
we go then?


Repository:
  rL LLVM

https://reviews.llvm.org/D31367



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

[NAKAMURA Takumi via Phabricator via lldb-commits]

chapuni added a comment.

@mgorny was doing the right thing.

The user of llvm/ExecutionEngine/SectionMemoryManager.h (from 
lldb/Expression/IRExecutionUnit.h) may depend on RuntimeDyld.
If a derived class from RTDyldMemoryManager is implemented, it should depend on 
RuntimeDyld.


Repository:
  rL LLVM

https://reviews.llvm.org/D31367



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r309803 - Fix ProcessAPITestCase.test_get_process_info

[Vadim Macagon via lldb-commits]

Author: enlight
Date: Wed Aug  2 03:12:12 2017
New Revision: 309803

URL: http://llvm.org/viewvc/llvm-project?rev=309803&view=rev
Log:
Fix ProcessAPITestCase.test_get_process_info

Modified:

lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py

Modified: 
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py?rev=309803&r1=309802&r2=309803&view=diff
==
--- 
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py 
(original)
+++ 
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py 
Wed Aug  2 03:12:12 2017
@@ -328,7 +328,6 @@ class ProcessAPITestCase(TestBase):
 
 @add_test_categories(['pyapi'])
 @no_debug_info_test
-@expectedFailureAll() # broken bots
 def test_get_process_info(self):
 """Test SBProcess::GetProcessInfo() API with a locally launched 
process."""
 self.build()
@@ -350,7 +349,7 @@ class ProcessAPITestCase(TestBase):
 if not error.Success():
 self.fail("Failed to launch process")
 
-# Verify all process info can be retrieved successfully
+# Verify basic process info can be retrieved successfully
 process_info = process.GetProcessInfo()
 self.assertTrue(process_info.IsValid())
 file_spec = process_info.GetExecutableFile()
@@ -363,29 +362,42 @@ class ProcessAPITestCase(TestBase):
 process_info.GetProcessID(), lldb.LLDB_INVALID_PROCESS_ID,
 "Process ID is valid")
 
-if self.getPlatform() != 'windows':
-self.assertTrue(process_info.UserIDIsValid())
+# Additional process info varies by platform, so just check that
+# whatever info was retrieved is consistent and nothing blows up.
+if process_info.UserIDIsValid():
 self.assertNotEqual(
 process_info.GetUserID(), lldb.UINT32_MAX,
 "Process user ID is valid")
-self.assertTrue(process_info.GroupIDIsValid())
+else:
+self.assertEqual(
+process_info.GetUserID(), lldb.UINT32_MAX,
+"Process user ID is invalid")
+
+if process_info.GroupIDIsValid():
 self.assertNotEqual(
 process_info.GetGroupID(), lldb.UINT32_MAX,
 "Process group ID is valid")
-self.assertTrue(process_info.EffectiveUserIDIsValid())
+else:
+self.assertEqual(
+process_info.GetGroupID(), lldb.UINT32_MAX,
+"Process group ID is invalid")
+
+if process_info.EffectiveUserIDIsValid():
 self.assertNotEqual(
 process_info.GetEffectiveUserID(), lldb.UINT32_MAX,
 "Process effective user ID is valid")
-self.assertTrue(process_info.EffectiveGroupIDIsValid())
+else:
+self.assertEqual(
+process_info.GetEffectiveUserID(), lldb.UINT32_MAX,
+"Process effective user ID is invalid")
+
+if process_info.EffectiveGroupIDIsValid():
 self.assertNotEqual(
 process_info.GetEffectiveGroupID(), lldb.UINT32_MAX,
 "Process effective group ID is valid")
-self.assertNotEqual(
-process_info.GetParentProcessID(), 
lldb.LLDB_INVALID_PROCESS_ID,
-"Parent process ID is valid"
-)
+else:
+self.assertEqual(
+process_info.GetEffectiveGroupID(), lldb.UINT32_MAX,
+"Process effective group ID is invalid")
 
-# Verify that a dead process doesn't yield stale process info
-process.Kill()
-process_info = process.GetProcessInfo()
-self.assertFalse(process_info.IsValid())
+process_info.GetParentProcessID()


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r309916 - Update for llvm api change.

[Rafael Espindola via lldb-commits]

Author: rafael
Date: Wed Aug  2 19:45:01 2017
New Revision: 309916

URL: http://llvm.org/viewvc/llvm-project?rev=309916&view=rev
Log:
Update for llvm api change.

Modified:
lldb/trunk/source/Expression/IRExecutionUnit.cpp

Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRExecutionUnit.cpp?rev=309916&r1=309915&r2=309916&view=diff
==
--- lldb/trunk/source/Expression/IRExecutionUnit.cpp (original)
+++ lldb/trunk/source/Expression/IRExecutionUnit.cpp Wed Aug  2 19:45:01 2017
@@ -260,7 +260,6 @@ void IRExecutionUnit::GetRunnableInfo(St
 
   llvm::Triple triple(m_module->getTargetTriple());
   llvm::Reloc::Model relocModel;
-  llvm::CodeModel::Model codeModel;
 
   if (triple.isOSBinFormatELF()) {
 relocModel = llvm::Reloc::Static;
@@ -268,9 +267,6 @@ void IRExecutionUnit::GetRunnableInfo(St
 relocModel = llvm::Reloc::PIC_;
   }
 
-  // This will be small for 32-bit and large for 64-bit.
-  codeModel = llvm::CodeModel::JITDefault;
-
   m_module_ap->getContext().setInlineAsmDiagnosticHandler(ReportInlineAsmError,
   &error);
 
@@ -281,7 +277,6 @@ void IRExecutionUnit::GetRunnableInfo(St
   .setRelocationModel(relocModel)
   .setMCJITMemoryManager(
   std::unique_ptr(new MemoryManager(*this)))
-  .setCodeModel(codeModel)
   .setOptLevel(llvm::CodeGenOpt::Less)
   .setUseOrcMCJITReplacement(true);
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits