[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams
labath added a comment. Ping. Any thoughts on this? https://reviews.llvm.org/D29615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams
Aside from the thread stuff, nothing seems particularly risky about this change. Did the thread-local stuff you removed have anything to do with the -t option to the log command? On Wed, Feb 8, 2017 at 9:15 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Ping. Any thoughts on this? > > > https://reviews.llvm.org/D29615 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as if we type two log enable commands like:
(lldb) log enable -f /tmp/a.txt lldb process
(lldb) log enable -f /tmp/a.txt lldb api
share the same log stream (we don't open /tmp/a.txt twice) if is still open and
available.
Comment at: source/Core/StreamCallback.cpp:22
StreamCallback::StreamCallback(lldb::LogOutputCallback callback, void *baton)
-: Stream(0, 4, eByteOrderBig), m_callback(callback), m_baton(baton),
- m_accumulated_data(), m_collection_mutex() {}
labath wrote:
> zturner wrote:
> > I find it rather odd that this was hardcoding big endian. Was the
> > endianness here important for some reason?
> I think that was there just because you needed to specify some value. As we
> were always printing strings, it did not matter anyway.
Pavel is correct, this is because streams can be put into binary mode and that
you can use Stream::Put32(uint32_t) which will write a number if in non-binary
mode, or endian correct bytes if in binary mode. Logs didn't ever use the
binary feature so we just set it to defaults.
https://reviews.llvm.org/D29615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for AArch64 targets
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would prefer to see NativeBreakpoint struct expanded to have more member
variables instead of adding a new hardware breakpoint list. Then you just ask
any breakpoint to enable/disable/remove itself and the structure contains all
of the info we need. Keeping two lists means we have to check two lists. Let me
know if any of my inline comments weren't clear?
Comment at: include/lldb/Host/common/HardwareBreakpointList.h:24
+
+class HardwareBreakpointList {
+public:
labath wrote:
> What's the benefit of this class over using `std::map HardwareBreakpoint>` directly?
There is no real error you can return from Add. Remove can just return a bool
if it succeeds or not. So we can probably just use a std::map directly like
Pavel suggests.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:318-320
NativeBreakpointList m_breakpoint_list;
NativeWatchpointList m_watchpoint_list;
+ HardwareBreakpointList m_hw_breakpoint_list;
It would be nice to just expand the contents of NativeBreakpoint and remove the
HardwareBreakpoint and HardwareBreakpointList. No need for another list to
check. I would suggest just adding a "bool m_hardware;" to NativeBreakpoint. Or
add a new NativeBreakpoint::Type enum in NativeBreakpoint.h that is:
```
NativeBreakpoint
{
enum class Type
{
Software,
Hardware
};
Type m_type;
};
```
Comment at: include/lldb/Host/common/NativeRegisterContext.h:78-81
+ virtual Error ClearAllHardwareBreakpoints();
+
+ virtual Error GetHardwareBreakHitIndex(uint32_t &bp_index,
+ lldb::addr_t trap_addr);
These would go away if we expand NativeBreakpoint to include new fields to
support hardware breakpoints?
Comment at: include/lldb/Host/common/NativeThreadProtocol.h:59-64
+ // -
+ // Thread-specific Hardware Breakpoint routines
+ // -
+ virtual Error SetHardwareBreakpoint(lldb::addr_t addr, size_t size) = 0;
+
+ virtual Error RemoveHardwareBreakpoint(lldb::addr_t addr) = 0;
Would we want to pass in the NativeBreakpoint class here instead of individual
arguments? Maybe each thread might want to store some extra data inside the
NativeBreakpoint class (like the index of the hardware breakpoint, which means
we might need to also add more fields to NativeBreakpoint).
Comment at: source/Host/common/HardwareBreakpointList.cpp:1-30
+//===-- HardwareBreakpointList.cpp --*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
Remove this if we just end up using the one breakpoint list and expand
NativeBreakpoint to include fields to support hardware breakpoints.
Comment at: source/Host/common/NativeProcessProtocol.cpp:275-276
+
+Error NativeProcessProtocol::SetHardwareBreakpoint(lldb::addr_t addr,
+ size_t size) {
+ // This default implementation assumes setting a hardware breakpoint for
Change this to take the "NativeBreakpoint" structure instead of manual
arguments?
Comment at: source/Host/common/NativeProcessProtocol.cpp:329
+
+Error NativeProcessProtocol::RemoveHardwareBreakpoint(lldb::addr_t addr) {
+ // Update the thread list
change argument to take NativeBreakpoint struct?
Comment at: source/Host/common/NativeProcessProtocol.cpp:430-436
+Error NativeProcessProtocol::RemoveBreakpoint(lldb::addr_t addr,
+ bool hardware) {
+ if (hardware)
+return RemoveHardwareBreakpoint(addr);
+ else
+return m_breakpoint_list.DecRef(addr);
}
Switch to use NativeBreakpoint struct as argument? Then we won't need extra
args since the NativeBreakpoint will have all the info inside of it.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1738
+Error NativeProcessLinux::RemoveBreakpoint(lldb::addr_t addr, bool hardware) {
+ if (hardware)
Use NativeBreakpoint struct as arg?
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:89
+ Error RemoveBreakpoint(lldb::addr_t addr, bool hardware = false) override;
+
Use NativeBreakpoint struct instead of manual args?
https://reviews.llvm.org/D29669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
[Lldb-commits] [PATCH] D29352: [CMake] Final dependency cleanup patch!
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294515: [CMake] Final dependency cleanup patch! (authored by
cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D29352?vs=87265&id=87701#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29352
Files:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/cmake/modules/AddLLDB.cmake
lldb/trunk/source/API/CMakeLists.txt
lldb/trunk/source/Initialization/CMakeLists.txt
lldb/trunk/source/Plugins/Process/CMakeLists.txt
lldb/trunk/source/Plugins/Process/Windows/Common/CMakeLists.txt
lldb/trunk/tools/intel-mpx/CMakeLists.txt
lldb/trunk/tools/lldb-server/CMakeLists.txt
lldb/trunk/unittests/CMakeLists.txt
Index: lldb/trunk/unittests/CMakeLists.txt
===
--- lldb/trunk/unittests/CMakeLists.txt
+++ lldb/trunk/unittests/CMakeLists.txt
@@ -39,7 +39,6 @@
POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E make_directory ${CMAKE_CURRENT_BINARY_DIR}/Inputs)
- lldb_link_common_libs(${test_name} EXE)
target_link_libraries(${test_name} ${ARG_LINK_LIBS} ${CLANG_USED_LIBS} ${LLDB_SYSTEM_LIBS})
endfunction()
Index: lldb/trunk/source/API/CMakeLists.txt
===
--- lldb/trunk/source/API/CMakeLists.txt
+++ lldb/trunk/source/API/CMakeLists.txt
@@ -16,6 +16,8 @@
message(FATAL_ERROR "LLDB.framework cannot be generated unless targeting Apple platforms.")
endif()
+get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+
add_lldb_library(liblldb SHARED
SBAddress.cpp
SBAttachInfo.cpp
@@ -80,6 +82,21 @@
SBUnixSignals.cpp
SystemInitializerFull.cpp
${LLDB_WRAP_PYTHON}
+
+ LINK_LIBS
+lldbBase
+lldbBreakpoint
+lldbCore
+lldbDataFormatters
+lldbExpression
+lldbHost
+lldbInitialization
+lldbInterpreter
+lldbSymbol
+lldbTarget
+${LLDB_ALL_PLUGINS}
+ LINK_COMPONENTS
+Support
)
if (LLVM_ENABLE_WERROR)
Index: lldb/trunk/source/Initialization/CMakeLists.txt
===
--- lldb/trunk/source/Initialization/CMakeLists.txt
+++ lldb/trunk/source/Initialization/CMakeLists.txt
@@ -7,11 +7,7 @@
endif()
if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )
- list(APPEND LLDB_USED_LIBS
-lldbPluginProcessWindowsCommon
-ws2_32
-rpcrt4
-)
+ list(APPEND EXTRA_PLUGINS lldbPluginProcessWindowsCommon)
endif ()
add_lldb_library(lldbInitialization
@@ -31,6 +27,7 @@
lldbPluginObjectFilePECOFF
lldbPluginProcessGDBRemote
${EXTRA_PLUGINS}
+${LLDB_SYSTEM_LIBS}
LINK_COMPONENTS
Support
)
Index: lldb/trunk/source/Plugins/Process/Windows/Common/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Process/Windows/Common/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Process/Windows/Common/CMakeLists.txt
@@ -28,6 +28,8 @@
lldbHost
lldbInterpreter
lldbTarget
+ws2_32
+rpcrt4
LINK_COMPONENTS
Support
)
Index: lldb/trunk/source/Plugins/Process/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Process/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Process/CMakeLists.txt
@@ -10,9 +10,9 @@
add_subdirectory(Windows/Common)
elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_subdirectory(MacOSX-Kernel)
+ add_subdirectory(mach-core)
endif()
add_subdirectory(gdb-remote)
add_subdirectory(Utility)
-add_subdirectory(mach-core)
add_subdirectory(elf-core)
add_subdirectory(minidump)
Index: lldb/trunk/tools/intel-mpx/CMakeLists.txt
===
--- lldb/trunk/tools/intel-mpx/CMakeLists.txt
+++ lldb/trunk/tools/intel-mpx/CMakeLists.txt
@@ -8,16 +8,8 @@
IntelMPXTablePlugin.cpp
)
-target_link_libraries(lldb-intel-mpxtable PUBLIC liblldb)
-
-if (LLDB_LINKER_SUPPORTS_GROUPS)
- target_link_libraries(lldb-intel-mpxtable PUBLIC
--Wl,--start-group ${LLDB_USED_LIBS} -Wl,--end-group)
-else()
- target_link_libraries(lldb-intel-mpxtable PUBLIC ${LLDB_USED_LIBS})
-endif()
-llvm_config(lldb-intel-mpxtable ${LLVM_LINK_COMPONENTS})
-
+target_link_libraries(lldb-intel-mpxtable
+ PUBLIC liblldb LLVMSupport)
install(TARGETS lldb-intel-mpxtable
LIBRARY DESTINATION bin)
Index: lldb/trunk/tools/lldb-server/CMakeLists.txt
===
--- lldb/trunk/tools/lldb-server/CMakeLists.txt
+++ lldb/trunk/tools/lldb-server/CMakeLists.txt
@@ -23,90 +23,6 @@
include_directories(../../source)
-
-set( LLDB_USED_LIBS
- lldbBase
- lldbBreakpoint
- lldbCommands
- lldbDataFormatters
- lldbHost
- lldbCore
- lldbExpression
- lldbInitialization
- lldbInterpreter
- lldbSymbol
- lldbTarget
- lldbUtility
-
- # Plugins
- lldbPluginDisassemblerLLVM
- lldbPluginSymbo
[Lldb-commits] [lldb] r294515 - [CMake] Final dependency cleanup patch!
Author: cbieneman Date: Wed Feb 8 15:00:46 2017 New Revision: 294515 URL: http://llvm.org/viewvc/llvm-project?rev=294515&view=rev Log: [CMake] Final dependency cleanup patch! Summary: This patch removes the over-specified dependencies from LLDBDependencies and instead relies on the dependencies as expressed in each library and tool. This also removes the library looping in favor of allowing CMake to do its thing. I've tested this patch on Darwin, and found no issues, but since linker semantics vary by system I'll also work on testing it on other platforms too. Help testing would be greatly appreciated. Reviewers: labath, zturner Subscribers: danalbert, srhines, mgorny, jgosnell, lldb-commits Differential Revision: https://reviews.llvm.org/D29352 Modified: lldb/trunk/cmake/LLDBDependencies.cmake lldb/trunk/cmake/modules/AddLLDB.cmake lldb/trunk/source/API/CMakeLists.txt lldb/trunk/source/Initialization/CMakeLists.txt lldb/trunk/source/Plugins/Process/CMakeLists.txt lldb/trunk/source/Plugins/Process/Windows/Common/CMakeLists.txt lldb/trunk/tools/intel-mpx/CMakeLists.txt lldb/trunk/tools/lldb-server/CMakeLists.txt lldb/trunk/unittests/CMakeLists.txt Modified: lldb/trunk/cmake/LLDBDependencies.cmake URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=294515&r1=294514&r2=294515&view=diff == --- lldb/trunk/cmake/LLDBDependencies.cmake (original) +++ lldb/trunk/cmake/LLDBDependencies.cmake Wed Feb 8 15:00:46 2017 @@ -1,152 +1,13 @@ -set( LLDB_USED_LIBS - lldbBase - lldbBreakpoint - lldbCommands - lldbDataFormatters - lldbHost - lldbCore - lldbExpression - lldbInitialization - lldbInterpreter - lldbSymbol - lldbTarget - lldbUtility - - # Plugins - lldbPluginDisassemblerLLVM - lldbPluginSymbolFileDWARF - lldbPluginSymbolFilePDB - lldbPluginSymbolFileSymtab - lldbPluginDynamicLoaderStatic - lldbPluginDynamicLoaderPosixDYLD - lldbPluginDynamicLoaderHexagonDYLD - lldbPluginDynamicLoaderWindowsDYLD - - lldbPluginCPlusPlusLanguage - lldbPluginGoLanguage - lldbPluginJavaLanguage - lldbPluginObjCLanguage - lldbPluginObjCPlusPlusLanguage - lldbPluginOCamlLanguage - - lldbPluginObjectFileELF - lldbPluginObjectFileJIT - lldbPluginSymbolVendorELF - lldbPluginObjectContainerBSDArchive - lldbPluginObjectContainerMachOArchive - lldbPluginProcessGDBRemote - lldbPluginProcessUtility - lldbPluginPlatformAndroid - lldbPluginPlatformGDB - lldbPluginPlatformFreeBSD - lldbPluginPlatformKalimba - lldbPluginPlatformLinux - lldbPluginPlatformNetBSD - lldbPluginPlatformPOSIX - lldbPluginPlatformWindows - lldbPluginObjectContainerMachOArchive - lldbPluginObjectContainerBSDArchive - lldbPluginPlatformMacOSX - lldbPluginStructuredDataDarwinLog - lldbPluginDynamicLoaderMacOSXDYLD - lldbPluginUnwindAssemblyInstEmulation - lldbPluginUnwindAssemblyX86 - lldbPluginAppleObjCRuntime - lldbPluginRenderScriptRuntime - lldbPluginLanguageRuntimeGo - lldbPluginLanguageRuntimeJava - lldbPluginCXXItaniumABI - lldbPluginABIMacOSX_arm - lldbPluginABIMacOSX_arm64 - lldbPluginABIMacOSX_i386 - lldbPluginABISysV_arm - lldbPluginABISysV_arm64 - lldbPluginABISysV_i386 - lldbPluginABISysV_x86_64 - lldbPluginABISysV_hexagon - lldbPluginABISysV_ppc - lldbPluginABISysV_ppc64 - lldbPluginABISysV_mips - lldbPluginABISysV_mips64 - lldbPluginABISysV_s390x - lldbPluginInstructionARM - lldbPluginInstructionARM64 - lldbPluginInstructionMIPS - lldbPluginInstructionMIPS64 - lldbPluginObjectFilePECOFF - lldbPluginOSGo - lldbPluginOSPython - lldbPluginMemoryHistoryASan - lldbPluginInstrumentationRuntimeAddressSanitizer - lldbPluginInstrumentationRuntimeThreadSanitizer - lldbPluginSystemRuntimeMacOSX - lldbPluginProcessElfCore - lldbPluginProcessMinidump - lldbPluginJITLoaderGDB - lldbPluginExpressionParserClang - lldbPluginExpressionParserGo - ) +set(LLDB_SYSTEM_LIBS) # Windows-only libraries if ( CMAKE_SYSTEM_NAME MATCHES "Windows" ) - list(APPEND LLDB_USED_LIBS -lldbPluginProcessWindowsCommon + list(APPEND LLDB_SYSTEM_LIBS ws2_32 rpcrt4 ) endif () -# Linux-only libraries -if ( CMAKE_SYSTEM_NAME MATCHES "Linux|Android" ) - list(APPEND LLDB_USED_LIBS -lldbPluginProcessLinux -lldbPluginProcessPOSIX - ) -endif () - -# FreeBSD-only libraries -if ( CMAKE_SYSTEM_NAME MATCHES "FreeBSD" ) - list(APPEND LLDB_USED_LIBS -lldbPluginProcessFreeBSD -lldbPluginProcessPOSIX -) -endif () - -# NetBSD-only libraries -if ( CMAKE_SYSTEM_NAME MATCHES "NetBSD" ) - list(APPEND LLDB_USED_LIBS -lldbPluginProcessPOSIX -) -endif () - -# Darwin-only libraries -if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" ) - list(APPEND LLDB_USED_LIBS -lldbPluginDynamicLoaderDarwinKernel -lldbPluginObjectFileMachO -lldbPluginProcessMachCore -lldbPluginProcessMacOSXKernel -lldbPluginSymbolVendorMacOSX -)
[Lldb-commits] [lldb] r294521 - [CMake] Add dependency on Mips target if it is available
Author: cbieneman
Date: Wed Feb 8 15:24:51 2017
New Revision: 294521
URL: http://llvm.org/viewvc/llvm-project?rev=294521&view=rev
Log:
[CMake] Add dependency on Mips target if it is available
The Mips plugins conditionally link the Mips backend, so we need to
conditionally add the target as a dependency.
This resolves a bot failure from r294515.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/4606/steps/build%20android/logs/stdio
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt
lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt?rev=294521&r1=294520&r2=294521&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt Wed Feb 8
15:24:51 2017
@@ -1,3 +1,7 @@
+if(Mips IN_LIST LLVM_TARGETS_TO_BUILD)
+ set(mips_target Mips)
+endif()
+
add_lldb_library(lldbPluginInstructionMIPS PLUGIN
EmulateInstructionMIPS.cpp
@@ -10,4 +14,5 @@ add_lldb_library(lldbPluginInstructionMI
LINK_COMPONENTS
MC
Support
+${mips_target}
)
Modified: lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt?rev=294521&r1=294520&r2=294521&view=diff
==
--- lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt Wed Feb 8
15:24:51 2017
@@ -1,3 +1,7 @@
+if(Mips IN_LIST LLVM_TARGETS_TO_BUILD)
+ set(mips_target Mips)
+endif()
+
add_lldb_library(lldbPluginInstructionMIPS64 PLUGIN
EmulateInstructionMIPS64.cpp
@@ -10,4 +14,5 @@ add_lldb_library(lldbPluginInstructionMI
LINK_COMPONENTS
MC
Support
+${mips_target}
)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] Buildbot numbers for the last week of 01/29/2017 - 02/04/2017
Hello everyone, Below are some buildbot numbers for the last week of 01/29/2017 - 02/04/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green); Count of commits by project; Number of completed builds, failed builds and average build time for successful builds per active builder; Average waiting time for a revision to get build result per active builder (response time). Thanks Galina The longest time each builder was red during the last week: buildername | was_red +-- clang-cmake-mips | 133:43:36 clang-cmake-mipsel | 129:53:02 clang-native-aarch64-full | 121:59:50 clang-cuda-build | 86:29:18 llvm-mips-linux| 79:33:17 clang-x86_64-linux-selfhost-modules| 40:31:55 clang-x86_64-linux-selfhost-modules-2 | 40:28:13 sanitizer-ppc64le-linux| 40:27:13 sanitizer-x86_64-linux-bootstrap | 31:49:39 sanitizer-x86_64-linux-fast| 30:47:53 lldb-windows7-android | 21:01:39 clang-with-thin-lto-ubuntu | 18:55:06 clang-with-lto-ubuntu | 18:20:40 clang-lld-x86_64-2stage| 17:36:25 clang-x86-windows-msvc2015 | 17:26:05 clang-ppc64le-linux-lnt| 17:20:48 perf-x86_64-penryn-O3-polly-before-vectorizer | 17:20:25 clang-x86_64-debian-fast | 16:39:30 clang-ppc64be-linux-multistage | 16:23:55 perf-x86_64-penryn-O3 | 15:37:33 clang-bpf-build| 12:50:42 sanitizer-x86_64-linux | 11:31:14 libcxx-libcxxabi-x86_64-linux-debian-noexceptions | 10:59:14 perf-x86_64-penryn-O3-polly-before-vectorizer-detect-only | 10:14:35 perf-x86_64-penryn-O3-polly-before-vectorizer-unprofitable | 09:45:59 libcxx-libcxxabi-libunwind-aarch64-linux-noexceptions | 09:43:16 perf-x86_64-penryn-O3-polly| 09:42:55 perf-x86_64-penryn-O3-polly-parallel-fast | 09:40:05 perf-x86_64-penryn-O3-polly-unprofitable | 09:35:55 libcxx-libcxxabi-libunwind-arm-linux | 08:55:15 libcxx-libcxxabi-libunwind-arm-linux-noexceptions | 08:54:58 libcxx-libcxxabi-libunwind-aarch64-linux | 08:54:50 clang-cmake-armv7-a15-selfhost | 08:48:09 perf-x86_64-penryn-O3-polly-fast | 08:04:24 clang-cmake-thumbv7-a15-full-sh| 06:22:11 llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast | 05:40:43 lld-x86_64-freebsd | 05:31:10 lld-x86_64-darwin13| 04:48:21 clang-cmake-aarch64-full | 04:35:09 llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast | 04:33:33 clang-cmake-aarch64-lld| 04:04:59 clang-cmake-armv7-a15-selfhost-neon| 04:03:00 lldb-x86_64-ubuntu-14.04-buildserver | 03:50:38 clang-native-arm-lnt | 03:19:27 clang-x64-ninja-win7 | 03:12:48 lldb-x86_64-darwin-13.4| 02:27:25 clang-ppc64le-linux| 02:22:38 clang-ppc64be-linux-lnt| 02:16:00 clang-cmake-thumbv7-a15| 02:06:50 clang-cmake-aarch64-quick | 02:03:36 clang-cmake-armv7-a15-full | 02:02:46 clang-s390x-linux | 02:02:10 clang-atom-d525-fedora-rel | 02:00:50 clang-ppc64be-linux| 01:59:50 clang-cmake-aarch64-42vma | 01:57:47 clang-cmake-armv7-a15 | 01:57:39 clang-cmake-aarch64-39vma | 01:56:55 lldb-x86_64-ubuntu-14.04-android | 01:56:15 clang-hexagon-elf | 01:42:59 lldb-amd64-ninja-ne
[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams
labath added a comment. Thank you for the review. I'll submit this tomorrow. In https://reviews.llvm.org/D29615#670879, @clayborg wrote: > Looks good as long as if we type two log enable commands like: > > (lldb) log enable -f /tmp/a.txt lldb process > (lldb) log enable -f /tmp/a.txt lldb api > Yes, the log file still gets shared. I am not changing that. > @zturner: > Aside from the thread stuff, nothing seems particularly risky about this > change. Did the thread-local stuff you removed have anything to do with the > -t option to the log command? Well... the thread-safe logging would make that unnecessary, but with the current temporary-buffer implementation you don't need that even without threadsafe logging. This makes be believe the logging callback was written before we had the temporary buffer logic in place, but I haven't dug through the history to verify that. https://reviews.llvm.org/D29615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r294549 - [cmake] add missing dependency lldbCommands->lldbBase
Author: labath Date: Wed Feb 8 19:17:34 2017 New Revision: 294549 URL: http://llvm.org/viewvc/llvm-project?rev=294549&view=rev Log: [cmake] add missing dependency lldbCommands->lldbBase CommandObjectVersion.cpp calls lldb_private::GetVersion (present in lldbBase). This should fix the unittest link on windows. I am not sure why is this not present on other platforms -- my guess is that there lldbBase is included in the link through some other dependency chain. Modified: lldb/trunk/source/Commands/CMakeLists.txt Modified: lldb/trunk/source/Commands/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CMakeLists.txt?rev=294549&r1=294548&r2=294549&view=diff == --- lldb/trunk/source/Commands/CMakeLists.txt (original) +++ lldb/trunk/source/Commands/CMakeLists.txt Wed Feb 8 19:17:34 2017 @@ -31,6 +31,7 @@ add_lldb_library(lldbCommands CommandObjectLanguage.cpp LINK_LIBS +lldbBase lldbBreakpoint lldbCore lldbDataFormatters ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
