[Lldb-commits] [lldb] r290180 - [CMake] [PR31433] Fix LLDB tool installation

[Chris Bieneman via lldb-commits]

Author: cbieneman
Date: Tue Dec 20 10:28:18 2016
New Revision: 290180

URL: http://llvm.org/viewvc/llvm-project?rev=290180&view=rev
Log:
[CMake] [PR31433] Fix LLDB tool installation

This resolves PR 31433.

Modified:
lldb/trunk/cmake/modules/AddLLDB.cmake

Modified: lldb/trunk/cmake/modules/AddLLDB.cmake
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/AddLLDB.cmake?rev=290180&r1=290179&r2=290180&view=diff
==
--- lldb/trunk/cmake/modules/AddLLDB.cmake (original)
+++ lldb/trunk/cmake/modules/AddLLDB.cmake Tue Dec 20 10:28:18 2016
@@ -117,7 +117,6 @@ function(add_lldb_executable name)
   set_target_properties(${name} PROPERTIES
 FOLDER "lldb executables")
 
-  set(install_dir bin)
   if(LLDB_BUILD_FRAMEWORK)
 if(ARG_INCLUDE_IN_FRAMEWORK)
   string(REGEX REPLACE "[^/]+" ".." _dots ${LLDB_FRAMEWORK_INSTALL_DIR})
@@ -129,18 +128,19 @@ function(add_lldb_executable name)
   set_target_properties(${name} PROPERTIES
 BUILD_WITH_INSTALL_RPATH On
 INSTALL_RPATH "@loader_path/../${LLDB_FRAMEWORK_INSTALL_DIR}")
-  if(ARG_GENERATE_INSTALL)
-install(TARGETS ${name}
-  COMPONENT ${name}
-  RUNTIME DESTINATION ${install_dir})
-if (NOT CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(install-${name}
-DEPENDS ${name}
-COMMAND "${CMAKE_COMMAND}"
--DCMAKE_INSTALL_COMPONENT=${name}
--P 
"${CMAKE_BINARY_DIR}/cmake_install.cmake")
-endif()
-  endif()
+endif()
+  endif()
+
+  if(ARG_GENERATE_INSTALL)
+install(TARGETS ${name}
+  COMPONENT ${name}
+  RUNTIME DESTINATION bin)
+if (NOT CMAKE_CONFIGURATION_TYPES)
+  add_custom_target(install-${name}
+DEPENDS ${name}
+COMMAND "${CMAKE_COMMAND}"
+-DCMAKE_INSTALL_COMPONENT=${name}
+-P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
 endif()
   endif()
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Any progress on this? Read the previous comments and see if what I said makes 
sense.


https://reviews.llvm.org/D19603



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r290216 - Ignore SIGPIPE in the mini-driver used by these tests.

[Jim Ingham via lldb-commits]

Author: jingham
Date: Tue Dec 20 18:12:54 2016
New Revision: 290216

URL: http://llvm.org/viewvc/llvm-project?rev=290216&view=rev
Log:
Ignore SIGPIPE in the mini-driver used by these tests.

We're seeing some very occasional failures in these tests where the
mini-driver dies with a SIGPIPE.  We don't use SIGPIPE for anything, and
the main lldb driver program already ignores SIGPIPE, so ignoring it in
the mini-driver is a good way to remove these spurious failures.



Modified:

lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template

Modified: 
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template?rev=290216&r1=290215&r2=290216&view=diff
==
--- 
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template 
(original)
+++ 
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template 
Tue Dec 20 18:12:54 2016
@@ -6,6 +6,9 @@
 #include 
 #include 
 #include 
+#if !defined(_MSC_VER)
+  #include 
+#endif
 
 %include_SB_APIs%
 
@@ -17,6 +20,13 @@ using namespace lldb;
 void test(SBDebugger &dbg, std::vector args);
 
 int main(int argc, char** argv) {
+
+// Ignore SIGPIPE.  The lldb driver does this as well,
+// because we seem to get spurious SIGPIPES on some
+// Unixen that take the driver down.
+#if !defined(_MSC_VER)
+  signal(SIGPIPE, SIG_IGN);
+#endif
   int code = 0;
 
   SBDebugger::Initialize();


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits