Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-03-20 Thread Pavel Labath via lldb-commits
labath added a comment.

So I ran the tests on windows (http://reviews.llvm.org/W7 Enterprise) now and I 
did indeed get the long "0:0:...:1" version here instead of "::1". Maybe we 
should just accept both versions as correct?


Repository:
  rL LLVM

http://reviews.llvm.org/D17106



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-03-20 Thread Zachary Turner via lldb-commits
Yea that works
On Wed, Mar 16, 2016 at 6:33 AM Pavel Labath  wrote:

> labath added a comment.
>
> So I ran the tests on windows (http://reviews.llvm.org/W7 Enterprise) now
> and I did indeed get the long "0:0:...:1" version here instead of "::1".
> Maybe we should just accept both versions as correct?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D17106
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] r263899 - Attempt to fix MSVC build (no __attribute__ there)

2016-03-20 Thread Pavel Labath via lldb-commits
Author: labath
Date: Sun Mar 20 08:37:55 2016
New Revision: 263899

URL: http://llvm.org/viewvc/llvm-project?rev=263899&view=rev
Log:
Attempt to fix MSVC build (no __attribute__ there)

Modified:
lldb/trunk/include/lldb/Expression/DiagnosticManager.h

Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/DiagnosticManager.h?rev=263899&r1=263898&r2=263899&view=diff
==
--- lldb/trunk/include/lldb/Expression/DiagnosticManager.h (original)
+++ lldb/trunk/include/lldb/Expression/DiagnosticManager.h Sun Mar 20 08:37:55 
2016
@@ -10,6 +10,7 @@
 #ifndef lldb_DiagnosticManager_h
 #define lldb_DiagnosticManager_h
 
+#include "lldb/lldb-defines.h"
 #include "lldb/lldb-types.h"
 
 #include 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits