[Lldb-commits] [lldb] r252058 - Fix test infrastructure when using xunit output.
Author: tfiala Date: Wed Nov 4 11:10:40 2015 New Revision: 252058 URL: http://llvm.org/viewvc/llvm-project?rev=252058&view=rev Log: Fix test infrastructure when using xunit output. Our test reporting infrastructure needed module names to change based on the python package layout. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=252058&r1=252057&r2=252058&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Wed Nov 4 11:10:40 2015 @@ -922,12 +922,12 @@ def setupTestResults(): else: results_file_object = open(results_filename, "w") cleanup_func = results_file_object.close -default_formatter_name = "test_results.XunitFormatter" +default_formatter_name = "lldbsuite.test.test_results.XunitFormatter" elif results_port: # Connect to the specified localhost port. results_file_object, cleanup_func = createSocketToLocalPort( results_port) -default_formatter_name = "test_results.RawPickledFormatter" +default_formatter_name = "lldbsuite.test.test_results.RawPickledFormatter" if results_file_object: # We care about the formatter. Choose user-specified or, if ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars
tfiala added a comment. I'll have a look. How do I test it, @artagnon? http://reviews.llvm.org/D13819 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14162: Create Python library `seven` in lldbsuite.support
tfiala added a comment. I think this went in, right? http://reviews.llvm.org/D14162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14157: Make dosep correctly invoke the top level script when doing the multiprocessing fork
tfiala added a comment. I think this got checked in, right? http://reviews.llvm.org/D14157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252059 - OS X: fix the Xcode debugserver lookup code when LLDB.framework does not contain a debugserver
Author: tfiala
Date: Wed Nov 4 12:10:31 2015
New Revision: 252059
URL: http://llvm.org/viewvc/llvm-project?rev=252059&view=rev
Log:
OS X: fix the Xcode debugserver lookup code when LLDB.framework does not
contain a debugserver
LLDB recently started supporting LLDB.framework without a
debugserver in it. When that happens, the Xcode-included debugserver
is searched for and used. This change fixes the code that looks for
Xcode when the housing process is not Xcode. In particular, this
addresses the problem where python is running the test suite and
the LLDB.framework does not contain a debugserver.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp?rev=252059&r1=252058&r2=252059&view=diff
==
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp Wed Nov 4
12:10:31 2015
@@ -10,7 +10,10 @@
#include "PlatformDarwin.h"
// C Includes
+#include
+
// C++ Includes
+#include
#include
// Other libraries and framework includes
@@ -1245,7 +1248,13 @@ GetXcodeContentsPath ()
if (fspec)
{
-g_xcode_filespec = CheckPathForXcode(fspec);
+// Ignore the current binary if it is python.
+std::string basename_lower = fspec.GetFilename ().GetCString ();
+std::transform(basename_lower.begin (), basename_lower.end (),
basename_lower.begin (), tolower);
+if (basename_lower != "python")
+{
+g_xcode_filespec = CheckPathForXcode(fspec);
+}
}
// Next check DEVELOPER_DIR environment variable
@@ -1263,7 +1272,7 @@ GetXcodeContentsPath ()
int status = 0;
int signo = 0;
std::string output;
-const char *command = "xcrun -sdk macosx --show-sdk-path";
+const char *command = "/usr/bin/xcode-select -p";
lldb_private::Error error = Host::RunShellCommand (command,
// shell command to run
NULL,
// current working directory
&status,
// Put the exit status of the process in here
@@ -1277,6 +1286,7 @@ GetXcodeContentsPath ()
{
output.erase(first_non_newline+1);
}
+output.append("/..");
g_xcode_filespec =
CheckPathForXcode(FileSpec(output.c_str(), false));
}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars
artagnon added a comment.
Okay, so run this on the current HEAD:
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at cmake/modules/LLDBStandalone.cmake:37 (get_filename_component):
get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
CMake Error at cmake/modules/LLDBStandalone.cmake:40 (get_filename_component):
get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
CMake Error at cmake/modules/LLDBStandalone.cmake:48 (include):
include could not find load file:
AddLLVM
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
CMake Error at cmake/modules/LLDBStandalone.cmake:49 (include):
include could not find load file:
HandleLLVMOptions
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
-- Found PythonInterp:
CMake Error at cmake/modules/LLDBStandalone.cmake:63 (include):
include could not find load file:
/share/llvm/cmake/LLVMConfig.cmake
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
-- Found PythonLibs: /usr/lib/libpython2.7.dylib (found version "2.7.10")
CMake Error at cmake/modules/LLDBConfig.cmake:205 (check_cxx_compiler_flag):
Unknown CMake command "check_cxx_compiler_flag".
Call Stack (most recent call first):
CMakeLists.txt:4 (include)
-- Configuring incomplete, errors occurred!
See also "/home/rramacha/src/lldb-build2/CMakeFiles/CMakeOutput.log".
Cryptic syntax errors right? Now apply the patch and run:
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at cmake/modules/LLDBStandalone.cmake:43 (message):
Please set LLDB_PATH_TO_LLVM_BUILD to the root directory of LLVM build or
install site.
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
-- Configuring incomplete, errors occurred!
See also "/home/rramacha/src/lldb-build2/CMakeFiles/CMakeOutput.log".
Great. To fix that, run:
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug
-DLLDB_PATH_TO_LLVM_BUILD=~/src/llvm-build ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at cmake/modules/LLDBStandalone.cmake:51 (message):
Please set LLDB_PATH_TO_CLANG_BUILD to the root directory of Clang build or
install site.
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
-- Configuring incomplete, errors occurred!
See also "/home/rramacha/src/lldb-build2/CMakeFiles/CMakeOutput.log".
To build successfully, you need to (with or without the patch):
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug
-DLLDB_PATH_TO_LLVM_SOURCE=~/src/llvm
-DLLDB_PATH_TO_LLVM_BUILD=~/src/llvm-build
-DLLDB_PATH_TO_CLANG_SOURCE=~/src/clang
-DLLDB_PATH_TO_CLANG_BUILD=~/src/clang-build ../lldb
The patch doesn't solve all issues: for instance, what happens when
LLDB_PATH_TO_{LLVM,CLANG}_SOURCE isn't suitable? Why can't I query llvm-config
and get all these paths? (and hopefully
[Lldb-commits] [PATCH] D14342: Enable absolute imports in lldbsuite
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
Enable absolute imports in lldbsuite.
Absolute imports were introduced in Python 2.5 as a feature
(e.g. from __future__ import absolute_import), and made default
in Python 3.
When absolute imports are enabled, the import system changes in
a couple of ways:
1) The `import foo` syntax will *only* search sys.path. If `foo`
isn't in sys.path, it won't be found. Period. Without absolute
imports, the import system will also search the same directory
that the importing file resides in, so that you can easily
import from the same folder.
2) From inside a package, you can use a dot syntax to refer to higher
levels of the current package. For example, if you are in the
package lldbsuite.test.utility, then ..foo refers to
lldbsuite.test.foo. You can use this notation with the
`from X import Y` syntax to write intra-package references. For
example, using the previous locationa s a starting point, writing
`from ..support import seven` would import lldbsuite.support.seven
Since this is now the default behavior in Python 3, this means that
importing from the same directory with `import foo` *no longer works*.
As a result, the only way to have portable code is to force absolute
imports for all versions of Python.
See PEP 0328 [https://www.python.org/dev/peps/pep-0328/] for more
information about absolute and relative imports.
http://reviews.llvm.org/D14342
Files:
packages/Python/lldbsuite/test/__init__.py
packages/Python/lldbsuite/test/bench.py
packages/Python/lldbsuite/test/curses_results.py
packages/Python/lldbsuite/test/dosep.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/dotest_channels.py
packages/Python/lldbsuite/test/lldb_pylint_helper.py
packages/Python/lldbsuite/test/lldbbench.py
packages/Python/lldbsuite/test/lldbcurses.py
packages/Python/lldbsuite/test/lldbinline.py
packages/Python/lldbsuite/test/lldbpexpect.py
packages/Python/lldbsuite/test/lldbplatformutil.py
packages/Python/lldbsuite/test/lldbtest.py
packages/Python/lldbsuite/test/lldbutil.py
packages/Python/lldbsuite/test/test_categories.py
packages/Python/lldbsuite/test/test_results.py
Index: packages/Python/lldbsuite/test/test_results.py
===
--- packages/Python/lldbsuite/test/test_results.py
+++ packages/Python/lldbsuite/test/test_results.py
@@ -9,9 +9,9 @@
"""
from __future__ import print_function
+from __future__ import absolute_import
-
-
+# System modules
import argparse
import inspect
import os
@@ -23,9 +23,11 @@
import traceback
import xml.sax.saxutils
+# Third-party modules
import six
from six.moves import cPickle
+# LLDB modules
class EventBuilder(object):
"""Helper class to build test result event dictionaries."""
Index: packages/Python/lldbsuite/test/test_categories.py
===
--- packages/Python/lldbsuite/test/test_categories.py
+++ packages/Python/lldbsuite/test/test_categories.py
@@ -2,8 +2,15 @@
Provides definitions for various lldb test categories
"""
+from __future__ import absolute_import
+
+# System modules
import sys
+# Third-party modules
+
+# LLDB modules
+
all_categories = {
'dataformatters': 'Tests related to the type command and the data formatters subsystem',
'expression': 'Tests related to the expression parser',
Index: packages/Python/lldbsuite/test/lldbutil.py
===
--- packages/Python/lldbsuite/test/lldbutil.py
+++ packages/Python/lldbsuite/test/lldbutil.py
@@ -5,16 +5,21 @@
"""
from __future__ import print_function
+from __future__ import absolute_import
-
-
-import lldb
-import os, sys
+# System modules
+import collections
+import os
import re
+import sys
+# Third-party modules
from six import StringIO as SixStringIO
import six
-import collections
+
+# LLDB modules
+import lldb
+
# ===
# Utilities for locating/checking executable programs
Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -32,10 +32,11 @@
"""
from __future__ import print_function
+from __future__ import absolute_import
-
-
+# System modules
import abc
+import collections
import gc
import glob
import os, sys, traceback
@@ -45,17 +46,19 @@
from subprocess import *
import time
import types
-import unittest2
-import lldb
-import lldbtest_config
-import lldbutil
-import test_categories
+# Third-party modules
+import unittest2
from six import add
[Lldb-commits] [lldb] r252065 - Fix TestMemoryRead after r252035
Author: tberghammer Date: Wed Nov 4 13:32:01 2015 New Revision: 252065 URL: http://llvm.org/viewvc/llvm-project?rev=252065&view=rev Log: Fix TestMemoryRead after r252035 Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectMemory.cpp?rev=252065&r1=252064&r2=252065&view=diff == --- lldb/trunk/source/Commands/CommandObjectMemory.cpp (original) +++ lldb/trunk/source/Commands/CommandObjectMemory.cpp Wed Nov 4 13:32:01 2015 @@ -114,7 +114,7 @@ public: m_force = true; break; -case 'o': +case 'E': error = m_offset.SetValueFromString(option_arg); break; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252067 - Revert r252001 as it brake TestCppIncompleteTypes on all platforms
Author: tberghammer
Date: Wed Nov 4 13:39:32 2015
New Revision: 252067
URL: http://llvm.org/viewvc/llvm-project?rev=252067&view=rev
Log:
Revert r252001 as it brake TestCppIncompleteTypes on all platforms
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp?rev=252067&r1=252066&r2=252067&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
(original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Wed Nov
4 13:39:32 2015
@@ -2777,23 +2777,6 @@ DWARFASTParserClang::ParseChildMembers (
}
}
-if
(ClangASTContext::IsCXXClassType(member_clang_type) &&
member_clang_type.GetCompleteType() == false)
-{
-module_sp->ReportError ("DWARF DIE at
0x%8.8x (class %s) has a member variable 0x%8.8x (%s) whose type is a forward
declaration, not a complete definition.\nPlease file a bug against the compiler
and include the preprocessed output for %s",
-
parent_die.GetOffset(),
-
parent_die.GetName(),
-die.GetOffset(),
-name,
-sc.comp_unit ?
sc.comp_unit->GetPath().c_str() : "the source file");
-// We have no choice other than to pretend
that the member class
-// is complete. If we don't do this, clang
will crash when trying
-// to layout the class. Since we provide
layout assistance, all
-// ivars in this class and other classes
will be fine, this is
-// the best we can do short of crashing.
-
ClangASTContext::StartTagDeclarationDefinition(member_clang_type);
-
ClangASTContext::CompleteTagDeclarationDefinition(member_clang_type);
-}
-
field_decl =
ClangASTContext::AddFieldToRecordType (class_clang_type,
name,
member_clang_type,
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252072 - Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero out
Author: jingham
Date: Wed Nov 4 14:32:27 2015
New Revision: 252072
URL: http://llvm.org/viewvc/llvm-project?rev=252072&view=rev
Log:
Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero
out
the Expression ResultVariable so it's in a known initial state.
Modified:
lldb/trunk/include/lldb/Expression/IRMemoryMap.h
lldb/trunk/include/lldb/Target/Process.h
lldb/trunk/source/Expression/IRExecutionUnit.cpp
lldb/trunk/source/Expression/IRMemoryMap.cpp
lldb/trunk/source/Expression/LLVMUserExpression.cpp
lldb/trunk/source/Expression/Materializer.cpp
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/include/lldb/Expression/IRMemoryMap.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/IRMemoryMap.h?rev=252072&r1=252071&r2=252072&view=diff
==
--- lldb/trunk/include/lldb/Expression/IRMemoryMap.h (original)
+++ lldb/trunk/include/lldb/Expression/IRMemoryMap.h Wed Nov 4 14:32:27 2015
@@ -50,7 +50,12 @@ public:
eAllocationPolicyProcessOnly///< The intent is that this
allocation exist only in the process.
};
-lldb::addr_t Malloc (size_t size, uint8_t alignment, uint32_t permissions,
AllocationPolicy policy, Error &error);
+lldb::addr_t Malloc (size_t size,
+ uint8_t alignment,
+ uint32_t permissions,
+ AllocationPolicy policy,
+ bool zero_memory,
+ Error &error);
void Leak (lldb::addr_t process_address, Error &error);
void Free (lldb::addr_t process_address, Error &error);
@@ -124,7 +129,7 @@ private:
typedef std::map AllocationMap;
AllocationMap m_allocations;
-lldb::addr_t FindSpace (size_t size);
+lldb::addr_t FindSpace (size_t size, bool zero_memory = false);
bool ContainsHostOnlyAllocations ();
AllocationMap::iterator FindAllocation (lldb::addr_t addr, size_t size);
Modified: lldb/trunk/include/lldb/Target/Process.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/Process.h?rev=252072&r1=252071&r2=252072&view=diff
==
--- lldb/trunk/include/lldb/Target/Process.h (original)
+++ lldb/trunk/include/lldb/Target/Process.h Wed Nov 4 14:32:27 2015
@@ -2376,6 +2376,33 @@ public:
AllocateMemory (size_t size, uint32_t permissions, Error &error);
//--
+/// The public interface to allocating memory in the process, this also
+/// clears the allocated memory.
+///
+/// This function will allocate memory in the process's address
+/// space. This can't rely on the generic function calling mechanism,
+/// since that requires this function.
+///
+/// @param[in] size
+/// The size of the allocation requested.
+///
+/// @param[in] permissions
+/// Or together any of the lldb::Permissions bits. The permissions on
+/// a given memory allocation can't be changed after allocation. Note
+/// that a block that isn't set writable can still be written on from
lldb,
+/// just not by the process itself.
+///
+/// @param[in/out] error
+/// An error object to fill in if things go wrong.
+/// @return
+/// The address of the allocated buffer in the process, or
+/// LLDB_INVALID_ADDRESS if the allocation failed.
+//--
+
+lldb::addr_t
+CallocateMemory (size_t size, uint32_t permissions, Error &error);
+
+//--
/// Resolve dynamically loaded indirect functions.
///
/// @param[in] address
Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRExecutionUnit.cpp?rev=252072&r1=252071&r2=252072&view=diff
==
--- lldb/trunk/source/Expression/IRExecutionUnit.cpp (original)
+++ lldb/trunk/source/Expression/IRExecutionUnit.cpp Wed Nov 4 14:32:27 2015
@@ -50,10 +50,12 @@ IRExecutionUnit::WriteNow (const uint8_t
size_t size,
Error &error)
{
+const bool zero_memory = false;
lldb::addr_t allocation_process_addr = Malloc (size,
8,
lldb::ePermissionsWritable
| lldb::ePermissionsReadable,
eAllocationPolicyMirror,
+ zero_memory,
error);
i
[Lldb-commits] [lldb] r252079 - [Core] Avoid default in switch() that covers all the cases.
Author: davide Date: Wed Nov 4 15:31:16 2015 New Revision: 252079 URL: http://llvm.org/viewvc/llvm-project?rev=252079&view=rev Log: [Core] Avoid default in switch() that covers all the cases. Unbreak the build for FreeBSD + -Werror. Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=252079&r1=252078&r2=252079&view=diff == --- lldb/trunk/source/Core/ValueObject.cpp (original) +++ lldb/trunk/source/Core/ValueObject.cpp Wed Nov 4 15:31:16 2015 @@ -525,7 +525,6 @@ ValueObject::IsLogicalTrue (Error& error case eLazyBoolNo: return (is_logical_true == true); case eLazyBoolCalculate: -default: break; } } ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252092 - Handle keyword args on our patched Popen methods.
Author: zturner Date: Wed Nov 4 17:03:21 2015 New Revision: 252092 URL: http://llvm.org/viewvc/llvm-project?rev=252092&view=rev Log: Handle keyword args on our patched Popen methods. Python 3 introduces the `timeout` keyword argument on Popen.wait(). If our patched version doesn't support keyword arguments, then when the internal Python implementation attempts to call wait() with the keyword argument, things will explode. Such as my head, after I finally figured out what was happening. Modified: lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py Modified: lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py?rev=252092&r1=252091&r2=252092&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py Wed Nov 4 17:03:21 2015 @@ -619,10 +619,10 @@ def patched_init(self, *args, **kwargs): self.wait_condition = threading.Condition() -def patched_wait(self): +def patched_wait(self, *args, **kwargs): self.wait_condition.acquire() try: -result = self.original_wait() +result = self.original_wait(*args, **kwargs) # The process finished. Signal the condition. self.wait_condition.notify_all() return result @@ -630,10 +630,10 @@ def patched_wait(self): self.wait_condition.release() -def patched_poll(self): +def patched_poll(self, *args, **kwargs): self.wait_condition.acquire() try: -result = self.original_poll() +result = self.original_poll(*args, **kwargs) if self.returncode is not None: # We did complete, and we have the return value. # Signal the event to indicate we're done. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252091 - Don't access class members inside of `__del__`.
Author: zturner Date: Wed Nov 4 17:03:10 2015 New Revision: 252091 URL: http://llvm.org/viewvc/llvm-project?rev=252091&view=rev Log: Don't access class members inside of `__del__`. Apparently this doesn't work as the attribute doesn't exist anymore. Modified: lldb/trunk/scripts/utilsDebug.py Modified: lldb/trunk/scripts/utilsDebug.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/utilsDebug.py?rev=252091&r1=252090&r2=252091&view=diff == --- lldb/trunk/scripts/utilsDebug.py (original) +++ lldb/trunk/scripts/utilsDebug.py Wed Nov 4 17:03:10 2015 @@ -76,10 +76,6 @@ class CDebugFnVerbose: def __init__( self, vstrFnName ): self.__indent_out( vstrFnName ); - # Class destructor - def __del__( self ): - self.__indent_back(); - #++ # Details: Build an indentation string of dots based on the __nLevel. # Type: Method. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252094 - [FreeBSD] Add missing overrides.
Author: davide Date: Wed Nov 4 17:12:17 2015 New Revision: 252094 URL: http://llvm.org/viewvc/llvm-project?rev=252094&view=rev Log: [FreeBSD] Add missing overrides. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h?rev=252094&r1=252093&r2=252094&view=diff == --- lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h (original) +++ lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.h Wed Nov 4 17:12:17 2015 @@ -136,7 +136,7 @@ protected: // POSIXThread override virtual void -WillResume(lldb::StateType resume_state); +WillResume(lldb::StateType resume_state) override; }; #endif // #ifndef liblldb_FreeBSDThread_H_ Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h?rev=252094&r1=252093&r2=252094&view=diff == --- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h (original) +++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h Wed Nov 4 17:12:17 2015 @@ -60,16 +60,16 @@ public: ~ProcessFreeBSD(); virtual lldb_private::Error -WillResume(); +WillResume() override; //-- // PluginInterface protocol //-- virtual lldb_private::ConstString -GetPluginName(); +GetPluginName() override; virtual uint32_t -GetPluginVersion(); +GetPluginVersion() override; public: //-- ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252100 - Fix x64 build on Windows, which was broken by my refactor from last week.
Author: amccarth
Date: Wed Nov 4 17:47:55 2015
New Revision: 252100
URL: http://llvm.org/viewvc/llvm-project?rev=252100&view=rev
Log:
Fix x64 build on Windows, which was broken by my refactor from last week.
No build bots build x64 on Windows yet, but this was spotted by another
developer who emailed me directly.
Added:
lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp
lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.h
- copied, changed from r252058,
lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h?rev=252100&r1=252099&r2=252100&view=diff
==
---
lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h
(original)
+++
lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.h
Wed Nov 4 17:47:55 2015
@@ -45,4 +45,4 @@ class RegisterContextWindows_x64 : publi
};
}
-#endif // #ifndef liblldb_RegisterContextPOSIX_x64_H_
+#endif // #ifndef liblldb_RegisterContextWindows_x64_H_
Added:
lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp?rev=252100&view=auto
==
---
lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp
(added)
+++
lldb/trunk/source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp
Wed Nov 4 17:47:55 2015
@@ -0,0 +1,171 @@
+//===-- RegisterContextWindowsLive_x64.cpp --*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#include "lldb/lldb-private-types.h"
+#include "lldb/Core/Error.h"
+#include "lldb/Core/RegisterValue.h"
+#include "lldb/Host/windows/HostThreadWindows.h"
+#include "lldb/Host/windows/windows.h"
+
+#include "lldb-x86-register-enums.h"
+#include "RegisterContextWindowsLive_x64.h"
+#include "TargetThreadWindows.h"
+
+#include "llvm/ADT/STLExtras.h"
+
+using namespace lldb;
+using namespace lldb_private;
+
+RegisterContextWindowsLive_x64::RegisterContextWindowsLive_x64(Thread &thread,
uint32_t concrete_frame_idx)
+: RegisterContextWindows_x64(thread, concrete_frame_idx)
+{
+}
+
+RegisterContextWindowsLive_x64::~RegisterContextWindowsLive_x64()
+{
+}
+
+
+bool
+RegisterContextWindowsLive_x64::ReadRegister(const RegisterInfo *reg_info,
RegisterValue ®_value)
+{
+if (!CacheAllRegisterValues())
+return false;
+
+switch (reg_info->kinds[eRegisterKindLLDB])
+{
+case lldb_rax_x86_64:
+reg_value.SetUInt64(m_context.Rax);
+break;
+case lldb_rbx_x86_64:
+reg_value.SetUInt64(m_context.Rbx);
+break;
+case lldb_rcx_x86_64:
+reg_value.SetUInt64(m_context.Rcx);
+break;
+case lldb_rdx_x86_64:
+reg_value.SetUInt64(m_context.Rdx);
+break;
+case lldb_rdi_x86_64:
+reg_value.SetUInt64(m_context.Rdi);
+break;
+case lldb_rsi_x86_64:
+reg_value.SetUInt64(m_context.Rsi);
+break;
+case lldb_r8_x86_64:
+reg_value.SetUInt64(m_context.R8);
+break;
+case lldb_r9_x86_64:
+reg_value.SetUInt64(m_context.R9);
+break;
+case lldb_r10_x86_64:
+reg_value.SetUInt64(m_context.R10);
+break;
+case lldb_r11_x86_64:
+reg_value.SetUInt64(m_context.R11);
+break;
+case lldb_r12_x86_64:
+reg_value.SetUInt64(m_context.R12);
+break;
+case lldb_r13_x86_64:
+reg_value.SetUInt64(m_context.R13);
+break;
+case lldb_r14_x86_64:
+reg_value.SetUInt64(m_context.R14);
+break;
+case lldb_r15_x86_64:
+reg_value.SetUInt64(m_context.R15);
+break;
+case lldb_rbp_x86_64:
+reg_value.SetUInt64(m_context.Rbp);
+break;
+case lldb_rsp_x86_64:
+reg_value.SetUInt64(m_context.Rsp);
+break;
+case lldb_rip_x86_64:
+reg_value.SetUInt64(m_context.Rip);
+break;
+case lldb_rflags_x86_64:
+
[Lldb-commits] [lldb] r252106 - One of the File constructors was missing initializers. Didn't seem
Author: jingham
Date: Wed Nov 4 18:22:19 2015
New Revision: 252106
URL: http://llvm.org/viewvc/llvm-project?rev=252106&view=rev
Log:
One of the File constructors was missing initializers. Didn't seem
to cause any problems, but still...
Modified:
lldb/trunk/include/lldb/Host/File.h
Modified: lldb/trunk/include/lldb/Host/File.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/File.h?rev=252106&r1=252105&r2=252106&view=diff
==
--- lldb/trunk/include/lldb/Host/File.h (original)
+++ lldb/trunk/include/lldb/Host/File.h Wed Nov 4 18:22:19 2015
@@ -125,7 +125,9 @@ public:
m_descriptor (fd),
m_stream (kInvalidStream),
m_options (0),
-m_own_stream (false)
+m_own_stream (false),
+m_is_interactive (eLazyBoolCalculate),
+m_is_real_terminal (eLazyBoolCalculate)
{
}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252108 - AddInitialArguments -> AddArguments, and we pass in the struct_address and push it too. All the
Author: jingham
Date: Wed Nov 4 18:24:18 2015
New Revision: 252108
URL: http://llvm.org/viewvc/llvm-project?rev=252108&view=rev
Log:
AddInitialArguments -> AddArguments, and we pass in the struct_address and push
it too. All the
callers had to do this by hand and we ended up never actually adding initial
arguments and then
reusing them by passing in the struct address separately, so the distinction
wasn't needed.
Modified:
lldb/trunk/include/lldb/Expression/LLVMUserExpression.h
lldb/trunk/source/Expression/LLVMUserExpression.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpression.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/LLVMUserExpression.h?rev=252108&r1=252107&r2=252108&view=diff
==
--- lldb/trunk/include/lldb/Expression/LLVMUserExpression.h (original)
+++ lldb/trunk/include/lldb/Expression/LLVMUserExpression.h Wed Nov 4 18:24:18
2015
@@ -77,11 +77,13 @@ class LLVMUserExpression : public UserEx
virtual void ScanContext(ExecutionContext &exe_ctx, lldb_private::Error
&err) = 0;
bool PrepareToExecuteJITExpression(Stream &error_stream, ExecutionContext
&exe_ctx, lldb::addr_t &struct_address);
+
virtual bool
-AddInitialArguments(ExecutionContext &exe_ctx, std::vector
&args, Stream &error_stream)
-{
-return true;
-}
+AddArguments (ExecutionContext &exe_ctx,
+ std::vector &args,
+ lldb::addr_t struct_address,
+ Stream &error_stream) = 0;
+
lldb::addr_t m_stack_frame_bottom; ///< The bottom of the allocated stack
frame.
lldb::addr_t m_stack_frame_top;///< The top of the allocated stack
frame.
Modified: lldb/trunk/source/Expression/LLVMUserExpression.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/LLVMUserExpression.cpp?rev=252108&r1=252107&r2=252108&view=diff
==
--- lldb/trunk/source/Expression/LLVMUserExpression.cpp (original)
+++ lldb/trunk/source/Expression/LLVMUserExpression.cpp Wed Nov 4 18:24:18 2015
@@ -111,14 +111,12 @@ LLVMUserExpression::Execute(Stream &erro
std::vector args;
-if (!AddInitialArguments(exe_ctx, args, error_stream))
+if (!AddArguments(exe_ctx, args, struct_address, error_stream))
{
-error_stream.Printf("Errored out in %s, couldn't
AddInitialArguments", __FUNCTION__);
+error_stream.Printf("Errored out in %s, couldn't
AddArguments", __FUNCTION__);
return lldb::eExpressionSetupError;
}
-args.push_back(struct_address);
-
function_stack_bottom = m_stack_frame_bottom;
function_stack_top = m_stack_frame_top;
@@ -143,14 +141,12 @@ LLVMUserExpression::Execute(Stream &erro
std::vector args;
-if (!AddInitialArguments(exe_ctx, args, error_stream))
+if (!AddArguments(exe_ctx, args, struct_address, error_stream))
{
-error_stream.Printf("Errored out in %s, couldn't
AddInitialArguments", __FUNCTION__);
+error_stream.Printf("Errored out in %s, couldn't
AddArguments", __FUNCTION__);
return lldb::eExpressionSetupError;
}
-args.push_back(struct_address);
-
lldb::ThreadPlanSP call_plan_sp(new
ThreadPlanCallUserExpression(exe_ctx.GetThreadRef(), wrapper_address,
args, options, shared_ptr_to_me));
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp?rev=252108&r1=252107&r2=252108&view=diff
==
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
(original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
Wed Nov 4 18:24:18 2015
@@ -555,9 +555,10 @@ ClangUserExpression::Parse (Stream &erro
}
bool
-ClangUserExpression::AddInitialArguments (ExecutionContext &exe_ctx,
- std::vector &args,
- Stream &error_stream)
+ClangUserExpression::AddArguments (ExecutionContext &exe_ctx,
+ std::vector &args,
+ lldb::addr_t struct_address,
+ Stream &error_stream)
{
lldb::addr_t object_ptr = LLDB_INVALID_ADDRESS;
lldb::addr_t cmd_ptr= LLDB_INVALID_ADDRESS;
@@ -612,7 +613,11 @@
[Lldb-commits] [lldb] r252109 - Add go data formatters.
Author: ribrdb
Date: Wed Nov 4 18:24:36 2015
New Revision: 252109
URL: http://llvm.org/viewvc/llvm-project?rev=252109&view=rev
Log:
Add go data formatters.
Differential Revision: http://reviews.llvm.org/D13878
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/main.go
lldb/trunk/source/Plugins/Language/Go/
lldb/trunk/source/Plugins/Language/Go/CMakeLists.txt
lldb/trunk/source/Plugins/Language/Go/GoFormatterFunctions.cpp
lldb/trunk/source/Plugins/Language/Go/GoFormatterFunctions.h
lldb/trunk/source/Plugins/Language/Go/GoLanguage.cpp
lldb/trunk/source/Plugins/Language/Go/GoLanguage.h
lldb/trunk/source/Plugins/Language/Go/Makefile
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/API/SystemInitializerFull.cpp
lldb/trunk/source/Plugins/Language/CMakeLists.txt
lldb/trunk/source/Plugins/Makefile
Modified: lldb/trunk/cmake/LLDBDependencies.cmake
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=252109&r1=252108&r2=252109&view=diff
==
--- lldb/trunk/cmake/LLDBDependencies.cmake (original)
+++ lldb/trunk/cmake/LLDBDependencies.cmake Wed Nov 4 18:24:36 2015
@@ -22,6 +22,7 @@ set( LLDB_USED_LIBS
lldbPluginDynamicLoaderWindowsDYLD
lldbPluginCPlusPlusLanguage
+ lldbPluginGoLanguage
lldbPluginObjCLanguage
lldbPluginObjCPlusPlusLanguage
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=252109&r1=252108&r2=252109&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Nov 4 18:24:36 2015
@@ -842,6 +842,8 @@
AE44FB301BB07EB20033EB62 /* GoUserExpression.cpp in Sources */
= {isa = PBXBuildFile; fileRef = AE44FB2C1BB07DD80033EB62 /*
GoUserExpression.cpp */; };
AE44FB311BB07EB80033EB62 /* GoLexer.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = AE44FB2A1BB07DD80033EB62 /* GoLexer.cpp */; };
AE44FB321BB07EBC0033EB62 /* GoParser.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = AE44FB2B1BB07DD80033EB62 /* GoParser.cpp */; };
+ AE44FB471BB4BB090033EB62 /* GoLanguage.cpp in Sources */ = {isa
= PBXBuildFile; fileRef = AE44FB451BB4BB090033EB62 /* GoLanguage.cpp */; };
+ AE44FB4C1BB4BB540033EB62 /* GoFormatterFunctions.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = AE44FB4A1BB4BB540033EB62 /*
GoFormatterFunctions.cpp */; };
AE44FB3E1BB485960033EB62 /* GoLanguageRuntime.cpp in Sources */
= {isa = PBXBuildFile; fileRef = AE44FB3D1BB485960033EB62 /*
GoLanguageRuntime.cpp */; };
AE6897281B94F6DE0018845D /* DWARFASTParserGo.cpp in Sources */
= {isa = PBXBuildFile; fileRef = AE6897261B94F6DE0018845D /*
DWARFASTParserGo.cpp */; };
AE7F56291B8FE418001377A8 /* GoASTContext.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = AEFFBA7C1AC4835D0087B932 /* GoASTContext.cpp */;
};
@@ -2695,6 +2697,10 @@
AE44FB2A1BB07DD80033EB62 /* GoLexer.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = GoLexer.cpp; path = ExpressionParser/Go/GoLexer.cpp; sourceTree =
""; };
AE44FB2B1BB07DD80033EB62 /* GoParser.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = GoParser.cpp; path = ExpressionParser/Go/GoParser.cpp; sourceTree =
""; };
AE44FB2C1BB07DD80033EB62 /* GoUserExpression.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = GoUserExpression.cpp; path = ExpressionParser/Go/GoUserExpression.cpp;
sourceTree = ""; };
+ AE44FB451BB4BB090033EB62 /* GoLanguage.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = GoLanguage.cpp; path = Language/Go/GoLanguage.cpp; sourceTree =
""; };
+ AE44FB461BB4BB090033EB62 /* GoLanguage.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
GoLanguage.h; path = Language/Go/GoLanguage.h; sourceTree = ""; };
+ AE44FB4A1BB4BB540033EB62 /* GoFormatterFunctions.cpp */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = GoFormatterFunctions.cpp; path = Language/Go/GoFormatterFunctions.cpp;
sourceTree = ""; };
+ AE44FB4B1BB4BB540033EB62 /* GoFormatterFunctions.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
GoFormatterFunctions.h;
Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252109: Add go data formatters. (authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D13878?vs=37900&id=39288#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py
lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/main.go
lldb/trunk/source/API/SystemInitializerFull.cpp
lldb/trunk/source/Plugins/Language/CMakeLists.txt
lldb/trunk/source/Plugins/Language/Go/CMakeLists.txt
lldb/trunk/source/Plugins/Language/Go/GoFormatterFunctions.cpp
lldb/trunk/source/Plugins/Language/Go/GoFormatterFunctions.h
lldb/trunk/source/Plugins/Language/Go/GoLanguage.cpp
lldb/trunk/source/Plugins/Language/Go/GoLanguage.h
lldb/trunk/source/Plugins/Language/Go/Makefile
lldb/trunk/source/Plugins/Makefile
Index: lldb/trunk/lldb.xcodeproj/project.pbxproj
===
--- lldb/trunk/lldb.xcodeproj/project.pbxproj
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj
@@ -842,6 +842,8 @@
AE44FB301BB07EB20033EB62 /* GoUserExpression.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB2C1BB07DD80033EB62 /* GoUserExpression.cpp */; };
AE44FB311BB07EB80033EB62 /* GoLexer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB2A1BB07DD80033EB62 /* GoLexer.cpp */; };
AE44FB321BB07EBC0033EB62 /* GoParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB2B1BB07DD80033EB62 /* GoParser.cpp */; };
+ AE44FB471BB4BB090033EB62 /* GoLanguage.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB451BB4BB090033EB62 /* GoLanguage.cpp */; };
+ AE44FB4C1BB4BB540033EB62 /* GoFormatterFunctions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB4A1BB4BB540033EB62 /* GoFormatterFunctions.cpp */; };
AE44FB3E1BB485960033EB62 /* GoLanguageRuntime.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE44FB3D1BB485960033EB62 /* GoLanguageRuntime.cpp */; };
AE6897281B94F6DE0018845D /* DWARFASTParserGo.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AE6897261B94F6DE0018845D /* DWARFASTParserGo.cpp */; };
AE7F56291B8FE418001377A8 /* GoASTContext.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AEFFBA7C1AC4835D0087B932 /* GoASTContext.cpp */; };
@@ -2695,6 +2697,10 @@
AE44FB2A1BB07DD80033EB62 /* GoLexer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoLexer.cpp; path = ExpressionParser/Go/GoLexer.cpp; sourceTree = ""; };
AE44FB2B1BB07DD80033EB62 /* GoParser.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoParser.cpp; path = ExpressionParser/Go/GoParser.cpp; sourceTree = ""; };
AE44FB2C1BB07DD80033EB62 /* GoUserExpression.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoUserExpression.cpp; path = ExpressionParser/Go/GoUserExpression.cpp; sourceTree = ""; };
+ AE44FB451BB4BB090033EB62 /* GoLanguage.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoLanguage.cpp; path = Language/Go/GoLanguage.cpp; sourceTree = ""; };
+ AE44FB461BB4BB090033EB62 /* GoLanguage.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = GoLanguage.h; path = Language/Go/GoLanguage.h; sourceTree = ""; };
+ AE44FB4A1BB4BB540033EB62 /* GoFormatterFunctions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoFormatterFunctions.cpp; path = Language/Go/GoFormatterFunctions.cpp; sourceTree = ""; };
+ AE44FB4B1BB4BB540033EB62 /* GoFormatterFunctions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = GoFormatterFunctions.h; path = Language/Go/GoFormatterFunctions.h; sourceTree = ""; };
AE44FB3C1BB4858A0033EB62 /* GoLanguageRuntime.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = GoLanguageRuntime.h; path = Go/GoLanguageRuntime.h; sourceTree = ""; };
AE44FB3D1BB485960033EB62 /* GoLanguageRuntime.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = GoLanguageRuntime.cpp; path = Go/GoLanguageRuntime.cpp; sourceTree = ""; };
AE6897261B94F6DE0018845D /* DWARFASTParserGo.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DWARFASTParserGo.cpp; sourceTree = ""; };
@@ -5512,6 +5518,7 @@
isa = PBXGroup;
children = (
94B6385A1B8FB109004FE1E4 /* CPlusPlus */,
+AE44FB431BB4BAC20033EB62 /* Go */,
94B638551B8FAC87004FE1E4 /* ObjC */,
94B638601B8FB7BE004FE1E4 /* ObjCPlusPlus */,
);
@@ -5613,6 +5620,25 @@
name = Go;
sourceTree = "";
};
+ AE44FB431BB4BAC20033EB62 /* Go */ = {
+ isa = PBXGroup;
+ chil
[Lldb-commits] [lldb] r252111 - LLDB needs a mutex around getopt_long_only() function calls to avoid multi-threading option parsing issues.
Author: jingham
Date: Wed Nov 4 18:38:39 2015
New Revision: 252111
URL: http://llvm.org/viewvc/llvm-project?rev=252111&view=rev
Log:
LLDB needs a mutex around getopt_long_only() function calls to avoid
multi-threading option parsing issues.
Modified:
lldb/trunk/include/lldb/Host/OptionParser.h
lldb/trunk/source/Host/common/OptionParser.cpp
lldb/trunk/source/Interpreter/Args.cpp
Modified: lldb/trunk/include/lldb/Host/OptionParser.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/OptionParser.h?rev=252111&r1=252110&r2=252111&view=diff
==
--- lldb/trunk/include/lldb/Host/OptionParser.h (original)
+++ lldb/trunk/include/lldb/Host/OptionParser.h Wed Nov 4 18:38:39 2015
@@ -11,6 +11,7 @@
#define liblldb_OptionParser_h_
#include
+#include "lldb/Host/Mutex.h"
struct option;
@@ -38,7 +39,7 @@ public:
eOptionalArgument
};
-static void Prepare();
+static void Prepare(Mutex::Locker &locker);
static void EnableError(bool error);
Modified: lldb/trunk/source/Host/common/OptionParser.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/OptionParser.cpp?rev=252111&r1=252110&r2=252111&view=diff
==
--- lldb/trunk/source/Host/common/OptionParser.cpp (original)
+++ lldb/trunk/source/Host/common/OptionParser.cpp Wed Nov 4 18:38:39 2015
@@ -16,8 +16,10 @@
using namespace lldb_private;
void
-OptionParser::Prepare()
+OptionParser::Prepare(Mutex::Locker &locker)
{
+static Mutex g_mutex(Mutex::eMutexTypeNormal);
+locker.Lock(g_mutex);
#ifdef __GLIBC__
optind = 0;
#else
Modified: lldb/trunk/source/Interpreter/Args.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/Args.cpp?rev=252111&r1=252110&r2=252111&view=diff
==
--- lldb/trunk/source/Interpreter/Args.cpp (original)
+++ lldb/trunk/source/Interpreter/Args.cpp Wed Nov 4 18:38:39 2015
@@ -575,7 +575,8 @@ Args::ParseOptions (Options &options)
}
}
}
-OptionParser::Prepare();
+Mutex::Locker options_locker(NULL);
+OptionParser::Prepare(options_locker);
int val;
while (1)
{
@@ -1189,7 +1190,8 @@ Args::ParseAliasOptions (Options &option
}
}
-OptionParser::Prepare();
+Mutex::Locker options_locker(NULL);
+OptionParser::Prepare(options_locker);
int val;
while (1)
{
@@ -1366,7 +1368,8 @@ Args::ParseArgsForCompletion
}
}
-OptionParser::Prepare();
+Mutex::Locker options_locker(NULL);
+OptionParser::Prepare(options_locker);
OptionParser::EnableError(false);
int val;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252112 - Teach LLDB how to directly launch processes on the iOS simulator
Author: enrico
Date: Wed Nov 4 18:46:25 2015
New Revision: 252112
URL: http://llvm.org/viewvc/llvm-project?rev=252112&view=rev
Log:
Teach LLDB how to directly launch processes on the iOS simulator
This allows for command-line debugging of iOS simulator binaries (as long as UI
is not required, or a full UI simulator has previously been otherwise
launched), as well as execution of the LLDB test suite on the iOS simulator
This is known to compile on OSX 10.11 GM - feedback from people on other
platforms and/or older versions of OSX as to the buildability of this code is
greatly appreciated
Added:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_attach/attach_denied/TestAttachDenied.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/register/TestRegisters.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
lldb/trunk/packages/Python/lldbsuite/test/python_api/hello_world/TestHelloWorld.py
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=252112&r1=252111&r2=252112&view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Nov 4 18:46:25 2015
@@ -772,6 +772,8 @@
945261C51B9A11FC00BF138D /* LibCxxVector.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 945261BB1B9A11E800BF138D /* LibCxxVector.cpp */;
};
945261C61B9A11FC00BF138D /* LibStdcpp.cpp in Sources */ = {isa
= PBXBuildFile; fileRef = 945261BC1B9A11E800BF138D /* LibStdcpp.cpp */; };
945261C81B9A14D300BF138D /* CXXFunctionPointer.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 945261C71B9A14D300BF138D /*
CXXFunctionPointer.cpp */; };
+ 9455630F1BEAD0600073F75F /* PlatformAppleSimulator.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 9455630A1BEAD0570073F75F /*
PlatformAppleSimulator.cpp */; };
+ 945563101BEAD0650073F75F /*
PlatformiOSSimulatorCoreSimulatorSupport.mm in Sources */ = {isa =
PBXBuildFile; fileRef = 9455630D1BEAD0570073F75F /*
PlatformiOSSimulatorCoreSimulatorSupport.mm */; };
945759671534941F005A9070 /* PlatformPOSIX.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 945759651534941F005A9070 /* PlatformPOSIX.cpp
*/; };
945E8D80152F6AB40019BCCD /* StreamGDBRemote.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 945E8D7F152F6AB40019BCCD /* StreamGDBRemote.cpp
*/; };
9461569A14E358A6003A195C /* SBTypeFilter.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 9461568A14E35621003A195C /* SBTypeFilter.cpp */;
};
@@ -2523,6 +2525,10 @@
945261BD1B9A11E800BF138D /* LibStdcpp.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = LibStdcpp.h; path
= Language/CPlusPlus/LibStdcpp.h; sourceTree = ""; };
945261C71B9A14D300BF138D /* CXXFunctionPointer.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CXXFunctionPointer.cpp; path =
source/DataFormatters/CXXFunctionPointer.cpp; sourceTree = ""; };
945261C91B9A14E000BF138D /* CXXFunctionPointer.h */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.c.h; name =
CXXFunctionPointer.h; path = include/lldb/DataFormatters/CXXFunctionPointer.h;
sourceTree = ""; };
+ 9455630A1BEAD0570073F75F /* PlatformAppleSimulator.cpp */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path =
PlatformAppleSimulator.cpp; sourceTree = ""; };
+ 9455630B1BEAD0570073F75F /* PlatformAppleSimulator.h */ = {isa
= PBXFileReference; lastKnownFileType = sourcecode.c.h; path =
PlatformAppleSimulator.h; sourceTree = ""; };
+ 9455630C1BEAD0570073F75F /*
PlatformiOSSimulatorCoreSimulatorSupport.h */ = {isa = PBXFileReference;
lastKnownFileType = sourcecode.c.h; path =
PlatformiOSSimulatorCoreSimulatorSupport.h; sourceTree
Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.
dawn marked an inline comment as done. dawn added a comment. In http://reviews.llvm.org/D12115#248069, @chaoren wrote: > Could you please take a look at these issues? > > TestMiSymbol started to fail on Linux with gcc-4.9: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6387 Hi Chaoren, I believe the issue with gcc was fixed for gcc a while back. Just checking to make sure you're no longer seeing the failure. Let me know otherwise. Comment at: lldb/trunk/tools/lldb-mi/MIUtilParse.h:13 @@ +12,3 @@ +// Third party headers: +#include "../lib/Support/regex_impl.h" + chaoren wrote: > This caused a build failure on OS X: > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5801 This was fixed by Sean - the XCode build wasn't including the full set of include paths when building lldb-mi. Repository: rL LLVM http://reviews.llvm.org/D12115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252122 - CommandObjectProxy needs to proxy GenerateHelpText as well as
Author: jingham
Date: Wed Nov 4 19:18:07 2015
New Revision: 252122
URL: http://llvm.org/viewvc/llvm-project?rev=252122&view=rev
Log:
CommandObjectProxy needs to proxy GenerateHelpText as well as
everything else.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
lldb/trunk/source/Commands/CommandObjectMultiword.cpp
Modified: lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h?rev=252122&r1=252121&r2=252122&view=diff
==
--- lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h (original)
+++ lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h Wed Nov 4
19:18:07 2015
@@ -126,6 +126,9 @@ public:
bool
IsMultiwordObject() override;
+void
+GenerateHelpText (Stream &result) override;
+
lldb::CommandObjectSP
GetSubcommandSP(const char *sub_cmd, StringList *matches = nullptr)
override;
Modified: lldb/trunk/source/Commands/CommandObjectMultiword.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectMultiword.cpp?rev=252122&r1=252121&r2=252122&view=diff
==
--- lldb/trunk/source/Commands/CommandObjectMultiword.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectMultiword.cpp Wed Nov 4 19:18:07
2015
@@ -382,6 +382,14 @@ CommandObjectProxy::IsMultiwordObject ()
return false;
}
+void
+CommandObjectProxy::GenerateHelpText (Stream &result)
+{
+CommandObject *proxy_command = GetProxyCommandObject();
+if (proxy_command)
+return proxy_command->GenerateHelpText(result);
+}
+
lldb::CommandObjectSP
CommandObjectProxy::GetSubcommandSP (const char *sub_cmd, StringList *matches)
{
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252124 - Fix build on Linux.
Author: chaoren Date: Wed Nov 4 19:23:19 2015 New Revision: 252124 URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev Log: Fix build on Linux. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff == --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm (original) +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Wed Nov 4 19:23:19 2015 @@ -9,6 +9,8 @@ #include "PlatformiOSSimulatorCoreSimulatorSupport.h" +#if defined (__APPLE__) // This Plugin uses the Mac-specific source/Host/macosx/cfcpp utilities + // C Includes // C++ Includes // Other libraries and framework includes @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc return dev; } + +#endif // __APPLE__ ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252126 - Python 3 - Use universal_newlines=True in subprocess.Popen.
Author: zturner Date: Wed Nov 4 19:33:44 2015 New Revision: 252126 URL: http://llvm.org/viewvc/llvm-project?rev=252126&view=rev Log: Python 3 - Use universal_newlines=True in subprocess.Popen. This follows the spirit of a previous patch which did essentially the same thing. In Python 3, when you use Popen.communicate(), you get back a bytes object which cannot normally be treated as a string. We could decode this manually, but universal_newlines=True does this automatically, and there's no disadvantage to doing so even on Python 2. So just enable it always. Modified: lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py Modified: lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py?rev=252126&r1=252125&r2=252126&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/test_runner/lib/process_control.py Wed Nov 4 19:33:44 2015 @@ -271,6 +271,7 @@ class UnixProcessHelper(ProcessHelper): stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, +universal_newlines=True, # Elicits automatic byte -> string decoding in Py3 close_fds=True, preexec_fn=preexec_func) @@ -383,6 +384,7 @@ class WindowsProcessHelper(ProcessHelper stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, +universal_newlines=True, # Elicits automatic byte -> string decoding in Py3 creationflags=creation_flags) def was_hard_terminate(self, returncode): ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252127 - Python 3 - Don't use `os.path.walk`, it's removed in Py3.
Author: zturner
Date: Wed Nov 4 19:33:54 2015
New Revision: 252127
URL: http://llvm.org/viewvc/llvm-project?rev=252127&view=rev
Log:
Python 3 - Don't use `os.path.walk`, it's removed in Py3.
It was deprecated even in 2.7, but not removed until 3.x. os.walk
provides all of the same functionality and is the correct way to
do this now.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=252127&r1=252126&r2=252127&view=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Wed Nov 4 19:33:54 2015
@@ -1230,9 +1230,6 @@ def visit(prefix, dir, names):
return
for name in names:
-if os.path.isdir(os.path.join(dir, name)):
-continue
-
if '.py' == os.path.splitext(name)[1] and name.startswith(prefix):
if name in all_tests:
@@ -1555,7 +1552,8 @@ def run_suite():
# Walk through the testdirs while collecting tests.
#
for testdir in testdirs:
-os.path.walk(testdir, visit, 'Test')
+for (dirpath, dirnames, filenames) in os.walk(testdir):
+visit('Test', dirpath, filenames)
#
# Now that we have loaded all the test cases, run the whole test suite.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
Why are we trying to build this at all on Linux? Seems odd to build an empty file rather than just not build it. Jim > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits > wrote: > > Author: chaoren > Date: Wed Nov 4 19:23:19 2015 > New Revision: 252124 > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > Log: > Fix build on Linux. > > Modified: > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > == > --- > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > (original) > +++ > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > Wed Nov 4 19:23:19 2015 > @@ -9,6 +9,8 @@ > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > source/Host/macosx/cfcpp utilities > + > // C Includes > // C++ Includes > // Other libraries and framework includes > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > return dev; > } > + > +#endif // __APPLE__ > > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
We do the same thing in other MacOSX platform files where they depend on Apple specific libraries. > On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits > wrote: > > Why are we trying to build this at all on Linux? Seems odd to build an empty > file rather than just not build it. > > Jim > >> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits >> wrote: >> >> Author: chaoren >> Date: Wed Nov 4 19:23:19 2015 >> New Revision: 252124 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev >> Log: >> Fix build on Linux. >> >> Modified: >> >> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >> >> Modified: >> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >> URL: >> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff >> == >> --- >> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >> (original) >> +++ >> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >> Wed Nov 4 19:23:19 2015 >> @@ -9,6 +9,8 @@ >> >> #include "PlatformiOSSimulatorCoreSimulatorSupport.h" >> >> +#if defined (__APPLE__) // This Plugin uses the Mac-specific >> source/Host/macosx/cfcpp utilities >> + >> // C Includes >> // C++ Includes >> // Other libraries and framework includes >> @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc >> >>return dev; >> } >> + >> +#endif // __APPLE__ >> >> >> ___ >> lldb-commits mailing list >> lldb-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252129 - Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in place.
Author: jingham
Date: Wed Nov 4 19:50:42 2015
New Revision: 252129
URL: http://llvm.org/viewvc/llvm-project?rev=252129&view=rev
Log:
Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in
place.
Modified:
lldb/trunk/include/lldb/lldb-forward.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
Modified: lldb/trunk/include/lldb/lldb-forward.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/lldb-forward.h?rev=252129&r1=252128&r2=252129&view=diff
==
--- lldb/trunk/include/lldb/lldb-forward.h (original)
+++ lldb/trunk/include/lldb/lldb-forward.h Wed Nov 4 19:50:42 2015
@@ -134,6 +134,7 @@ class ModuleSpecList;
class Mutex;
struct NameSearchContext;
class ObjCLanguageRuntime;
+class ObjCRuntimeSyntheticProvider;
class ObjectContainer;
class OptionGroup;
class OptionGroupOptions;
@@ -338,6 +339,7 @@ namespace lldb {
typedef std::shared_ptr
InstrumentationRuntimeSP;
typedef std::shared_ptr IOHandlerSP;
typedef std::shared_ptr IOObjectSP;
+typedef std::shared_ptr IRExecutionUnitSP;
typedef std::shared_ptr JITLoaderSP;
typedef std::unique_ptr JITLoaderListUP;
typedef std::shared_ptr LanguageRuntimeSP;
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=252129&r1=252128&r2=252129&view=diff
==
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
(original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Wed Nov 4 19:50:42 2015
@@ -524,7 +524,7 @@ static bool FindFunctionInModule (ConstS
Error
ClangExpressionParser::PrepareForExecution (lldb::addr_t &func_addr,
lldb::addr_t &func_end,
-std::shared_ptr
&execution_unit_sp,
+lldb::IRExecutionUnitSP
&execution_unit_sp,
ExecutionContext &exe_ctx,
bool &can_interpret,
ExecutionPolicy execution_policy)
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h?rev=252129&r1=252128&r2=252129&view=diff
==
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
(original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
Wed Nov 4 19:50:42 2015
@@ -113,7 +113,7 @@ public:
Error
PrepareForExecution (lldb::addr_t &func_addr,
lldb::addr_t &func_end,
- std::shared_ptr &execution_unit_sp,
+ lldb::IRExecutionUnitSP &execution_unit_sp,
ExecutionContext &exe_ctx,
bool &can_interpret,
lldb_private::ExecutionPolicy execution_policy)
override;
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
Why? Jim > On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: > > We do the same thing in other MacOSX platform files where they depend on > Apple specific libraries. > > >> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits >> wrote: >> >> Why are we trying to build this at all on Linux? Seems odd to build an >> empty file rather than just not build it. >> >> Jim >> >>> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits >>> wrote: >>> >>> Author: chaoren >>> Date: Wed Nov 4 19:23:19 2015 >>> New Revision: 252124 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev >>> Log: >>> Fix build on Linux. >>> >>> Modified: >>> >>> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >>> >>> Modified: >>> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >>> URL: >>> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff >>> == >>> --- >>> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >>> (original) >>> +++ >>> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm >>> Wed Nov 4 19:23:19 2015 >>> @@ -9,6 +9,8 @@ >>> >>> #include "PlatformiOSSimulatorCoreSimulatorSupport.h" >>> >>> +#if defined (__APPLE__) // This Plugin uses the Mac-specific >>> source/Host/macosx/cfcpp utilities >>> + >>> // C Includes >>> // C++ Includes >>> // Other libraries and framework includes >>> @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc >>> >>> return dev; >>> } >>> + >>> +#endif // __APPLE__ >>> >>> >>> ___ >>> lldb-commits mailing list >>> lldb-commits@lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >> >> ___ >> lldb-commits mailing list >> lldb-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.
Yeah, it seems like it's been passing for gcc-4.9 for a while now. Thanks for checking! On Wed, Nov 4, 2015 at 5:15 PM, Dawn Perchik wrote: > dawn marked an inline comment as done. > dawn added a comment. > > In http://reviews.llvm.org/D12115#248069, @chaoren wrote: > > > Could you please take a look at these issues? > > > > TestMiSymbol started to fail on Linux with gcc-4.9: > > > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6387 > > > Hi Chaoren, > I believe the issue with gcc was fixed for gcc a while back. Just > checking to make sure you're no longer seeing the failure. Let me know > otherwise. > > > > Comment at: lldb/trunk/tools/lldb-mi/MIUtilParse.h:13 > @@ +12,3 @@ > +// Third party headers: > +#include "../lib/Support/regex_impl.h" > + > > chaoren wrote: > > This caused a build failure on OS X: > > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5801 > This was fixed by Sean - the XCode build wasn't including the full set of > include paths when building lldb-mi. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D12115 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.
chaoren added a comment. Yeah, it seems like it's been passing for gcc-4.9 for a while now. Thanks for checking! Repository: rL LLVM http://reviews.llvm.org/D12115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
You're making a valid point. I was only noting that this is not the first instance where've conditionally compiled mac platform files. J > On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > > Why? > > Jim > >> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: >> >> We do the same thing in other MacOSX platform files where they depend on >> Apple specific libraries. >> >> >>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits >>> wrote: >>> >>> Why are we trying to build this at all on Linux? Seems odd to build an >>> empty file rather than just not build it. >>> >>> Jim >>> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits wrote: Author: chaoren Date: Wed Nov 4 19:23:19 2015 New Revision: 252124 URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev Log: Fix build on Linux. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff == --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm (original) +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Wed Nov 4 19:23:19 2015 @@ -9,6 +9,8 @@ #include "PlatformiOSSimulatorCoreSimulatorSupport.h" +#if defined (__APPLE__) // This Plugin uses the Mac-specific source/Host/macosx/cfcpp utilities + // C Includes // C++ Includes // Other libraries and framework includes @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc return dev; } + +#endif // __APPLE__ ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >>> >>> ___ >>> lldb-commits mailing list >>> lldb-commits@lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >> > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
Yeah, I just looked at PlatformDarwinKernel.cpp as example for a quick fix. I agree that kind of logic probably belongs in the CMakeLists.txt. On Wed, Nov 4, 2015 at 6:02 PM, Jason Molenda wrote: > You're making a valid point. I was only noting that this is not the first > instance where've conditionally compiled mac platform files. > > J > > > On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > > > > Why? > > > > Jim > > > >> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: > >> > >> We do the same thing in other MacOSX platform files where they depend > on Apple specific libraries. > >> > >> > >>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >>> > >>> Why are we trying to build this at all on Linux? Seems odd to build > an empty file rather than just not build it. > >>> > >>> Jim > >>> > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > Author: chaoren > Date: Wed Nov 4 19:23:19 2015 > New Revision: 252124 > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > Log: > Fix build on Linux. > > Modified: > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > > == > --- > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > (original) > +++ > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > Wed Nov 4 19:23:19 2015 > @@ -9,6 +9,8 @@ > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > source/Host/macosx/cfcpp utilities > + > // C Includes > // C++ Includes > // Other libraries and framework includes > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > return dev; > } > + > +#endif // __APPLE__ > > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > >>> > >>> ___ > >>> lldb-commits mailing list > >>> lldb-commits@lists.llvm.org > >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > >> > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
In this case it's even a little weirder, 'cause we compile a source file that contains a class declaration (since the #if defined is after the #include), but not the methods that aren't inlined. Then presumably link in the .o file containing whatever was the result of that compilation. That seems potentially harmful. Jim > On Nov 4, 2015, at 6:02 PM, Jason Molenda wrote: > > You're making a valid point. I was only noting that this is not the first > instance where've conditionally compiled mac platform files. > > J > >> On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: >> >> Why? >> >> Jim >> >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: >>> >>> We do the same thing in other MacOSX platform files where they depend on >>> Apple specific libraries. >>> >>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits wrote: Why are we trying to build this at all on Linux? Seems odd to build an empty file rather than just not build it. Jim > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits > wrote: > > Author: chaoren > Date: Wed Nov 4 19:23:19 2015 > New Revision: 252124 > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > Log: > Fix build on Linux. > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > == > --- > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > (original) > +++ > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > Wed Nov 4 19:23:19 2015 > @@ -9,6 +9,8 @@ > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > source/Host/macosx/cfcpp utilities > + > // C Includes > // C++ Includes > // Other libraries and framework includes > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > return dev; > } > + > +#endif // __APPLE__ > > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >>> >> > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
There's no simulator support outside of Darwin, so none of it should get used anyway. On Wed, Nov 4, 2015 at 6:08 PM, Jim Ingham wrote: > In this case it's even a little weirder, 'cause we compile a source file > that contains a class declaration (since the #if defined is after the > #include), but not the methods that aren't inlined. Then presumably link > in the .o file containing whatever was the result of that compilation. > That seems potentially harmful. > > Jim > > > > On Nov 4, 2015, at 6:02 PM, Jason Molenda wrote: > > > > You're making a valid point. I was only noting that this is not the > first instance where've conditionally compiled mac platform files. > > > > J > > > >> On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > >> > >> Why? > >> > >> Jim > >> > >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: > >>> > >>> We do the same thing in other MacOSX platform files where they depend > on Apple specific libraries. > >>> > >>> > On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > Why are we trying to build this at all on Linux? Seems odd to build > an empty file rather than just not build it. > > Jim > > > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > Author: chaoren > > Date: Wed Nov 4 19:23:19 2015 > > New Revision: 252124 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > > Log: > > Fix build on Linux. > > > > Modified: > > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > > > == > > --- > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > (original) > > +++ > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > Wed Nov 4 19:23:19 2015 > > @@ -9,6 +9,8 @@ > > > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > source/Host/macosx/cfcpp utilities > > + > > // C Includes > > // C++ Includes > > // Other libraries and framework includes > > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > > > return dev; > > } > > + > > +#endif // __APPLE__ > > > > > > ___ > > lldb-commits mailing list > > lldb-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > >>> > >> > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
Yeah, sure. But I bet you could figure out something to put in PlatformiOSSimulatorCoreSimulatorSupport.h that would cause this to fail to link except on OS X. Not that that's likely, but as a general strategy it seems wrong. Jim > On Nov 4, 2015, at 6:09 PM, Chaoren Lin wrote: > > There's no simulator support outside of Darwin, so none of it should get used > anyway. > > On Wed, Nov 4, 2015 at 6:08 PM, Jim Ingham wrote: > In this case it's even a little weirder, 'cause we compile a source file that > contains a class declaration (since the #if defined is after the #include), > but not the methods that aren't inlined. Then presumably link in the .o file > containing whatever was the result of that compilation. That seems > potentially harmful. > > Jim > > > > On Nov 4, 2015, at 6:02 PM, Jason Molenda wrote: > > > > You're making a valid point. I was only noting that this is not the first > > instance where've conditionally compiled mac platform files. > > > > J > > > >> On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > >> > >> Why? > >> > >> Jim > >> > >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote: > >>> > >>> We do the same thing in other MacOSX platform files where they depend on > >>> Apple specific libraries. > >>> > >>> > On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits > wrote: > > Why are we trying to build this at all on Linux? Seems odd to build an > empty file rather than just not build it. > > Jim > > > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits > > wrote: > > > > Author: chaoren > > Date: Wed Nov 4 19:23:19 2015 > > New Revision: 252124 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > > Log: > > Fix build on Linux. > > > > Modified: > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > > > Modified: > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > URL: > > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > > == > > --- > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > (original) > > +++ > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > Wed Nov 4 19:23:19 2015 > > @@ -9,6 +9,8 @@ > > > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > > source/Host/macosx/cfcpp utilities > > + > > // C Includes > > // C++ Includes > > // Other libraries and framework includes > > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > > > return dev; > > } > > + > > +#endif // __APPLE__ > > > > > > ___ > > lldb-commits mailing list > > lldb-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > ___ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > >>> > >> > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252133 - Fix TestGoFormatters.py.
Author: chaoren Date: Wed Nov 4 20:17:21 2015 New Revision: 252133 URL: http://llvm.org/viewvc/llvm-project?rev=252133&view=rev Log: Fix TestGoFormatters.py. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py?rev=252133&r1=252132&r2=252133&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py Wed Nov 4 20:17:21 2015 @@ -3,14 +3,13 @@ import os, time import unittest2 import lldb -import lldbutil -from lldbtest import * +import lldbsuite.test.lldbutil as lldbutil +from lldbsuite.test.lldbtest import * class TestGoLanguage(TestBase): mydir = TestBase.compute_mydir(__file__) -@python_api_test @skipIfFreeBSD # llvm.org/pr24895 triggers assertion failure @skipIfRemote # Not remote test suite ready @no_debug_info_test ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.
Yeah, it fails to build if we don't have objc too. I'll upload an update. On Wed, Nov 4, 2015 at 6:12 PM, Jim Ingham wrote: > Yeah, sure. But I bet you could figure out something to put in > PlatformiOSSimulatorCoreSimulatorSupport.h that would cause this to fail to > link except on OS X. Not that that's likely, but as a general strategy it > seems wrong. > > Jim > > > On Nov 4, 2015, at 6:09 PM, Chaoren Lin wrote: > > > > There's no simulator support outside of Darwin, so none of it should get > used anyway. > > > > On Wed, Nov 4, 2015 at 6:08 PM, Jim Ingham wrote: > > In this case it's even a little weirder, 'cause we compile a source file > that contains a class declaration (since the #if defined is after the > #include), but not the methods that aren't inlined. Then presumably link > in the .o file containing whatever was the result of that compilation. > That seems potentially harmful. > > > > Jim > > > > > > > On Nov 4, 2015, at 6:02 PM, Jason Molenda wrote: > > > > > > You're making a valid point. I was only noting that this is not the > first instance where've conditionally compiled mac platform files. > > > > > > J > > > > > >> On Nov 4, 2015, at 6:00 PM, Jim Ingham wrote: > > >> > > >> Why? > > >> > > >> Jim > > >> > > >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda > wrote: > > >>> > > >>> We do the same thing in other MacOSX platform files where they > depend on Apple specific libraries. > > >>> > > >>> > > On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > Why are we trying to build this at all on Linux? Seems odd to > build an empty file rather than just not build it. > > > > Jim > > > > > On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > > > Author: chaoren > > > Date: Wed Nov 4 19:23:19 2015 > > > New Revision: 252124 > > > > > > URL: http://llvm.org/viewvc/llvm-project?rev=252124&view=rev > > > Log: > > > Fix build on Linux. > > > > > > Modified: > > > > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > > > > > Modified: > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > > > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff > > > > == > > > --- > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > (original) > > > +++ > lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm > Wed Nov 4 19:23:19 2015 > > > @@ -9,6 +9,8 @@ > > > > > > #include "PlatformiOSSimulatorCoreSimulatorSupport.h" > > > > > > +#if defined (__APPLE__) // This Plugin uses the Mac-specific > source/Host/macosx/cfcpp utilities > > > + > > > // C Includes > > > // C++ Includes > > > // Other libraries and framework includes > > > @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc > > > > > > return dev; > > > } > > > + > > > +#endif // __APPLE__ > > > > > > > > > ___ > > > lldb-commits mailing list > > > lldb-commits@lists.llvm.org > > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > > > ___ > > lldb-commits mailing list > > lldb-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > >>> > > >> > > > > > > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D14365: Fix build for platforms without ObjC++.
chaoren created this revision.
chaoren added reviewers: jingham, jasonmolenda.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D14365
Files:
source/Plugins/Platform/MacOSX/CMakeLists.txt
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Index:
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
===
--- source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
+++ source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
@@ -9,8 +9,6 @@
#include "PlatformiOSSimulatorCoreSimulatorSupport.h"
-#if defined (__APPLE__) // This Plugin uses the Mac-specific
source/Host/macosx/cfcpp utilities
-
// C Includes
// C++ Includes
// Other libraries and framework includes
@@ -773,5 +771,3 @@
return dev;
}
-
-#endif // __APPLE__
Index: source/Plugins/Platform/MacOSX/CMakeLists.txt
===
--- source/Plugins/Platform/MacOSX/CMakeLists.txt
+++ source/Plugins/Platform/MacOSX/CMakeLists.txt
@@ -1,9 +1,16 @@
-add_lldb_library(lldbPluginPlatformMacOSX
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
PlatformAppleSimulator.cpp
PlatformDarwin.cpp
PlatformDarwinKernel.cpp
PlatformiOSSimulator.cpp
- PlatformiOSSimulatorCoreSimulatorSupport.mm
PlatformMacOSX.cpp
PlatformRemoteiOS.cpp
)
+
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
+ PlatformiOSSimulatorCoreSimulatorSupport.mm
+ )
+endif()
+
+add_lldb_library(lldbPluginPlatformMacOSX ${PLUGIN_PLATFORM_MACOSX_SOURCES})
Index: source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
===
--- source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
+++ source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
@@ -9,8 +9,6 @@
#include "PlatformiOSSimulatorCoreSimulatorSupport.h"
-#if defined (__APPLE__) // This Plugin uses the Mac-specific source/Host/macosx/cfcpp utilities
-
// C Includes
// C++ Includes
// Other libraries and framework includes
@@ -773,5 +771,3 @@
return dev;
}
-
-#endif // __APPLE__
Index: source/Plugins/Platform/MacOSX/CMakeLists.txt
===
--- source/Plugins/Platform/MacOSX/CMakeLists.txt
+++ source/Plugins/Platform/MacOSX/CMakeLists.txt
@@ -1,9 +1,16 @@
-add_lldb_library(lldbPluginPlatformMacOSX
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
PlatformAppleSimulator.cpp
PlatformDarwin.cpp
PlatformDarwinKernel.cpp
PlatformiOSSimulator.cpp
- PlatformiOSSimulatorCoreSimulatorSupport.mm
PlatformMacOSX.cpp
PlatformRemoteiOS.cpp
)
+
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
+ PlatformiOSSimulatorCoreSimulatorSupport.mm
+ )
+endif()
+
+add_lldb_library(lldbPluginPlatformMacOSX ${PLUGIN_PLATFORM_MACOSX_SOURCES})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D14365: Fix build for platforms without ObjC++.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252143: Fix build for platforms without ObjC++. (authored by
chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14365?vs=39305&id=39309#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14365
Files:
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Index:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
===
---
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
+++
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
@@ -9,8 +9,6 @@
#include "PlatformiOSSimulatorCoreSimulatorSupport.h"
-#if defined (__APPLE__) // This Plugin uses the Mac-specific
source/Host/macosx/cfcpp utilities
-
// C Includes
// C++ Includes
// Other libraries and framework includes
@@ -773,5 +771,3 @@
return dev;
}
-
-#endif // __APPLE__
Index: lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
@@ -1,9 +1,16 @@
-add_lldb_library(lldbPluginPlatformMacOSX
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
PlatformAppleSimulator.cpp
PlatformDarwin.cpp
PlatformDarwinKernel.cpp
PlatformiOSSimulator.cpp
- PlatformiOSSimulatorCoreSimulatorSupport.mm
PlatformMacOSX.cpp
PlatformRemoteiOS.cpp
)
+
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
+ PlatformiOSSimulatorCoreSimulatorSupport.mm
+ )
+endif()
+
+add_lldb_library(lldbPluginPlatformMacOSX ${PLUGIN_PLATFORM_MACOSX_SOURCES})
Index: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
===
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
@@ -9,8 +9,6 @@
#include "PlatformiOSSimulatorCoreSimulatorSupport.h"
-#if defined (__APPLE__) // This Plugin uses the Mac-specific source/Host/macosx/cfcpp utilities
-
// C Includes
// C++ Includes
// Other libraries and framework includes
@@ -773,5 +771,3 @@
return dev;
}
-
-#endif // __APPLE__
Index: lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
===
--- lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
+++ lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
@@ -1,9 +1,16 @@
-add_lldb_library(lldbPluginPlatformMacOSX
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
PlatformAppleSimulator.cpp
PlatformDarwin.cpp
PlatformDarwinKernel.cpp
PlatformiOSSimulator.cpp
- PlatformiOSSimulatorCoreSimulatorSupport.mm
PlatformMacOSX.cpp
PlatformRemoteiOS.cpp
)
+
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
+ PlatformiOSSimulatorCoreSimulatorSupport.mm
+ )
+endif()
+
+add_lldb_library(lldbPluginPlatformMacOSX ${PLUGIN_PLATFORM_MACOSX_SOURCES})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r252143 - Fix build for platforms without ObjC++.
Author: chaoren
Date: Wed Nov 4 21:30:45 2015
New Revision: 252143
URL: http://llvm.org/viewvc/llvm-project?rev=252143&view=rev
Log:
Fix build for platforms without ObjC++.
Reviewers: jingham, jasonmolenda
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14365
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt?rev=252143&r1=252142&r2=252143&view=diff
==
--- lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt Wed Nov 4
21:30:45 2015
@@ -1,9 +1,16 @@
-add_lldb_library(lldbPluginPlatformMacOSX
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
PlatformAppleSimulator.cpp
PlatformDarwin.cpp
PlatformDarwinKernel.cpp
PlatformiOSSimulator.cpp
- PlatformiOSSimulatorCoreSimulatorSupport.mm
PlatformMacOSX.cpp
PlatformRemoteiOS.cpp
)
+
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin")
+list(APPEND PLUGIN_PLATFORM_MACOSX_SOURCES
+ PlatformiOSSimulatorCoreSimulatorSupport.mm
+ )
+endif()
+
+add_lldb_library(lldbPluginPlatformMacOSX ${PLUGIN_PLATFORM_MACOSX_SOURCES})
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252143&r1=252142&r2=252143&view=diff
==
---
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
(original)
+++
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Wed Nov 4 21:30:45 2015
@@ -9,8 +9,6 @@
#include "PlatformiOSSimulatorCoreSimulatorSupport.h"
-#if defined (__APPLE__) // This Plugin uses the Mac-specific
source/Host/macosx/cfcpp utilities
-
// C Includes
// C++ Includes
// Other libraries and framework includes
@@ -773,5 +771,3 @@ CoreSimulatorSupport::DeviceSet::GetFanc
return dev;
}
-
-#endif // __APPLE__
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
