RE: [PATCH 1/2][v7] driver/memory:Move Freescale IFC driver to a common driver

[prabha...@freescale.com]

> -Original Message-
> From: Wood Scott-B07421
> Sent: Friday, January 31, 2014 3:01 AM
> To: Kushwaha Prabhakar-B32579
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH 1/2][v7] driver/memory:Move Freescale IFC driver to a 
> common
> driver
> 
> On Tue, 2014-01-28 at 10:59 +0530, Prabhakar Kushwaha wrote:
> >  Freescale IFC controller has been used for mpc8xxx. It will be used
> > for ARM-based SoC as well. This patch moves the driver to
> > driver/memory  and fix the header file includes.
> >
> >  Also remove module_platform_driver() and  instead call
> >  platform_driver_register() from subsys_initcall() to make sure this
> > module  has been loaded before MTD partition parsing starts.
> >
> > Signed-off-by: Prabhakar Kushwaha 
> > Acked-by: Arnd Bergmann 
> 
> When did Arnd ack this?  Especially in v7 form... and I don't see him on CC.
> 
> > +config FSL_IFC
> > +   bool "Freescale Integrated Flash Controller"
> > +   depends on FSL_SOC
> > +   help
> > + This driver is for the Integrated Flash Controller Controller(IFC)
> 
> Controller Controller?

I will fix it

> 
> > + module available in Freescale SoCs. This controller allows to handle
> flash
> > + devices such as NOR, NAND, FPGA and ASIC etc
> 
> FPGA and ASIC are not (necessarily) flash devices.
> 

Yes it true. 
I am not sure this folder is only for flash controller.
I can see references of FPGA, SRAM in same Kconfigs. 

Regards,
Prabhakar
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH 1/2][v8] driver/memory:Move Freescale IFC driver to a common driver

[prabha...@freescale.com]

> -Original Message-
> From: Wood Scott-B07421
> Sent: Tuesday, February 04, 2014 4:52 AM
> To: Kushwaha Prabhakar-B32579
> Cc: linuxppc-dev@lists.ozlabs.org; Arnd Bergmann
> Subject: Re: [PATCH 1/2][v8] driver/memory:Move Freescale IFC driver to a 
> common
> driver
> 
> On Fri, 2014-01-31 at 15:09 +0530, Prabhakar Kushwaha wrote:
> >  Freescale IFC controller has been used for mpc8xxx. It will be used
> > for ARM-based SoC as well. This patch moves the driver to
> > driver/memory  and fix the header file includes.
> >
> >  Also remove module_platform_driver() and  instead call
> >  platform_driver_register() from subsys_initcall() to make sure this
> > module  has been loaded before MTD partition parsing starts.
> >
> > Signed-off-by: Prabhakar Kushwaha 
> > Acked-by: Arnd Bergmann 
> 
> Again, when did Arnd ack this?
> 

Hi Scott,

I guess you missed his mail on kernel.org. Please find attached mail.


> >  .../{powerpc => memory-controllers}/fsl/ifc.txt|0
> >  arch/powerpc/Kconfig   |4 
> >  arch/powerpc/sysdev/Makefile   |1 -
> >  drivers/memory/Kconfig |8 
> >  drivers/memory/Makefile|1 +
> >  {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c  |8 ++--
> >  drivers/mtd/nand/fsl_ifc_nand.c|2 +-
> >  .../include/asm => include/linux}/fsl_ifc.h|0
> >  8 files changed, 16 insertions(+), 8 deletions(-)  rename
> > Documentation/devicetree/bindings/{powerpc =>
> > memory-controllers}/fsl/ifc.txt (100%)  rename {arch/powerpc/sysdev =>
> > drivers/memory}/fsl_ifc.c (98%)  rename {arch/powerpc/include/asm =>
> > include/linux}/fsl_ifc.h (100%)
> 
> Do we need a MAINTAINERS entry for this?  I don't see anything covering
> drivers/memory currently.
> 

I am not sure about this. 

Regards,
Prabhakar
--- Begin Message ---
On Wednesday 15 January 2014, Prabhakar Kushwaha wrote:
> Freescale IFC controller has been used for mpc8xxx. It will be used
> for ARM-based SoC as well. This patch moves the driver to driver/memory
> and fix the header file includes.
>
> Also remove module_platform_driver() and  instead call
> platform_driver_register() from subsys_initcall() to make sure this module
> has been loaded before MTD partition parsing starts.
>
> Signed-off-by: Prabhakar Kushwaha 

Acked-by: Arnd Bergmann 

provided that you also move the binding from powerpc/fsl/ifc.txt to
memory/fsl-ifc.txt.


--- End Message ---
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev