Re: [PATCH 2/7] kexec_file: print out debugging message if required
On 11/17/23 at 09:37am, Liu, Yujie wrote: > Hi Baoquan, > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote: > > Hi, > > > > On 11/16/23 at 05:04am, kernel test robot wrote: > > > Hi Baoquan, > > > > > > kernel test robot noticed the following build errors: > > > > > > [auto build test ERROR on arm64/for-next/core] > > > [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes > > > linus/master v6.7-rc1 next-20231115] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > url: > > > https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/kexec_file-add-kexec_file-flag-to-control-debug-printing/20231114-234003 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > > for-next/core > > > patch link: > > > https://lore.kernel.org/r/20231114153253.241262-3-bhe%40redhat.com > > > patch subject: [PATCH 2/7] kexec_file: print out debugging message if > > > required > > > config: hexagon-comet_defconfig > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/config) > > > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git > > > ae42196bc493ffe877a7e3dff8be32035dea4d07) > > > reproduce (this is a W=1 build): > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/reproduce) > > > > > > > Thanks for reporting. > > > > I met below failure when following the steps of provided reproducer. > > Could anyone help check what's wrong with that? > > Sorry this seems to be a bug in the reproducer. Could you please change > the compiler parameter to "COMPILER=clang-16" and rerun the command? We > will fix the issue ASAP. Here you are. Thanks for your quick response. -- [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-16 ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig Compiler will be installed in /root/0day lftpget -c https://cdn.kernel.org/pub/tools/llvm/files/./llvm-16.0.6-x86_64.tar.xz /root/linux tar Jxf /root/0day/./llvm-16.0.6-x86_64.tar.xz -C /root/0day PATH=/root/0day/llvm-16.0.6-x86_64/bin:/root/.local/bin:/root/bin:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin make --keep-going LLVM=1 CROSS_COMPILE=hexagon-linux- LLVM_IAS=1 --jobs=128 KCFLAGS=-Warray-bounds -Wundef -fstrict-flex-arrays=3 -funsigned-char -Wenum-conversion W=1 O=build_dir ARCH=hexagon olddefconfig make[1]: Entering directory '/root/linux/build_dir' GEN Makefile HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/confdata.o HOSTCC scripts/kconfig/expr.o HOSTCC scripts/kconfig/lexer.lex.o HOSTCC scripts/kconfig/menu.o HOSTCC scripts/kconfig/parser.tab.o HOSTCC scripts/kconfig/preprocess.o HOSTCC scripts/kconfig/symbol.o HOSTCC scripts/kconfig/util.o HOSTLD scripts/kconfig/conf # # configuration written to .config # make[1]: Leaving directory '/root/linux/build_dir' > > > [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang > > ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > Compiler will be installed in /root/0day > > lftpget -c https://cdn.kernel.org/pub/tools/llvm/files/ > > get1: /pub/tools/llvm/files/: files/: Is a directory > > Failed to download https://cdn.kernel.org/pub/tools/llvm/files/ > > clang crosstool install failed > > Install clang compiler failed > > setup_crosstool failed > >
Re: [PATCH 2/7] kexec_file: print out debugging message if required
On 11/17/23 at 10:01pm, Baoquan He wrote: > On 11/17/23 at 09:37am, Liu, Yujie wrote: > > Hi Baoquan, > > > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote: > > > Hi, > > > > > > On 11/16/23 at 05:04am, kernel test robot wrote: > > > > Hi Baoquan, > > > > > > > > kernel test robot noticed the following build errors: > > > > > > > > [auto build test ERROR on arm64/for-next/core] > > > > [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes > > > > linus/master v6.7-rc1 next-20231115] > > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > > And when submitting patch, we suggest to use '--base' as documented in > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > > > url: > > > > https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/kexec_file-add-kexec_file-flag-to-control-debug-printing/20231114-234003 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > > > for-next/core > > > > patch link: > > > > https://lore.kernel.org/r/20231114153253.241262-3-bhe%40redhat.com > > > > patch subject: [PATCH 2/7] kexec_file: print out debugging message if > > > > required > > > > config: hexagon-comet_defconfig > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/config) > > > > compiler: clang version 16.0.4 > > > > (https://github.com/llvm/llvm-project.git > > > > ae42196bc493ffe877a7e3dff8be32035dea4d07) > > > > reproduce (this is a W=1 build): > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/reproduce) > > > > > > > > > > Thanks for reporting. > > > > > > I met below failure when following the steps of provided reproducer. > > > Could anyone help check what's wrong with that? > > > > Sorry this seems to be a bug in the reproducer. Could you please change > > the compiler parameter to "COMPILER=clang-16" and rerun the command? We > > will fix the issue ASAP. Any update for the reproducer? I would like to post v2 with the fix. I doubt it's the same issue as another report on this patch, while not quite sure. > > Here you are. Thanks for your quick response. > -- > [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-16 > ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > Compiler will be installed in /root/0day > lftpget -c > https://cdn.kernel.org/pub/tools/llvm/files/./llvm-16.0.6-x86_64.tar.xz > /root/linux > > tar Jxf /root/0day/./llvm-16.0.6-x86_64.tar.xz -C /root/0day > PATH=/root/0day/llvm-16.0.6-x86_64/bin:/root/.local/bin:/root/bin:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin > make --keep-going LLVM=1 CROSS_COMPILE=hexagon-linux- LLVM_IAS=1 --jobs=128 > KCFLAGS=-Warray-bounds -Wundef -fstrict-flex-arrays=3 -funsigned-char > -Wenum-conversion W=1 O=build_dir ARCH=hexagon olddefconfig > make[1]: Entering directory '/root/linux/build_dir' > GEN Makefile > HOSTCC scripts/basic/fixdep > HOSTCC scripts/kconfig/conf.o > HOSTCC scripts/kconfig/confdata.o > HOSTCC scripts/kconfig/expr.o > HOSTCC scripts/kconfig/lexer.lex.o > HOSTCC scripts/kconfig/menu.o > HOSTCC scripts/kconfig/parser.tab.o > HOSTCC scripts/kconfig/preprocess.o > HOSTCC scripts/kconfig/symbol.o > HOSTCC scripts/kconfig/util.o > HOSTLD scripts/kconfig/conf > # > # configuration written to .config > # > make[1]: Leaving directory '/root/linux/build_dir' > > > > > > [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang > > > ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > > Compiler will be installed in /root/0day > > > lftpget -c https://cdn.kernel.org/pub/tools/llvm/files/ > > > get1: /pub/tools/llvm/files/: files/: Is a directory > > > Failed to download https://cdn.kernel.org/pub/tools/llvm/files/ > > > clang crosstool install failed > > > Install clang compiler failed > > > setup_crosstool failed > > > > >
Re: [PATCH 2/7] kexec_file: print out debugging message if required
On 11/23/23 at 08:41am, Nathan Chancellor wrote:
> On Thu, Nov 23, 2023 at 09:49:20PM +0800, b...@redhat.com wrote:
> > On 11/17/23 at 10:01pm, Baoquan He wrote:
> > > On 11/17/23 at 09:37am, Liu, Yujie wrote:
> > > > Hi Baoquan,
> > > >
> > > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote:
> > > > > Hi,
> > > > >
> > > > > On 11/16/23 at 05:04am, kernel test robot wrote:
> > > > > > Hi Baoquan,
> > > > > >
> > > > > > kernel test robot noticed the following build errors:
> > > > > >
> > > > > > [auto build test ERROR on arm64/for-next/core]
> > > > > > [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes
> > > > > > linus/master v6.7-rc1 next-20231115]
> > > > > > [If your patch is applied to the wrong git tree, kindly drop us a
> > > > > > note.
> > > > > > And when submitting patch, we suggest to use '--base' as documented
> > > > > > in
> > > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > > > > >
> > > > > > url:
> > > > > > https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/kexec_file-add-kexec_file-flag-to-control-debug-printing/20231114-234003
> > > > > > base:
> > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> > > > > > for-next/core
> > > > > > patch link:
> > > > > > https://lore.kernel.org/r/20231114153253.241262-3-bhe%40redhat.com
> > > > > > patch subject: [PATCH 2/7] kexec_file: print out debugging message
> > > > > > if required
> > > > > > config: hexagon-comet_defconfig
> > > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/config)
> > > > > > compiler: clang version 16.0.4
> > > > > > (https://github.com/llvm/llvm-project.git
> > > > > > ae42196bc493ffe877a7e3dff8be32035dea4d07)
> > > > > > reproduce (this is a W=1 build):
> > > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/reproduce)
> > > > > >
> > > > >
> > > > > Thanks for reporting.
> > > > >
> > > > > I met below failure when following the steps of provided reproducer.
> > > > > Could anyone help check what's wrong with that?
> > > >
> > > > Sorry this seems to be a bug in the reproducer. Could you please change
> > > > the compiler parameter to "COMPILER=clang-16" and rerun the command? We
> > > > will fix the issue ASAP.
> >
> > Any update for the reproducer? I would like to post v2 with the fix. I
> > doubt it's the same issue as another report on this patch, while not
> > quite sure.
>
> Shouldn't you be able to run
>
> $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-16 ~/bin/make.cross W=1
> O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/
>
Yes, I can reproduce it, it's the same issue as the one reported on
arm64. I thought Yujie is using the clang-16 to debug. Thanks for help.
> after the command you just ran to reproduce this now? It is
> essentially the same fix that they mention above but for the second
> invocation of make.cross.
>
> You can also not even bother with the wrapper altogether if you have the
> compiler installed in the default path that they provide (W=1 is not
> necessary to reproduce this issue):
>
> $ mkdir -p build_dir
> $ curl -LSso build_dir/.config
> https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/config
> $ make -skj"$(nproc)" ARCH=hexagon LLVM=$HOME/0day/llvm-16.0.6-x86_64/bin/
> O=build_dir olddefconfig kernel/crash_core.o
> ...
> kernel/crash_core.c:554:3: error: call to undeclared function
> 'kexec_dprintk'; ISO C99 and later do not support implicit function
> declarations [-Wimplicit-function-declaration]
> kexec_dprintk("Crash PT_LOAD ELF header. phdr=%p
> vaddr=0x%llx, paddr=0x%llx, "
> ^
> 1 error generated.
>
> > > Here you are. Thanks for your quick response.
> > > --
> > > [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-16
> > > ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddef
Re: [PATCH 2/7] kexec_file: print out debugging message if required
On 11/24/23 at 09:18am, Yujie Liu wrote: > On Thu, Nov 23, 2023 at 09:49:20PM +0800, b...@redhat.com wrote: > > On 11/17/23 at 10:01pm, Baoquan He wrote: > > > On 11/17/23 at 09:37am, Liu, Yujie wrote: > > > > Hi Baoquan, > > > > > > > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote: > > > > > Hi, > > > > > > > > > > On 11/16/23 at 05:04am, kernel test robot wrote: > > > > > > Hi Baoquan, > > > > > > > > > > > > kernel test robot noticed the following build errors: > > > > > > > > > > > > [auto build test ERROR on arm64/for-next/core] > > > > > > [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes > > > > > > linus/master v6.7-rc1 next-20231115] > > > > > > [If your patch is applied to the wrong git tree, kindly drop us a > > > > > > note. > > > > > > And when submitting patch, we suggest to use '--base' as documented > > > > > > in > > > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > > > > > > > url: > > > > > > https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/kexec_file-add-kexec_file-flag-to-control-debug-printing/20231114-234003 > > > > > > base: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > > > > > for-next/core > > > > > > patch link: > > > > > > https://lore.kernel.org/r/20231114153253.241262-3-bhe%40redhat.com > > > > > > patch subject: [PATCH 2/7] kexec_file: print out debugging message > > > > > > if required > > > > > > config: hexagon-comet_defconfig > > > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/config) > > > > > > compiler: clang version 16.0.4 > > > > > > (https://github.com/llvm/llvm-project.git > > > > > > ae42196bc493ffe877a7e3dff8be32035dea4d07) > > > > > > reproduce (this is a W=1 build): > > > > > > (https://download.01.org/0day-ci/archive/20231116/202311160431.bxpc7no9-...@intel.com/reproduce) > > > > > > > > > > > > > > > > Thanks for reporting. > > > > > > > > > > I met below failure when following the steps of provided reproducer. > > > > > Could anyone help check what's wrong with that? > > > > > > > > Sorry this seems to be a bug in the reproducer. Could you please change > > > > the compiler parameter to "COMPILER=clang-16" and rerun the command? We > > > > will fix the issue ASAP. > > > > Any update for the reproducer? I would like to post v2 with the fix. I > > doubt it's the same issue as another report on this patch, while not > > quite sure. > > Setting "COMPILER=clang-16" is exactly the correct fix and should > reproduce the issue in this report. We've fixed the steps of reproducer > but this will only take effect in future reports. Thanks, Yujie. I thought you were asking me to use "COMPILER=clang-16" to get information to debug. I have done the testing according to Nathan's suggestion and can confirm it's the same issue as the one on arm64. Will post v2. > > > > > > > Here you are. Thanks for your quick response. > > > -- > > > [root@~ linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-16 > > > ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > > Compiler will be installed in /root/0day > > > lftpget -c > > > https://cdn.kernel.org/pub/tools/llvm/files/./llvm-16.0.6-x86_64.tar.xz > > > /root/linux > > > > > > tar Jxf /root/0day/./llvm-16.0.6-x86_64.tar.xz -C /root/0day > > > PATH=/root/0day/llvm-16.0.6-x86_64/bin:/root/.local/bin:/root/bin:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin > > > make --keep-going LLVM=1 CROSS_COMPILE=hexagon-linux- LLVM_IAS=1 > > > --jobs=128 KCFLAGS=-Warray-bounds -Wundef -fstrict-flex-arrays=3 > > > -funsigned-char -Wenum-conversion W=1 O=build_dir ARCH=hexagon > > > olddefconfig > > > make[1]: Entering directory '/root/linux/build_dir' > > > GEN Makefile > > > H
