Re: [PATCH] fix double ;;s in code
Hi!
> > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> > index 53f7275..cfb42f5 100644
> > --- a/drivers/soc/imx/gpc.c
> > +++ b/drivers/soc/imx/gpc.c
> > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev,
> > struct regmap *regmap,
> > if (i == 1) {
> > domain->supply = devm_regulator_get(dev, "pu");
> > if (IS_ERR(domain->supply))
> > - return PTR_ERR(domain->supply);;
> > + return PTR_ERR(domain->supply);
> >
> > ret = imx_pgc_get_clocks(dev, domain);
> > if (ret)
> >
>
> Considering the controversy how the changes should be merged, I'm going
> to send a separate patch just for IMX GPC driver with a reported-by-you
> tag. Thanks for catching this.
That works for me.
Alternatively... Andrew Morton merged the patch to his -mm tree
(thanks!), so you don't need to take any action, and it will be
eventually fixed.
If you merge your own version of the patch, that's ok, too, since
Andrew will just drop his version.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Re: [PATCH] fix double ;;s in code
On Sat, Feb 24, 2018 at 09:52:27AM +0100, Pavel Machek wrote:
> Hi!
>
> > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> > > index 53f7275..cfb42f5 100644
> > > --- a/drivers/soc/imx/gpc.c
> > > +++ b/drivers/soc/imx/gpc.c
> > > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev,
> > > struct regmap *regmap,
> > > if (i == 1) {
> > > domain->supply = devm_regulator_get(dev, "pu");
> > > if (IS_ERR(domain->supply))
> > > - return PTR_ERR(domain->supply);;
> > > + return PTR_ERR(domain->supply);
> > >
> > > ret = imx_pgc_get_clocks(dev, domain);
> > > if (ret)
> > >
> >
> > Considering the controversy how the changes should be merged, I'm going
> > to send a separate patch just for IMX GPC driver with a reported-by-you
> > tag. Thanks for catching this.
>
> That works for me.
>
> Alternatively... Andrew Morton merged the patch to his -mm tree
> (thanks!), so you don't need to take any action, and it will be
> eventually fixed.
Okay, I'm dropping my patch from IMX tree.
Shawn
Re: [PATCH 0/5] PPC32/ioremap: Use memblock API to check for RAM
On Fri, Feb 23, 2018 at 09:01:17AM +0100, Christophe LEROY wrote: > > > Le 22/02/2018 à 13:15, Jonathan Neuschäfer a écrit : > > This patchset solves the same problem as my previous one[1] but follows > > a rather different approach. Instead of implementing DISCONTIGMEM for > > PowerPC32, I simply switched the "is this RAM" check in __ioremap_caller > > to the existing page_is_ram function, and unified page_is_ram to search > > memblock.memory on PPC64 and PPC32. > > > > The intended result is, as before, that my Wii can allocate the MMIO > > range of its GPIO controller, which was previously not possible, because > > the reserved memory hack (__allow_ioremap_reserved) didn't affect the > > API in kernel/resource.c. > > > > Thanks to Christophe Leroy for reviewing the previous patchset. > > I tested your new serie, it doesn't break my 8xx so it is OK for me. Thanks for testing it! Jonathan Neuschäfer signature.asc Description: PGP signature
