[PATCH] Simplify symbol check in prom_init_check.sh

2014-09-13 Thread Andreas Schwab 
Signed-off-by: Andreas Schwab 
---
 arch/powerpc/kernel/prom_init_check.sh | 22 ++
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init_check.sh 
b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..12640f7 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -50,24 +50,14 @@ do
done
 
# ignore register save/restore funcitons
-   if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+   case $UNDEF in
+   _restgpr_*|_restgpr0_*|_rest32gpr_*)
OK=1
-   fi
-   if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
-   OK=1
-   fi
-   if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
-   OK=1
-   fi
-   if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+   ;;
+   _savegpr_*|_savegpr0_*|_save32gpr_*)
OK=1
-   fi
-   if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
-   OK=1
-   fi
-   if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
-   OK=1
-   fi
+   ;;
+   esac
 
if [ $OK -eq 0 ]; then
ERROR=1
-- 
2.1.0

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V2] powerpc/eeh: Fix kernel crash when passing through VF

2014-09-13 Thread Gavin Shan 
On Fri, Sep 12, 2014 at 05:35:25PM +0800, Wei Yang wrote:
>On Fri, Sep 12, 2014 at 03:05:18PM +1000, Gavin Shan wrote:
>>On Fri, Sep 12, 2014 at 01:55:23PM +1000, Michael Ellerman wrote:
>>>On Thu, 2014-09-11 at 11:42 +0800, Wei Yang wrote:
 diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
 index 4a45ba8..403445e 100644
 --- a/arch/powerpc/kernel/eeh.c
 +++ b/arch/powerpc/kernel/eeh.c
 @@ -625,7 +625,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function)
  int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum 
 pcie_reset_state state)
  {
struct eeh_dev *edev = pci_dev_to_eeh_dev(dev);
 -  struct eeh_pe *pe = edev->pe;
 +  struct eeh_pe *pe = edev ? edev->pe : NULL;
  
if (!pe) {
pr_err("%s: No PE found on PCI device %s\n",
>>>
>>>
>>>We seem to do this or something similar in a few places. Is it worth having a
>>>pci_dev_to_eeh_pe() inline?
>>>
>>
>>Yes, maybe we just need a eeh_dev_to_pe() because converting
>>pci_dev to eeh_dev is already coverred by pci_dev_to_eeh_dev().
>>
>>With eeh_dev_to_pe(), it looks like this:
>>
>>struct pci_dev *pdev;
>>struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev);
>>struct eeh_pe *pe = eeh_dev_to_pe(edev);
>>
>>Or another case:
>>
>>struct device_node *dn;
>>struct eeh_dev *edev = of_node_to_eeh_dev(dn);
>>struct eeh_pe *pe = eeh_dev_to_pe(edev);
>
>With these helper, it would be more consolidate to jump between those data.
>
>Gavin,
>
>You would add these helpers? Or would like me to add them?
>

It would be Richard to help on this :-)

Thanks,
Gavin

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev