Re: [PATCH 7/8] 44x/476fpe: Add 476fpe SoC code
On Sat, Dec 03, 2011 at 07:58:17AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2011-12-01 at 18:39 +1100, Tony Breeds wrote: > > Based on original work by David 'Shaggy' Kliekamp. > > Typo in Shaggy's last name :-) Rats! Looks like I stuffed it up once. Do you need me to respin with these changes or are the minor enough to be done as the patches are applied? Yours Tony pgp5UvMJoOrOF.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 7/8] 44x/476fpe: Add 476fpe SoC code
On Sat, Dec 3, 2011 at 5:11 AM, Tony Breeds wrote: > On Sat, Dec 03, 2011 at 07:58:17AM +1100, Benjamin Herrenschmidt wrote: >> On Thu, 2011-12-01 at 18:39 +1100, Tony Breeds wrote: >> > Based on original work by David 'Shaggy' Kliekamp. >> >> Typo in Shaggy's last name :-) > > Rats! > > Looks like I stuffed it up once. Do you need me to respin with these > changes or are the minor enough to be done as the patches are applied? If the plan is to have them go through my tree, I can fix them up when I apply them. josh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3 02/10] powerpc: Consolidate mpic_alloc() OF address translation
On Dec 2, 2011, at 10:27 AM, Kyle Moffett wrote: > Instead of using the open-coded "reg" property lookup and address > translation in mpic_alloc(), directly call of_address_to_resource(). > This includes various workarounds for special cases which the naive > of_address_translate() does not. > > Afterwards it is possible to remove the copiously copy-pasted calls to > of_address_translate() from the 85xx/86xx/powermac platforms. > > Signed-off-by: Kyle Moffett > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Grant Likely > Cc: Kumar Gala > --- > arch/powerpc/platforms/85xx/corenet_ds.c |9 + > arch/powerpc/platforms/85xx/ksi8560.c |9 + > arch/powerpc/platforms/85xx/mpc8536_ds.c |9 + > arch/powerpc/platforms/85xx/mpc85xx_ads.c |9 + > arch/powerpc/platforms/85xx/mpc85xx_cds.c |9 + > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 11 + > arch/powerpc/platforms/85xx/mpc85xx_mds.c |9 + > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 11 + > arch/powerpc/platforms/85xx/p1010rdb.c|9 + > arch/powerpc/platforms/85xx/p1022_ds.c|9 + > arch/powerpc/platforms/85xx/p1023_rds.c |9 + > arch/powerpc/platforms/85xx/sbc8548.c |9 + > arch/powerpc/platforms/85xx/sbc8560.c |9 + > arch/powerpc/platforms/85xx/socrates.c|9 + > arch/powerpc/platforms/85xx/stx_gp3.c |9 + > arch/powerpc/platforms/85xx/tqm85xx.c |9 + > arch/powerpc/platforms/85xx/xes_mpc85xx.c |9 + > arch/powerpc/platforms/86xx/pic.c |4 +- > arch/powerpc/platforms/powermac/pic.c |8 +--- > arch/powerpc/sysdev/mpic.c| 61 - > 20 files changed, 55 insertions(+), 175 deletions(-) What about cleaning up: arch/powerpc/platforms/chrp/setup.c:chrp_mpic = mpic_alloc(np, opaddr, MPIC_PRIMARY, arch/powerpc/platforms/embedded6xx/holly.c: mpic = mpic_alloc(tsi_pic, mpic_paddr, arch/powerpc/platforms/embedded6xx/linkstation.c: mpic = mpic_alloc(dnp, paddr, MPIC_PRIMARY | MPIC arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c: mpic = mpic_alloc(tsi_pic, mpic_paddr, arch/powerpc/platforms/embedded6xx/storcenter.c:mpic = mpic_alloc(dnp, paddr, MPIC_PRIMARY | MPIC arch/powerpc/platforms/maple/setup.c: mpic = mpic_alloc(mpic_node, openpic_addr, flags, arch/powerpc/platforms/pasemi/setup.c: mpic = mpic_alloc(mpic_node, openpic_addr, arch/powerpc/platforms/pseries/setup.c: mpic = mpic_alloc(pSeries_mpic_node, openpic_addr, Seems like we should be able to remove the 'phys_addr' argument altogether. - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3 05/10] powerpc/mpic: Search for open-pic device-tree node if NULL
On Dec 2, 2011, at 10:28 AM, Kyle Moffett wrote: > Almost all PowerPC platforms use a standard "open-pic" device node so > the mpic_alloc() function now accepts NULL for the device-node. This > will cause it to perform a default search with of_find_matching_node(). > > Signed-off-by: Kyle Moffett > --- > arch/powerpc/platforms/85xx/corenet_ds.c | 10 +- > arch/powerpc/platforms/85xx/ksi8560.c | 14 + > arch/powerpc/platforms/85xx/mpc8536_ds.c | 13 +--- > arch/powerpc/platforms/85xx/mpc85xx_ads.c | 13 +--- > arch/powerpc/platforms/85xx/mpc85xx_cds.c | 15 + > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 14 ++--- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 10 +- > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 14 +--- > arch/powerpc/platforms/85xx/p1010rdb.c| 12 +-- > arch/powerpc/platforms/85xx/p1022_ds.c| 14 + > arch/powerpc/platforms/85xx/p1023_rds.c | 11 +-- > arch/powerpc/platforms/85xx/sbc8548.c | 16 +- > arch/powerpc/platforms/85xx/sbc8560.c | 13 +--- > arch/powerpc/platforms/85xx/socrates.c| 11 +-- > arch/powerpc/platforms/85xx/stx_gp3.c | 13 +--- > arch/powerpc/platforms/85xx/tqm85xx.c | 13 +--- > arch/powerpc/platforms/85xx/xes_mpc85xx.c | 13 +--- > arch/powerpc/platforms/86xx/pic.c | 11 +- > arch/powerpc/platforms/embedded6xx/holly.c| 10 +- > arch/powerpc/platforms/embedded6xx/linkstation.c |8 + > arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c | 10 +- > arch/powerpc/platforms/embedded6xx/storcenter.c | 10 +- > arch/powerpc/sysdev/mpic.c| 34 ++-- > 23 files changed, 58 insertions(+), 244 deletions(-) Ben, What do pseries, cell, & maple really have in there device trees? We should be able to move all this into mpic.c - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] pq3: Add default tbi address
>> arch/powerpc/boot/dts/fsl/pq3-etsec1-0.dtsi | 5 + >> arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi | 5 + >> 2 files changed, 10 insertions(+), 0 deletions(-) > > This doesn't seem correct, meaning this should really be in the board .dts > not in the IP. > > I think the driver should check and warn if this property doesn't exist. Hmm... in principle, I agree with you. I suppose I was just being lazy, and avoiding changing all the device trees again. However, it's not an unreasonable default. A search through *all* of the device trees for the tbi node indicates that 0x11 is chosen about 50% of the time. However, I'll devise a patch which complains if the node isn't found, and another patch which modifies all of the offending device trees. Andy ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 7/8] 44x/476fpe: Add 476fpe SoC code
On Sat, Dec 03, 2011 at 08:33:40AM -0500, Josh Boyer wrote: > If the plan is to have them go through my tree, I can fix them up when > I apply them. I was expecting them to go through your tree, so it'd be grat if you didn't mind finxing those up. Yours Tony pgpPpuZpwUGxh.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
