RE: [PATCH 0/2] lsusb LPM BESL support
Sorry about that. Here is the blurb: The two patches enable lsusb with LPM for USB2.0 Errata. They present the user with link status, BESL and DBESL values. Thank you, Alexandra. -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, August 07, 2013 12:28 PM To: Yates, Alexandra Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH 0/2] lsusb LPM BESL support On Wed, Aug 07, 2013 at 12:12:26PM -0700, Alexandra Yates wrote: > *** BLURB HERE *** What is supposed to go here? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
Ahh! Good point. Will resend the patch. :) Thank you, Alexandra. -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH Sent: Thursday, August 08, 2013 2:12 PM To: Yates, Alexandra Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL On Thu, Aug 08, 2013 at 02:05:53PM -0700, Alexandra Yates wrote: > Modified xHCI roothub descriptor to return USB2.0 extension descriptor > with BESL and DBESL values set when these values are set on the xHCI > host. Why would we want this? What benefit or bug does this fix? You need to explain why we want to accept this patch, not just what the patch does. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC v2] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
You are right that comment should read USB2.0! Will resend.
Thank you.
From: linux-usb-ow...@vger.kernel.org [linux-usb-ow...@vger.kernel.org] on
behalf of Greg KH [gre...@linuxfoundation.org]
Sent: Thursday, August 08, 2013 5:36 PM
To: Alexandra Yates
Cc: sarah.a.sh...@linux.intel.com; linux-usb@vger.kernel.org
Subject: Re: [RFC v2] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
On Thu, Aug 08, 2013 at 05:24:46PM -0700, Alexandra Yates wrote:
> Modified the xHCI roothub descriptor to return USB2.0 extension
> descriptor Best Effort Service Latency (BESL) and Deep Best Effort
> Service Latency (DBESL) values when set on the xHCI host.
>
> On link power management the BESL and DBESL values are used to
> estimate L1 exit latency for USB2.0 host and devices. Tools such as
> PowerTop and lsusb will use BESL and DBESL values to
> monitor LPM L1 exit latency. Additionally, by presenting the host
> controller BESL and DBESL values one could check if the BIOS or
> firmware is setting these values correctly.
>
> Currently the root hub device descriptor bcdUSB value is set to zero by
> the BIOS. Therefore to test this functionality with lsusb, I hard
> coded the usb2_rh_dev_descriptor (not include on patch) to:
> bcdUSB 0x01.
>
> Here is the test output.
> $ sudo lsusb -s 01:01 -v
> ...
> Binary Object Store Descriptor:
> bLength 5
> bDescriptorType15
> wTotalLength 12
> bNumDeviceCaps 1
> USB 2.0 Extension Device Capability:
> bLength 7
> bDescriptorType16
> bDevCapabilityType 2
> bmAttributes 0xff1e
> BESL Link Power Management (LPM) Supported
> BESL value 3840 us
> Deep BESL value61440 us
> Device Status: 0x0001
> Self Powered
>
> Signed-off-by: Alexandra Yates
> ---
> drivers/usb/host/xhci-hub.c | 53
> +++
> drivers/usb/host/xhci.h |3 +++
> 2 files changed, 51 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> index 1d35459..60601df 100644
> --- a/drivers/usb/host/xhci-hub.c
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -30,7 +30,7 @@
>PORT_RC | PORT_PLC | PORT_PE)
>
> /* USB 3.0 BOS descriptor and a capability descriptor, combined */
> -static u8 usb_bos_descriptor [] = {
> +static u8 usb3_bos_descriptor[] = {
> USB_DT_BOS_SIZE,/* __u8 bLength, 5 bytes */
> USB_DT_BOS, /* __u8 bDescriptorType */
> 0x0F, 0x00, /* __le16 wTotalLength, 15 bytes */
> @@ -47,6 +47,28 @@ static u8 usb_bos_descriptor [] = {
> 0x00, 0x00 /* __le16 bU2DevExitLat, set later. */
> };
>
> +/* USB 3.0 BOS descriptor and a capability descriptor, combined */
> +static u8 usb2_bos_descriptor[] = {
I don't think that comment is correct, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
Will do! Thank you Sarah and Greg for the great feedback to make this patch better :) Thank you, Alexandra. -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Sarah Sharp Sent: Friday, August 09, 2013 1:03 PM To: Alexandra Yates Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL Hi Alex, For just one patch, you don't need to send a cover letter, especially when it contains the contents of your patch description. Also, please use PATCH instead of RFC in the future. I'll test this patch out, and try to come up with a way to get the USB core to use bcdUSB 2.10 for xHCI USB 2.0 roothubs. Sarah Sharp On Fri, Aug 09, 2013 at 12:20:49PM -0700, Alexandra Yates wrote: > Modified the xHCI roothub descriptor to return USB2.0 extension > descriptor Best Effort Service Latency (BESL) and Deep Best Effort > Service Latency (DBESL) values when set on the xHCI host. > > On link power management the BESL and DBESL values are used to > estimate L1 exit latency for USB2.0 host and devices. Tools such as > PowerTop and lsusb will use BESL and DBESL values to > monitor LPM L1 exit latency. Additionally, by presenting the host > controller BESL and DBESL values one could check if the BIOS or > firmware is setting these values correctly. > > Currently the root hub device descriptor bcdUSB value is set to zero > by the BIOS. Therefore to test this functionality with lsusb, I hard > coded the usb2_rh_dev_descriptor (not include on patch) to: > bcdUSB 0x01. > > Alexandra Yates (1): > xhci-hub: Roothub USB2.0 descriptor for BESL DBESL > > drivers/usb/host/xhci-hub.c | 53 > +++ > drivers/usb/host/xhci.h |3 +++ > 2 files changed, 51 insertions(+), 5 deletions(-) > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
Oh! Bummer, I rant the tool but somehow I missed it. I will add the tool,
change and resend patch.
Thank you,
Alexandra.
-Original Message-
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
Sent: Friday, August 09, 2013 4:43 PM
To: Yates, Alexandra
Cc: Alexandra Yates; gre...@linuxfoundation.org; linux-usb@vger.kernel.org
Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
Hi Alex,
Can you make sure to add the checkpatch.pl to your git pre-commit hooks?
This patch fails checkpatch:
sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
Applying: xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
ERROR: spaces prohibited around that '->' (ctx:WxV)
#52: FILE: drivers/usb/host/xhci-hub.c:727:
+ } else if (hcd ->speed == HCD_USB2) {
^
ERROR: code indent should use tabs where possible
#56: FILE: drivers/usb/host/xhci-hub.c:731:
+/* Set first byte of bmAttributes in the$
ERROR: code indent should use tabs where possible
#57: FILE: drivers/usb/host/xhci-hub.c:732:
+ * usb2_bos_descriptor */$
total: 3 errors, 0 warnings, 82 lines checked
Please fix these and resend.
Sarah Sharp
On Fri, Aug 09, 2013 at 08:32:32PM +, Yates, Alexandra wrote:
> Will do! Thank you Sarah and Greg for the great feedback to make this patch
> better :)
>
>
> Thank you,
>
> Alexandra.
>
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Sarah Sharp
> Sent: Friday, August 09, 2013 1:03 PM
> To: Alexandra Yates
> Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org
> Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
>
> Hi Alex,
>
> For just one patch, you don't need to send a cover letter, especially
> when it contains the contents of your patch description. Also, please
> use PATCH instead of RFC in the future.
>
> I'll test this patch out, and try to come up with a way to get the USB
> core to use bcdUSB 2.10 for xHCI USB 2.0 roothubs.
>
> Sarah Sharp
>
> On Fri, Aug 09, 2013 at 12:20:49PM -0700, Alexandra Yates wrote:
> > Modified the xHCI roothub descriptor to return USB2.0 extension
> > descriptor Best Effort Service Latency (BESL) and Deep Best Effort
> > Service Latency (DBESL) values when set on the xHCI host.
> >
> > On link power management the BESL and DBESL values are used to
> > estimate L1 exit latency for USB2.0 host and devices. Tools such as
> > PowerTop and lsusb will use BESL and DBESL values to
> > monitor LPM L1 exit latency. Additionally, by presenting the host
> > controller BESL and DBESL values one could check if the BIOS or
> > firmware is setting these values correctly.
> >
> > Currently the root hub device descriptor bcdUSB value is set to zero
> > by the BIOS. Therefore to test this functionality with lsusb, I hard
> > coded the usb2_rh_dev_descriptor (not include on patch) to:
> > bcdUSB 0x01.
> >
> > Alexandra Yates (1):
> > xhci-hub: Roothub USB2.0 descriptor for BESL DBESL
> >
> > drivers/usb/host/xhci-hub.c | 53
> > +++
> > drivers/usb/host/xhci.h |3 +++
> > 2 files changed, 51 insertions(+), 5 deletions(-)
> >
> > --
> > 1.7.9.5
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
