RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device
Kukjin Kim wrote:
>
Re-sending due to e-mail client problem...
> Doug Anderson wrote:
> >
> > On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam
> > wrote:
> > > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam
> > wrote:
> > >>
> > >> On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely
> > >> wrote:
> > >>> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam
> > wrote:
> > >>>> Using chip specific compatible string as it should be.
> > >>>> So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos
> > >>>> which till now used a generic 'exynos' in their compatible strings.
> > >>>>
> > >>>> This goes as per the discussion happened in the thread for
> > >>>> [PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver
> > >>>> available at:
> > >>>> http://www.spinics.net/lists/linux-usb/msg74145.html
> > >>>>
> > >>>> Vivek Gautam (2):
> > >>>> usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
> > >>>> usb: dwc3-exynos: Fix compatible strings for the device
> > >>>
> > >>> for both patches:
> > >>> Acked-by: Grant Likely
> > >>>
> > >
> > > Any more thought about this patch-set?
> > > Or does this change seems fine?
> >
> > These two changes look good to me. For both of them:
> >
> > Reviewed-by: Doug Anderson
>
> Well, I have another idea. Yes, I know, specific chip name should be used.
But
> you know the specific chip name in compatible can cause another confusion
> on other SoC which has same IP. So I think, we need to consider to use
> common name or any specific name not chip in compatible for IP/driver like
> following?
>
> - { .compatible = "samsung,exynos-dwc3" },
> + { .compatible = "samsung,synopsis-dwc3" },
>
> Or if any version or something, how about following?
>
> + { .compatible = "samsung,dwc-v3" },
>
> - Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation
Vivek Gautam wrote: > > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam > Reviewed-by: Sylwester Nawrocki > Reviewed-by: Doug Anderson This looks good to me, Acked-by: Kukjin Kim Vivek, could you please re-send following in one series? - [PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg - [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support As I know, this should be applied on top of above patches. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
Felipe Balbi wrote: > > On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > > > This patch-set enables the samsung-usbphy driver on exynos5250, > > > which enables the support for USB2 type and USB3 type phys. > > > The corresponding phy driver patches are available at: > > > 1) https://lkml.org/lkml/2012/12/18/201 > > > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012- > December/024559.html > > > > > > Tested this patch-set on exynos5250 with following patch-sets for > > > USB 2.0 and USB 3.0: > > > - https://patchwork.kernel.org/patch/1794651/ > > > - https://lkml.org/lkml/2012/12/18/201 > > > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012- > December/024559.html > > > - http://comments.gmane.org/gmane.linux.usb.general/76352 > > > - https://lkml.org/lkml/2012/12/13/492 > > > > > > Vivek Gautam (2): > > > ARM: Exynos5250: Enabling samsung-usbphy driver > > > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver > > > > What should I do with this series ? Is it ready to apply ? If it is, > > then please resend with Kukjim's Acked-by. > > actually, now that I look again, it's all under arch/arm/, so Kukjim can > take all of those through his tree ;-) > Yes, once Vivek addresses comments from Sylwester, let me pick up into Samsung tree :-) Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250
Vivek Gautam wrote: > > Changes from v5: > - Rebased on top of latest patches: > usb: phy: samsung: Introducing usb phy driver for hsotg (v9) > usb: phy: samsung: Add support to set pmu isolation (v6) >As a result adding hostphy enable mask and hostphy register offsets >to driver data in order to access the HOSTPHY CONTROL register. > > - Adding member 'otg' to struct samsung-usbphy so that its consumers >can call otg->set_host so as to make 'phy' aware of the consumer type: > HOST/DEVICE > > - Adding 'otg' to 'struct s5p_ehci_hcd' and 'struct exynos_ohci_hcd' >which keeps track of 'otg' of the controllers' phy. This then sets >the host. > > - Moved samsung_usbphy_set_type() calls from ehci-s5p and ohci-exynos >to phy driver itself where based on phy_type it is called. > > - Added separate macro definition for USB20PHY_CFG register to select >between host/device type usb link. > > - Removing unnecessary argument 'phy_type' from > samsung_usbphy_set_type() >and samsung_usbphy_cfg_sel(). > > - Addressed few nits: > -- added macro for 'KHZ' > -- removing useless 'if' from samsung_usbphy_cfg_sel() > -- keeping the place of clk_get intact and requesting driver > data before that. > > Vivek Gautam (4): > ARM: EXYNOS: Update & move usb-phy types to generic include layer > usb: phy: samsung: Add host phy support to samsung-phy driver > USB: ehci-s5p: Add phy driver support > USB: ohci-exynos: Add phy driver support > > .../devicetree/bindings/usb/samsung-usbphy.txt | 12 +- > drivers/usb/host/ehci-s5p.c| 81 +++- > drivers/usb/host/ohci-exynos.c | 85 +++- > drivers/usb/phy/Kconfig|2 +- > drivers/usb/phy/samsung-usbphy.c | 512 ++-- > include/linux/usb/samsung_usb_phy.h| 16 + > 6 files changed, 635 insertions(+), 73 deletions(-) > create mode 100644 include/linux/usb/samsung_usb_phy.h > > -- > 1.7.6.5 Looks good to me, Felipe and Greg, I don't know who should take this series anyway, feel free to add my ack: Acked-by: Kukjin Kim Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device
Sylwester Nawrocki wrote:
>
> On 12/24/2012 09:13 AM, Vivek Gautam wrote:
> These two changes look good to me. For both of them:
>
> Reviewed-by: Doug Anderson
> >>>
> >>> Well, I have another idea. Yes, I know, specific chip name should be
used.
> >> But
> >>> you know the specific chip name in compatible can cause another
> confusion
> >>> on other SoC which has same IP. So I think, we need to consider to use
> >>> common name or any specific name not chip in compatible for IP/driver
> like
> >>> following?
> >>>
> >>> - { .compatible = "samsung,exynos-dwc3" },
> >>> + { .compatible = "samsung,synopsis-dwc3" },
> >>>
> >>> Or if any version or something, how about following?
> >>>
> >>> + { .compatible = "samsung,dwc-v3" },
> >>>
> > Well, yes the newer SoCs with same IP using the chip name can cause some
> > confusion, but won't it be fine that -
> > "Newer parts using the same core can claim compatibility by
> > including the older string in the compatible list" - as quoted by Grant
Likely
> >
> > Or, can we try another option, using multiple compatible strings for
> > SoC specific
> > in of_match_table, so that we don't create any confusion by using same
> > compatible for newer SoCs also. Like,
> >
> > - { .compatible = "samsung,exynos-dwc3" },
> > + { .compatible = "samsung,exynos5250-dwc3" },
> > + { .compatible = },
>
> Yes, why not just use an SoC name where given IP first appeared ? I
believe
> IP revision numbers are not always well documented. Also when an IP is
> instantiated multiple times in specific SoC, its revision number might not
> be sufficient to determine the system integration details for each
instance.
> I think having version for some devices and SoC name for others just adds
> to the confusion. Thus using specific chip name in the compatible property
> seems more clear to me.
>
Well, I don't think so. Let's see the DMAC PL330. Its compatible is
"arm,pl330" and "arm,primecell" not SoC/Chip name. I think DWC is a same
case or at least similar.
You know, the DWC is a IP from Synopsis and I _Believe_ it has a kind of
version and it can be used for identify.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device
Felipe Balbi wrote:
> Hi,
>
Hi Felipe,
[...]
> > Right, DWC has version number, but that being the kind of USB controller
> > (USB 2.0 and USB 3.0)
> >
> > DWC2: USB High Speed controller (as also indicated in the patch from
> > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver)
> > DWC3: USB Super Speed controller
> >
> > Is it fine if we use something like shown below, as suggested by you
earlier ?
> >
> > - { .compatible = "samsung,exynos-dwc3" },
> > + { .compatible = "samsung,synopsis-dwc3" }
>
> You're both missing a point here. The synopsys IP driver is called
> dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver
> (dwc3-exynos.ko) is compatible with your platform, so
> samsung,exynos-dwc3 sounds correct to me.
>
Hmm...yeah, you're right and agreed.
However, we need to use more clear name there like "samsung,exynos-dwusb3"
in compatible, because you know there are lots of other IPs in Synopsis
Design Ware brand. So we have to include usb in compatible for that.
> The glue layer is just to "abstract" away the integration details of the
> IP core into a specific platform.
>
Right.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device
Vivek Gautam wrote: > > Using chip specific compatible string as it should be. > So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos > which till now used a generic 'exynos' in their compatible strings. > > Changes from v1: > - Changing compatible string from "samsung,exynos5250-dwc3" to > "samsung,exynos5250-dwusb3" as per discussion happened in > thread: > [PATCH 0/2] usb: exynos: Fix compatible strings used for device. > > Vivek Gautam (2): > usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device > usb: dwc3-exynos: Fix compatible strings for the device > > drivers/usb/dwc3/dwc3-exynos.c |2 +- > drivers/usb/host/ehci-s5p.c|2 +- > drivers/usb/host/ohci-exynos.c |2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > For now, I'm fine on this series, I'm still thinking we need to sort out the chip name in compatible for IP though. Felipe, please go ahead, if you want my ack, feel free to add: Acked-by: Kukjin Kim Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
Vivek Gautam wrote:
>
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 15 +++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 30485de..610e338 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,21 @@
> #size-cells = <0>;
> };
>
> + usbphy@1213 {
Please put above node by order of address.
> + compatible = "samsung,exynos5250-usbphy";
> + reg = <0x1213 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers
*/
Please add the binding documentation instead of comment here.
> + reg = <0x10040704 0x8>,
> + /* USB2.0 PHY configuration register */
> + <0x10050230 0x4>;
> + };
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 1.7.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver
Vivek Gautam wrote:
>
> Adding usb3.0 phy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 +
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 610e338..018a70d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,19 @@
> #size-cells = <0>;
> };
>
> + usbphy@1210 {
> + compatible = "samsung,exynos5250-usb3-phy";
> + reg = <0x1210 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers
*/
> + reg = <0x10040704 0x8>;
> + };
> + };
> +
> usbphy@1213 {
> compatible = "samsung,exynos5250-usbphy";
> reg = <0x1213 0x100>;
> --
> 1.7.6.5
Same as previous comments.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff
Vivek Gautam wrote:
>
> Moving register and structure definitions to header file,
> and keeping the generic functions to be used across
> multiple PHYs in common file "samsung-usbphy.c".
> Also renaming the usb 2.0 phy driver to "samsung-usb2.c"
Just in my opinion, Samsung-usb2phy is more clear?...In addition, I looked
at using SAMSUNG_USB2PHY as a statement.
>
> Signed-off-by: Vivek Gautam
> ---
>
> Changes from v3:
> - Using separate config SAMSUNG_USB2PHY dependent on
>SAMSUNG_USBPHY for samsung-usb2 type PHY controller.
>
> drivers/usb/phy/Kconfig | 14 +-
> drivers/usb/phy/Makefile |1 +
> drivers/usb/phy/samsung-usb2.c | 511 +++
> drivers/usb/phy/samsung-usbphy.c | 714
+-
> drivers/usb/phy/samsung-usbphy.h | 247 +
> 5 files changed, 778 insertions(+), 709 deletions(-)
> create mode 100644 drivers/usb/phy/samsung-usb2.c
> create mode 100644 drivers/usb/phy/samsung-usbphy.h
>
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index fae4d08..cc0d230 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -48,8 +48,18 @@ config USB_RCAR_PHY
>
> config SAMSUNG_USBPHY
> bool "Samsung USB PHY controller Driver"
> - depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> USB_OHCI_EXYNOS
So this can be selected without any dependency?
> select USB_OTG_UTILS
> help
> - Enable this to support Samsung USB phy controller for samsung
> + Enable this to support Samsung USB phy controllers for Samsung
> SoCs.
Hmm, according to above comments, this should be enabled under Samsung SoC?
> +
> +if SAMSUNG_USBPHY
Why is this needed here?
> +
> +config SAMSUNG_USB2PHY
> + bool "Samsung USB 2.0 PHY controller Driver"
> + depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> USB_OHCI_EXYNOS
> + help
> + Enable this to support Samsung USB 2.0 (High Speed) phy controller
> + for Samsung SoCs.
> +
> +endif
> diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
> index ec304f6..7ba9862 100644
> --- a/drivers/usb/phy/Makefile
> +++ b/drivers/usb/phy/Makefile
> @@ -10,3 +10,4 @@ obj-$(CONFIG_MV_U3D_PHY)+=
> mv_u3d_phy.o
> obj-$(CONFIG_USB_EHCI_TEGRA) += tegra_usb_phy.o
> obj-$(CONFIG_USB_RCAR_PHY) += rcar-phy.o
> obj-$(CONFIG_SAMSUNG_USBPHY) += samsung-usbphy.o
> +obj-$(CONFIG_SAMSUNG_USB2PHY)+= samsung-usb2.o
> diff --git a/drivers/usb/phy/samsung-usb2.c b/drivers/usb/phy/samsung-
> usb2.c
> new file mode 100644
> index 000..9a9d1d0
> --- /dev/null
> +++ b/drivers/usb/phy/samsung-usb2.c
> @@ -0,0 +1,511 @@
> +/* linux/drivers/usb/phy/samsung-usb2.c
> + *
> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * Author: Praveen Paneri
> + *
> + * Samsung USB2.0 PHY transceiver; talks to S3C HS OTG controller,
EHCI-S5P
> and
> + * OHCI-EXYNOS controllers.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +#include "samsung-usbphy.h"
> +
> +int samsung_usbphy_set_host(struct usb_otg *otg, struct usb_bus *host)
For naming, if you want to support usb 2.0 phy here, the name of fuction
should be changed to more clear name such as usb2phy or whatever.
As I'm understanding, the samsung-usbphy.c can be used for common stuff and
this is for only usb 2.0 phy.
[...]
> +#ifdef CONFIG_OF
> +static const struct of_device_id samsung_usbphy_dt_match[] = {
> + {
> + .compatible = "samsung,s3c64xx-usbphy",
> + .data = &usbphy_s3c64xx,
> + }, {
> + .compatible = "samsung,exynos4210-usbphy",
> + .data = &usbphy_exynos4,
> + }, {
> + .compatible = "samsung,exynos5250-usbphy",
> + .data = &usbphy_exynos5
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, samsung_usbphy_dt_match);
> +#endif
> +
> +static struct platform_device_id samsung_usbphy_driver_ids[] = {
> + {
> + .name = "s3c64xx-usbphy",
> + .driver_data= (unsigned long)&usbphy_s3c64xx,
> + }, {
> + .name = "exynos4210-usbphy",
> + .driver_data= (unsigned long)&usbphy_exynos4,
> + }, {
> + .name = "exynos5250-usbphy",
> + .driver_data= (unsigned long)&usbphy_exynos5,
> + },
> + {},
> +
RE: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller
Vivek Gautam wrote:
>
> Adding PHY driver support for USB 3.0 controller for Samsung's
> SoCs.
>
> Signed-off-by: Vivek Gautam
> ---
>
> Changes from v3:
> - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY.
> - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since
>dwc3 controller also looks for USB2 type PHY.
>
> drivers/usb/phy/Kconfig | 11 +-
> drivers/usb/phy/Makefile |1 +
> drivers/usb/phy/samsung-usb3.c | 349
> ++
> drivers/usb/phy/samsung-usbphy.h | 81 +
> 4 files changed, 441 insertions(+), 1 deletions(-)
> create mode 100644 drivers/usb/phy/samsung-usb3.c
>
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index cc0d230..9325a95 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -52,14 +52,23 @@ config SAMSUNG_USBPHY
> help
> Enable this to support Samsung USB phy controllers for Samsung
> SoCs.
> + Further enable USB 2.0 type PHY or USB 3.0 type PHY as required
> + for USB controllers in use.
>
> if SAMSUNG_USBPHY
>
> config SAMSUNG_USB2PHY
> bool "Samsung USB 2.0 PHY controller Driver"
> - depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> USB_OHCI_EXYNOS
> + depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> USB_OHCI_EXYNOS || USB_DWC3
> help
> Enable this to support Samsung USB 2.0 (High Speed) phy controller
> for Samsung SoCs.
>
> +config SAMSUNG_USB3PHY
> + bool "Samsung USB 3.0 PHY controller Driver"
> + depends on USB_DWC3
> + help
> + Enable this to support Samsung USB 3.0 (Super Speed) phy
> controller
> + for samsung SoCs.
> +
> endif
It mean, when USB_DWC3 is selected, we can select only one USB2PHY or
USB3PHY?
[...]
> +#ifdef CONFIG_OF
> +static const struct of_device_id samsung_usbphy_dt_match[] = {
> + {
> + .compatible = "samsung,exynos5250-usb3-phy",
> + .data = &usb3_phy_exynos5
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, samsung_usbphy_dt_match);
> +#endif
> +
> +static struct platform_device_id samsung_usbphy_driver_ids[] = {
> + {
> + .name = "exynos5250-usb3-phy",
According to the name of file, exynos5250-usb3phy? Just it is imho...
> + .driver_data= (unsigned long)&usb3_phy_exynos5,
> + },
> + {},
> +};
> +
> +MODULE_DEVICE_TABLE(platform, samsung_usbphy_driver_ids);
> +
> +static struct platform_driver samsung_usb3_phy_driver = {
> + .probe = samsung_usb3_phy_probe,
> + .remove = samsung_usb3_phy_remove,
> + .id_table = samsung_usbphy_driver_ids,
> + .driver = {
> + .name = "samsung-usb3-phy",
> + .owner = THIS_MODULE,
> + .of_match_table =
> of_match_ptr(samsung_usbphy_dt_match),
> + },
> +};
> +
> +module_platform_driver(samsung_usb3_phy_driver);
> +
> +MODULE_DESCRIPTION("Samsung USB 3.0 phy controller");
> +MODULE_AUTHOR("Vivek Gautam ");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:samsung-usb3-phy");
I want you to use same naming rule.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos
Vivek Gautam wrote: > > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam > wrote: > > Hi Tomasz, > > > > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa > wrote: > >> Hi Vivek, > >> > >> Don't you need also some clkdev lookup entry to make the clock available > >> in the driver? > >> > > > > This clock source we added with a motive of completion, however it's > > not being used as of now. > > As far as i could see the lookup structure contains clocks for devices > > having multiple instances. > > Do you feel that i should be adding an entry in clk_lookup structure ? > > May be i am missing here something. Can you please elaborate on the > > use-case of clk_lookup > > entries. > > > > Any suggestions on this please ? > Just note, I think you can do it based on Samsung common clock is for all of exynos stuff which will be done in a couple of days. Sorry for late it, because there were some problems. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver
Tomasz Figa wrote:
>
> Hi Vivek,
[...]
> > + usb@1212 {
> > + compatible = "samsung,exynos4210-ohci";
> > + reg = <0x1212 0x100>;
> > + interrupts = <0 71 0>;
>
> For Samsung platforms we decided per board enabling of nodes and so this
> node should also contain:
>
> status = "disabled";
>
> while in dts file of board using ohci there would be an overriding entry:
>
> usb@1212 {
> status = "okay";
> };
>
> I know that Exynos5250 has not been yet converted into this convention,
> but using it when adding new devices will simplify the process.
>
Well, I have another opinion on this...
Let's see, yeah, we are using following method in EXYNOS4 DT...
- disabling IPs in SoC DT source and enabling IPs in board DT source
But as I said, in EXYNOS5440 DT, I want to use following, because most of
them should be enabled/used.
- enabling IPs in SoC DT source and no need enabling in board DT source.
I mean, it depends on each SoC's situation.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver
Vivek Gautam wrote:
>
> Adding EHCI device tree node for Exynos5250 along with
> the device base adress and gpio line for vbus.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> Acked-by: Grant Likely
> ---
>
> Changes from v4:
> - Added gpio line for VBUS of USB2.0 on snow board.
>
> .../devicetree/bindings/usb/exynos-usb.txt | 25
>
> arch/arm/boot/dts/exynos5250-smdk5250.dts |4 +++
> arch/arm/boot/dts/exynos5250-snow.dts |4 +++
> arch/arm/boot/dts/exynos5250.dtsi |6
> 4 files changed, 39 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/exynos-
> usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> new file mode 100644
> index 000..e8bbb47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -0,0 +1,25 @@
> +Samsung Exynos SoC USB controller
> +
> +The USB devices interface with USB controllers on Exynos SOCs.
> +The device node has following properties.
> +
> +EHCI
> +Required properties:
> + - compatible: should be "samsung,exynos4210-ehci" for USB 2.0
> + EHCI controller in host mode.
> + - reg: physical base address of the controller and length of memory
> mapped
> + region.
> + - interrupts: interrupt number to the cpu.
> +
> +Optional properties:
> + - samsung,vbus-gpio: if present, specifies the GPIO that
> + needs to be pulled up for the bus to be powered.
> +
> +Example:
> +
> + usb@1211 {
> + compatible = "samsung,exynos4210-ehci";
> + reg = <0x1211 0x100>;
> + interrupts = <0 71 0>;
> + samsung,vbus-gpio = <&gpx2 6 1 3 3>;
> + };
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 942d576..7363e14 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -204,4 +204,8 @@
> samsung,mfc-r = <0x4300 0x80>;
> samsung,mfc-l = <0x5100 0x80>;
> };
> +
> + usb@1211 {
> + samsung,vbus-gpio = <&gpx2 6 1 3 3>;
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
> b/arch/arm/boot/dts/exynos5250-snow.dts
> index 17dd951..47b6b84 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -40,4 +40,8 @@
> <&gpc4 5 2 3 0>, <&gpc4 6 2 3 0>;
> };
> };
> +
> + usb@1211 {
> + samsung,vbus-gpio = <&gpx1 1 1 3 3>;
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 30485de..2cbe53e 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,12 @@
> #size-cells = <0>;
> };
>
> + usb@1211 {
> + compatible = "samsung,exynos4210-ehci";
> + reg = <0x1211 0x100>;
> + interrupts = <0 71 0>;
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 1.7.6.5
Looks good to me and applied this and "[PATCH v3 2/4] ARM: Exynos5250:
Enabling ohci-exynos driver" in Samsung tree.
Note, I think, you need to implement to use pinctrl for this instead of old
gpio bindings next time, probably after release v3.9-rc1.
Ah, one more, please use subject lines appropriate like others, "ARM: dts:
".
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Praveen Paneri wrote: > > Changes from v1: > Rebased patches to latest usb-next branch > Changed the name 'sec_usbphy' to 'samsung_usbphy' > Yes, looks better. But I'm not sure Felipe or Greg would prefer to use '_' not '-'...you used samsung-usbphy as a name in your patch. > This patch set introduces a phy driver for samsung SoCs. It uses the > existing > transceiver infrastructure to provide phy control functions. Use of this > driver > can be extended for usb host phy as well. Over the period of time all the > phy > related code for most of the samsung SoCs can be integrated here. > Removing the existing phy code from mach-s3c64xx but not from other > machine Why? Is there any reason? After quick looking at your patches, seems this can remove all of setup-usb-phy in arch/arm/ for Samsung stuff. In addition, the isolation hook function also can be put in this by using platform_data or dt parsing. > code.This driver is tested with smdk6410 and Exynos4210(with DT). > I and my colleague, Yulgon will comment on this series soon. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Praveen Paneri (5): > usb: phy: samsung: Introducing usb phy driver for hsotg > usb: s3c-hsotg: Adding phy driver support > ARM: S3C64XX: Removing old phy setup code > ARM: S3C64XX: Enabling samsung_usbphy driver > ARM: Exynos4210: Enabling samsung_usbphy driver > > .../devicetree/bindings/usb/samsung-usbphy.txt |9 + > arch/arm/boot/dts/exynos4210.dtsi |5 + > arch/arm/mach-exynos/include/mach/map.h|1 + > arch/arm/mach-exynos/mach-exynos4-dt.c |8 + > arch/arm/mach-exynos/setup-usb-phy.c | 13 + > arch/arm/mach-s3c64xx/include/mach/map.h |2 + > arch/arm/mach-s3c64xx/mach-crag6410.c |5 +- > arch/arm/mach-s3c64xx/mach-smartq.c|6 +- > arch/arm/mach-s3c64xx/mach-smdk6410.c |5 +- > arch/arm/mach-s3c64xx/setup-usb-phy.c | 79 + > arch/arm/plat-samsung/devs.c | 32 ++ > arch/arm/plat-samsung/include/plat/devs.h |1 + > arch/arm/plat-samsung/include/plat/usb-phy.h |1 + > drivers/usb/gadget/s3c-hsotg.c | 38 ++- > drivers/usb/phy/Kconfig|8 + > drivers/usb/phy/Makefile |1 + > drivers/usb/phy/samsung_usbphy.c | 355 > drivers/usb/phy/samsung_usbphy.h | 48 +++ > include/linux/platform_data/s3c-hsotg.h|5 + > 19 files changed, 534 insertions(+), 88 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/samsung- > usbphy.txt > create mode 100644 drivers/usb/phy/samsung_usbphy.c > create mode 100644 drivers/usb/phy/samsung_usbphy.h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] Common Clock Framework support for Samsung S3C64xx
On 06/06/13 08:57, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. Looks good :) First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introduced. Further patches contain fixes for drivers to make them compliant with CCF semantics, migration of platform code to use the new clock driver and removal of old clock management code. Depends on: - [PATCH 0/6] Samsung watchdog support clean-up http://thread.gmane.org/gmane.linux.kernel.samsung-soc/18736/focus=18989 - [PATCH 00/15] Final Samsung PWM support cleanup http://www.spinics.net/lists/arm-kernel/msg248725.html BTW, Tomasz, so how was going on above PWM patches? On S3C6410-based Tiny6410 board (Mini6410-compatible): Tested-by: Tomasz Figa Tomasz Figa (7): clk: samsung: pll: Add support for PLL6552 and PLL6553 clk: samsung: Add clock driver for S3C64xx SoCs ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare ARM: s3c64xx: Migrate clock handling to Common Clock Framework ARM: s3c64xx: Remove old clock management code -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] clk: samsung: Add clock driver for S3C64xx SoCs
On 06/13/13 06:38, Tomasz Figa wrote: [...] Another thing is that it's unlikely for any new SoC from S3C64xx series to show up, so basically the clock list is fixed. Sure. I can take this into clk-next along with patch #1, or if you prefer: Acked-by: Mike Turquette Thanks. IMHO with all the remaining platform patches in this series, it should go through Samsung tree. Mike, thanks for your ack. Let me take this whole series into samsung tree when ready for other dependencies like PWM... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
Tomasz Figa wrote: > > This series is an attempt to move clock support on Samsung S3C64xx SoCs > to Common Clock Framework. > > First, support for PLL types present on S3C64xx SoCs is added to Samsung > Common Clock Framework driver. Then the main clock driver for mentioned > SoCs is introduced. Further patches contain fixes for drivers to make them > compliant with CCF semantics, migration of platform code to use the new > clock driver and removal of old clock management code. > > Depends on: > - [PATCH v4 00/20] Samsung PWM support cleanup >http://thread.gmane.org/gmane.linux.kernel.samsung-soc/20856 > > On S3C6410-based Tiny6410 board (Mini6410-compatible): > > Tested-by: Tomasz Figa > > For v1: > > Acked-by: Mike Turquette > > Changes since v1: > - added patch for read-only muxes, > - exported configurable muxes and dividers, > - defined mout_syncmux as read-only mux, > - in DT-enabled case fixed-clock binding is used to define external > clocks. > > Tomasz Figa (8): > clk: mux: Add support for read-only muxes. > clk: samsung: pll: Add support for PLL6552 and PLL6553 > clk: samsung: Add clock driver for S3C64xx SoCs > ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros > ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare > usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare > ARM: s3c64xx: Migrate clock handling to Common Clock Framework > ARM: s3c64xx: Remove old clock management code > > .../bindings/clock/samsung,s3c64xx-clock.txt | 77 ++ > arch/arm/Kconfig |2 +- > arch/arm/mach-s3c64xx/Makefile |2 +- > arch/arm/mach-s3c64xx/clock.c | 1007 > > arch/arm/mach-s3c64xx/common.c | 21 +- > arch/arm/mach-s3c64xx/common.h | 12 +- > arch/arm/mach-s3c64xx/dma.c|4 +- > arch/arm/mach-s3c64xx/include/mach/regs-clock.h| 132 +-- > arch/arm/mach-s3c64xx/mach-anw6410.c |2 +- > arch/arm/mach-s3c64xx/mach-crag6410.c |2 +- > arch/arm/mach-s3c64xx/mach-hmt.c |2 +- > arch/arm/mach-s3c64xx/mach-mini6410.c |2 +- > arch/arm/mach-s3c64xx/mach-ncp.c |2 +- > arch/arm/mach-s3c64xx/mach-smartq.c| 11 +- > arch/arm/mach-s3c64xx/mach-smdk6400.c |2 +- > arch/arm/mach-s3c64xx/mach-smdk6410.c |2 +- > arch/arm/mach-s3c64xx/pm.c | 21 - > arch/arm/mach-s3c64xx/s3c6400.c|6 - > arch/arm/mach-s3c64xx/s3c6410.c|7 - > arch/arm/plat-samsung/include/plat/cpu.h |4 + > drivers/clk/clk-mux.c | 10 +- > drivers/clk/samsung/Makefile |1 + > drivers/clk/samsung/clk-pll.c | 160 > drivers/clk/samsung/clk-pll.h |4 + > drivers/clk/samsung/clk-s3c64xx.c | 465 + > drivers/usb/host/ohci-s3c2410.c|8 +- > include/dt-bindings/clock/samsung,s3c64xx-clock.h | 178 > include/linux/clk-provider.h |2 + > 28 files changed, 943 insertions(+), 1205 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/clock/samsung,s3c64xx-clock.txt > delete mode 100644 arch/arm/mach-s3c64xx/clock.c > create mode 100644 drivers/clk/samsung/clk-s3c64xx.c > create mode 100644 include/dt-bindings/clock/samsung,s3c64xx-clock.h > > -- > 1.8.3.2 Looks nice series, thanks. I've applied this whole series including updated v3 2nd and 3rd patches on top of PWM cleanup series. BTW, if I could get ack on 1st and 6th patches, would be helpful :-) Regards, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introduced. Further patches contain fixes for drivers to make them compliant with CCF semantics, migration of platform code to use the new clock driver and removal of old clock management code. Depends on: - [PATCH v4 00/20] Samsung PWM support cleanup http://thread.gmane.org/gmane.linux.kernel.samsung-soc/20856 On S3C6410-based Tiny6410 board (Mini6410-compatible): Tested-by: Tomasz Figa For v1: Acked-by: Mike Turquette Changes since v1: - added patch for read-only muxes, - exported configurable muxes and dividers, - defined mout_syncmux as read-only mux, - in DT-enabled case fixed-clock binding is used to define external clocks. Tomasz Figa (8): clk: mux: Add support for read-only muxes. clk: samsung: pll: Add support for PLL6552 and PLL6553 clk: samsung: Add clock driver for S3C64xx SoCs ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare ARM: s3c64xx: Migrate clock handling to Common Clock Framework ARM: s3c64xx: Remove old clock management code .../bindings/clock/samsung,s3c64xx-clock.txt | 77 ++ arch/arm/Kconfig |2 +- arch/arm/mach-s3c64xx/Makefile |2 +- arch/arm/mach-s3c64xx/clock.c | 1007 arch/arm/mach-s3c64xx/common.c | 21 +- arch/arm/mach-s3c64xx/common.h | 12 +- arch/arm/mach-s3c64xx/dma.c|4 +- arch/arm/mach-s3c64xx/include/mach/regs-clock.h| 132 +-- arch/arm/mach-s3c64xx/mach-anw6410.c |2 +- arch/arm/mach-s3c64xx/mach-crag6410.c |2 +- arch/arm/mach-s3c64xx/mach-hmt.c |2 +- arch/arm/mach-s3c64xx/mach-mini6410.c |2 +- arch/arm/mach-s3c64xx/mach-ncp.c |2 +- arch/arm/mach-s3c64xx/mach-smartq.c| 11 +- arch/arm/mach-s3c64xx/mach-smdk6400.c |2 +- arch/arm/mach-s3c64xx/mach-smdk6410.c |2 +- arch/arm/mach-s3c64xx/pm.c | 21 - arch/arm/mach-s3c64xx/s3c6400.c|6 - arch/arm/mach-s3c64xx/s3c6410.c|7 - arch/arm/plat-samsung/include/plat/cpu.h |4 + drivers/clk/clk-mux.c | 10 +- drivers/clk/samsung/Makefile |1 + drivers/clk/samsung/clk-pll.c | 160 drivers/clk/samsung/clk-pll.h |4 + drivers/clk/samsung/clk-s3c64xx.c | 465 + drivers/usb/host/ohci-s3c2410.c|8 +- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 178 include/linux/clk-provider.h |2 + 28 files changed, 943 insertions(+), 1205 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c64xx-clock.txt delete mode 100644 arch/arm/mach-s3c64xx/clock.c create mode 100644 drivers/clk/samsung/clk-s3c64xx.c create mode 100644 include/dt-bindings/clock/samsung,s3c64xx-clock.h Basically, this series looks good to me, but I'm not sure how this should be handled because of dependency with PWM cleanup and clk stuff in clk tree now... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introduced. Further patches contain fixes for drivers to make them compliant with CCF semantics, migration of platform code to use the new clock driver and removal of old clock management code. Depends on: - [PATCH v4 00/20] Samsung PWM support cleanup http://thread.gmane.org/gmane.linux.kernel.samsung-soc/20856 On S3C6410-based Tiny6410 board (Mini6410-compatible): Tested-by: Tomasz Figa For v1: Acked-by: Mike Turquette Changes since v1: - added patch for read-only muxes, - exported configurable muxes and dividers, - defined mout_syncmux as read-only mux, - in DT-enabled case fixed-clock binding is used to define external clocks. Tomasz Figa (8): clk: mux: Add support for read-only muxes. clk: samsung: pll: Add support for PLL6552 and PLL6553 clk: samsung: Add clock driver for S3C64xx SoCs ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare ARM: s3c64xx: Migrate clock handling to Common Clock Framework ARM: s3c64xx: Remove old clock management code .../bindings/clock/samsung,s3c64xx-clock.txt | 77 ++ arch/arm/Kconfig |2 +- arch/arm/mach-s3c64xx/Makefile |2 +- arch/arm/mach-s3c64xx/clock.c | 1007 arch/arm/mach-s3c64xx/common.c | 21 +- arch/arm/mach-s3c64xx/common.h | 12 +- arch/arm/mach-s3c64xx/dma.c|4 +- arch/arm/mach-s3c64xx/include/mach/regs-clock.h| 132 +-- arch/arm/mach-s3c64xx/mach-anw6410.c |2 +- arch/arm/mach-s3c64xx/mach-crag6410.c |2 +- arch/arm/mach-s3c64xx/mach-hmt.c |2 +- arch/arm/mach-s3c64xx/mach-mini6410.c |2 +- arch/arm/mach-s3c64xx/mach-ncp.c |2 +- arch/arm/mach-s3c64xx/mach-smartq.c| 11 +- arch/arm/mach-s3c64xx/mach-smdk6400.c |2 +- arch/arm/mach-s3c64xx/mach-smdk6410.c |2 +- arch/arm/mach-s3c64xx/pm.c | 21 - arch/arm/mach-s3c64xx/s3c6400.c|6 - arch/arm/mach-s3c64xx/s3c6410.c|7 - arch/arm/plat-samsung/include/plat/cpu.h |4 + drivers/clk/clk-mux.c | 10 +- drivers/clk/samsung/Makefile |1 + drivers/clk/samsung/clk-pll.c | 160 drivers/clk/samsung/clk-pll.h |4 + drivers/clk/samsung/clk-s3c64xx.c | 465 + drivers/usb/host/ohci-s3c2410.c|8 +- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 178 include/linux/clk-provider.h |2 + 28 files changed, 943 insertions(+), 1205 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c64xx-clock.txt delete mode 100644 arch/arm/mach-s3c64xx/clock.c create mode 100644 drivers/clk/samsung/clk-s3c64xx.c create mode 100644 include/dt-bindings/clock/samsung,s3c64xx-clock.h Basically, this series looks good to me, but I'm not sure how this should be handled because of dependency with PWM cleanup and clk stuff in clk tree now... Patches 1-3 can go into the clk tree. 4-6 should go through their respective trees. If you want I can take 7& 8 through the clk tree. Alternatively I can provide patches 1-3 in a separate stable topic branch for you to pull in as a dependency. We'll both merge that stable topic branch into our trees and you can make a note of it for the arm-soc folks. Thanks for your quick response. Would be helpful to samsung tree if you could provide a separate stable topic branch what you suggested for clk stuff in this series. Of course, I will inform when I send pull-request for this series to arm-soc. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
On 08/07/13 07:06, Tomasz Figa wrote: On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 11:13:55) On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introduced. Further patches contain fixes for drivers to make them compliant with CCF semantics, migration of platform code to use the new clock driver and removal of old clock management code. Depends on: - [PATCH v4 00/20] Samsung PWM support cleanup http://thread.gmane.org/gmane.linux.kernel.samsung-soc/20 856 On S3C6410-based Tiny6410 board (Mini6410-compatible): Tested-by: Tomasz Figa For v1: Acked-by: Mike Turquette Changes since v1: - added patch for read-only muxes, - exported configurable muxes and dividers, - defined mout_syncmux as read-only mux, - in DT-enabled case fixed-clock binding is used to define external clocks.> >>> Tomasz Figa (8): clk: mux: Add support for read-only muxes. clk: samsung: pll: Add support for PLL6552 and PLL6553 clk: samsung: Add clock driver for S3C64xx SoCs ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare ARM: s3c64xx: Migrate clock handling to Common Clock Framework ARM: s3c64xx: Remove old clock management code .../bindings/clock/samsung,s3c64xx-clock.txt | 77 ++ arch/arm/Kconfig |2 +- arch/arm/mach-s3c64xx/Makefile |2 +- arch/arm/mach-s3c64xx/clock.c | 1007 arch/arm/mach-s3c64xx/common.c | 21 +- arch/arm/mach-s3c64xx/common.h | 12 +- arch/arm/mach-s3c64xx/dma.c|4 +- arch/arm/mach-s3c64xx/include/mach/regs-clock.h| 132 +-- arch/arm/mach-s3c64xx/mach-anw6410.c |2 +- arch/arm/mach-s3c64xx/mach-crag6410.c |2 +- arch/arm/mach-s3c64xx/mach-hmt.c |2 +- arch/arm/mach-s3c64xx/mach-mini6410.c |2 +- arch/arm/mach-s3c64xx/mach-ncp.c |2 +- arch/arm/mach-s3c64xx/mach-smartq.c| 11 +- arch/arm/mach-s3c64xx/mach-smdk6400.c |2 +- arch/arm/mach-s3c64xx/mach-smdk6410.c |2 +- arch/arm/mach-s3c64xx/pm.c | 21 - arch/arm/mach-s3c64xx/s3c6400.c|6 - arch/arm/mach-s3c64xx/s3c6410.c|7 - arch/arm/plat-samsung/include/plat/cpu.h |4 + drivers/clk/clk-mux.c | 10 +- drivers/clk/samsung/Makefile |1 + drivers/clk/samsung/clk-pll.c | 160 drivers/clk/samsung/clk-pll.h |4 + drivers/clk/samsung/clk-s3c64xx.c | 465 + drivers/usb/host/ohci-s3c2410.c|8 +- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 178 include/linux/clk-provider.h |2 + 28 files changed, 943 insertions(+), 1205 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c64xx-clo ck. txt delete mode 100644 arch/arm/mach-s3c64xx/clock.c create mode 100644 drivers/clk/samsung/clk-s3c64xx.c create mode 100644 include/dt-bindings/clock/samsung,s3c64xx-clock.h Basically, this series looks good to me, but I'm not sure how this should be handled because of dependency with PWM cleanup and clk stuff in clk tree now... Patches 1-3 can go into the clk tree. 4-6 should go through their respective trees. If you want I can take 7& 8 through the clk tree. Alternatively I can provide patches 1-3 in a separate stable topic branch for you to pull in as a dependency. We'll both merge that stable topic branch into our trees and you can make a note of it for the arm-soc folks. Thanks for your quick response. Would be helpful to samsung tree if you could provide a separate stable topic branch what you suggested for clk stuff in this series. git://git.linaro.org/people/mturquette/linux.git clk-next-s3c64xx Topic branch contains patches 1-3 of this series on top of v3.11-rc2. I have already merged the same into the clk-next branch. Mik
RE: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
Tomasz Figa wrote: [...] > > > > > > > > > > Basically, this series looks good to me, but I'm not sure how this > > > > > should be handled because of dependency with PWM cleanup and clk > > > > > stuff > > > > > in clk tree now... > > > > > > > > Patches 1-3 can go into the clk tree. 4-6 should go through their > > > > respective trees. > > > > > > It looks like version 2 of patch 2/8 has been applied by mistake, > > > breaking compilation (and operation) of the clock driver added in > > > patch 3/8. > > Ugh. My mistake. > > Happens. Thanks for fast response. > Sorry for late ;-) > > > Could you please fix this up? Thanks in advance. > > > > This is a little tricky since I published the clk-next-s3c64xx branch as > > a stable branch for Samsung which I think has been merged to the > > Samsung tree already. > > Right, this somewhat limits our options. Although I'm not really sure > whether Kukjin already has pushed it to his public tree. > Yeah, I already did sort out in my local but not public tree because of some problem. > > So what are the options? > > > > One option is to create a fixup patch that just manages the delta > > between V2 and V3. I can then add this to the top of clk-next-s3c64xx > > and re-merge it into clk-next. Then the Samsung tree will need to > > re-merge that dependency branch. > > Well, I can make a "convert PLL65xx to new registration method" patch, > that would be basically the delta. If this could be merged before patch > 7/8, no regression would be introduced. > > > Do you have a better idea? > > Not really. Maybe let's ask Kukjin whether he has already merged it to his > tree. Kukjin, have you? > OK, if new branch is ready, I will replace with that or if re-merge is required, I will. Either way, I'm fine and can handle. Mike, let me know your choice :-) Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: RE: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
Mike Turquette wrote: > [...] > > OK, if new branch is ready, I will replace with that or if re-merge is > > required, I will. Either way, I'm fine and can handle. Mike, let me know > > your choice :-) > > Since I have already published it let's just go with the delta patch. I > can create another stable branch named clk-next-s3c64xx-delta that just > has this patch on top of clk-next-s3c64xx OR I can apply it on top of > the existing clk-next-s3c64xx and re-merge it. > Sounds good to me. If the branch for the delta is ready, let me know. > I'm trying to think on whether there are any weird git corner cases with > re-merging clk-next-s3c64xx. Let me know if re-merging is somehow unsafe > (makes history weird, or whatever). > I don't think it causes some problem. > Let me know what option is better for you. I'll publish as soon as I get > the delta patch. Apologies again for creating some extra work! > No problem. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx
On 08/20/13 16:09, Kukjin Kim wrote: Mike Turquette wrote: [...] OK, if new branch is ready, I will replace with that or if re-merge is required, I will. Either way, I'm fine and can handle. Mike, let me know your choice :-) Since I have already published it let's just go with the delta patch. I can create another stable branch named clk-next-s3c64xx-delta that just has this patch on top of clk-next-s3c64xx OR I can apply it on top of the existing clk-next-s3c64xx and re-merge it. Sounds good to me. If the branch for the delta is ready, let me know. Mike, I'm waiting for your delta branch which includes following from Tomasz. [PATCH] clk: samsung: pll: Use new registration method for PLL6552 and PLL6553 I couldn't send some branches to arm-soc for upcoming merge window yet because of build compilation breakage of common-clk-s3c64xx branch which has many dependencies... - Kukjin I'm trying to think on whether there are any weird git corner cases with re-merging clk-next-s3c64xx. Let me know if re-merging is somehow unsafe (makes history weird, or whatever). I don't think it causes some problem. Let me know what option is better for you. I'll publish as soon as I get the delta patch. Apologies again for creating some extra work! No problem. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: pll: Use new registration method for PLL6552 and PLL6553
On 08/27/13 10:14, Mike Turquette wrote: Quoting Tomasz Figa (2013-08-20 17:33:21) This patch modifies PLL6552 and PLL6553 clock drivers to use recently added common Samsung PLL registration method. Signed-off-by: Tomasz Figa Sigh. This change won't apply on top of clk-next-s3c64xx since it requires Yadwinder's change (amongst) others. The best I could do was spin out another topic branch with the relevant changes and apply this patch on top. It is a subset of clk-next but it is almost entirely Samsung patches: git://git.linaro.org/people/mturquette/linux.git clk-next-s3c64xx-delta Kukjin& Tomasz, let me know if this OK for you to add as a dependency to the Samsung tree. If it is I will merge it into clk-next, but I want your OK that this branch is OK for you to take. Hi Mike, I merged the branch clk-next-s3c64xx-delta you provided on top of previous clk-next-s3c64xx for common-clk-s3c64xx and dt-s3c64xx and it looks fine to me. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg
name for the definition.
See arch/arm/mach-exynos/include/mach/regs-usb-phy.h
> +#define EXYNOS4_PHYPWR_SLEEP (1 << 5)
Ditto.
> +
> +#define S3C_PHYCLK (0x04)
> +
> +#define S3C_PHYCLK_MODE_SERIAL (1 << 6)
MODE_USB11?
> +#define S3C_PHYCLK_EXT_OSC (1 << 5)
> +#define S3C_PHYCLK_COMMON_ON_N (1 << 4)
There are Samsung SoCs which is having two PHYs, so I think, we need to
design this with considering it.
> +#define S3C_PHYCLK_ID_PULL (1 << 2)
> +#define S3C_PHYCLK_CLKSEL_MASK (0x3 << 0)
> +#define S3C_PHYCLK_CLKSEL_SHIFT (0)
> +#define S3C_PHYCLK_CLKSEL_48M(0x0 << 0)
> +#define S3C_PHYCLK_CLKSEL_12M(0x2 << 0)
> +#define S3C_PHYCLK_CLKSEL_24M(0x3 << 0)
As you know, the values for CLKSEL are different on each Samsung SoCs...if
we use this patch, we need to implement for other SoCs many things. In
addition, this patch says can support EXYNOS4210 but not actually...
> +
> +#define S3C_RSTCON (0x08)
> +
> +#define S3C_RSTCON_PHYCLK(1 << 2)
> +#define S3C_RSTCON_HCLK (1 << 1)
> +#define S3C_RSTCON_PHY (1 << 0)
> +
> +#ifndef MHZ
> +#define MHZ (1000*1000)
> +#endif
> +
> +enum samsung_cpu_type {
> + TYPE_S3C64XX,
> + TYPE_EXYNOS4210,
> +};
> +
> +/*
> + * struct samsung_usbphy - transceiver driver state
> + * @phy: transceiver structure
> + * @plat: platform data
> + * @dev: The parent device supplied to the probe function
> + * @clk: usb phy clock
> + * @regs: usb phy register memory base
> + * @ref_clk_freq: reference clock frequency selection
> + * @cpu_type: machine identifier
> + */
> +struct samsung_usbphy {
> + struct usb_phy phy;
> + struct samsung_usbphy_data *plat;
> + struct device *dev;
> + struct clk *clk;
> + void __iomem*regs;
> + int ref_clk_freq;
> + int cpu_type;
> +};
> +
> +#define phy_to_sphy(x) container_of((x), struct
samsung_usbphy,
> phy)
> +
> +/*
> + * Returns reference clock frequency selection value
> + */
> +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy)
> +{
> + struct clk *ref_clk;
> + int refclk_freq = 0;
> +
> + ref_clk = clk_get(sphy->dev, "xusbxti");
> + if (IS_ERR(ref_clk)) {
IS_ERR_OR_NULL(ref_clk)?
> + dev_err(sphy->dev, "Failed to get reference clock\n");
> + return PTR_ERR(ref_clk);
> + }
> +
> + switch (clk_get_rate(ref_clk)) {
> + case 12 * MHZ:
> + refclk_freq |= S3C_PHYCLK_CLKSEL_12M;
Just,
+ refclk_freq = S3C_PHYCLK_CLKSEL_12M;
because its defalut value is 0...BTW, how do you think to support other SoCs
such as EXYNOS4210, EXYNOS4X12?
> + break;
> + case 24 * MHZ:
> + refclk_freq |= S3C_PHYCLK_CLKSEL_24M;
Ditto.
> + break;
> + default:
> + case 48 * MHZ:
> + /* default reference clock */
> + refclk_freq |= S3C_PHYCLK_CLKSEL_48M;
Ditto...and default refernec clock for EXYNOS4 is 24MHz...
> + break;
> + }
> + clk_put(ref_clk);
> +
> + return refclk_freq;
> +}
> +
Hmm...I need more time to look at this again...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Felipe Balbi wrote:
>
> Hi,
>
Hi :-)
[...]
> Sure, but I still need Kukjin's 'say-so' for the arch/arm/plat-samsung
> and arch/arm/mach-exynos part.
>
Basically, this approach looks OK to me.
BTW, I have some comments and need to update...
>From 4th patch...
> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-
> s3c64xx/mach-smdk6410.c
[...]
> @@ -72,6 +73,8 @@
> #include
> #include
> #include
> +#include
Why? In addition, this causes build error with s3c6400_defconfig.
[...]
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 03f654d..9cdb666 100644
[...]
> @@ -1370,6 +1371,30 @@ struct platform_device s5p_device_mixer = {
>
> /* USB */
>
> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
> +/* USB PHY*/
> +static struct resource samsung_usbphy_resource[] = {
> + [0] = {
> + .start = S3C_PA_USB_PHY,
> + .end = S3C_PA_USB_PHY + SZ_16 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> +};
+static struct resource samsung_usbphy_resource[] = {
+ [0] = DEFINED_RES_MEM(S3C_PA_USB_PHY, SZ_16),
+};
[...]
Happens build error with s5pv210_defconfig
arch/arm/plat-samsung/devs.c:1375: error: 'S3C_PA_USB_PHY' undeclared here
(not in a function)
make[2]: *** [arch/arm/plat-samsung/devs.o] Error 1
make[1]: *** [arch/arm/plat-samsung] Error 2
make[1]: *** Waiting for unfinished jobs
And another build error with exynos_defconfig...
arch/arm/mach-exynos/built-in.o: In function `.LANCHOR1':
setup-i2c0.c:(.data+0x8080): undefined reference to
`s5p_usb_phy_pmu_isolation'
>From 5th patch
If possible, please to use 'ARM: [sub-arch dir name]: [subject]' format.
So I preferred to use 'ARM: EXYNOS: Enabling samsung-usbphy driver for
EXYNOS4210' on that.
Please make sure your patch has no problem for kernel compilation before
submitting...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare
Thomas Abraham wrote: > > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Thomas Abraham (+ Alan Stern) Acked-by: Kukjin Kim Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > --- > drivers/usb/host/ohci-exynos.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci- > exynos.c > index 20a5008..7bca600 100644 > --- a/drivers/usb/host/ohci-exynos.c > +++ b/drivers/usb/host/ohci-exynos.c > @@ -123,7 +123,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > goto fail_clk; > } > > - err = clk_enable(exynos_ohci->clk); > + err = clk_prepare_enable(exynos_ohci->clk); > if (err) > goto fail_clken; > > @@ -167,7 +167,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > return 0; > > fail_io: > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > fail_clken: > clk_put(exynos_ohci->clk); > fail_clk: > @@ -186,7 +186,7 @@ static int __devexit exynos_ohci_remove(struct > platform_device *pdev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > clk_put(exynos_ohci->clk); > > usb_put_hcd(hcd); > @@ -232,7 +232,7 @@ static int exynos_ohci_suspend(struct device *dev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > > fail: > spin_unlock_irqrestore(&ohci->lock, flags); > @@ -247,7 +247,7 @@ static int exynos_ohci_resume(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct exynos4_ohci_platdata *pdata = pdev->dev.platform_data; > > - clk_enable(exynos_ohci->clk); > + clk_prepare_enable(exynos_ohci->clk); > > if (pdata && pdata->phy_init) > pdata->phy_init(pdev, S5P_USB_PHY_HOST); > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: ehci-s5p: use clk_prepare_enable and clk_disable_unprepare
Thomas Abraham wrote: > > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Thomas Abraham (+ Alan Stern) Acked-by: Kukjin Kim Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > --- > drivers/usb/host/ehci-s5p.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c > index 85b74be..abc178d 100644 > --- a/drivers/usb/host/ehci-s5p.c > +++ b/drivers/usb/host/ehci-s5p.c > @@ -136,7 +136,7 @@ static int __devinit s5p_ehci_probe(struct > platform_device *pdev) > goto fail_clk; > } > > - err = clk_enable(s5p_ehci->clk); > + err = clk_prepare_enable(s5p_ehci->clk); > if (err) > goto fail_clk; > > @@ -183,7 +183,7 @@ static int __devinit s5p_ehci_probe(struct > platform_device *pdev) > return 0; > > fail_io: > - clk_disable(s5p_ehci->clk); > + clk_disable_unprepare(s5p_ehci->clk); > fail_clk: > usb_put_hcd(hcd); > return err; > @@ -200,7 +200,7 @@ static int __devexit s5p_ehci_remove(struct > platform_device *pdev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(s5p_ehci->clk); > + clk_disable_unprepare(s5p_ehci->clk); > > usb_put_hcd(hcd); > > @@ -231,7 +231,7 @@ static int s5p_ehci_suspend(struct device *dev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(s5p_ehci->clk); > + clk_disable_unprepare(s5p_ehci->clk); > > return rc; > } > @@ -243,7 +243,7 @@ static int s5p_ehci_resume(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct s5p_ehci_platdata *pdata = pdev->dev.platform_data; > > - clk_enable(s5p_ehci->clk); > + clk_prepare_enable(s5p_ehci->clk); > > if (pdata && pdata->phy_init) > pdata->phy_init(pdev, S5P_USB_PHY_HOST); > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio
Doug Anderson wrote:
>
> The ehci_vbus_gpio is requested but never freed. This can cause
> problems with deferred probes and would cause problems if
> s5p_ehci_remove was ever called. Use devm to fix this.
>
> Signed-off-by: Doug Anderson
Acked-by: Kukjin Kim
Thanks.
- Kukjin
> ---
> Changes in v2:
> - &pdev->dev => dev elsewhere in s5p_setup_vbus_gpio()
>
> drivers/usb/host/ehci-s5p.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 20ebf6a..738490e 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -92,20 +92,21 @@ static void s5p_ehci_phy_disable(struct s5p_ehci_hcd
> *s5p_ehci)
>
> static void s5p_setup_vbus_gpio(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
> int err;
> int gpio;
>
> - if (!pdev->dev.of_node)
> + if (!dev->of_node)
> return;
>
> - gpio = of_get_named_gpio(pdev->dev.of_node,
> - "samsung,vbus-gpio", 0);
> + gpio = of_get_named_gpio(dev->of_node, "samsung,vbus-gpio", 0);
> if (!gpio_is_valid(gpio))
> return;
>
> - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio");
> + err = devm_gpio_request_one(dev, gpio, GPIOF_OUT_INIT_HIGH,
> + "ehci_vbus_gpio");
> if (err)
> - dev_err(&pdev->dev, "can't request ehci vbus gpio %d",
gpio);
> + dev_err(dev, "can't request ehci vbus gpio %d", gpio);
> }
>
> static u64 ehci_s5p_dma_mask = DMA_BIT_MASK(32);
> --
> 1.8.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: phy: samsung: fix sparse warning
Felipe Balbi wrote:
>
> Fix the following sparse warning:
>
> drivers/usb/phy/phy-samsung-usb2.c:50:26: sparse: incorrect type in
> argument 1 (different address spaces)
> drivers/usb/phy/phy-samsung-usb2.c:50:26:expected void const volatile
> [noderef] *addr
> drivers/usb/phy/phy-samsung-usb2.c:50:26:got void *
>
> Cc: Vivek Gautam
> Cc: Kukjin Kim
Looks good to me, if you want:
Acked-by: Kukjin Kim
Thanks.
- Kukjin
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/phy/phy-samsung-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy/phy-
> samsung-usb2.c
> index dce9681..45ffe03 100644
> --- a/drivers/usb/phy/phy-samsung-usb2.c
> +++ b/drivers/usb/phy/phy-samsung-usb2.c
> @@ -43,7 +43,7 @@ static int samsung_usbphy_set_host(struct usb_otg *otg,
> struct usb_bus *host)
> return 0;
> }
>
> -static bool exynos5_phyhost_is_on(void *regs)
> +static bool exynos5_phyhost_is_on(void __iomem *regs)
> {
> u32 reg;
>
> --
> 1.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy
Vivek Gautam wrote: > > Based on 'for-next' of linux-samsung tree with following patches > from Doug on top: > usb: Document clocks in samsung, exynos4210-ehci/ohci bindings > ARM: dts: add usb 2.0 clock references to exynos5250 device tree > > Also depending upon following patch-series for Samsung-usb-phy driver: > [PATCH v7 0/2] Adding USB 3.0 DRD-phy support for exynos5250 > > Changes from v3: > Added 'clocks' and 'clock-names' entry also in device nodes, aligning > with common clock framework for Samsung's SoCs. > > Vivek Gautam (2): > ARM: Exynos5250: Enabling samsung-usb2phy driver > ARM: Exynos5250: Enabling samsung-usb3phy driver > > arch/arm/boot/dts/exynos5250.dtsi | 29 + > 1 files changed, 29 insertions(+), 0 deletions(-) > > -- > 1.7.6.5 OK, applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver
Vivek Gautam wrote: > > This patch-set is in continuation with patch-series: > [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 > out of which follwowing patches have been picked up: > ARM: Exynos5250: Enabling ehci-s5p driver > ARM: Exynos5250: Enabling ohci-exynos driver > > Based on following patch-set for Samsung's usb PHY enablement: > [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy > > and further depends on dwc3-exynos driver patch-set: > [PATCH 0/2] dwc3: exynos: Device tree fixes > > Changes from v4: > - Aligning with the recently merged common clock framework, thereby >no place for clock file changes. ;-) > - Adding proper binding documentation as per latest bindings changes in >dwc3 driver (dwc3/core.c as well as for dwc3-exynos.c change reflected >by above patch-set. > - Bifurcating the patch to separate our Documentation, arch and dts > changes. > > Vivek Gautam (3): > usb: Add device tree bindings for dwc3-exynos > ARM: exynos5250: dts: Enabling dwc3-exynos driver > ARM: exynos5: Enable XHCI support on exynos5 > > .../devicetree/bindings/usb/exynos-usb.txt | 34 > > arch/arm/boot/dts/exynos5250.dtsi | 20 ++- > arch/arm/mach-exynos/Kconfig |1 + > 3 files changed, 53 insertions(+), 2 deletions(-) > > -- > 1.7.6.5 Applied this series, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing
On 04/09/13 22:12, Vivek Gautam wrote: 7edb3da: (USB: EHCI: make ehci-s5p a separate driver) raised an issue with ehci-s5p's driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing but a pointer to hcd->priv; add hcd to the driver data rather than s5p_ehci. This fixes issues with null pointer dereferencing in s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume(). Signed-off-by: Vivek Gautam CC: Manjunath Goudar CC: Arnd Bergmann CC: Jingoo Han Acked-by: Kukjin Kim Thanks. - Kukjin --- Based on 'usb-next' drivers/usb/host/ehci-s5p.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c index d8cb0ca..580548a 100644 --- a/drivers/usb/host/ehci-s5p.c +++ b/drivers/usb/host/ehci-s5p.c @@ -173,7 +173,7 @@ static int s5p_ehci_probe(struct platform_device *pdev) goto fail_add_hcd; } - platform_set_drvdata(pdev, s5p_ehci); + platform_set_drvdata(pdev, hcd); return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support
On 11/22/14 17:40, Kishon Vijay Abraham I wrote: > > On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: >> On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: >>> The series has dependency on >>> a) "[PATCH v7 0/7] Enable support for Samsung Exynos7 SoC" >>>http://www.spinics.net/lists/linux-samsung-soc/msg38734.html >>> b) "[GIT PULL] Samsung clock changes for 3.19" - specifically the clock dt >>>bindings header. >>>http://comments.gmane.org/gmane.linux.kernel.samsung-soc/39142 >>> c) "tty: serial: samsung: Clean-up selection of number of available UARTs" >>>http://www.spinics.net/lists/linux-samsung-soc/msg37418.html >>> d) "dts, kbuild: Implement support for dtb vendor subdirs"(merged in >>> linux-next) >>>https://lkml.org/lkml/2014/10/21/654 >>> e) "Samsung pinctrl patches for v3.19" >>>http://www.spinics.net/lists/linux-samsung-soc/msg38744.html >>> >>> Tested on Exynos7-espresso board with 3.18-rc5 and above dependencies. >>> >>> Clubbing the pinctrl, clk, and usb driver changes alongwith the dt changes >>> together in this series only so as to avoid having 'n' number of >>> dependencies. >>> >>> The USB driver patches in this series were part of [1] sent earlier. >>> [1] [PATCH v2 0/4] usb: dwc3/phy-exynos5-usbdrd: Extend support to Exynos7 >>> https://lkml.org/lkml/2014/10/7/191 >> >> I took dwc3 driver patches. > > I took the phy patches. > I'll take DT changes once exynos7 is landing into samsung tree :) Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/4] usb: ehci/ohci-exynos: Move to generic phy framework
On 05/02/14 21:47, Vivek Gautam wrote: Based and tested on 'usb-next' branch of Greg's usb tree, with relevant device tree patches[1] Hi Alan, I have included your Acked-by in all the four patches, but there has been some amount of restructuring as suggested by Tomasz Figa. Please let me know if you have some comments on this patch-series. Changes from v4: - Addressed review comments for restructuring exynos_ohci_get_phy() and exynos_ehci_get_phy(); and thereby adding proper checks in exynos_ohci_phy_enable()/disable() as well as exynos_ehci_phy_enable()/ disable(). Changes from v3: - Calling usb_phy_shutdown() when exynos_o/ehci_phy_enable() is failing. - Made exynos_o/ehci_phy_disable() return void, since its return value did not serve any purpose. - Calling clk_disable_unprepare() in exynos_o/ehci_resume() when exynos_o/ehci_phy_enable() is failed. Changes from v2: - Added two patches in the series for some cleanup. usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device - Addressed review comments. -- Moved exynos_ohci_phyg_on()/off routines inside exynos_ohci_phy_enable()/disable. -- Added functions exynos_ehci_phy_enable() and exynos_ehci_phy_disable() and moved exynos_ehci_phyg_on()/off routines respectively in them. -- Added necessary checks. [1]: [PATCH 0/4] dts: Add usb2phy to Exynos 5250/5420 https://lkml.org/lkml/2014/4/30/119 Kamil Debski (1): usb: ehci-exynos: Change to use phy provided by the generic phy framework Vivek Gautam (3): usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device usb: ohci-exynos: Add facility to use phy provided by the generic phy framework .../devicetree/bindings/usb/exynos-usb.txt | 31 + drivers/usb/host/ehci-exynos.c | 136 drivers/usb/host/ohci-exynos.c | 134 +++ 3 files changed, 254 insertions(+), 47 deletions(-) This series looks good to me, please feel free to add my ack on this series, Acked-by: Kukjin Kim Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/8] Enable USB 3.0 support on Exynos5 systems
On 05/14/14 23:01, Vivek Gautam wrote: From: Vivek gautam Based on 'for-next' branch of Kgene's linux-samsung tree; along with dts patches for USB 2.0 phy[1], and Exynos5800 [2]. Also based on the latest USB 3.0 DRD phy driver patches posted [3]. Changes from v5: - Added node reference names for new boards. - Removed 'samsung,pmu-offset' porperty from nodes, since with latest driver bindings this is not required. - Added aliase nodes in Exynos5420 to facilitate latest driver bindings. - Added patch to add VBUS regulator for peach-pi board also. - Dropped patches removing older usb-phy driver: usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver ARM: exynos_defconfig: Remove SAMSUNG_USB3PHY config as appeared in V5 version of this series. Will post them separately after the new driver is merged. [1] http://www.spinics.net/lists/linux-samsung-soc/msg30494.html [2] http://comments.gmane.org/gmane.linux.kernel.samsung-soc/31133 [3] https://lkml.org/lkml/2014/5/13/285 Vivek Gautam (7): ARM: dts: exynos5420: Enable support for USB 3.0 PHY controller ARM: dts: exynos5420: Enable support for DWC3 controller ARM: dts: exynos5250: Enable support for generic USB DRD phy ARM: dts: exynos5250: Update DWC3 usb controller to use new phy driver ARM: dts: exynos5250-snow: Add Vbus regulator for USB 3.0 ARM: dts: exynos5420-peach-pit: Add Vbus regulator for USB 3.0 ARM: dts: exynos5420-smdk5420: Add Vbus regulator for USB 3.0 Vivek gautam (1): should be same guy. Vivek Gautam ;-) ARM: dts: exynos5800-peach-pi: Add Vbus regulator for USB 3.0 arch/arm/boot/dts/exynos5250-snow.dts | 22 arch/arm/boot/dts/exynos5250.dtsi | 20 +-- arch/arm/boot/dts/exynos5420-peach-pit.dts | 46 arch/arm/boot/dts/exynos5420-smdk5420.dts | 46 arch/arm/boot/dts/exynos5420.dtsi | 54 arch/arm/boot/dts/exynos5800-peach-pi.dts | 46 6 files changed, 222 insertions(+), 12 deletions(-) Looks good to me. Applied 1 to 4 patches, but for others 5 to 8 I need to get any review or ack from dt guys. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420
Vivek Gautam wrote:
>
> This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
> tree, to access System Register's registers using syscon driver.
>
> Signed-off-by: Kamil Debski
> [gautam.vi...@samsung.com: Split this syreg-syscon dts entry from
> dts: Add usb2phy to Exynos 5250 patch]
> [gautam.vi...@samsung.com: added similar syscon entry for exynos5420]
> Signed-off-by: Vivek Gautam
> ---
>
Vivek,
See my comment below.
And please don't version each patch in series...it's really not a good way.
It cause very big confusing...
> Changes since v7:
> None
>
> arch/arm/boot/dts/exynos5250.dtsi |5 +
> arch/arm/boot/dts/exynos5420.dtsi |5 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 3742331..70f0cd5 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -175,6 +175,11 @@
> reg = <0x1004 0x5000>;
> };
>
> + sysreg_system_controller: syscon@1005 {
> + compatible = "samsung,exynos5250-sys", "syscon";
Maybe exynos5250-sysreg?
And need to add/modify binding doc?
- Kukjin
> + reg = <0x1005 0x5000>;
> + };
> +
> watchdog@101D {
> compatible = "samsung,exynos5250-wdt";
> reg = <0x101D 0x100>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index a802f74..5d5d6e3 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -682,6 +682,11 @@
> reg = <0x1004 0x5000>;
> };
>
> + sysreg_system_controller: syscon@1005 {
> + compatible = "samsung,exynos5420-sys", "syscon";
> + reg = <0x1005 0x5000>;
> + };
> +
> tmu_cpu0: tmu@1006 {
> compatible = "samsung,exynos5420-tmu";
> reg = <0x1006 0x100>;
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 5/8] ARM: dts: exynos5250-snow: Add Vbus regulator for USB 3.0
Vivek Gautam wrote:
>
> Add required fixed-regulator for VBUS supply for USB 3.0
> controller phy.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
> b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1ce1088..fd9b3b3 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -37,6 +37,13 @@
> sd3_bus4: sd3-bus-width4 {
> samsung,pin-drv = <0>;
> };
> +
> + usb3_vbus_en: usb3-vbus-en {
> + samsung,pins = "gpx2-7";
> + samsung,pin-function = <1>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
>
> gpio-keys {
> @@ -196,6 +203,21 @@
> };
> };
>
> + usb3_vbus_reg: regulator-usb3 {
> + compatible = "regulator-fixed";
> + regulator-name = "P5.0V_USB3CON";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + gpio = <&gpx2 7 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb3_vbus_en>;
> + enable-active-high;
> + };
> +
> + phy@1210 {
> + vbus-supply = <&usb3_vbus_reg>;
> + };
> +
> usb@1211 {
> samsung,vbus-gpio = <&gpx1 1 0>;
> };
> --
> 1.7.10.4
Looks OK to me and applied 5 to 8 as well.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V3 0/4] dts: Add usb2phy to Exynos 5250/5420
Vikas Sajjan wrote: > > Based on 'for-next' branch of Kgene's linux-samsung tree. > These patches are as per discussions on the driver side patches > which have already been acked. [1] > Sounds good. I will apply this whole series if dt guys have no objection to add the exynos5-sysreg dt binding. Thanks, Kukjin > Changes from v2: > - Addressed kukjin's comments to update DT binding documentation > for sysreg. > - removed the version for each patch. Made all patches version as > same. > > Changes from v1: > - Rebase on 'for-next' branch. > - Removed 'phy-names' property as per discuusion in the driver patches. > [1] > > V1 of this series was the next version for earlier patch-series: > [PATCH v7 0/2] dts: Add usb2phy to Exynos 5250 [2] > > Changes from v7 series: > - Added patches to enable usb 2.0 support on exynos5420; >which include dt nodes for usb2phy as well as ehci and ohci >controllers. > > Changes from v6: > - Splitted the patch into two: > adding syscon nodes to Exynos5250 and Exynos5420 in first; > and phy entry change in the second. > - Changed the name of phandle for usb2phy from 'usb2_phy_new' >to 'usb2_phy_gen' indicating generic phy. > - Using clock macros in dt entries. > > [1] http://www.spinics.net/lists/linux-usb/msg106908.html > http://www.spinics.net/lists/linux-usb/msg106837.html > [2] http://www.spinics.net/lists/linux-usb/msg106427.html > > Kamil Debski (1): > ARM: dts: Add usb2phy to Exynos 5250 > > Vivek Gautam (3): > ARM: dts: Add sysreg sytem controller node to exynos5250 and > exynos5420 > ARM: dts: Add usb2phy support on exynos5420 > ARM: dts: Add usb 2.0 support on exynos5420 > > .../devicetree/bindings/arm/samsung/sysreg.txt | 11 - > arch/arm/boot/dts/exynos5250.dtsi | 27 > arch/arm/boot/dts/exynos5420.dtsi | 45 > 3 files changed, 81 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] usb: phy: samsung: remove old USB PHY code
On 08/23/14 02:14, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Wednesday, August 20, 2014 01:12:44 PM Felipe Balbi wrote:
Hi,
On Thu, Aug 14, 2014 at 04:25:22PM +0200, Bartlomiej Zolnierkiewicz wrote:
Hi,
This patch series removes the old Samsung USB PHY drivers that
got replaced by the new ones using the generic PHY layer.
Depends on:
- next-20140813 branch of linux-next kernel
this thread seems to have died, what do I need to do with these patches?
Please apply them (patches #3, #4 and #5). Patches #1 and #2
should be applied (or Acked-by) by Kukjin Kim.
I've applied #1 and #2, sorry for late taking.
Thanks,
Kukjin
Are we deleting the phy drivers or not ?
Yes, we are deleting them. It has been agreed on by Kishon and
Vivek.
Please rebase on v3.17-rc1 and resend with all Acks in place.
Done:
https://lkml.org/lkml/2014/8/22/446
Please note that if you want to apply it to current -next kernel
(next-20140822) then you need to resolve conflict between patch
#5/5 ("usb: phy: samsung: remove old common USB PHY code") and
commit bbc66e140bab ("usb: phy: samsung: Fix wrong bit mask for
PHYPARAM1_PCS_TXDEEMPH") by simply removing the new version of
drivers/usb/phy/phy-samsung-usb.h file.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: DTS: Exynos: add 'dr_mode' property to hsotg devices
Marek Szyprowski wrote:
>
> All currently supported boards use hsotg/dwc2 controller in device
> ('peripheral') mode, so add property which sets correct operation mode.
> This patch fixes support in recent changes in dwc2 driver, which added
> support for dual-role devices.
>
> Suggested-by: Paul Zimmerman
> Signed-off-by: Marek Szyprowski
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 1 +
> arch/arm/boot/dts/exynos3250-rinato.dts | 1 +
> arch/arm/boot/dts/exynos4210-trats.dts | 1 +
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 1 +
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 +
> arch/arm/boot/dts/exynos4412-trats2.dts | 1 +
> arch/arm/boot/dts/s5pv210-aquila.dts| 1 +
> arch/arm/boot/dts/s5pv210-goni.dts | 1 +
> arch/arm/boot/dts/s5pv210-smdkv210.dts | 1 +
> 9 files changed, 9 insertions(+)
>
Looks good to me, will apply.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: DTS: Exynos: add 'dr_mode' property to hsotg devices
Kukjin Kim wrote:
>
> Marek Szyprowski wrote:
> >
> > All currently supported boards use hsotg/dwc2 controller in device
> > ('peripheral') mode, so add property which sets correct operation mode.
> > This patch fixes support in recent changes in dwc2 driver, which added
> > support for dual-role devices.
> >
> > Suggested-by: Paul Zimmerman
Maybe typo Paul's email? Let me fix his e-mail to "paulz at ..."
- Kukjin
> > Signed-off-by: Marek Szyprowski
> > ---
> > arch/arm/boot/dts/exynos3250-monk.dts | 1 +
> > arch/arm/boot/dts/exynos3250-rinato.dts | 1 +
> > arch/arm/boot/dts/exynos4210-trats.dts | 1 +
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 1 +
> > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 +
> > arch/arm/boot/dts/exynos4412-trats2.dts | 1 +
> > arch/arm/boot/dts/s5pv210-aquila.dts| 1 +
> > arch/arm/boot/dts/s5pv210-goni.dts | 1 +
> > arch/arm/boot/dts/s5pv210-smdkv210.dts | 1 +
> > 9 files changed, 9 insertions(+)
> >
> Looks good to me, will apply.
>
> Thanks,
> Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
