Re: [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure

[Andrew Jeffery]

On Wed, 31 Oct 2018, at 02:49, Julia Lawall wrote:
> The usb_gadget_ops structure can be const as it is only stored in
> the ops field of a usb_gadget structure and this field is const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall 

Reviewed-by: Andrew Jeffery 

> 
> ---
>  drivers/usb/gadget/udc/aspeed-vhub/dev.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/
> gadget/udc/aspeed-vhub/dev.c
> index f0233912bace..6b1b16b17d7d 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
> @@ -438,7 +438,7 @@ static int ast_vhub_udc_stop(struct usb_gadget 
> *gadget)
>   return 0;
>  }
>  
> -static struct usb_gadget_ops ast_vhub_udc_ops = {
> +static const struct usb_gadget_ops ast_vhub_udc_ops = {
>   .get_frame  = ast_vhub_udc_get_frame,
>   .wakeup = ast_vhub_udc_wakeup,
>   .pullup = ast_vhub_udc_pullup,
> 

Re: [PATCH] usb: gadget: fix spelling mistakeis "[En]queing" -> "[En]queuing"

[Andrew Jeffery]

On Sat, 29 Sep 2018, at 22:13, Colin King wrote:
> From: Colin Ian King 
> 
> Trivial fix to spelling mistakes in debug warning messages
> 
> Signed-off-by: Colin Ian King 

Reviewed-by: Andrew Jeffery 

> ---
>  drivers/usb/gadget/udc/aspeed-vhub/epn.c | 2 +-
>  drivers/usb/gadget/udc/udc-xilinx.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/epn.c b/drivers/usb/
> gadget/udc/aspeed-vhub/epn.c
> index 5939eb1e97f2..e9ee2b72af19 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/epn.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/epn.c
> @@ -353,7 +353,7 @@ static int ast_vhub_epn_queue(struct usb_ep* u_ep, 
> struct usb_request *u_req,
>   /* Endpoint enabled ? */
>   if (!ep->epn.enabled || !u_ep->desc || !ep->dev || !ep->d_idx ||
>   !ep->dev->enabled || ep->dev->suspended) {
> - EPDBG(ep,"Enqueing request on wrong or disabled EP\n");
> + EPDBG(ep, "Enqueuing request on wrong or disabled EP\n");
>   return -ESHUTDOWN;
>   }
>  
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/
> udc/udc-xilinx.c
> index 6407e433bc78..b1f4104d1283 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -1078,7 +1078,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, 
> struct usb_request *_req,
>   unsigned long flags;
>  
>   if (!ep->desc) {
> - dev_dbg(udc->dev, "%s:queing request to disabled %s\n",
> + dev_dbg(udc->dev, "%s: queuing request to disabled %s\n",
>   __func__, ep->name);
>   return -ESHUTDOWN;
>   }
> -- 
> 2.17.1
>