Re: [PATCH 4/8] usb: xhci: pci: Only create Intel mux device when it's needed
On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
wrote:
>
> Only create thre Intel role mux device if the platform has
> USB peripheral controller PCI device.
>
> While here, enable the role mux on Apollo Lake platforms.
> +static int xhci_pci_board_has_udc(void)
> +{
> + struct pci_dev *udc = pci_get_class(PCI_CLASS_SERIAL_USB_DEVICE,
> NULL);
> +
> + if (udc) {
> + pci_dev_put(udc);
> + return true;
> + }
> + return false;
> +}
Looks like a code duplication with patch 3. Does it make sense to have
this in some header (usb.h?)?
--
With Best Regards,
Andy Shevchenko
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus wrote: > > Hi, > > The second last patch in this series will make it possible to use > multiport USB Type-C and PD controllers with the muxes. The CHT > connections are simply adapted to that. The rest of the series will > mainly allow us to use the USB Type-C on CHT boards even without a > USB device controller. > Throught which tree you are planning to direct this? > > Heikki Krogerus (8): > drivers: base: Helpers for adding device connection descriptions > plarform: x86: intel_cht_int33fe: Register all connections at once > plarform: x86: intel_cht_int33fe: Use the USB role switch > conditionally > usb: xhci: pci: Only create Intel mux device when it's needed > plarform: x86: intel_cht_int33fe: Fix the identifier for the mux > connection > plarform: x86: intel_cht_int33fe: Add connections for the USB Type-C > port > usb: typec: class: Don't use port parent for getting mux handles > plarform: x86: intel_cht_int33fe: Remove the old connections for the > muxes > > drivers/platform/x86/intel_cht_int33fe.c | 34 +++-- > drivers/usb/host/xhci-pci.c | 20 +++-- > drivers/usb/typec/class.c| 38 ++-- > include/linux/device.h | 24 +++ > 4 files changed, 74 insertions(+), 42 deletions(-) > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko
Nothing in /sys/class/udc
Hello, I try to add gadget configfs as described in: https://www.kernel.org/doc/Documentation/usb/gadget_configfs.txt Yet, I find nothing in /sys/class/udc: user@user-VirtualBox:~/tegra$ ls /sys/class/udc/ -al total 0 drwxr-xr-x 2 root root 0 Sep 3 00:30 . drwxr-xr-x 58 root root 0 Sep 3 00:30 .. I also don't have dwc2, but dwc3: user@user-VirtualBox:~/tegra$ lsmod | grep dw dwc3 90112 0 ulpi 16384 1 dwc3 udc_core 24576 2 dwc3,libcomposite user@user-VirtualBox:~/tegra$ Kernel is 4.4.50. Thank you for any idea, ranran
[PATCH] usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match
The SPDX-License-Identifier is set to GPL-2.0+, which correspond to
MODULE_LICENSE "GPL".
Signed-off-by: Marcus Folkesson
---
drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
drivers/usb/chipidea/usbmisc_imx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 19f5f5f2a48a..555d398fbfa7 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -492,7 +492,7 @@ static struct platform_driver ci_hdrc_imx_driver = {
module_platform_driver(ci_hdrc_imx_driver);
MODULE_ALIAS("platform:imx-usb");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("CI HDRC i.MX USB binding");
MODULE_AUTHOR("Marek Vasut ");
MODULE_AUTHOR("Richard Zhao ");
diff --git a/drivers/usb/chipidea/usbmisc_imx.c
b/drivers/usb/chipidea/usbmisc_imx.c
index 34ad5bf8acd8..d9cfa00b8a6c 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -633,6 +633,6 @@ static struct platform_driver usbmisc_imx_driver = {
module_platform_driver(usbmisc_imx_driver);
MODULE_ALIAS("platform:usbmisc-imx");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("driver for imx usb non-core registers");
MODULE_AUTHOR("Richard Zhao ");
--
2.18.0
[PATCH] usb: chipidea: imx: do not use preprocessor conditionals for PM
Use preprocessor conditionals for CONFIG_PM and CONFIG_PM_SLEEP is
not necessary since SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS does
that internally.
It is also the preferred way according to our coding style guidelines.
Signed-off-by: Marcus Folkesson
---
drivers/usb/chipidea/ci_hdrc_imx.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 555d398fbfa7..09b37c0d075d 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -364,8 +364,7 @@ static void ci_hdrc_imx_shutdown(struct platform_device
*pdev)
ci_hdrc_imx_remove(pdev);
}
-#ifdef CONFIG_PM
-static int imx_controller_suspend(struct device *dev)
+static int __maybe_unused imx_controller_suspend(struct device *dev)
{
struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
@@ -377,7 +376,7 @@ static int imx_controller_suspend(struct device *dev)
return 0;
}
-static int imx_controller_resume(struct device *dev)
+static int __maybe_unused imx_controller_resume(struct device *dev)
{
struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
int ret = 0;
@@ -408,8 +407,7 @@ static int imx_controller_resume(struct device *dev)
return ret;
}
-#ifdef CONFIG_PM_SLEEP
-static int ci_hdrc_imx_suspend(struct device *dev)
+static int __maybe_unused ci_hdrc_imx_suspend(struct device *dev)
{
int ret;
@@ -431,7 +429,7 @@ static int ci_hdrc_imx_suspend(struct device *dev)
return imx_controller_suspend(dev);
}
-static int ci_hdrc_imx_resume(struct device *dev)
+static int __maybe_unused ci_hdrc_imx_resume(struct device *dev)
{
struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
int ret;
@@ -445,9 +443,8 @@ static int ci_hdrc_imx_resume(struct device *dev)
return ret;
}
-#endif /* CONFIG_PM_SLEEP */
-static int ci_hdrc_imx_runtime_suspend(struct device *dev)
+static int __maybe_unused ci_hdrc_imx_runtime_suspend(struct device *dev)
{
struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
int ret;
@@ -466,13 +463,11 @@ static int ci_hdrc_imx_runtime_suspend(struct device *dev)
return imx_controller_suspend(dev);
}
-static int ci_hdrc_imx_runtime_resume(struct device *dev)
+static int __maybe_unused ci_hdrc_imx_runtime_resume(struct device *dev)
{
return imx_controller_resume(dev);
}
-#endif /* CONFIG_PM */
-
static const struct dev_pm_ops ci_hdrc_imx_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(ci_hdrc_imx_suspend, ci_hdrc_imx_resume)
SET_RUNTIME_PM_OPS(ci_hdrc_imx_runtime_suspend,
--
2.18.0
Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote: > This patch is to add description of 'configure-gfladj' to binding > so that configuring devicetree > > Signed-off-by: Yinbo Zhu Ah, okay. You just started documenting the binding. So please send me dts patch only after the corresponding bindings and driver code are accepted. Shawn > --- > Documentation/devicetree/bindings/usb/dwc3.txt |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt > b/Documentation/devicetree/bindings/usb/dwc3.txt > index 3e4c38b..40c6568 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -101,6 +101,7 @@ Optional properties: > When just one value, which means INCRX burst mode > enabled. When > more than one value, which means undefined length INCR > burst type > enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and > 256. > + - configure-gfladj: determine whether frame length adjustment is required > or not. > > - in addition all properties from usb-xhci.txt from the current directory > are > supported as well > -- > 1.7.1 >
[PATCH] usb: typec: fix kernel-doc parameter warning
From: Randy Dunlap Fix kernel-doc warning (13 times): ../drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode' Signed-off-by: Randy Dunlap Cc: Heikki Krogerus --- drivers/usb/typec/class.c |1 - 1 file changed, 1 deletion(-) --- lnx-419-rc2.orig/drivers/usb/typec/class.c +++ lnx-419-rc2/drivers/usb/typec/class.c @@ -1484,7 +1484,6 @@ EXPORT_SYMBOL_GPL(typec_set_mode); * typec_port_register_altmode - Register USB Type-C Port Alternate Mode * @port: USB Type-C Port that supports the alternate mode * @desc: Description of the alternate mode - * @drvdata: Private pointer to driver specific info * * This routine is used to register an alternate mode that @port is capable of * supporting.
[PATCH] usb/dwc3/gadget: fix kernel-doc parameter warning
From: Randy Dunlap Fix kernel-doc warning: ../drivers/usb/dwc3/gadget.c:510: warning: Excess function parameter 'dwc' description in 'dwc3_gadget_start_config' Signed-off-by: Randy Dunlap Cc: Felipe Balbi --- drivers/usb/dwc3/gadget.c |1 - 1 file changed, 1 deletion(-) --- lnx-419-rc2.orig/drivers/usb/dwc3/gadget.c +++ lnx-419-rc2/drivers/usb/dwc3/gadget.c @@ -473,7 +473,6 @@ static int dwc3_gadget_set_xfer_resource /** * dwc3_gadget_start_config - configure ep resources - * @dwc: pointer to our controller context structure * @dep: endpoint that is being enabled * * Issue a %DWC3_DEPCMD_DEPSTARTCFG command to @dep. After the command's
RE: linux-next: Tree for Aug 31 (drivers/usb/gadget/udc/renesas_usb3)
Hi, > From: Randy Dunlap, Sent: Saturday, September 1, 2018 12:43 AM > > On 08/30/2018 08:03 PM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180830: > > > > on i386: > > drivers/usb/gadget/udc/renesas_usb3.o: In function `renesas_usb3_probe': > renesas_usb3.c:(.text+0x16da): undefined reference to > `usb_of_get_companion_dev' > > > Full randconfig file is attached. Thank you for the report! I already submitted a fix patch [1]. But this patch is not applied yet. [1] https://marc.info/?l=linux-usb&m=153476263226681&w=2 Related ML archives: https://marc.info/?l=linux-usb&m=153382696712253&w=2 https://marc.info/?l=linux-usb&m=153419699328537&w=2 Best regards, Yoshihiro Shimoda > -- > ~Randy
RE: [PATCH] usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match
>
> The SPDX-License-Identifier is set to GPL-2.0+, which correspond to
> MODULE_LICENSE "GPL".
>
> Signed-off-by: Marcus Folkesson
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> drivers/usb/chipidea/usbmisc_imx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 19f5f5f2a48a..555d398fbfa7 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -492,7 +492,7 @@ static struct platform_driver ci_hdrc_imx_driver =
> { module_platform_driver(ci_hdrc_imx_driver);
>
> MODULE_ALIAS("platform:imx-usb");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("CI HDRC i.MX USB binding");
> MODULE_AUTHOR("Marek Vasut ");
> MODULE_AUTHOR("Richard Zhao "); diff --git
> a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 34ad5bf8acd8..d9cfa00b8a6c 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -633,6 +633,6 @@ static struct platform_driver usbmisc_imx_driver =
> { module_platform_driver(usbmisc_imx_driver);
>
> MODULE_ALIAS("platform:usbmisc-imx");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("driver for imx usb non-core registers");
> MODULE_AUTHOR("Richard Zhao ");
Greg, does this is a useful change? I am not sure.
Peter
