Re: [PATCH v2 1/1] mm: pgtable: fix pte_swp_exclusive

2025-04-05 Thread Sam James
Sam James  writes:

> Lovely cleanup and a great suggestion from Al.
>
> Reviewed-by: Sam James 
>
> I'd suggest adding a:
> Suggested-by: Al Viro 

Al, were you planning on taking this through your tree?

>
> thanks,
> sam



Re: [PATCH v2 1/1] mm: pgtable: fix pte_swp_exclusive

2025-02-19 Thread Sam James
Lovely cleanup and a great suggestion from Al.

Reviewed-by: Sam James 

I'd suggest adding a:
Suggested-by: Al Viro 

thanks,
sam



Re: [PATCH v2 1/1] mm: pgtable: fix pte_swp_exclusive

2025-06-02 Thread Sam James
Al Viro  writes:

> On Sat, Apr 05, 2025 at 06:09:11PM +0100, Sam James wrote:
>> Sam James  writes:
>> 
>> > Lovely cleanup and a great suggestion from Al.
>> >
>> > Reviewed-by: Sam James 
>> >
>> > I'd suggest adding a:
>> > Suggested-by: Al Viro 
>> 
>> Al, were you planning on taking this through your tree?
>
> FWIW, I expected it to get sent to Linus as "please, run this
> sed script before -rc1" kind of thing, script being something
> like
>
> sed -i -e 's/int pte_swp_exclusive/bool pte_swp_exclusive/' \
>   `git grep -l 'int pte_swp_exclusive'`
>
> with suggested commit message...  It's absolutely regular and
> that kind of tree-wide change is easier handled that way.

Ah, sorry. Both Magnus and I are new and irregular kernel contributors,
but I've seen that before and should've thought of it.

> [...]

cheers,
sam