Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.
Dear Stanislav, On Mon, Feb 12, 2018 at 2:06 AM, Jaegeuk Kim wrote: > On 02/06, Stanislav Nijnikov wrote: >> This patch introduces attribute group to show existing sysfs entries. >> >> Signed-off-by: Stanislav Nijnikov >> --- /dev/null >> +++ b/drivers/scsi/ufs/ufs-sysfs.c >> @@ -0,0 +1,156 @@ >> +// SPDX-License-Identifier: GPL-2.0-only I commend you for using license ids here. But there is an issue with your attempt to use the latest and greatest license ids from SPDX: GPL-2.0-only is not a documented license id in our doc [1] Until this is updated (help welcomed including patching a few 10K+ files) , this should be GPL-2.0 instead to avoid confusion and keep things homogeneous and tidy. FYI, using only the doc as the reference was brought forward by Russell King and Christoph Hellwig and in particular with this: On Thu, Nov 9, 2017 at 5:44 PM, Russell King wrote: > I'd be more comfortable if we could have something in the kernel tree > that identifies the SPDX tags and their meaning, maybe with the > _standard_ file header for that license included, so there is no > argument about what any particular SPDX tag means. Based on this, Thomas Gleixner updated the doc alright following this important point. So, in case of doubt the doc should be the reference for this and nothing else. And if there are issue with the doc, then we can fix it with a patch ;) CC: Russell King CC: Christoph Hellwig CC: Thomas Gleixner [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne
Re: [PATCH] scsi: csiostor: remove unneeded DRIVER_LICENSE #define
On Fri, Nov 17, 2017 at 3:21 PM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference, especially when the string is defined in a .h file > far away from the .c file it is used in. > > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Varun Prakash > Reported-by: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Philippe Ombredanne -- Cordially Philippe Ombredanne
Re: [PATCH v6 1/5] scsi: ufs: add Hisilicon ufs driver code
Dear Li, On Thu, Dec 7, 2017 at 11:20 AM, Li Wei wrote: > add Hisilicon ufs driver code. > > Signed-off-by: Li Wei > Signed-off-by: Geng Jianfeng > Signed-off-by: Zang Leigang > Signed-off-by: Yu Jianfeng [] > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-hisi.c > @@ -0,0 +1,624 @@ > +/* > + * > + * HiSilicon Hi UFS Driver > + * > + * Copyright (c) 2016-2017 Linaro Ltd. > + * Copyright (c) 2016-2017 HiSilicon Technologies Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ Would you consider using the new SPDX license ids instead? Check Thomas doc patches for instructions. This would be great and while you are it may be this could be adopted for all HiSilicon and Huawei past, present and future contributions? Thank you for your kind consideration! -- Cordially Philippe Ombredanne
