[Bug 135031] New: error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868
https://bugzilla.kernel.org/show_bug.cgi?id=135031 Bug ID: 135031 Summary: error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868 Product: SCSI Drivers Version: 2.5 Kernel Version: error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: sym53c8xx Assignee: scsi_drivers-sym53c...@kernel-bugs.osdl.org Reporter: philby.map...@gmail.com Regression: No error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868 CALL quickbooks ((()))Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll help desk phone number... Contents [hide] QuickBooks pro Toll Free Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll help desk phone number... Contents [hide] QuickBooks pro Toll Free Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro support number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro pro help desk phone number... ~Help Usa@ +1-844-414-4868...((( QuickBooks pro payroll help desk phone number... Contents [hide] QuickBooks pro Toll Free, Intuit@(1-844-414-4868)@ QuickBooks pro Tech Support Phone Number provides online solution for all USA/CANADA clients. For any help of query call 1 844 414 4868 to get all QuickBooks pro account solution. @@Call, 1-844-414-4868 for all type help by QuickBooks pro tech support phone number, Intuit QuickBooks pro Tech Support Phone Number, QuickBooks pro Help Desk Phone Number, QuickBooks pro tech support number, QuickBooks pro technical support phone number,@@@ QuickBooks pro phone number, QuickBooks pro technical support number, QuickBooks pro support phone number, QuickBooks pro technical support, QuickBooks pro Customer Service Phone Number, QuickBooks pro Customer Service Number, QuickBooks pro Customer Support Phone Number, QuickBooks pro Customer Support Number, QuickBooks pro Customer Service Helpline Number, QuickBooks pro Customer Care Number, QuickBooks pro support team phone number, @ QuickBooks pro help number-QuickBooks pro Helpline Number; QuickBooks pro help phone number-QuickBooks pro Helpline Number, QuickBooks pro Tech Support Toll free Number, QuickBooks pro Support Telephone Number, QuickBooks pro Tech Support Telephone number, QuickBooks pro Tech Support contact number, QuickBooks pro support contact number, QuickBooks pro technical support contact number. Call, QuickBooks pro tech support phone number, Intuit QuickBooks pro Tech Support Phone Number, QuickBooks pro Help Desk Phone Number, QuickBooks pro tech support number, QuickBooks pro technical support phone number, QuickBooks pro phone number, QuickBooks pro technical support number, QuickBooks pro support phone number. It is very popular toll free number which provide by QuickBooks pro technical support, QuickBooks pro Customer Service Phone Number, QuickBooks pro Customer Service Number, QuickBooks pro Customer Support Phone Number, QuickBooks pro Customer Support Number, QuickBooks pro Customer Service Helpline Number, QuickBooks pro Customer Care Number, QuickBooks pro support team phone number. Call, QuickBooks pro tech support phone number, Intuit QuickBooks pro Tech Support Phone Number, QuickBooks pro Help Desk Phone Number, QuickBooks pro tech support number, QuickBooks pro technical support phone number, QuickBooks pro phone number, QuickBooks pro technical support number, QuickBooks pro support phone number, QuickBooks pro technical support, QuickBooks pro Customer Service Phone Number, QuickBooks pro Customer Service Number, QuickBooks pro Customer Support Phone Number, QuickBooks pro Customer Support Number, QuickBooks pro Customer Service Helpline Number, QuickBooks pro Customer Care Number, QuickBooks pro support team phone number, QuickBooks pro help number-
[patch] ibmvfc: prevent a potential deadlock
My static checker complains that we need to unlock on this path. Seems true. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index fc523c3..ab67ec4 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work) tgt_dbg(tgt, "Setting rport roles\n"); fc_remote_port_rolechg(rport, tgt->ids.roles); put_device(&rport->dev); + } else { + spin_unlock_irqrestore(vhost->host->host_lock, flags); } kref_put(&tgt->kref, ibmvfc_release_tgt); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/19] qla2xxx: Remove sysfs node fw_dump_template.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 89 > - > drivers/scsi/qla2xxx/qla_dbg.c | 1 + > 2 files changed, 1 insertion(+), 89 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/19] qla2xxx: Shutdown board on thermal shutdown aen.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_def.h | 1 + > drivers/scsi/qla2xxx/qla_isr.c | 7 +++ > drivers/scsi/qla2xxx/qla_os.c | 10 ++ > 4 files changed, 19 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/19] qla2xxx: Add ram area DDR for fwdump template entry T262.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_def.h | 2 ++ > drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- > drivers/scsi/qla2xxx/qla_tmpl.c | 9 - > 3 files changed, 15 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 04/19] qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Giridhar Malavali > > When VP decoupling enabled, there could be a window where, FLOGI from > initiators > can be dropped before VP0 is enabled, causing link level recovery. > Retry FLOGI to avoid link level recovery. > > Signed-off-by: Giridhar Malavali > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_init.c | 24 > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c > index 0671f07..907a7ac 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.c > +++ b/drivers/scsi/qla2xxx/qla_dbg.c > @@ -16,7 +16,7 @@ > * | || 0x016e-0x0170 | > * | Mailbox commands | 0x1192 | | > * | || | > - * | Device Discovery | 0x2016 | 0x2020-0x2022, | > + * | Device Discovery | 0x2003 | 0x2016 > | > * | || 0x2011-0x2012, | > * | || 0x2099-0x20a4 | > * | Queue Command and IO tracing | 0x3074 | 0x300b | > diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c > index c56cdb3..a3685b6 100644 > --- a/drivers/scsi/qla2xxx/qla_init.c > +++ b/drivers/scsi/qla2xxx/qla_init.c > @@ -2053,6 +2053,14 @@ qla2x00_update_fw_options(scsi_qla_host_t *vha) > if (IS_QLA6312(ha)) > ha->fw_options[2] |= BIT_13; > > + /* Set Retry FLOGI in case of P2P connection */ > + if (ha->operating_mode == P2P) { > + ha->fw_options[2] |= BIT_3; > + ql_dbg(ql_dbg_disc, vha, 0x2100, > + "(%s): Setting FLOGI retry BIT in fw_options[2]: 0x%x\n", > + __func__, ha->fw_options[2]); > + } > + > /* Update firmware options. */ > qla2x00_set_fw_options(vha, ha->fw_options); > } > @@ -2070,6 +2078,14 @@ qla24xx_update_fw_options(scsi_qla_host_t *vha) > if (ql2xfwholdabts) > ha->fw_options[3] |= BIT_12; > > + /* Set Retry FLOGI in case of P2P connection */ > + if (ha->operating_mode == P2P) { > + ha->fw_options[2] |= BIT_3; > + ql_dbg(ql_dbg_disc, vha, 0x2101, > + "(%s): Setting FLOGI retry BIT in fw_options[2]: 0x%x\n", > + __func__, ha->fw_options[2]); > + } > + > /* Update Serial Link options. */ > if ((le16_to_cpu(ha->fw_seriallink_options24[0]) & BIT_0) == 0) > return; > @@ -6513,6 +6529,14 @@ qla81xx_update_fw_options(scsi_qla_host_t *vha) > if (ql2xfwholdabts) > ha->fw_options[3] |= BIT_12; > > + /* Set Retry FLOGI in case of P2P connection */ > + if (ha->operating_mode == P2P) { > + ha->fw_options[2] |= BIT_3; > + ql_dbg(ql_dbg_disc, vha, 0x2103, > + "(%s): Setting FLOGI retry BIT in fw_options[2]: 0x%x\n", > + __func__, ha->fw_options[2]); > + } > + > if (!ql2xetsenable) > goto out; > > Is this bit available for all firmware versions? Or does one need a newer firmware here? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 05/19] qla2xxx: Add module parameter alternate/short names.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_os.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index dc608ce..f1a2394 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -80,6 +80,7 @@ MODULE_PARM_DESC(ql2xallocfwdump, > > int ql2xextended_error_logging; > module_param(ql2xextended_error_logging, int, S_IRUGO|S_IWUSR); > +module_param_named(logging, ql2xextended_error_logging, int, > S_IRUGO|S_IWUSR); > MODULE_PARM_DESC(ql2xextended_error_logging, > "Option to enable extended error logging,\n" > "\t\tDefault is 0 - no logging. 0x4000 - Module Init & > Probe.\n" > @@ -106,6 +107,7 @@ MODULE_PARM_DESC(ql2xshiftctondsd, > > int ql2xfdmienable=1; > module_param(ql2xfdmienable, int, S_IRUGO|S_IWUSR); > +module_param_named(fdmi, ql2xfdmienable, int, S_IRUGO|S_IWUSR); > MODULE_PARM_DESC(ql2xfdmienable, > "Enables FDMI registrations. " > "0 - no FDMI. Default is 1 - perform FDMI."); > @@ -157,6 +159,7 @@ MODULE_PARM_DESC(ql2xmultique_tag, > > int ql2xfwloadbin; > module_param(ql2xfwloadbin, int, S_IRUGO|S_IWUSR); > +module_param_named(fwload, ql2xfwloadbin, int, S_IRUGO|S_IWUSR); > MODULE_PARM_DESC(ql2xfwloadbin, > "Option to specify location from which to load ISP firmware:.\n" > " 2 -- load firmware via the request_firmware() (hotplug).\n" > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 06/19] qla2xxx: Make debug buffer log easier to view.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 33 ++--- > 1 file changed, 14 insertions(+), 19 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 08/19] qla2xxx: Properly reset firmware statistics.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 28 > drivers/scsi/qla2xxx/qla_bsg.c | 2 +- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_gbl.h | 2 +- > drivers/scsi/qla2xxx/qla_mbx.c | 18 -- > 5 files changed, 35 insertions(+), 17 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 07/19] qla2xxx: Properly initialize IO statistics.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Properly initialize IO statistics to avoid initial 0xFFF (-1) values. > > Cleanup/simplify usage of pointer to statistics structure. > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 50 > +++ > drivers/scsi/qla2xxx/qla_def.h| 1 - > drivers/scsi/qla2xxx/qla_init.c | 3 +++ > drivers/scsi/qla2xxx/qla_target.c | 16 ++--- > 4 files changed, 36 insertions(+), 34 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/19] qla2xxx: Check for device state before unloading the driver.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > During hot swap of PCI device, there can be PCI error on device, > during normal driver unload. The race between normal driver unload and > driver unload due to PCI error, can lead to system crash.Fix is to check > if there is unload going on and allow that function to unload the driver. > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_def.h | 1 + > drivers/scsi/qla2xxx/qla_mbx.c | 41 + > drivers/scsi/qla2xxx/qla_os.c | 21 + > 4 files changed, 52 insertions(+), 13 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/19] qla2xxx: Add bsg interface to support D_Port Diagnostics.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_bsg.c | 44 > drivers/scsi/qla2xxx/qla_bsg.h | 12 + > drivers/scsi/qla2xxx/qla_dbg.c | 3 +-- > drivers/scsi/qla2xxx/qla_gbl.h | 3 +++ > drivers/scsi/qla2xxx/qla_isr.c | 7 +++-- > drivers/scsi/qla2xxx/qla_mbx.c | 58 > +- > 6 files changed, 122 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] qla2xxx: Add bsg interface to support statistics counter reset.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_bsg.c | 48 > ++ > drivers/scsi/qla2xxx/qla_bsg.h | 1 + > 2 files changed, 26 insertions(+), 23 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/19] qla2xxx: Let DPORT be enabled purely by nvram.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_def.h | 1 + > drivers/scsi/qla2xxx/qla_init.c | 12 ++-- > 3 files changed, 8 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/19] qla2xxx: Add support to handle Loop Init error Asynchronus event.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_isr.c | 11 +-- > 2 files changed, 10 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 16/19] qla2xxx: Disable the adapter and skip error recovery in case of register disconnect.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > If there is error recovery going on due to command timeout and > there is register disconnect, then disable the adapter. > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 3 +++ > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_os.c | 55 > + > 3 files changed, 59 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 15/19] qla2xxx: Separate ISP type bits out from device type.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_def.h | 6 -- > drivers/scsi/qla2xxx/qla_os.c | 44 > +- > 2 files changed, 26 insertions(+), 24 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h > index c04d83e..ae4a747 100644 > --- a/drivers/scsi/qla2xxx/qla_def.h > +++ b/drivers/scsi/qla2xxx/qla_def.h > @@ -3130,7 +3130,7 @@ struct qla_hw_data { > #define PCI_DEVICE_ID_QLOGIC_ISP2271 0x2271 > #define PCI_DEVICE_ID_QLOGIC_ISP2261 0x2261 > > - uint32_tdevice_type; > + uint32_tisp_type; > #define DT_ISP2100 BIT_0 > #define DT_ISP2200 BIT_1 > #define DT_ISP2300 BIT_2 > @@ -3155,6 +3155,7 @@ struct qla_hw_data { > #define DT_ISP2261 BIT_21 > #define DT_ISP_LAST (DT_ISP2261 << 1) > > + uint32_tdevice_type; > #define DT_T10_PI BIT_25 > #define DT_IIDMABIT_26 > #define DT_FWI2 BIT_27 > @@ -3162,7 +3163,8 @@ struct qla_hw_data { > #define DT_OEM_001 BIT_29 > #define DT_ISP2200A BIT_30 > #define DT_EXTENDED_IDS BIT_31 > -#define DT_MASK(ha) ((ha)->device_type & (DT_ISP_LAST - 1)) > + > +#define DT_MASK(ha) ((ha)->isp_type & (DT_ISP_LAST - 1)) > #define IS_QLA2100(ha) (DT_MASK(ha) & DT_ISP2100) > #define IS_QLA2200(ha) (DT_MASK(ha) & DT_ISP2200) > #define IS_QLA2300(ha) (DT_MASK(ha) & DT_ISP2300) Hmm. I would've thought that you take the opportunity to reshuffle the device_type bit to start with '0'; as it stands now it doesn't really buy you anything right now... But anyway. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/19] qla2xxx: Correction to function qla26xx_dport_diagnostics().
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_isr.c | 8 +++- > drivers/scsi/qla2xxx/qla_mbx.c | 5 - > 3 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c > index 288338d..1a04270 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.c > +++ b/drivers/scsi/qla2xxx/qla_dbg.c > @@ -14,7 +14,7 @@ > * | Module Init and Probe| 0x0191 | 0x0146 | > * | || 0x015b-0x0160 > | > * | || 0x016e > | > - * | Mailbox commands | 0x1196 | | > + * | Mailbox commands | 0x1196 | 0x1193 > | > * | || | > * | Device Discovery | 0x2003 | 0x2016 > | > * | || 0x2011-0x2012, | > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 134ad2f..1b87977 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -1159,13 +1159,11 @@ global_port_update: > > case MBA_DPORT_DIAGNOSTICS: > ql_dbg(ql_dbg_async, vha, 0x5052, > - "D-Port Diagnostics: %04x result=%s index=%u size=%u\n", > + "D-Port Diagnostics: %04x result=%s\n", > mb[0], > mb[1] == 0 ? "start" : > - mb[1] == 1 ? "done (ok)" : > - mb[1] == 2 ? "done (error)" : "other", > - LSB(mb[2]), > - mb[3]); > + mb[1] == 1 ? "done (pass)" : > + mb[1] == 2 ? "done (error)" : "other"); > break; > > case MBA_TEMPERATURE_ALERT: > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > index 0f7b83a..bf16e6f 100644 > --- a/drivers/scsi/qla2xxx/qla_mbx.c > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > @@ -5764,11 +5764,6 @@ qla26xx_dport_diagnostics(scsi_qla_host_t *vha, > ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1192, > "Entered %s.\n", __func__); > > - if (size < 1024) { > - ql_log(ql_log_warn, vha, 0x1193, "Failed insufficient size.\n"); > - return QLA_FUNCTION_PARAMETER_ERROR; > - } > - > dd_dma = dma_map_single(&vha->hw->pdev->dev, > dd_buf, size, DMA_FROM_DEVICE); > if (!dd_dma) { > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/19] qla2xxx: Fix duplicate message id.
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 7 +++ > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > drivers/scsi/qla2xxx/qla_mbx.c | 4 ++-- > 3 files changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/21] lpfc: Fix Transgression Flag of Optical Element descriptor for RDP on Linux
On 07/06/2016 09:35 PM, James Smart wrote: > > Fix Transgression Flag of Optical Element descriptor for RDP on Linux > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 12 + > drivers/scsi/lpfc/lpfc_els.c | 101 > +- > drivers/scsi/lpfc/lpfc_hw.h | 6 +++ > drivers/scsi/lpfc/lpfc_hw4.h | 6 +-- > drivers/scsi/lpfc/lpfc_init.c | 2 + > 5 files changed, 101 insertions(+), 26 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 18/19] qla2xxx: Fix BBCR offset
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Fixes: 969a619 ("qla2xxx: Add support for buffer to buffer credit value for > ISP27XX.") > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_fw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx/qla_fw.h > index 4c0f3a7..8a2368b 100644 > --- a/drivers/scsi/qla2xxx/qla_fw.h > +++ b/drivers/scsi/qla2xxx/qla_fw.h > @@ -1288,7 +1288,7 @@ struct vp_rpt_id_entry_24xx { > > uint8_t vp_idx_map[16]; > > - uint8_t reserved_4[28]; > + uint8_t reserved_4[24]; > uint16_t bbcr; > uint8_t reserved_5[6]; > }; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/19] qla2xxx: Update driver version to 8.07.00.38-k
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > --- > drivers/scsi/qla2xxx/qla_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_version.h > b/drivers/scsi/qla2xxx/qla_version.h > index 0bc93fa..3cb1964 100644 > --- a/drivers/scsi/qla2xxx/qla_version.h > +++ b/drivers/scsi/qla2xxx/qla_version.h > @@ -7,7 +7,7 @@ > /* > * Driver version > */ > -#define QLA2XXX_VERSION "8.07.00.33-k" > +#define QLA2XXX_VERSION "8.07.00.38-k" > > #define QLA_DRIVER_MAJOR_VER 8 > #define QLA_DRIVER_MINOR_VER 7 > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/21] lpfc: Correct RDP response sizing issue
On 07/06/2016 09:35 PM, James Smart wrote: > > Correct RDP response sizing issue > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 113 > --- > drivers/scsi/lpfc/lpfc_hw.h | 26 +++--- > 2 files changed, 81 insertions(+), 58 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/21] lpfc: Add recovery from adapter parity errors on some SLI4 adapters
On 07/06/2016 09:35 PM, James Smart wrote: > > Add recovery from adapter parity errors on some SLI4 adapters > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 2 + > drivers/scsi/lpfc/lpfc_hw4.h | 23 > drivers/scsi/lpfc/lpfc_init.c | 118 > +++--- > drivers/scsi/lpfc/lpfc_sli.c | 45 ++-- > drivers/scsi/lpfc/lpfc_sli4.h | 2 + > 5 files changed, 155 insertions(+), 35 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 05/21] lpfc: Reject RDP ELS if port has no login
On 07/06/2016 09:35 PM, James Smart wrote: > > Reject RDP ELS if port has no login > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c > index 02e3a1f..861270e 100644 > --- a/drivers/scsi/lpfc/lpfc_els.c > +++ b/drivers/scsi/lpfc/lpfc_els.c > @@ -5243,6 +5243,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct > lpfc_iocbq *cmdiocb, >be32_to_cpu(rdp_req->nport_id_desc.nport_id), >be32_to_cpu(rdp_req->nport_id_desc.length)); > > + if (!(ndlp->nlp_flag & NLP_RPI_REGISTERED) && > + !phba->cfg_enable_SmartSAN) { > + rjt_err = LSRJT_UNABLE_TPC; > + rjt_expl = LSEXP_PORT_LOGIN_REQ; > + goto error; > + } > if (sizeof(struct fc_rdp_nport_desc) != > be32_to_cpu(rdp_req->rdp_des_length)) > goto rjt_logerr; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 04/21] lpfc: Correct Buffer credit descriptor values in RDP response
On 07/06/2016 09:35 PM, James Smart wrote: > > Correct Buffer credit descriptor values in RDP response > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 74 > +++- > drivers/scsi/lpfc/lpfc_hw.h | 2 +- > 2 files changed, 32 insertions(+), 44 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 06/21] lpfc: Add sysfs proc_name support
On 07/06/2016 09:35 PM, James Smart wrote: > > Add sysfs proc_name support > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_scsi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c > index 3bd0be6..12b8e82 100644 > --- a/drivers/scsi/lpfc/lpfc_scsi.c > +++ b/drivers/scsi/lpfc/lpfc_scsi.c > @@ -5886,6 +5886,7 @@ lpfc_disable_oas_lun(struct lpfc_hba *phba, struct > lpfc_name *vport_wwpn, > struct scsi_host_template lpfc_template_s3 = { > .module = THIS_MODULE, > .name = LPFC_DRIVER_NAME, > + .proc_name = LPFC_DRIVER_NAME, > .info = lpfc_info, > .queuecommand = lpfc_queuecommand, > .eh_abort_handler = lpfc_abort_handler, > @@ -5910,6 +5911,7 @@ struct scsi_host_template lpfc_template_s3 = { > struct scsi_host_template lpfc_template = { > .module = THIS_MODULE, > .name = LPFC_DRIVER_NAME, > + .proc_name = LPFC_DRIVER_NAME, > .info = lpfc_info, > .queuecommand = lpfc_queuecommand, > .eh_abort_handler = lpfc_abort_handler, > @@ -5935,6 +5937,7 @@ struct scsi_host_template lpfc_template = { > struct scsi_host_template lpfc_vport_template = { > .module = THIS_MODULE, > .name = LPFC_DRIVER_NAME, > + .proc_name = LPFC_DRIVER_NAME, > .info = lpfc_info, > .queuecommand = lpfc_queuecommand, > .eh_abort_handler = lpfc_abort_handler, > Hehe. Finally. We have been carrying a similar for ages in SLES :-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 07/21] lpfc: Add MDS Diagnostics Support
On 07/06/2016 09:36 PM, James Smart wrote: > > Add MDS Diagnostics Support > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 4 ++- > drivers/scsi/lpfc/lpfc_attr.c | 10 +++ > drivers/scsi/lpfc/lpfc_els.c | 7 + > drivers/scsi/lpfc/lpfc_hw4.h | 14 +- > drivers/scsi/lpfc/lpfc_init.c | 28 +++ > drivers/scsi/lpfc/lpfc_sli.c | 65 > --- > 6 files changed, 103 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 08/21] lpfc: Fix SLI mode 2 config failure
On 07/06/2016 09:36 PM, James Smart wrote: > > Fix SLI mode 2 config failure > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 6eef972..b1ddbaa 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -4696,6 +4696,8 @@ lpfc_sli_hba_setup(struct lpfc_hba *phba) > "Not supported by adapter.\n"); > if (rc && mode != 2) > rc = lpfc_sli_config_port(phba, 2); > + else if (rc && mode == 2) > + rc = lpfc_sli_config_port(phba, 3); > if (rc) > goto lpfc_sli_hba_setup_error; > > Hmm. Maybe a code reorg here if (rc) { if (mode == 2) .. else .. goto ... } would make things easier to read. But it's not that important. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/21] lpfc: Correct FCOE discovery to avoid loss of storage devices after system reboot
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct FCOE discovery to avoid loss of storage devices after system reboot > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index bb514d2..8d940ed 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -4484,7 +4484,8 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba, >* the corresponding FCF bit in the roundrobin bitmap. >*/ > spin_lock_irq(&phba->hbalock); > - if (phba->fcf.fcf_flag & FCF_DISCOVERY) { > + if ((phba->fcf.fcf_flag & FCF_DISCOVERY) && > + (phba->fcf.current_rec.fcf_indx != acqe_fip->index)) { > spin_unlock_irq(&phba->hbalock); > /* Update FLOGI FCF failover eligible FCF bmask */ > lpfc_sli4_fcf_rr_index_clear(phba, acqe_fip->index); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 10/21] lpfc: Re-organize source for easier device-id management
On 07/06/2016 09:36 PM, James Smart wrote: > > Re-organize source for easier device-id management > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ids.h | 122 > ++ > drivers/scsi/lpfc/lpfc_init.c | 101 +- > 2 files changed, 123 insertions(+), 100 deletions(-) > create mode 100644 drivers/scsi/lpfc/lpfc_ids.h > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/21] lpfc: Correct RDP response Revision location
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct RDP response Revision location > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_hw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h > index c99c2b3..8226543 100644 > --- a/drivers/scsi/lpfc/lpfc_hw.h > +++ b/drivers/scsi/lpfc/lpfc_hw.h > @@ -1239,8 +1239,8 @@ struct fc_rdp_opd_sfp_info { > uint8_tvendor_name[16]; > uint8_tmodel_number[16]; > uint8_tserial_number[16]; > - uint8_treserved[2]; > uint8_trevision[2]; > + uint8_treserved[2]; > uint8_tdate[8]; > }; > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/21] lpfc: Add support for XLane LUN priority
On 07/06/2016 09:36 PM, James Smart wrote: > > Add support for XLane LUN priority > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 89 > +-- > drivers/scsi/lpfc/lpfc_crtn.h | 2 +- > drivers/scsi/lpfc/lpfc_scsi.c | 9 - > drivers/scsi/lpfc/lpfc_scsi.h | 1 + > drivers/scsi/lpfc/lpfc_sli.c | 21 +++--- > drivers/scsi/lpfc/lpfc_sli.h | 1 + > 7 files changed, 104 insertions(+), 20 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 13/21] lpfc: Correct Port reset resulting in FC port going offline
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct Port reset resulting in FC port going offline > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 6e11574..f4b3548 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -1595,9 +1595,10 @@ lpfc_sli4_port_sta_fn_reset(struct lpfc_hba *phba, int > mbx_action, >* ready before performing reset. >*/ > rc = lpfc_sli4_pdev_status_reg_wait(phba); > - if (!rc) > + if (rc) > return rc; > } > + > /* need reset: attempt for port recovery */ > if (en_rn_msg) > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/21] lpfc: Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv lieu > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- > drivers/scsi/lpfc/lpfc_crtn.h | 1 - > drivers/scsi/lpfc/lpfc_init.c | 24 +--- > 3 files changed, 11 insertions(+), 22 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 15/21] lpfc: Remove global lpfc_delay_discovery attribute in leiu of per-hba lpfc_delay_discovery
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_delay_discovery attribute in leiu of per-hba > lpfc_delay_discovery > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 8 +++- > drivers/scsi/lpfc/lpfc_crtn.h | 1 - > drivers/scsi/lpfc/lpfc_els.c | 3 ++- > 4 files changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 16/21] lpfc: Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- > drivers/scsi/lpfc/lpfc_crtn.h | 1 - > drivers/scsi/lpfc/lpfc_sli.c | 12 ++-- > 4 files changed, 13 insertions(+), 13 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/21] lpfc: Re-organize source for easier driver attribute management
On 07/06/2016 09:36 PM, James Smart wrote: > > Re-organize source for easier driver attribute management > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_attr.c | 97 +-- > drivers/scsi/lpfc/lpfc_attr.h | 116 > ++ > 2 files changed, 117 insertions(+), 96 deletions(-) > create mode 100644 drivers/scsi/lpfc/lpfc_attr.h > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 18/21] lpfc: Correct issue with ioremap() call on 32bit kernel
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct issue with ioremap() call on 32bit kernel > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h > index 4d9f1b1..b484859 100644 > --- a/drivers/scsi/lpfc/lpfc.h > +++ b/drivers/scsi/lpfc/lpfc.h > @@ -785,9 +785,9 @@ struct lpfc_hba { > > atomic_t fcp_qidx; /* next work queue to post work to */ > > - unsigned long pci_bar0_map; /* Physical address for PCI BAR0 */ > - unsigned long pci_bar1_map; /* Physical address for PCI BAR1 */ > - unsigned long pci_bar2_map; /* Physical address for PCI BAR2 */ > + phys_addr_t pci_bar0_map; /* Physical address for PCI BAR0 */ > + phys_addr_t pci_bar1_map; /* Physical address for PCI BAR1 */ > + phys_addr_t pci_bar2_map; /* Physical address for PCI BAR2 */ > void __iomem *slim_memmap_p;/* Kernel memory mapped address for > PCI BAR0 */ > void __iomem *ctrl_regs_memmap_p;/* Kernel memory mapped address for > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/21] lpfc: Disable FDMI probing if not connected to a fabric
On 07/06/2016 09:36 PM, James Smart wrote: > > Disable FDMI probing if not connected to a fabric > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ct.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c > index a38816e..63e48d4 100644 > --- a/drivers/scsi/lpfc/lpfc_ct.c > +++ b/drivers/scsi/lpfc/lpfc_ct.c > @@ -1510,6 +1510,10 @@ lpfc_fdmi_num_disc_check(struct lpfc_vport *vport) > if (!lpfc_is_link_up(phba)) > return; > > + /* Must be connected to a Fabric */ > + if (!(vport->fc_flag & FC_FABRIC)) > + return; > + > if (!(vport->fdmi_port_mask & LPFC_FDMI_PORT_ATTR_num_disc)) > return; > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 20/21] lpfc: Copyright updates
On 07/06/2016 09:36 PM, James Smart wrote: > > Copyright updates > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_crtn.h | 2 +- > drivers/scsi/lpfc/lpfc_scsi.c | 2 +- > drivers/scsi/lpfc/lpfc_scsi.h | 2 +- > drivers/scsi/lpfc/lpfc_sli.h | 2 +- > drivers/scsi/lpfc/lpfc_sli4.h | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 21/21] lpfc: Update lpfc version to 11.2.0.0
On 07/06/2016 09:36 PM, James Smart wrote: > > Update lpfc version to 11.2.0.0 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_version.h > b/drivers/scsi/lpfc/lpfc_version.h > index fa0d531..c9bf20e 100644 > --- a/drivers/scsi/lpfc/lpfc_version.h > +++ b/drivers/scsi/lpfc/lpfc_version.h > @@ -18,7 +18,7 @@ > * included with this package. * > ***/ > > -#define LPFC_DRIVER_VERSION "11.1.0.0." > +#define LPFC_DRIVER_VERSION "11.2.0.0." > #define LPFC_DRIVER_NAME "lpfc" > > /* Used for SLI 2/3 */ > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] ibmvfc: prevent a potential deadlock
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [net-next 1/6] libcxgb: add library module for Chelsio drivers
> Add common library module(libcxgb.ko) for > Chelsio drivers to remove duplicate code. > > Code for iSCSI DDP Page Pod Manager is moved > from cxgb4.ko to libcxgb.ko. Earlier only cxgbit.ko > was using this code, now cxgb3i and cxgb4i will > also use common Page Pod manager code. > > In future this module will have common connection > management and hardware specific code that can be > shared by multiple Chelsio drivers. > > Signed-off-by: Varun Prakash > --- > drivers/net/ethernet/chelsio/Kconfig | 18 ++-- > drivers/net/ethernet/chelsio/Makefile | 1 + > drivers/net/ethernet/chelsio/cxgb4/Makefile| 1 - > drivers/net/ethernet/chelsio/libcxgb/Makefile | 3 +++ > .../{cxgb4/cxgb4_ppm.c => libcxgb/libcxgb_ppm.c} | 25 -- > .../{cxgb4/cxgb4_ppm.h => libcxgb/libcxgb_ppm.h} | 8 +++ > drivers/target/iscsi/cxgbit/Kconfig| 2 +- > drivers/target/iscsi/cxgbit/Makefile | 1 + > drivers/target/iscsi/cxgbit/cxgbit.h | 2 +- > 9 files changed, 41 insertions(+), 20 deletions(-) > create mode 100644 drivers/net/ethernet/chelsio/libcxgb/Makefile > rename drivers/net/ethernet/chelsio/{cxgb4/cxgb4_ppm.c => > libcxgb/libcxgb_ppm.c} (95%) > rename drivers/net/ethernet/chelsio/{cxgb4/cxgb4_ppm.h => > libcxgb/libcxgb_ppm.h} (98%) > > diff --git a/drivers/net/ethernet/chelsio/Kconfig > b/drivers/net/ethernet/chelsio/Kconfig > index 4686a85..1a5ce1e 100644 > --- a/drivers/net/ethernet/chelsio/Kconfig > +++ b/drivers/net/ethernet/chelsio/Kconfig > @@ -96,17 +96,6 @@ config CHELSIO_T4_DCB > > If unsure, say N. > > -config CHELSIO_T4_UWIRE > - bool "Unified Wire Support for Chelsio T5 cards" > - default n > - depends on CHELSIO_T4 > - ---help--- > - Enable unified-wire offload features. > - Say Y here if you want to enable unified-wire over Ethernet > - in the driver. > - > - If unsure, say N. > - > config CHELSIO_T4_FCOE > bool "Fibre Channel over Ethernet (FCoE) Support for Chelsio T5 cards" > default n > @@ -137,4 +126,11 @@ config CHELSIO_T4VF > To compile this driver as a module choose M here; the module > will be called cxgb4vf. > > +config CHELSIO_LIB > + tristate "Chelsio common library" > + default n > + ---help--- > + This is common library module for Chelsio T3/T4/T5/T6 > + drivers. > + > endif # NET_VENDOR_CHELSIO > diff --git a/drivers/net/ethernet/chelsio/Makefile > b/drivers/net/ethernet/chelsio/Makefile > index 390510b..b6a5eec 100644 > --- a/drivers/net/ethernet/chelsio/Makefile > +++ b/drivers/net/ethernet/chelsio/Makefile > @@ -6,3 +6,4 @@ obj-$(CONFIG_CHELSIO_T1) += cxgb/ > obj-$(CONFIG_CHELSIO_T3) += cxgb3/ > obj-$(CONFIG_CHELSIO_T4) += cxgb4/ > obj-$(CONFIG_CHELSIO_T4VF) += cxgb4vf/ > +obj-$(CONFIG_CHELSIO_LIB) += libcxgb/ > diff --git a/drivers/net/ethernet/chelsio/cxgb4/Makefile > b/drivers/net/ethernet/chelsio/cxgb4/Makefile > index 85c9282..ace0ab9 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/Makefile > +++ b/drivers/net/ethernet/chelsio/cxgb4/Makefile > @@ -7,5 +7,4 @@ obj-$(CONFIG_CHELSIO_T4) += cxgb4.o > cxgb4-objs := cxgb4_main.o l2t.o t4_hw.o sge.o clip_tbl.o cxgb4_ethtool.o > cxgb4-$(CONFIG_CHELSIO_T4_DCB) += cxgb4_dcb.o > cxgb4-$(CONFIG_CHELSIO_T4_FCOE) += cxgb4_fcoe.o > -cxgb4-$(CONFIG_CHELSIO_T4_UWIRE) += cxgb4_ppm.o > cxgb4-$(CONFIG_DEBUG_FS) += cxgb4_debugfs.o > diff --git a/drivers/net/ethernet/chelsio/libcxgb/Makefile > b/drivers/net/ethernet/chelsio/libcxgb/Makefile > new file mode 100644 > index 000..2362230 > --- /dev/null > +++ b/drivers/net/ethernet/chelsio/libcxgb/Makefile > @@ -0,0 +1,3 @@ > +obj-$(CONFIG_CHELSIO_LIB) += libcxgb.o > + > +libcxgb-y := libcxgb_ppm.o > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ppm.c > b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c > similarity index 95% > rename from drivers/net/ethernet/chelsio/cxgb4/cxgb4_ppm.c > rename to drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c > index d88a7a7..aa9a9bb 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ppm.c > +++ b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c > @@ -1,5 +1,5 @@ > /* > - * cxgb4_ppm.c: Chelsio common library for T4/T5 iSCSI PagePod Manager > + * libcxgb_ppm.c: Chelsio common library for T3/T4/T5 iSCSI PagePod Manager > * > * Copyright (c) 2016 Chelsio Communications, Inc. All rights reserved. > * > @@ -10,6 +10,10 @@ > * Written by: Karen Xie (k...@chelsio.com) > */ > > +#define DRV_NAME "libcxgb" > +#define DRV_VERSION "1.0.0-ko" > +#define pr_fmt(fmt) DRV_NAME ": " fmt > + > #include > #include > #include > @@ -22,7 +26,7 @@ > #include > #include > > -#include "cxgb4_ppm.h" > +#include "libcxgb_ppm.h" > > /* Direct Data Placement - > * Directly place the iSCSI Data-In or Data-Out PDU's payload into > @@ -462,3 +466,20 @@ unsigned int cxgbi_tagmask_set(unsigned int ppmax) > >
RE: [net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support
> Remove old ddp code from cxgb3i,cxgb4i,libcxgbi. > > Next two commits adds DDP support using > common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash > --- > drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 128 > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 142 - > drivers/scsi/cxgbi/libcxgbi.c | 578 - > drivers/scsi/cxgbi/libcxgbi.h | 161 --- > 4 files changed, 1009 deletions(-) Looks good. I guess this series needs to be squashed or we'll have bisect compile problems? Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [net-next 3/6] cxgb4i,libcxgbi: add iSCSI DDP support
> Add iSCSI DDP support in cxgb4i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash > --- > drivers/scsi/cxgbi/Makefile| 2 + > drivers/scsi/cxgbi/cxgb3i/Kbuild | 1 + > drivers/scsi/cxgbi/cxgb3i/Kconfig | 1 + Should the cxgb3i changes be in patch 4? > drivers/scsi/cxgbi/cxgb4i/Kbuild | 1 + > drivers/scsi/cxgbi/cxgb4i/Kconfig | 1 + > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 145 > drivers/scsi/cxgbi/libcxgbi.c | 331 + > drivers/scsi/cxgbi/libcxgbi.h | 27 ++- > 8 files changed, 507 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/Makefile b/drivers/scsi/cxgbi/Makefile > index 86007e3..a73781a 100644 > --- a/drivers/scsi/cxgbi/Makefile > +++ b/drivers/scsi/cxgbi/Makefile > @@ -1,2 +1,4 @@ > +ccflags-y += -Idrivers/net/ethernet/chelsio/libcxgb > + > obj-$(CONFIG_SCSI_CXGB3_ISCSI) += libcxgbi.o cxgb3i/ > obj-$(CONFIG_SCSI_CXGB4_ISCSI) += libcxgbi.o cxgb4i/ > diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild > index 961a12f..663c52e 100644 > --- a/drivers/scsi/cxgbi/cxgb3i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild > @@ -1,3 +1,4 @@ > ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3 > +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/libcxgb > > obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o > diff --git a/drivers/scsi/cxgbi/cxgb3i/Kconfig b/drivers/scsi/cxgbi/cxgb3i/Kconfig > index e460398..f68c871 100644 > --- a/drivers/scsi/cxgbi/cxgb3i/Kconfig > +++ b/drivers/scsi/cxgbi/cxgb3i/Kconfig > @@ -5,6 +5,7 @@ config SCSI_CXGB3_ISCSI > select ETHERNET > select NET_VENDOR_CHELSIO > select CHELSIO_T3 > + select CHELSIO_LIB > select SCSI_ISCSI_ATTRS > ---help--- > This driver supports iSCSI offload for the Chelsio T3 devices. > diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild > index 3745864..38e03c2 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild > @@ -1,3 +1,4 @@ > ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4 > +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/libcxgb > > obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o > diff --git a/drivers/scsi/cxgbi/cxgb4i/Kconfig b/drivers/scsi/cxgbi/cxgb4i/Kconfig > index 8c4e423..594f593 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/Kconfig > +++ b/drivers/scsi/cxgbi/cxgb4i/Kconfig > @@ -5,6 +5,7 @@ config SCSI_CXGB4_ISCSI > select ETHERNET > select NET_VENDOR_CHELSIO > select CHELSIO_T4 > + select CHELSIO_LIB > select SCSI_ISCSI_ATTRS > ---help--- > This driver supports iSCSI offload for the Chelsio T4 devices. > diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > index 2911214..521f9e4 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > @@ -1543,6 +1543,115 @@ int cxgb4i_ofld_init(struct cxgbi_device *cdev) > return 0; > } > > +static inline void > +ulp_mem_io_set_hdr(struct cxgbi_device *cdev, > +struct ulp_mem_io *req, > +unsigned int wr_len, unsigned int dlen, > +unsigned int pm_addr, > +int tid) > +{ nit: the type and function should be on the same line, yes? EG: static inline void ulp_mem_io_set_hdr(... > + struct cxgb4_lld_info *lldi = cxgbi_cdev_priv(cdev); > + struct ulptx_idata *idata = (struct ulptx_idata *)(req + 1); > + > + INIT_ULPTX_WR(req, wr_len, 0, tid); > + req->wr.wr_hi = htonl(FW_WR_OP_V(FW_ULPTX_WR) | > + FW_WR_ATOMIC_V(0)); > + req->cmd = htonl(ULPTX_CMD_V(ULP_TX_MEM_WRITE) | > + ULP_MEMIO_ORDER_V(is_t4(lldi->adapter_type)) | > + T5_ULP_MEMIO_IMM_V(!is_t4(lldi->adapter_type))); > + req->dlen = htonl(ULP_MEMIO_DATA_LEN_V(dlen >> 5)); > + req->lock_addr = htonl(ULP_MEMIO_ADDR_V(pm_addr >> 5)); > + req->len16 = htonl(DIV_ROUND_UP(wr_len - sizeof(req->wr), 16)); > + > + idata->cmd_more = htonl(ULPTX_CMD_V(ULP_TX_SC_IMM)); > + idata->len = htonl(dlen); > +} > + > +static struct sk_buff * > +ddp_ppod_init_idata(struct cxgbi_device *cdev, > + struct cxgbi_ppm *ppm, > + unsigned int idx, unsigned int npods, > + unsigned int tid) Same here > +{ > + unsigned int pm_addr = (idx << PPOD_SIZE_SHIFT) + ppm->llimit; > + unsigned int dlen = npods << PPOD_SIZE_SHIFT; > + unsigned int wr_len = roundup(sizeof(struct ulp_mem_io) + > + sizeof(struct ulptx_idata) + dlen, 16); > + struct sk_buff *skb = alloc_wr(wr_len, 0, GFP_ATOMIC); > + > + if (!skb) { > + pr_err("%s: %s idx %u, npods %u, OOM.\n", > +__func__, ppm->ndev->name, idx, npods); > + return NULL; > + } > + > + ulp_mem_io_set_hdr(cdev, (struct ulp_mem_io *)skb->hea
RE: [net-next 4/6] cxgb3i: add iSCSI DDP support
> Add iSCSI DDP support in cxgb3i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash Looks ok. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [net-next 5/6] libcxgb: export ppm release and tagmask set api
> Export cxgbi_ppm_release() to release > ppod manager and cxgbi_tagmask_set() to > set tag mask, they are used by cxgb3i, cxgb4i > and cxgbit. > > Signed-off-by: Varun Prakash Looks good. Reviewd-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning
> > Fix following sparse warnings > warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static? > warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static? > warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static? > > Signed-off-by: Varun Prakash looks fine. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] ibmvfc: prevent a potential deadlock
On Fri, 2016-07-15 at 14:18 +0300, Dan Carpenter wrote: > My static checker complains that we need to unlock on this path. Seems > true. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index fc523c3..ab67ec4 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct > *work) > tgt_dbg(tgt, "Setting rport roles\n"); > fc_remote_port_rolechg(rport, > tgt->ids.roles); > put_device(&rport->dev); > + } else { > + > spin_unlock_irqrestore(vhost->host->host_lock, flags); > } > > kref_put(&tgt->kref, ibmvfc_release_tgt); > -- Reviewed-by: Ewan D. Milne -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR
> "Johannes" == Johannes Thumshirn writes: Johannes> qla2xxx first calls request_irq() and then does the setup of Johannes> the queue entry data needed in the interrupt handlers in when Johannes> using MSI-X. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: PR API fixes for multipathing
> "Christoph" == Christoph Hellwig writes: Christoph> I was a bit overeager to thing ALL_TG_PT would solve all our Christoph> multipathing woes in respect to persistent reservation. Christoph> Turns out that there are lots of possible setups where it Christoph> doesn't work, and we'll have to ask device mapper to register Christoph> all underlying devices instead. Should I queue the sd patch or let Mike take both through the DM tree? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mpt3sas: Fix panic when aer correct error occured
> "Kefeng" == Kefeng Wang writes: Kefeng> The _scsih_pci_mmio_enabled called if scsih_pci_error_detected Kefeng> returns PCI_ERS_RESULT_CAN_RECOVER, at this point, read/write to Kefeng> the device still works, no need to reset slot. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] scsi: ufs: tc-dwc-g210 driver fix for 20-bit RMMI
> "Manjunath" == Manjunath M B writes: Manjunath> The code was checking on PA_CONNECTEDRXLANES and Manjunath> PA_CONNECTEDTXLANES attributes to program the Lane#1 Manjunath> attributes. The correct attributes are PA_AVAILRXDATALANES Manjunath> and PA_AVAILTXDATALANES respectively. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] scsi: remove the disable_blk_mq host flag
> "Christoph" == Christoph Hellwig writes: Christoph> We've had scsi-mq for 2.5 years now, so we can remove the Christoph> unused flag to disable the code on a per-host basis that was Christoph> put in for unexpected emergencies during bringup. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer
> "Hans" == Hans de Goede writes: Hans> Oliver Neukum is taking over uas maintainership from me and Gerd Hans> Hoffmann. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] scsi: lpfc: avoid harmless comparison warning
Patch is good. Thanks -- james Signed-off-by: James Smart On 6/15/2016 1:42 PM, Arnd Bergmann wrote: When building with -Wextra, we get a lot of warnings for the lpfc driver concerning expressions that are always true, starting with: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init': drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_rrq_init': drivers/scsi/lpfc/lpfc_attr.c:2802:76: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_suppress_link_up_init': drivers/scsi/lpfc/lpfc_attr.c:2812:2050: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_log_verbose_init': drivers/scsi/lpfc/lpfc_attr.c:3064:1930: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] The code works as intented, but it would be nice to shut up the warning so we don't clutter up build logs with this. Using a separate inline function for it makes it clear to the compiler that the comparison is necessary in the caller but still lets it do the constant-folding. Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_attr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index cfec2eca4dd3..3e1d2e669902 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -1620,6 +1620,11 @@ lpfc_sriov_hw_max_virtfn_show(struct device *dev, return snprintf(buf, PAGE_SIZE, "%d\n", max_nr_virtfn); } +static inline bool lpfc_rangecheck(uint val, uint min, uint max) +{ + return val >= min && val <= max; +} + /** * lpfc_param_show - Return a cfg attribute value in decimal * @@ -1697,7 +1702,7 @@ lpfc_##attr##_show(struct device *dev, struct device_attribute *attr, \ static int \ lpfc_##attr##_init(struct lpfc_hba *phba, uint val) \ { \ - if (val >= minval && val <= maxval) {\ + if (lpfc_rangecheck(val, minval, maxval)) {\ phba->cfg_##attr = val;\ return 0;\ }\ @@ -1732,7 +1737,7 @@ lpfc_##attr##_init(struct lpfc_hba *phba, uint val) \ static int \ lpfc_##attr##_set(struct lpfc_hba *phba, uint val) \ { \ - if (val >= minval && val <= maxval) {\ + if (lpfc_rangecheck(val, minval, maxval)) {\ lpfc_printf_log(phba, KERN_ERR, LOG_INIT, \ "3052 lpfc_" #attr " changed from %d to %d\n", \ phba->cfg_##attr, val); \ @@ -1856,7 +1861,7 @@ lpfc_##attr##_show(struct device *dev, struct device_attribute *attr, \ static int \ lpfc_##attr##_init(struct lpfc_vport *vport, uint val) \ { \ - if (val >= minval && val <= maxval) {\ + if (lpfc_rangecheck(val, minval, maxval)) {\ vport->cfg_##attr = val;\ return 0;\ }\ @@ -1888,7 +1893,7 @@ lpfc_##attr##_init(struct lpfc_vport *vport, uint val) \ static int \ lpfc_##attr##_set(struct lpfc_vport *vport, uint val) \ { \ - if (val >= minval && val <= maxval) {\ + if (lpfc_rangecheck(val, minval, maxval)) {\ lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT, \ "3053 lpfc_" #attr \ " changed from %d (x%x) to %d (x%x)\n", \ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] ibmvfc: prevent a potential deadlock
> "Dan" == Dan Carpenter writes: Dan> My static checker complains that we need to unlock on this path. Dan> Seems true. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/21] lpfc: Update to revision 11.2.0.0
> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.2.0.00 Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] qla2xxx: Patches for scsi "misc" branch.
> "Himanshu" == Himanshu Madhani writes: Himanshu> Please apply the following patches to the scsi tree, misc Himanshu> branch at your earliest convenience. Applied to 4.8/scsi-queue. I folded the compiler fix into the offending commit. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] hpsa update
> "Don" == Don Brace writes: Don> These patches are based on Linus's tree The changes are: - enhanced Don> check for skipping masked devices - corrected hpsa_passthru_ioctl Don> timeouts for fw flash Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] scsi: ufs: remove unnecessary goto label
> "Tiezhu" == Tiezhu Yang writes: Tiezhu> When buff_ascii kmalloc failed, there is no need to call kfree, Tiezhu> it should return -ENOMEM directly, this patch fixes it. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/1] ipr: Wait to do async scan until scsi host is initialized
When performing an async scan, make sure the kthread doing scanning doesn't start before the scsi host is fully initialized. Signed-off-by: Brian King --- drivers/scsi/ipr.c |9 + drivers/scsi/ipr.h |1 + 2 files changed, 10 insertions(+) diff -puN drivers/scsi/ipr.c~ipr_async_scan_fixup drivers/scsi/ipr.c --- linux-2.6.git/drivers/scsi/ipr.c~ipr_async_scan_fixup 2016-07-15 14:47:13.412003811 -0500 +++ linux-2.6.git-bjking1/drivers/scsi/ipr.c2016-07-15 14:47:13.422003757 -0500 @@ -3288,6 +3288,11 @@ static void ipr_worker_thread(struct wor return; } + if (!ioa_cfg->scan_enabled) { + spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); + return; + } + restart: do { did_work = 0; @@ -10362,6 +10367,7 @@ static void ipr_remove(struct pci_dev *p static int ipr_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id) { struct ipr_ioa_cfg *ioa_cfg; + unsigned long flags; int rc, i; rc = ipr_probe_ioa(pdev, dev_id); @@ -10414,7 +10420,10 @@ static int ipr_probe(struct pci_dev *pde } } + spin_lock_irqsave(ioa_cfg->host->host_lock, flags); + ioa_cfg->scan_enabled = 1; schedule_work(&ioa_cfg->work_q); + spin_unlock_irqrestore(ioa_cfg->host->host_lock, flags); return 0; } diff -puN drivers/scsi/ipr.h~ipr_async_scan_fixup drivers/scsi/ipr.h --- linux-2.6.git/drivers/scsi/ipr.h~ipr_async_scan_fixup 2016-07-15 14:47:13.415003795 -0500 +++ linux-2.6.git-bjking1/drivers/scsi/ipr.h2016-07-15 14:47:13.424003746 -0500 @@ -1478,6 +1478,7 @@ struct ipr_ioa_cfg { u8 in_ioa_bringdown:1; u8 ioa_unit_checked:1; u8 dump_taken:1; + u8 scan_enabled:1; u8 scan_done:1; u8 needs_hard_reset:1; u8 dual_raid:1; _ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[BUG] Slab corruption during XFS writeback under memory pressure
Hello all, I've found a nasty source of slab corruption. Based on seeing similar symptoms on boxes at Facebook, I suspect it's been around since at least 3.10. It only reproduces under memory pressure so far as I can tell: the issue seems to be that XFS reclaims pages from buffers that are still in use by scsi/block. I'm not sure which side the bug lies on, but I've only observed it with XFS. [67203.776421] == [67203.792521] BUG: KASAN: use-after-free in xfs_destroy_ioend+0x3bf/0x4c0 at addr 8804cf466288 [67203.812036] Read of size 8 by task python2.7/22913 [67203.822713] = [67203.840917] BUG buffer_head (Not tainted): kasan: bad access detected [67203.855253] - [67203.855253] [67203.876727] Disabling lock debugging due to kernel taint [67203.888575] INFO: Allocated in 0x8804cf465d40 age=18437180719206552994 cpu=2191548261 pid=-1 [67203.908139] alloc_buffer_head+0x22/0xd0 [67203.916903] ___slab_alloc+0x4e0/0x520 [67203.925286] __slab_alloc+0x43/0x70 [67203.933087] kmem_cache_alloc+0x228/0x2c0 [67203.942042] alloc_buffer_head+0x22/0xd0 [67203.950782] alloc_page_buffers+0xa9/0x1f0 [67203.959936] create_empty_buffers+0x30/0x420 [67203.969495] create_page_buffers+0x120/0x1b0 [67203.979029] __block_write_begin+0x16b/0x1010 [67203.988756] xfs_vm_write_begin+0x55/0x1b0 [67203.997884] generic_perform_write+0x288/0x510 [67204.007771] xfs_file_buffered_aio_write+0x316/0x780 [67204.018811] xfs_file_write_iter+0x26f/0x6c0 [67204.028313] __vfs_write+0x2a0/0x620 [67204.036276] vfs_write+0x159/0x4c0 [67204.043855] SyS_write+0xd2/0x1b0 [67204.051245] INFO: Freed in 0x103fc80ec age=18446651500051355200 cpu=2165122683 pid=-1 [67204.068634] free_buffer_head+0x41/0x90 [67204.077175] __slab_free+0x1ed/0x340 [67204.085138] kmem_cache_free+0x270/0x300 [67204.093867] free_buffer_head+0x41/0x90 [67204.102422] try_to_free_buffers+0x171/0x240 [67204.111925] xfs_vm_releasepage+0xcb/0x3b0 [67204.121101] try_to_release_page+0x106/0x190 [67204.130602] shrink_page_list+0x118e/0x1a10 [67204.139910] shrink_inactive_list+0x42c/0xdf0 [67204.149600] shrink_zone_memcg+0xa09/0xfa0 [67204.158715] shrink_zone+0x2c3/0xbc0 [67204.166679] do_try_to_free_pages+0x42a/0x12f0 [67204.176562] try_to_free_pages+0x1a3/0x5d0 [67204.185709] __alloc_pages_nodemask+0xbeb/0x20d0 [67204.195979] alloc_pages_vma+0x11b/0x5e0 [67204.204709] handle_mm_fault+0x2c27/0x47d0 [67204.213823] INFO: Slab 0xea00133d1900 objects=37 used=14 fp=0x8804cf464530 flags=0x20004080 [67204.235439] INFO: Object 0x8804cf466260 @offset=8800 fp=0x [67204.235439] [67204.455817] CPU: 1 PID: 22913 Comm: python2.7 Tainted: GB 4.7.0-rc7-calvinowens-1468357363-1-gcaa3dc6 #1 [67204.480313] Hardware name: Wiwynn HoneyBadger/PantherPlus, BIOS HBM6.71 02/03/2016 [67204.497509] 88075e99f480 88075ec87a30 81e8b8e4 8804cf464000 [67204.514224] 8804cf466260 88075ec87a60 8153a995 88075e99f480 [67204.530924] ea00133d1900 8804cf466260 dc00 88075ec87a88 [67204.547624] Call Trace: [67204.553086][] dump_stack+0x68/0x94 [67204.565946] [] print_trailer+0x115/0x1a0 [67204.578334] [] object_err+0x34/0x40 [67204.589762] [] kasan_report_error+0x217/0x530 [67204.616847] [] __asan_report_load8_noabort+0x43/0x50 [67204.645085] [] xfs_destroy_ioend+0x3bf/0x4c0 [67204.658243] [] xfs_end_bio+0x154/0x220 [67204.685362] [] bio_endio+0x158/0x1b0 [67204.696983] [] blk_update_request+0x18b/0xb80 [67204.710334] [] scsi_end_request+0x97/0x5a0 [67204.723108] [] scsi_io_completion+0x438/0x1690 [67204.807293] [] scsi_finish_command+0x375/0x4e0 [67204.820838] [] scsi_softirq_done+0x280/0x340 [67204.848884] [] blk_done_softirq+0x1ff/0x360 [67204.875074] [] __do_softirq+0x22d/0x8d7 [67204.887270] [] irq_exit+0x15c/0x190 [67204.898697] [] smp_apic_timer_interrupt+0x83/0xa0 [67204.912815] [] apic_timer_interrupt+0x89/0x90 [67205.029113] == Another ASAN trace: [10856.599645] == [10856.614109] BUG: KASAN: use-after-free in xfs_destroy_ioend+0x3b5/0x4c0 at addr 88006be5db90 [10856.631696] Read of size 8 by task kworker/13:1/314 [10856.641464] = [10856.657836] BUG buffer_head (Tainted: GB ): kasan: bad access detected [10856.673158] - [10856.673158] [10856.692477] INFO: Allocated in 0x88006be5c378 age=18445973393378446689 cpu=2191548517 pid=-1 [10856.710062] alloc_buffer_head+0x22/0xd0 [10856.717928] ___slab_alloc+0x4e0/0x520 [
Re: PR API fixes for multipathing
On Fri, Jul 15, 2016 at 03:03:54PM -0400, Martin K. Petersen wrote: > > "Christoph" == Christoph Hellwig writes: > > Christoph> I was a bit overeager to thing ALL_TG_PT would solve all our > Christoph> multipathing woes in respect to persistent reservation. > Christoph> Turns out that there are lots of possible setups where it > Christoph> doesn't work, and we'll have to ask device mapper to register > Christoph> all underlying devices instead. > > Should I queue the sd patch or let Mike take both through the DM tree? I think having both in the same tree would be very useful. I don't care which one that is. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html