RE: [RFC,1/8] soc/fman: Add FMan MURAM support

2015-04-20 Thread igal.liber...@freescale.com


Regards,
Igal Liberman.

> -Original Message-
> From: Kumar Gala [mailto:ga...@kernel.crashing.org]
> Sent: Thursday, March 12, 2015 5:57 PM
> To: Liberman Igal-B31950
> Cc: linuxppc-...@lists.ozlabs.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Wood Scott-B07421
> Subject: Re: [RFC,1/8] soc/fman: Add FMan MURAM support
> 
> 
> On Mar 11, 2015, at 12:07 AM, Igal.Liberman 
> wrote:
> 
> > From: Igal Liberman 
> >
> > Add Frame Manager Multi-User RAM support.
> >
> > Signed-off-by: Igal Liberman 
> > ---
> > drivers/soc/fsl/fman/Kconfig|1 +
> > drivers/soc/fsl/fman/Makefile   |5 +-
> > drivers/soc/fsl/fman/fm_muram.c |  174
> +++
> > drivers/soc/fsl/fman/inc/fm_muram_ext.h |   98 +
> > 4 files changed, 276 insertions(+), 2 deletions(-) create mode 100644
> > drivers/soc/fsl/fman/fm_muram.c create mode 100644
> > drivers/soc/fsl/fman/inc/fm_muram_ext.h
> >
> 
> use lib/genalloc instead of rheap
> 

Hi Kumar,
I looked into lib/genalloc allocator.
As far as I see, the genalloc allocator doesn't allow to control the memory 
alignment when you allocate a chunk of memory.
Two important notes regarding MURAM memory:
- The allocated memory chunks should have specific alignment (might be 
different in each chunk).
- The allocations must be efficient, we don't want to "waste" MURAM due to 
alignment issues.

> - k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [v2,00/11] Freescale DPAA FMan FLIB(s)

2015-03-12 Thread igal.liber...@freescale.com
Hello, 

In v2 of DPAA FMan FLIBs we've made the following updates:
- Split the header patch ([v2,01/11] soc/fman: Add the FMan FLIB headers) from 
one big patch to smaller patches - Kumar's feedback.
- Removed the KILOBYTE defines - Kumar's feedback.
- Addressed several comments from Scott on [v2,02/11] soc/fman: Add the FMan 
FLIB.

Best regards,
Igal Liberman.

> -Original Message-
> From: Igal.Liberman [mailto:igal.liber...@freescale.com]
> Sent: Wednesday, March 11, 2015 7:04 AM
> To: linuxppc-...@lists.ozlabs.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: Wood Scott-B07421; Liberman Igal-B31950
> Subject: [v2,00/11] Freescale DPAA FMan FLIB(s)
> 
> From: Igal Liberman 
> 
> The Freescale Data Path Acceleration Architecture (DPAA) is a set of
> hardware components on specific QorIQ multicore processors. This
> architecture provides the infrastructure to support simplified sharing of
> networking interfaces and accelerators by multiple CPU cores and the
> accelerators.
> 
> One of the DPAA accelerators is the Frame Manager (FMan) which enables
> the Ethernet network interfaces.
> 
> This patch presents the FMan Foundation Libraries (FLIB) headers.
> The FMan FLIB adds basic support for the DPAA FMan hardware register
> access.
> 
> Igal Liberman (7):
>   soc/fman: Add the FMan FLIB headers
>   soc/fman: Add the FMan FLIB
>   soc/fman: Add the FMan port FLIB
>   soc/fman: Add the FMan MAC FLIB
>   soc/fman: Add the FMan parser and KeyGen FLIB(s)
>   soc/fman: Add the FMan RTC FLIB
>   soc/fman: Add the FMan SP FLIB
> 
> Madalin Bucur (4):
>   soc/fman: Add the FMan port FLIB headers
>   soc/fman: Add the FMan MAC FLIB headers
>   soc/fman: Add the FMan parser and KeyGen FLIB headers
>   soc/fman: Add the FMan RTC FLIB header
> 
>  drivers/soc/Kconfig|1 +
>  drivers/soc/Makefile   |1 +
>  drivers/soc/fsl/Kconfig|1 +
>  drivers/soc/fsl/Makefile   |1 +
>  drivers/soc/fsl/fman/Kconfig   |   35 +
>  drivers/soc/fsl/fman/Makefile  |   11 +
>  drivers/soc/fsl/fman/flib/common/general.h |   41 +
>  drivers/soc/fsl/fman/flib/fman_common.h|   73 +
>  drivers/soc/fsl/fman/flib/fsl_enet.h   |  275 
>  drivers/soc/fsl/fman/flib/fsl_fman.h   |  802 ++
>  drivers/soc/fsl/fman/flib/fsl_fman_dtsec.h | 1016 +
>  drivers/soc/fsl/fman/flib/fsl_fman_dtsec_mii_acc.h |  103 ++
>  drivers/soc/fsl/fman/flib/fsl_fman_kg.h|  505 +++
>  drivers/soc/fsl/fman/flib/fsl_fman_memac.h |  494 +++
>  drivers/soc/fsl/fman/flib/fsl_fman_memac_mii_acc.h |   76 +
>  drivers/soc/fsl/fman/flib/fsl_fman_port.h  |  601 
>  drivers/soc/fsl/fman/flib/fsl_fman_prs.h   |  106 ++
>  drivers/soc/fsl/fman/flib/fsl_fman_rtc.h   |  414 ++
>  drivers/soc/fsl/fman/flib/fsl_fman_sp.h|  132 ++
>  drivers/soc/fsl/fman/flib/fsl_fman_tgec.h  |  483 ++
>  drivers/soc/fsl/fman/fman.c| 1355 +
>  drivers/soc/fsl/fman/mac/Makefile  |5 +
>  drivers/soc/fsl/fman/mac/fman_crc32.c  |  116 ++
>  drivers/soc/fsl/fman/mac/fman_crc32.h  |   39 +
>  drivers/soc/fsl/fman/mac/fman_dtsec.c  |  838 +++
>  drivers/soc/fsl/fman/mac/fman_dtsec_mii_acc.c  |  168 +++
>  drivers/soc/fsl/fman/mac/fman_memac.c  |  510 +++
>  drivers/soc/fsl/fman/mac/fman_memac_mii_acc.c  |  217 +++
>  drivers/soc/fsl/fman/mac/fman_tgec.c   |  371 +
>  drivers/soc/fsl/fman/pcd/Makefile  |3 +
>  drivers/soc/fsl/fman/pcd/fman_kg.c |  849 +++
>  drivers/soc/fsl/fman/pcd/fman_prs.c|  126 ++
>  drivers/soc/fsl/fman/port/Makefile |3 +
>  drivers/soc/fsl/fman/port/fman_port.c  | 1535
> 
>  drivers/soc/fsl/fman/rtc/Makefile  |3 +
>  drivers/soc/fsl/fman/rtc/fman_rtc.c|  353 +
>  drivers/soc/fsl/fman/sp/Makefile   |3 +
>  drivers/soc/fsl/fman/sp/fman_sp.c  |  203 +++
>  38 files changed, 11868 insertions(+)
>  create mode 100644 drivers/soc/fsl/Kconfig  create mode 100644
> drivers/soc/fsl/Makefile  create mode 100644 drivers/soc/fsl/fman/Kconfig
> create mode 100644 drivers/soc/fsl/fman/Makefile  create mode 100644
> drivers/soc/fsl/fman/flib/common/general.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fman_common.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fsl_enet.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fsl_fman.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fsl_fman_dtsec.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fsl_fman_dtsec_mii_acc.h
>  create mode 100644 drivers/soc/fsl/fman/flib/fsl_fman_kg.h
>