[PATCH] correctly name the Shell sort
This patch was previously sent on 2005-02-13: http://marc.theaimsgroup.com/?l=linux-kernel&m=110826336917607&w=2 It still applies against 2.6.12-rc1-bk1. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
question about build.c
x86_64 checks if we're building a big kernel to make sure that it's <= 4MB. Should we be doing something similar for i386? Or perhaps we shouldn't be
imposing this limit on x86_64?
Below is the relevant code diff that I'm asking about.
Thanks,
Daniel
--- linux-2.6.12-rc1-bk1/arch/i386/boot/tools/build.c 2005-03-02
02:38:09.0 -0500
+++ linux-2.6.12-rc1-bk1/arch/x86_64/boot/tools/build.c 2005-03-02
02:38:37.0 -0500
@@ -150,8 +150,10 @@
sz = sb.st_size;
fprintf (stderr, "System is %d kB\n", sz/1024);
sys_size = (sz + 15) / 16;
- if (!is_big_kernel && sys_size > DEF_SYSSIZE)
- die("System is too big. Try using bzImage or modules.");
+ /* 0x4*16 = 4.0 MB, reasonable estimate for the current maximum */
+ if (sys_size > (is_big_kernel ? 0x4 : DEF_SYSSIZE))
+ die("System is too big. Try using %smodules.",
+ is_big_kernel ? "" : "bzImage or ");
while (sz > 0) {
int l, n;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] correctly name the Shell sort
As per http://www.nist.gov/dads/HTML/shellsort.html, this should be referred to
as a Shell sort. Shell-Metzner is a misnomer.
Signed-off-by: Daniel Dickman <[EMAIL PROTECTED]>
--- linux-2.6.11-rc3-bk9/kernel/sys.c 2005-02-12 22:17:26.801294776 -0500
+++ linux/kernel/sys.c 2005-02-12 17:53:15.0 -0500
@@ -1192,7 +1192,7 @@
return 0;
}
-/* a simple shell-metzner sort */
+/* a simple Shell sort */
static void groups_sort(struct group_info *group_info)
{
int base, max, stride;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[no subject]
For the m32r architecture, is there a reason not to use the generic bug.h
definition?
Signed-off-by: Daniel Dickman <[EMAIL PROTECTED]>
--- linux-2.6.11-rc4/include/asm-m32r/bug.h 2004-12-24 16:34:01.0
-0500
+++ linux/include/asm-m32r/bug.h2005-02-13 03:39:39.775236000 -0500
@@ -1,22 +1,4 @@
#ifndef _M32R_BUG_H
#define _M32R_BUG_H
-
-#define BUG() do { \
- printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
-} while (0)
-
-#define PAGE_BUG(page) do { BUG(); } while (0)
-
-#define BUG_ON(condition) \
- do { if (unlikely((condition)!=0)) BUG(); } while(0)
-
-#define WARN_ON(condition) do { \
- if (unlikely((condition)!=0)) { \
- printk("Badness in %s at %s:%d\n", __FUNCTION__, \
- __FILE__, __LINE__); \
- dump_stack(); \
- } \
-} while (0)
-
-#endif /* _M32R_BUG_H */
-
+#include
+#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: obsolete code must die
Hi Andrew, Thanks for your email. I am aware of the "traditions" of the Linux kernel, and this is really why I wanted to start a discussion going about this. Basically one of the things I am wondering is how complex the kernel code can grow to become. All I am proposing is that old features start becoming deprecated and eventually removed. What I'd like to know is this -- will support for the i386, say, ever go away? What if the hardware is no longer in existence/used by anyone? will support stay in the kernel? This is the main point I wanted to make, and I guess I should have been clearer about this. Daniel - Original Message - From: "Andrew Pimlott" <[EMAIL PROTECTED]> To: "Daniel" <[EMAIL PROTECTED]> Sent: Wednesday, June 13, 2001 8:47 PM Subject: Re: obsolete code must die > Do you realize how violently your suggestions conflict with the > goals, practices, and traditions of Linux? I don't mean any > offense, but you should really learn more about Linux development > before making broad suggestions. > > Andrew - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: obsolete code must die
Okay, I didn't realize how much opposition there would be to this, thanks for all the input. If you'd like to add anything to this, please email me personally -- the mailing list has probably seen enough traffic regarding this issue. :-) Thanks Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] to init/main.c
Here is a small patch to main.c.
It does the following:
- makes sure that asm/mtrr.h actually gets included, and
- changes formatting in one place as per Documentation/CodingStyle
--- linux-2.4.5/init/main.c Tue May 22 12:35:42 2001
+++ linux/init/main.c Sat Jun 16 11:48:42 2001
@@ -50,7 +50,7 @@
#endif
#ifdef CONFIG_MTRR
-# include
+#include
#endif
#ifdef CONFIG_NUBUS
@@ -292,8 +292,7 @@
ROOT_DEV = name_to_kdev_t(line);
memset (root_device_name, 0, sizeof root_device_name);
if (strncmp (line, "/dev/", 5) == 0) line += 5;
- for (i = 0; i < sizeof root_device_name - 1; ++i)
- {
+ for (i = 0; i < sizeof root_device_name - 1; ++i) {
ch = line[i];
if ( isspace (ch) || (ch == ',') || (ch == '\0') ) break;
root_device_name[i] = ch;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
