Re: [PATCH v3 01/10] arm: sunxi: add support for R40 SoC

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:22 PM, Icenowy Zheng  wrote:
> Allwinner R40 is a new SoC, with Quad Core Cortex-A7 and peripherals
> like A20.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng 
> ---
> Changes in v3:
> - Use V1.0 documents.
>
>  Documentation/arm/sunxi/README  | 6 ++
>  Documentation/devicetree/bindings/arm/sunxi.txt | 1 +
>  arch/arm/mach-sunxi/sunxi.c | 1 +
>  3 files changed, 8 insertions(+)
>
> diff --git a/Documentation/arm/sunxi/README b/Documentation/arm/sunxi/README
> index d7b1f016bd62..af56321137e8 100644
> --- a/Documentation/arm/sunxi/README
> +++ b/Documentation/arm/sunxi/README
> @@ -75,6 +75,12 @@ SunXi family
>  + Datasheet
>http://linux-sunxi.org/File:Allwinner_V3s_Datasheet_V1.0.pdf
>
> +  - Allwinner R40 (sun8i)
> ++ Datasheet
> +  
> https://github.com/tinalinux/docs/blob/r40-v1.y/R40_Datasheet_V1.0.pdf
> ++ User Manual
> +  
> https://github.com/tinalinux/docs/blob/r40-v1.y/Allwinner_R40_User_Manual_V1.0.pdf
> +
>  * Quad ARM Cortex-A15, Quad ARM Cortex-A7 based SoCs
>- Allwinner A80
>  + Datasheet
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt 
> b/Documentation/devicetree/bindings/arm/sunxi.txt
> index d2c46449b4eb..b3ffe6cf821a 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.txt
> +++ b/Documentation/devicetree/bindings/arm/sunxi.txt
> @@ -14,6 +14,7 @@ using one of the following compatible strings:
>allwinner,sun8i-a83t
>allwinner,sun8i-h2-plus
>allwinner,sun8i-h3
> +  allwinner-sun8i-r40

v3s is missing from this list. Can you send a separate patch to add it?

>allwinner,sun9i-a80
>allwinner,sun50i-a64
>nextthing,gr8
> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
> index f44e3acb5c90..aea616759451 100644
> --- a/arch/arm/mach-sunxi/sunxi.c
> +++ b/arch/arm/mach-sunxi/sunxi.c
> @@ -66,6 +66,7 @@ static const char * const sun8i_board_dt_compat[] = {
> "allwinner,sun8i-h2-plus",
> "allwinner,sun8i-h3",
> "allwinner,sun8i-v3s",
> +   "allwinner,sun8i-r40",

Prefer to have them in alphabetical order.

Otherwise,

Reviewed-by: Chen-Yu Tsai 

> NULL,
>  };
>
> --
> 2.12.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 02/10] pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:23 PM, Icenowy Zheng  wrote:
> Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
>
> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
> into A10 driver, and add R40 support into it.
>
> Signed-off-by: Icenowy Zheng 

Reviewed-by: Chen-Yu Tsai 
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 03/10] pinctrl: sunxi: add A20 support to A10 driver

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:23 PM, Icenowy Zheng  wrote:
> As A20 is designed as a pin-compatible upgrade of A10, their pin
> controller are very similar, and can share one driver.
>
> Add A20 support to the A10 driver.
>
> Signed-off-by: Icenowy Zheng 

Reviewed-by: Chen-Yu Tsai 
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 04/10] pinctrl: sunxi: drop dedicated A20 driver

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:23 PM, Icenowy Zheng  wrote:
> As we added A20 support to A10 pinctrl driver, now we can delete the
> dedicated A20 pinctrl driver, which is duplicated code.
>
> Signed-off-by: Icenowy Zheng 
> ---
> Changes in v3:
> - Only remove the A20 driver(A10 driver for A20 is enabled in
>   the previous commit now).
>
>  drivers/pinctrl/sunxi/Kconfig |4 -
>  drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c | 1056 
> -

You forgot to remove the Makefile entry. Otherwise,

Reviewed-by: Chen-Yu Tsai 
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 05/10] dt-bindings: add compatible string for Allwinner R40 pinctrl

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:23 PM, Icenowy Zheng  wrote:
> Allwinner R40 has a pin controller like the ones in older Allwinner SoCs
> (especially A20), and can use modified version of the A10/A20 pinctrl
> driver.
>
> Add a compatible string for it.
>
> Signed-off-by: Icenowy Zheng 
> Acked-by: Rob Herring 

Reviewed-by: Chen-Yu Tsai 

> ---
> Changes in v3:
> - Added Rob's ACK.
>
>  Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git 
> a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt 
> b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
> index b53224473672..3ab9f7849a19 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
> @@ -22,6 +22,7 @@ Required properties:
>"allwinner,sun8i-a83t-pinctrl"
>"allwinner,sun8i-h3-pinctrl"
>"allwinner,sun8i-h3-r-pinctrl"
> +  "allwinner,sun8i-r40-pinctrl"

Seems like we are missing an entry for the V3s. Can you send a separate patch?

Thanks

>"allwinner,sun50i-a64-pinctrl"
>"allwinner,sun50i-a64-r-pinctrl"
>"allwinner,sun50i-h5-pinctrl"
> --
> 2.12.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 07/10] dt-bindings: add compatible string for Allwinner R40 CCU

2017-05-28 Thread Chen-Yu Tsai
On Sat, May 27, 2017 at 6:23 PM, Icenowy Zheng  wrote:
> Allwinner R40 has a clock controlling unit like the ones on other
> Allwinner SoCs after sun6i, and can also use a CCU-based driver.
>
> Add a compatible string for it.
>
> Signed-off-by: Icenowy Zheng 
> Acked-by: Rob Herring 

Reviewed-by: Chen-Yu Tsai 
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html