Re: [PATCH v7 0/4] i2c-smbus: add support for HOST NOTIFY
Hi Benjamin, > this is mostly a resubmission of the v6 with the acks, tested-by and few typos > here and there. I actually reviewed v6 but got an NMI so writing the mails fell through the cracks :( Sorry about that! Good news is that the code is fine from my point of view, some documentation updates I'd request. After updating those, I will pick up the core patches right away. Note that while the i801 patch looks good to me, I need Jean's review here. There are other patches pending for i801, that needs to be coordinated by him. Thanks, Wolfram signature.asc Description: PGP signature
Re: [PATCH v7 1/4] i2c: add a protocol parameter to the alert callback
On Tue, May 31, 2016 at 12:03:02PM +0200, Benjamin Tissoires wrote: > .alert() is meant to be generic, but there is currently no way > for the device driver to know which protocol generated the alert. > Add a parameter in .alert() to help the device driver to understand > what is given in data. > > This patch is required to have the support of SMBus Host Notify protocol > through .alert(). > > Tested-by: Andrew Duggan signature.asc Description: PGP signature
Re: [PATCH v7 2/4] i2c-smbus: add SMBus Host Notify support
> diff --git a/Documentation/i2c/smbus-protocol
> b/Documentation/i2c/smbus-protocol
> index 6012b12..4e07848 100644
> --- a/Documentation/i2c/smbus-protocol
> +++ b/Documentation/i2c/smbus-protocol
> @@ -199,6 +199,9 @@ alerting device's address.
>
> [S] [HostAddr] [Wr] A [DevAddr] A [DataLow] A [DataHigh] A [P]
>
> +I2C drivers for devices which can trigger SMBus Host Notify should implement
> +the optional alert() callback.
> +
I'd like a similar "This is implemented the following way in the Linux
kernel:" paragraph here as in the alert section. The item what bus
drivers should do is missing.
> + if (host_notify->pending) {
> + spin_unlock_irqrestore(&host_notify->lock, flags);
> + dev_warn(&adapter->dev, "Host Notify already scheduled.\n");
> + return -EFAULT;
Very minor nit: -EBUSY?
> +#if defined(CONFIG_I2C_SMBUS) || defined(CONFIG_I2C_SMBUS_MODULE)
IS_ENABLED()?
signature.asc
Description: PGP signature
Re: [PATCH v7 3/4] i2c: i801: add support of Host Notify
On Tue, May 31, 2016 at 12:03:04PM +0200, Benjamin Tissoires wrote: > The i801 chip can handle the Host Notify feature since ICH 3 as mentioned > in > http://www.intel.com/content/dam/doc/datasheet/82801ca-io-controller-hub-3-datasheet.pdf > > Enable the functionality unconditionally and propagate the alert > on each notification. > > With a T440s and a Synaptics touchpad that implements Host Notify, the > payload data is always 0x, so I am not sure if the device actually > sends the payload or if there is a problem regarding the implementation. > > Tested-by: Andrew Duggan > Signed-off-by: Benjamin Tissoires Did some high level review. Did not dig into datasheets. Acked-by: Wolfram Sang signature.asc Description: PGP signature
RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC
Thanks, Machek, This patch has already been dropped. > On Tue 2016-05-03 11:04:24, changbin...@intel.com wrote: > > From: "Du, Changbin" > > > > On most platforms, there is only one device controller available. > > In this case, we desn't care the UDC's name. So let's ignore the > > name by setting 'UDC' to 'any'. And also we can change UDC name > > at any time if it is not binded (no need set to "" first). > > making "any" special does not look like a good idea. What if it really > is "any"? > > Return nothing instead, not even \n? > > > Signed-off-by: Du, Changbin > > Signed-off-by: Du, Changbin > > I don't think this is how you should sign it off. > > Best regards, > > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
