Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default
On Tue, Mar 8, 2016 at 2:53 PM, Maciej S. Szmigiero
wrote:
> FAT has long supported its own default file name encoding
> config setting, separate from CONFIG_NLS_DEFAULT.
>
> However, if UTF-8 encoded file names are desired FAT
> character set should not be set to utf8 since this would
> make file names case sensitive even if case insensitive
> matching is requested.
> Instead, "utf8" mount options should be provided to enable
> UTF-8 file names in FAT file system.
>
> Unfortunately, there was no possibility to set the default
> value of this option so on UTF-8 system "utf8" mount option
> had to be added manually to most FAT mounts.
>
> This patch adds config option to set such default value.
>
> Signed-off-by: Maciej S. Szmigiero
> --- a/fs/fat/Kconfig
> +++ b/fs/fat/Kconfig
> @@ -93,8 +93,24 @@ config FAT_DEFAULT_IOCHARSET
> that most of your FAT filesystems use, and can be overridden
> with the "iocharset" mount option for FAT filesystems.
> Note that "utf8" is not recommended for FAT filesystems.
> - If unsure, you shouldn't set "utf8" here.
> + If unsure, you shouldn't set "utf8" here - select the next option
> + instead if you would like to use UTF-8 encoded file names by
> default.
> See for more information.
>
> Enable any character sets you need in File Systems/Native Language
> Support.
> +
> +config FAT_DEFAULT_UTF8
> + bool "Enable FAT UTF-8 option by default"
> + depends on VFAT_FS
> + default n
> + help
> + Set this if you would like to have "utf8" mount option set
> + by default when mounting FAT filesystems.
> +
> + Even if you say Y here can always disable UTF-8 for
> + particular mount by adding "utf8=0" to mount options.
> +
> + Say Y if you use UTF-8 encoding for file names, N otherwise.
> +
> + See for more information.
What's the recommended value of CONFIG_FAT_DEFAULT_UTF8 for
a (distro) defconfig?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 19/23] ncr5380: Update usage documentation
Update kernel parameter documentation for atari_scsi, mac_scsi and
g_NCR5380 drivers. Remove duplication.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
---
Documentation/scsi/g_NCR5380.txt | 17 ++-
Documentation/scsi/scsi-parameters.txt | 11 +++---
drivers/scsi/g_NCR5380.c | 36 -
3 files changed, 16 insertions(+), 48 deletions(-)
Index: linux/Documentation/scsi/scsi-parameters.txt
===
--- linux.orig/Documentation/scsi/scsi-parameters.txt 2016-03-23
21:05:15.0 +1100
+++ linux/Documentation/scsi/scsi-parameters.txt2016-03-23
21:10:02.0 +1100
@@ -27,13 +27,15 @@ parameters may be changed at runtime by
aic79xx=[HW,SCSI]
See Documentation/scsi/aic79xx.txt.
- atascsi=[HW,SCSI] Atari SCSI
+ atascsi=[HW,SCSI]
+ See drivers/scsi/atari_scsi.c.
BusLogic= [HW,SCSI]
See drivers/scsi/BusLogic.c, comment before function
BusLogic_ParseDriverOptions().
dtc3181e= [HW,SCSI]
+ See Documentation/scsi/g_NCR5380.txt.
eata= [HW,SCSI]
@@ -51,8 +53,8 @@ parameters may be changed at runtime by
ips=[HW,SCSI] Adaptec / IBM ServeRAID controller
See header of drivers/scsi/ips.c.
- mac5380=[HW,SCSI] Format:
-
+ mac5380=[HW,SCSI]
+ See drivers/scsi/mac_scsi.c.
max_luns= [SCSI] Maximum number of LUNs to probe.
Should be between 1 and 2^32-1.
@@ -65,10 +67,13 @@ parameters may be changed at runtime by
See header of drivers/scsi/NCR_D700.c.
ncr5380=[HW,SCSI]
+ See Documentation/scsi/g_NCR5380.txt.
ncr53c400= [HW,SCSI]
+ See Documentation/scsi/g_NCR5380.txt.
ncr53c400a= [HW,SCSI]
+ See Documentation/scsi/g_NCR5380.txt.
ncr53c406a= [HW,SCSI]
Index: linux/Documentation/scsi/g_NCR5380.txt
===
--- linux.orig/Documentation/scsi/g_NCR5380.txt 2016-03-23 21:05:15.0
+1100
+++ linux/Documentation/scsi/g_NCR5380.txt 2016-03-23 21:10:02.0
+1100
@@ -23,11 +23,10 @@ supported by the driver.
If the default configuration does not work for you, you can use the kernel
command lines (eg using the lilo append command):
- ncr5380=port,irq,dma
- ncr53c400=port,irq
-or
- ncr5380=base,irq,dma
- ncr53c400=base,irq
+ ncr5380=addr,irq
+ ncr53c400=addr,irq
+ ncr53c400a=addr,irq
+ dtc3181e=addr,irq
The driver does not probe for any addresses or ports other than those in
the OVERRIDE or given to the kernel as above.
@@ -36,19 +35,17 @@ This driver provides some information on
/proc/scsi/g_NCR5380/x where x is the scsi card number as detected at boot
time. More info to come in the future.
-When NCR53c400 support is compiled in, BIOS parameters will be returned by
-the driver (the raw 5380 driver does not and I don't plan to fiddle with
-it!).
-
This driver works as a module.
When included as a module, parameters can be passed on the insmod/modprobe
command line:
ncr_irq=xx the interrupt
ncr_addr=xx the port or base address (for port or memory
mapped, resp.)
- ncr_dma=xx the DMA
ncr_5380=1 to set up for a NCR5380 board
ncr_53c400=1 to set up for a NCR53C400 board
+ ncr_53c400a=1 to set up for a NCR53C400A board
+ dtc_3181e=1 to set up for a Domex Technology Corp 3181E board
+ hp_c2502=1 to set up for a Hewlett Packard C2502 board
e.g.
modprobe g_NCR5380 ncr_irq=5 ncr_addr=0x350 ncr_5380=1
for a port mapped NCR5380 board or
Index: linux/drivers/scsi/g_NCR5380.c
===
--- linux.orig/drivers/scsi/g_NCR5380.c 2016-03-23 21:10:00.0 +1100
+++ linux/drivers/scsi/g_NCR5380.c 2016-03-23 21:10:02.0 +1100
@@ -18,42 +18,8 @@
*
* Added ISAPNP support for DTC436 adapters,
* Thomas Sailer, sai...@ife.ee.ethz.ch
- */
-
-/*
- * TODO : flesh out DMA support, find some one actually using this (I have
- * a memory mapped Trantor board that works fine)
- */
-
-/*
- * The card is detected and initialized in one of several ways :
- * 1. With command line overrides - NCR5380=port,irq may be
- * used on the LILO command line to override the defaults.
- *
- * 2. With the GENERIC_NCR5380_OVERRIDE compile time define. This is
- * specified as an array of address, irq, dma, board tuples. Ie, for
- * one board at 0x350, IRQ5, no dma, I could say
- * -DGENERIC_NCR5380_OVERRIDE={{0xcc000, 5,
Re: [PATCH v4] tty: serial: meson: Implement earlycon support
Am 06.03.2016 um 12:21 schrieb Andreas Färber:
> Split off the bulk of the existing meson_serial_console_write()
> implementation into meson_serial_port_write() for implementing
> meson_serial_early_console_write().
>
> Use "meson" as the earlycon driver name, courtesy of Nicolas.
>
> Signed-off-by: Nicolas Saenz Julienne
> Acked-by: Carlo Caione
> Signed-off-by: Andreas Färber
> ---
> v3 -> v4:
> * Select SERIAL_EARLYCON (Arnd)
Ping?
Andreas
>
> v2 -> v3:
> * Rename from "meson_serial" to just "meson" (Nicolas)
>
> v1 -> v2:
> * Implement meson_serial_early_console_write() instead of reusing
>meson_serial_console_write() (Peter)
>
> Documentation/kernel-parameters.txt | 6 ++
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/meson_uart.c | 42
> ++---
> 3 files changed, 42 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/kernel-parameters.txt
> b/Documentation/kernel-parameters.txt
> index e0a21e4556a6..a7c1377fd80f 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1039,6 +1039,12 @@ bytes respectively. Such letter suffixes can also be
> entirely omitted.
> the driver will use only 32-bit accessors to read/write
> the device registers.
>
> + meson,
> + Start an early, polled-mode console on a meson serial
> + port at the specified address. The serial port must
> + already be setup and configured. Options are not yet
> + supported.
> +
> msm_serial,
> Start an early, polled-mode console on an msm serial
> port at the specified address. The serial port
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index bdbe1c533c6a..ad7538e8a4e8 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -213,6 +213,7 @@ config SERIAL_MESON_CONSOLE
> bool "Support for console on meson"
> depends on SERIAL_MESON=y
> select SERIAL_CORE_CONSOLE
> + select SERIAL_EARLYCON
> help
> Say Y here if you wish to use a Amlogic MesonX UART as the
> system console (the system console is the device which
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 024445aa0521..6aea0f4a9165 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -481,18 +481,13 @@ static void meson_console_putchar(struct uart_port
> *port, int ch)
> writel(ch, port->membase + AML_UART_WFIFO);
> }
>
> -static void meson_serial_console_write(struct console *co, const char *s,
> -u_int count)
> +static void meson_serial_port_write(struct uart_port *port, const char *s,
> + u_int count)
> {
> - struct uart_port *port;
> unsigned long flags;
> int locked;
> u32 val, tmp;
>
> - port = meson_ports[co->index];
> - if (!port)
> - return;
> -
> local_irq_save(flags);
> if (port->sysrq) {
> locked = 0;
> @@ -516,6 +511,18 @@ static void meson_serial_console_write(struct console
> *co, const char *s,
> local_irq_restore(flags);
> }
>
> +static void meson_serial_console_write(struct console *co, const char *s,
> +u_int count)
> +{
> + struct uart_port *port;
> +
> + port = meson_ports[co->index];
> + if (!port)
> + return;
> +
> + meson_serial_port_write(port, s, count);
> +}
> +
> static int meson_serial_console_setup(struct console *co, char *options)
> {
> struct uart_port *port;
> @@ -554,6 +561,27 @@ static int __init meson_serial_console_init(void)
> }
> console_initcall(meson_serial_console_init);
>
> +static void meson_serial_early_console_write(struct console *co,
> + const char *s,
> + u_int count)
> +{
> + struct earlycon_device *dev = co->data;
> +
> + meson_serial_port_write(&dev->port, s, count);
> +}
> +
> +static int __init
> +meson_serial_early_console_setup(struct earlycon_device *device, const char
> *opt)
> +{
> + if (!device->port.membase)
> + return -ENODEV;
> +
> + device->con->write = meson_serial_early_console_write;
> + return 0;
> +}
> +OF_EARLYCON_DECLARE(meson, "amlogic,meson-uart",
> + meson_serial_early_console_setup);
> +
> #define MESON_SERIAL_CONSOLE (&meson_serial_console)
> #else
> #define MESON_SERIAL_CONSOLE NULL
>
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.o
Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default
On Wed, Mar 23, 2016 at 4:17 AM, Geert Uytterhoeven wrote: > On Tue, Mar 8, 2016 at 2:53 PM, Maciej S. Szmigiero > wrote: >> FAT has long supported its own default file name encoding >> config setting, separate from CONFIG_NLS_DEFAULT. >> >> However, if UTF-8 encoded file names are desired FAT >> character set should not be set to utf8 since this would >> make file names case sensitive even if case insensitive >> matching is requested. >> Instead, "utf8" mount options should be provided to enable >> UTF-8 file names in FAT file system. >> >> Unfortunately, there was no possibility to set the default >> value of this option so on UTF-8 system "utf8" mount option >> had to be added manually to most FAT mounts. >> >> This patch adds config option to set such default value. >> >> Signed-off-by: Maciej S. Szmigiero > >> --- a/fs/fat/Kconfig >> +++ b/fs/fat/Kconfig >> @@ -93,8 +93,24 @@ config FAT_DEFAULT_IOCHARSET >> that most of your FAT filesystems use, and can be overridden >> with the "iocharset" mount option for FAT filesystems. >> Note that "utf8" is not recommended for FAT filesystems. >> - If unsure, you shouldn't set "utf8" here. >> + If unsure, you shouldn't set "utf8" here - select the next option >> + instead if you would like to use UTF-8 encoded file names by >> default. >> See for more information. >> >> Enable any character sets you need in File Systems/Native Language >> Support. >> + >> +config FAT_DEFAULT_UTF8 >> + bool "Enable FAT UTF-8 option by default" >> + depends on VFAT_FS >> + default n >> + help >> + Set this if you would like to have "utf8" mount option set >> + by default when mounting FAT filesystems. >> + >> + Even if you say Y here can always disable UTF-8 for >> + particular mount by adding "utf8=0" to mount options. >> + >> + Say Y if you use UTF-8 encoding for file names, N otherwise. >> + >> + See for more information. > > What's the recommended value of CONFIG_FAT_DEFAULT_UTF8 for > a (distro) defconfig? Yes, I'm curious about this as well. My initial assumption is to leave it off, given that if you turn it on when it wasn't previously it will change the behavior. I would also assume that is why it is marked as default n. josh -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default
On Wed, Mar 23, 2016 at 12:28 PM, Josh Boyer wrote:
> On Wed, Mar 23, 2016 at 4:17 AM, Geert Uytterhoeven
> wrote:
>> On Tue, Mar 8, 2016 at 2:53 PM, Maciej S. Szmigiero
>> wrote:
>>> FAT has long supported its own default file name encoding
>>> config setting, separate from CONFIG_NLS_DEFAULT.
>>>
>>> However, if UTF-8 encoded file names are desired FAT
>>> character set should not be set to utf8 since this would
>>> make file names case sensitive even if case insensitive
>>> matching is requested.
>>> Instead, "utf8" mount options should be provided to enable
>>> UTF-8 file names in FAT file system.
>>>
>>> Unfortunately, there was no possibility to set the default
>>> value of this option so on UTF-8 system "utf8" mount option
>>> had to be added manually to most FAT mounts.
>>>
>>> This patch adds config option to set such default value.
>>>
>>> Signed-off-by: Maciej S. Szmigiero
>>
>>> --- a/fs/fat/Kconfig
>>> +++ b/fs/fat/Kconfig
>>> @@ -93,8 +93,24 @@ config FAT_DEFAULT_IOCHARSET
>>> that most of your FAT filesystems use, and can be overridden
>>> with the "iocharset" mount option for FAT filesystems.
>>> Note that "utf8" is not recommended for FAT filesystems.
>>> - If unsure, you shouldn't set "utf8" here.
>>> + If unsure, you shouldn't set "utf8" here - select the next option
>>> + instead if you would like to use UTF-8 encoded file names by
>>> default.
>>> See for more
>>> information.
>>>
>>> Enable any character sets you need in File Systems/Native Language
>>> Support.
>>> +
>>> +config FAT_DEFAULT_UTF8
>>> + bool "Enable FAT UTF-8 option by default"
>>> + depends on VFAT_FS
>>> + default n
>>> + help
>>> + Set this if you would like to have "utf8" mount option set
>>> + by default when mounting FAT filesystems.
>>> +
>>> + Even if you say Y here can always disable UTF-8 for
>>> + particular mount by adding "utf8=0" to mount options.
>>> +
>>> + Say Y if you use UTF-8 encoding for file names, N otherwise.
>>> +
>>> + See for more
>>> information.
>>
>> What's the recommended value of CONFIG_FAT_DEFAULT_UTF8 for
>> a (distro) defconfig?
>
> Yes, I'm curious about this as well. My initial assumption is to
> leave it off, given that if you turn it on when it wasn't previously
> it will change the behavior. I would also assume that is why it is
> marked as default n.
"default n" is superfluous, as all options default to "n" in the absence
of a default specifier.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default
On Wed, Mar 23, 2016 at 8:27 AM, Geert Uytterhoeven wrote: > On Wed, Mar 23, 2016 at 12:28 PM, Josh Boyer > wrote: >> On Wed, Mar 23, 2016 at 4:17 AM, Geert Uytterhoeven >> wrote: >>> On Tue, Mar 8, 2016 at 2:53 PM, Maciej S. Szmigiero >>> wrote: FAT has long supported its own default file name encoding config setting, separate from CONFIG_NLS_DEFAULT. However, if UTF-8 encoded file names are desired FAT character set should not be set to utf8 since this would make file names case sensitive even if case insensitive matching is requested. Instead, "utf8" mount options should be provided to enable UTF-8 file names in FAT file system. Unfortunately, there was no possibility to set the default value of this option so on UTF-8 system "utf8" mount option had to be added manually to most FAT mounts. This patch adds config option to set such default value. Signed-off-by: Maciej S. Szmigiero >>> --- a/fs/fat/Kconfig +++ b/fs/fat/Kconfig @@ -93,8 +93,24 @@ config FAT_DEFAULT_IOCHARSET that most of your FAT filesystems use, and can be overridden with the "iocharset" mount option for FAT filesystems. Note that "utf8" is not recommended for FAT filesystems. - If unsure, you shouldn't set "utf8" here. + If unsure, you shouldn't set "utf8" here - select the next option + instead if you would like to use UTF-8 encoded file names by default. See for more information. Enable any character sets you need in File Systems/Native Language Support. + +config FAT_DEFAULT_UTF8 + bool "Enable FAT UTF-8 option by default" + depends on VFAT_FS + default n + help + Set this if you would like to have "utf8" mount option set + by default when mounting FAT filesystems. + + Even if you say Y here can always disable UTF-8 for + particular mount by adding "utf8=0" to mount options. + + Say Y if you use UTF-8 encoding for file names, N otherwise. + + See for more information. >>> >>> What's the recommended value of CONFIG_FAT_DEFAULT_UTF8 for >>> a (distro) defconfig? >> >> Yes, I'm curious about this as well. My initial assumption is to >> leave it off, given that if you turn it on when it wasn't previously >> it will change the behavior. I would also assume that is why it is >> marked as default n. > > "default n" is superfluous, as all options default to "n" in the absence > of a default specifier. Yes, I know that. I meant that I assumed the patch author knows that too, and included it anyway as a helpful indicator that it shouldn't be turned on in most cases. At any rate, your question still stands and it would be nice to get an answer. josh -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch
On Tue, Mar 22, 2016 at 08:03:14PM -0400, Jessica Yu wrote:
> Patches based on linux-next.
>
> Previous patchset (v5) found here:
> http://lkml.kernel.org/g/1458157628-8264-1-git-send-email-j...@redhat.com
>
> v6:
> - Since we hard-code the field widths for the objname and symbol name
>for the sscanf() calls, which are supposed to correspond to the values
>of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
>the values of these constants deviate from the expected values.
> - Squash the sample livepatch module patch into patch 4
>("livepatch: reuse module loader code to write relocations") so
>git bisects don't break
> - Don't need the klp_buf struct, just use plain char arrays to hold the
>output of sscanf(). Also, no need to clear the bufs after every
>invocation, as sscanf() takes care to put a null byte at the end of
>the bufs.
> - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> - Fixed some small module.c nits
For the series:
Acked-by: Josh Poimboeuf
Thanks Jessica!
--
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] tty: serial: meson: Implement earlycon support
On Wed, Mar 23, 2016 at 11:39:36AM +0100, Andreas Färber wrote: > Am 06.03.2016 um 12:21 schrieb Andreas Färber: > > Split off the bulk of the existing meson_serial_console_write() > > implementation into meson_serial_port_write() for implementing > > meson_serial_early_console_write(). > > > > Use "meson" as the earlycon driver name, courtesy of Nicolas. > > > > Signed-off-by: Nicolas Saenz Julienne > > Acked-by: Carlo Caione > > Signed-off-by: Andreas Färber > > --- > > v3 -> v4: > > * Select SERIAL_EARLYCON (Arnd) > > Ping? It's the middle of the merge window, there's nothing I can do at the moment, please wait for after 4.6-rc1 is out before I can start catching up... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch
On Tue, 22 Mar 2016, Jessica Yu wrote:
> v6:
> - Since we hard-code the field widths for the objname and symbol name
>for the sscanf() calls, which are supposed to correspond to the values
>of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
>the values of these constants deviate from the expected values.
> - Squash the sample livepatch module patch into patch 4
>("livepatch: reuse module loader code to write relocations") so
>git bisects don't break
> - Don't need the klp_buf struct, just use plain char arrays to hold the
>output of sscanf(). Also, no need to clear the bufs after every
>invocation, as sscanf() takes care to put a null byte at the end of
>the bufs.
> - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> - Fixed some small module.c nits
FWIW I am fine with all the changes and my Reviewed-by tag is still valid.
Great job, Jessica.
Miroslav
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3 6/9] Documentation: dt: socfpga: Add Altera Arria10 L2 cache binding
On Mon, Mar 21, 2016 at 11:01:43AM -0500, ttha...@opensource.altera.com wrote: > From: Thor Thayer > > Add the device tree bindings needed to support the Altera L2 > cache on the Arria10 chip. Since all the peripherals share > IRQs, the IRQ fields are now in the ecc_manager. > > Signed-off-by: Thor Thayer > --- > v2 Correct spelling of Arria10 in patch title. > v3 Major restructuring change for ecc_manager to include IRQs > --- > .../bindings/arm/altera/socfpga-eccmgr.txt | 40 > > 1 file changed, 40 insertions(+) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Documentation,barriers: Mention smp_cond_acquire()
On Mon, Mar 21, 2016 at 02:07:19PM -0700, Davidlohr Bueso wrote: > ... do this next to smp_load_acquire when first mentioning > ACQUIRE. While this call is briefly explained and ctrl > dependencies are mentioned later, it does not hurt the reader. > > Signed-off-by: Davidlohr Bueso Queued for review, thank you, Davidlohr! Thanx, Paul > --- > Documentation/memory-barriers.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/memory-barriers.txt > b/Documentation/memory-barriers.txt > index 3729cbe60e41..2b5ea9d01a8f 100644 > --- a/Documentation/memory-barriers.txt > +++ b/Documentation/memory-barriers.txt > @@ -430,8 +430,9 @@ And a couple of implicit varieties: > This acts as a one-way permeable barrier. It guarantees that all memory > operations after the ACQUIRE operation will appear to happen after the > ACQUIRE operation with respect to the other components of the system. > - ACQUIRE operations include LOCK operations and smp_load_acquire() > - operations. > + ACQUIRE operations include LOCK operations and both smp_load_acquire() > + and smp_cond_acquire() operations. The later builds the necessary > ACQUIRE > + semantics from relying on a control dependency and smp_rmb(). > > Memory operations that occur before an ACQUIRE operation may appear to > happen after it completes. > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default
On 23.03.2016 13:57, Josh Boyer wrote: > On Wed, Mar 23, 2016 at 8:27 AM, Geert Uytterhoeven > wrote: >> On Wed, Mar 23, 2016 at 12:28 PM, Josh Boyer >> wrote: >>> On Wed, Mar 23, 2016 at 4:17 AM, Geert Uytterhoeven >>> wrote: On Tue, Mar 8, 2016 at 2:53 PM, Maciej S. Szmigiero wrote: > FAT has long supported its own default file name encoding > config setting, separate from CONFIG_NLS_DEFAULT. > > However, if UTF-8 encoded file names are desired FAT > character set should not be set to utf8 since this would > make file names case sensitive even if case insensitive > matching is requested. > Instead, "utf8" mount options should be provided to enable > UTF-8 file names in FAT file system. > > Unfortunately, there was no possibility to set the default > value of this option so on UTF-8 system "utf8" mount option > had to be added manually to most FAT mounts. > > This patch adds config option to set such default value. > > Signed-off-by: Maciej S. Szmigiero > --- a/fs/fat/Kconfig > +++ b/fs/fat/Kconfig > @@ -93,8 +93,24 @@ config FAT_DEFAULT_IOCHARSET > that most of your FAT filesystems use, and can be overridden > with the "iocharset" mount option for FAT filesystems. > Note that "utf8" is not recommended for FAT filesystems. > - If unsure, you shouldn't set "utf8" here. > + If unsure, you shouldn't set "utf8" here - select the next > option > + instead if you would like to use UTF-8 encoded file names by > default. > See for more > information. > > Enable any character sets you need in File Systems/Native > Language > Support. > + > +config FAT_DEFAULT_UTF8 > + bool "Enable FAT UTF-8 option by default" > + depends on VFAT_FS > + default n > + help > + Set this if you would like to have "utf8" mount option set > + by default when mounting FAT filesystems. > + > + Even if you say Y here can always disable UTF-8 for > + particular mount by adding "utf8=0" to mount options. > + > + Say Y if you use UTF-8 encoding for file names, N otherwise. > + > + See for more > information. What's the recommended value of CONFIG_FAT_DEFAULT_UTF8 for a (distro) defconfig? >>> >>> Yes, I'm curious about this as well. My initial assumption is to >>> leave it off, given that if you turn it on when it wasn't previously >>> it will change the behavior. I would also assume that is why it is >>> marked as default n. >> >> "default n" is superfluous, as all options default to "n" in the absence >> of a default specifier. > > Yes, I know that. I meant that I assumed the patch author knows that > too, and included it anyway as a helpful indicator that it shouldn't > be turned on in most cases. At any rate, your question still stands > and it would be nice to get an answer. The default is 'n' here for compatibility with older .configs, and to be consistent with the main FS NLS option (CONFIG_NLS_DEFAULT) since it also defaults to non-UTF-8 encoding. If file names are UTF-8 encoded then if FAT filesystems were always mounted with utf8 mount option, or with CONFIG_FAT_DEFAULT_IOCHARSET or "iocharset" mount option set to "utf8" (not recommended, but I've seen for example Knoppix doing it) then with this options set there is effectively no change in functionality. If file names are UTF-8 encoded but none of conditions described in the previous paragraph were true then UTF-8 file names were reinterpreted as CONFIG_FAT_DEFAULT_IOCHARSET (by default iso8859-1) then converted into UTF-16 for storage. While this usually worked it weren't correct: file names containing characters outside ASCII had them replaced with some garbage when accessing such FS with UTF-8 correctly enabled (for example with this option set) or on Windows. However, if such conditions (UTF-8 file names but non-UTF-8 FAT mount options) were present for a long time then it has to be taken into consideration that there are likely at least a few file systems with file names encoded in such way and it would be good not to change it suddenly when people update their kernels. > josh Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
