Re: AUTHORS material (re)started
Graham Percival percival-music.ca> writes: > > On Fri, Dec 04, 2009 at 12:34:34AM +, Graham Percival wrote: > > Sorry, now I'm doubting this. I've realized that we have lots of > other links on the web page without spelling them out like this. > Updating them all would be a fair-sized job, and there's no reason > to single out this page. Let me know what a 'fair-sized' job means. If it's a 'take a load of files open them in an editor and search/replace then open another file and another and another', then that's fine I can do that (I know it sounds dull, but I'm ok with this tidying up kind of job', maybe make it another 'to do' and assign it me - as long as I know what files or roughly where, we can start making the consistencies from now if you like? > > That said, I'm not fond of the alternate "Name" vs. > "@email{blah,Name}" vs. "@uref{blah,Name}". Maybe we should > specify either "Name" or "@email{blah,Name}" (as appropriate), > with a separate "(@uref{blah,website}): " after the first string > if they want a website listed? > Any ideas? I don't have any ideas yet as this is the first time I've done this kind of thing and have nothing to compare so again, if you want to start making some 'from now on let's make it like..' consistencies, then do it, I can go back and redo the edits. Once I get the feel for what I think you want in terms of style it will be more intuitive I think. > > I'm still fairly confident about my other instructions, although > if anything seems questionable, please question it! :) No it seems pretty straight forward, what I will probably get wrong are things like knowing when/when not to 'git -r' or download a later build and if I need to compile or not (as opposed to just working with the source files - whatever that actally means ;) ). I will need some hand holding on that side to start with. So if I get it wrong, I apologise now! Ah...to be a n00b all over again! ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: AUTHORS material (re)started
>Graham Percival percival-music.ca> writes: > > Thanks, added! A few requests for next time: > ... No problem - just replying so you know I saw both threads. James ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for February 12th
Hello, Here is the current patch countdown list. The next countdown will be on February 14th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ [1] *** PUSH: 5745 GUILE2: softcode GC environment tuning - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5745 [2] http://codereview.appspot.com/563500045 [3] 5744 parser-ly-from-scheme: Make #{ compilable - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5744 [4] http://codereview.appspot.com/581610043 [5] 5743 Don't let display-lily-tests use anonymous functions - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5743 [6] http://codereview.appspot.com/545550044 [7] 5742 Add support for itexi files to the vim config - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5742 [8] http://codereview.appspot.com/557350044 [9] 5718 Grow heap aggressively during music interpretation - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5718 [10] http://codereview.appspot.com/561390043 [11] 5703 Run scripts/auxiliar/fixcc.py - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5703 [12] http://codereview.appspot.com/549480043 [13] 5679 In verbose mode, dump time spent on parsing lily.scm and friends. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5679 [14] http://codereview.appspot.com/573420043 COUNTDOWN: 5748 engraver: continue when trying to create non-existent Grob - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5748 [15] http://codereview.appspot.com/547620043 [16] 5741 Parse inline scheme using per-expression port - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5741 [17] http://codereview.appspot.com/557330043 REVIEW: 5709 Use a pointer for the output parameter of Lily_lexer::scan_word - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5709 [18] http://codereview.appspot.com/577440044 NEW: 5750 Drop support for multiple configurations - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5750 [19] http://codereview.appspot.com/581630043 [20] 5749 Special-case syntax error of duration before octave marks - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5749 [21] http://codereview.appspot.com/557410043 [22] 5747 input/regression/multi-measure-rest-reminder: a demo of user-defined grobs - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5747 [23] http://codereview.appspot.com/557380044 [24] 5746 Fix and align musicxml and input language "deutsch" - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5746 [25] http://codereview.appspot.com/547610043 [26] 5738 Doc: Some miscellaneous suggestions from Peter Toye - xmichael-k https://sourceforge.net/p/testlilyissues/issues/5738 [27] http://codereview.appspot.com/579280043 [28] WAITING: 5740 Add post to defer context actions to end of time step - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5740 [29] http://codereview.appspot.com/581600043 [30] 4943 Manual page breaking causing assertion failure - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/4943 [31] http://codereview.appspot.com/575600043 [32] *** Regards, James Links: -- [1] http://philholmes.net/lilypond/allura/ [2] https://sourceforge.net/p/testlilyissues/issues/5745 [3] http://codereview.appspot.com/563500045 [4] https://sourceforge.net/p/testlilyissues/issues/5744 [5] http://codereview.appspot.com/581610043 [6] https://sourceforge.net/p/testlilyissues/issues/5743 [7] http://codereview.appspot.com/545550044 [8] https://sourceforge.net/p/testlilyissues/issues/5742 [9] http://codereview.appspot.com/557350044 [10] https://sourceforge.net/p/testlilyissues/issues/5718 [11] http://codereview.appspot.com/561390043 [12] https://sourceforge.net/p/testlilyissues/issues/5703 [13] http://codereview.appspot.com/549480043 [14] https://sourceforge.net/p/testlilyissues/issues/5679 [15] https://sourceforge.net/p/testlilyissues/issues/5748 [16] http://codereview.appspot.com/547620043 [17] https://sourceforge.net/p/testlilyissues/issues/5741 [18] https://sourceforge.net/p/testlilyissues/issues/5709 [19] https://sourceforge.net/p/testlilyissues/issues/5750 [20] http://codereview.appspot.com/581630043 [21] https://sourceforge.net/p/testlilyissues/issues/5749 [22] http://codereview.appspot.com/557410043 [23] https://sourceforge.net/p/testlilyissues/issues/5747 [24] http://codereview.appspot.com/557380044 [25] https://sourceforge.net/p/testlilyissues/issues/5746 [26] http://codereview.appspot.com/547610043 [27] https://sourceforge.net/p/testlilyissues/issues/5738 [28] http://codereview.appspot.com/579280043 [29] https://sourceforge.net/p/testlilyissues/issues/5740 [30] http://codereview.appspot.com/581600043 [31] https://sourceforge.net/p/testlilyissues/issues/4943 [32] http://coderev
Re: Staging broken.
Hello, On 18.02.2020 11:59, David Kastrup wrote: David Kastrup writes: Hi, staging does not compile anymore. Making lily/out/keyword.o < cc Making lily/out/simple-spacer-scheme.o < cc Making lily/out/episema-engraver.o < cc Making lily/out/lyric-extender.o < cc Making lily/out/includable-lexer.o < cc Making lily/out/timing-translator.o < cc Making lily/out/pango-font.o < cc Making lily/out/part-combine-part-iterator.o < cc Making lily/out/horizontal-bracket.o < cc /tmp/lilypond-autobuild/lily/pango-font.cc: In member function 'Stencil Pango_font::pango_item_string_stencil(const PangoGlyphItem*) const': /tmp/lilypond-autobuild/lily/pango-font.cc:229:28: error: invalid use of incomplete type 'PangoFcFont' {aka 'struct _PangoFcFont'} 229 | FcPattern *fcpat = fcfont->font_pattern; |^~ In file included from /usr/include/pango-1.0/pango/pangoft2.h:29, from /tmp/lilypond-autobuild/lily/pango-font.cc:20: /usr/include/pango-1.0/pango/pangofc-font.h:47:16: note: forward declaration of 'PangoFcFont' {aka 'struct _PangoFcFont'} 47 | typedef struct _PangoFcFont PangoFcFont; |^~~~ Making lily/out/clef-engraver.o < cc Making lily/out/key-performer.o < cc make[1]: *** [/tmp/lilypond-autobuild/stepmake/stepmake/c++-rules.make:5: out/pango-font.o] Error 1 make[1]: *** Waiting for unfinished jobs make: *** [/tmp/lilypond-autobuild/stepmake/stepmake/generic-targets.make:6: all] Error 2 I'll back out the Pango related commit and retry. It is a bit of a puzzler to me how this could have passed testing. Actually if you look on the tracker you'll see that I wrote 'Passes make, make test-baseline, and a full make doc.' This is probably my fault misunderstanding what can and what cannot be 'tested' after 'configure' has been run. For example, as far as I can remember/tell if I *.ac files are patched then when I run ./autogen.sh --noconfigure mkdir build cd build ../configure make make test-baseline and THEN I try to apply the diff, I get some 'error' about the file being newer (or something, I cannot recall without doing it) as when you run the patch tests you are not re-running autogen/configure. I am not versed enough to probably articulate myself here, but anyway, I assumed that I could never patch any of the make/config files because they never get re-done for the workflow that I have been using. So I just apply these 'make file' patches to master and build from that without the make check (this way I figured at least that I'd test most of the patch because it would still have to build the reg tests and the docs). So sorry for that. Obviously I need some education here. James --- Regards James
Re: Cross-staff spanners?
Hello On 02.03.2020 20:37, Jean Abou Samra wrote: Hi, Some time ago, I heard of a fantastic GSoC project aimed at enabling cross-staff spanners. [1]https://lilypondblog.org/2016/08/google-summer-of-code-2016-cross-vo ice-spanners/ However, this is not yet in any release. For the score I'm engraving, it would be tremendously helpful to get this working. I tried to compile the gsoc-2016-spanners branch from [2]https://github.com/starrynte/lilypond but it didn't do the trick. I know this will be unstable, but still, is there a patch somewhere that I could apply to use this feature nevertheless? Thank you very much! Regards, Jean Abou Samra References 1. https://lilypondblog.org/2016/08/google-summer-of-code-2016-cross-voice-spanners/ 2. https://github.com/starrynte/lilypond If you go to the lilypondblog link you eventually can find the code review here https://codereview.appspot.com/304160043/ James
PATCHES - Countdown for March 3rd
Hello, Here is the current patch countdown list. The next countdown will be on March 5th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ [1] *** PUSH: 5805 sources: fix handling of non-existent include files - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5805 [2] http://codereview.appspot.com/547700043 [3] 5800 aclocal.m4: also recognize guile2.2 - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5800 [4] http://codereview.appspot.com/555370043 [5] 5798 Make make-autochange function upwards-compatible to 2.18 - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5798 [6] http://codereview.appspot.com/567280043 [7] 5797 Do not run GC after processing every file. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5797 [8] http://codereview.appspot.com/579330043 [9] 5796 aclocal.m4 (STEPMAKE_GUILE_DEVEL): Fix logic and improve diagnostics. - Werner LEMBERG https://sourceforge.net/p/testlilyissues/issues/5796 [10] http://codereview.appspot.com/573570044 [11] 5788 New French Beamimg Approach - Torsten Hammerle https://sourceforge.net/p/testlilyissues/issues/5788 [12] http://codereview.appspot.com/557500043 [13] 5703 Run scripts/auxiliar/fixcc.py - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5703 [14] http://codereview.appspot.com/549480043 COUNTDOWN: 5813 Remove unused .1 => .txt rule - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5813 [15] http://codereview.appspot.com/557560044 [16] 5812 build cleanups. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5812 [17] http://codereview.appspot.com/547690053 [18] 5809 output-distance: avoid calling strip() on None - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5809 [19] http://codereview.appspot.com/549640043 [20] 5808 Web: Productions - typo fix - Torsten Hammerle https://sourceforge.net/p/testlilyissues/issues/5808 [21] http://codereview.appspot.com/557570043 [22] 5806 Tweak mf files to avoid FontForge internal overlap error - Torsten Hammerle https://sourceforge.net/p/testlilyissues/issues/5806 [23] http://codereview.appspot.com/571780043 [24] 5804 Do not allow page breaks on the first column of a score - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5804 [25] http://codereview.appspot.com/581720054 [26] 5803 output-distance: treat non-existent files as empty string - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5803 [27] http://codereview.appspot.com/583590043 [28] 5802 Add comments to code related to page breaking/layout - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5802 [29] http://codereview.appspot.com/563630043 [30] 5787 Add a cooperative FS lock to lilypond-book. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5787 [31] http://codereview.appspot.com/555360043 REVIEW: 5815 Mention Windows 10 in Windows package download - Torsten Hammerle https://sourceforge.net/p/testlilyissues/issues/5815 [32] http://codereview.appspot.com/553590043 [33] 5799 Fixes for cross-compilation to x86_64-w64-mingw32 - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5799 [34] http://codereview.appspot.com/579340043 [35] NEW: No new patches at this time. WAITING: 5771 remove unnecessary (descend-to-context ... 'Score) - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5771 [36] http://codereview.appspot.com/557440043 [37] 5740 Add post to defer context actions to end of time step - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5740 [38] http://codereview.appspot.com/581600043 [39] *** Regards, James Links: -- [1] http://philholmes.net/lilypond/allura/ [2] https://sourceforge.net/p/testlilyissues/issues/5805 [3] http://codereview.appspot.com/547700043 [4] https://sourceforge.net/p/testlilyissues/issues/5800 [5] http://codereview.appspot.com/555370043 [6] https://sourceforge.net/p/testlilyissues/issues/5798 [7] http://codereview.appspot.com/567280043 [8] https://sourceforge.net/p/testlilyissues/issues/5797 [9] http://codereview.appspot.com/579330043 [10] https://sourceforge.net/p/testlilyissues/issues/5796 [11] http://codereview.appspot.com/573570044 [12] https://sourceforge.net/p/testlilyissues/issues/5788 [13] http://codereview.appspot.com/557500043 [14] https://sourceforge.net/p/testlilyissues/issues/5703 [15] https://sourceforge.net/p/testlilyissues/issues/5813 [16] http://codereview.appspot.com/557560044 [17] https://sourceforge.net/p/testlilyissues/issues/5812 [18] http://codereview.appspot.com/547690053 [19] https://sourceforge.net/p/testlilyissues/issues/5809 [20] http://codereview.appspot.com/549640043 [21] https://sourceforge.net/p/testlilyissues/issues/5808 [22] http://codereview.appspot.com/557570043 [23] https://sourceforge.net/p/testlilyissues/issues/
Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend
Kevin, Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? James On 25/04/2020 08:42, Kevin Barry wrote: Patch is attached to this mail as a file if that is more convenient. Kevin
PATCHES - Countdown for April 28th
Hello, Here is the current patch countdown list. The next countdown will be on April 30th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5930 Make dblatex an optional dependency - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5930 http://codereview.appspot.com/567480043 5929 stepmake: Remove defunct test template - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5929 http://codereview.appspot.com/565960043 5927 Doc: Minor typo (missing dash) in MusicXML2ly usage - xmichael-k https://sourceforge.net/p/testlilyissues/issues/5927 http://codereview.appspot.com/551800043 5921 Documentation: Remove deprecated skeleton-update - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5921 http://codereview.appspot.com/545910043 Countdown: 5942 output-distance: print summary as final step - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5942 http://codereview.appspot.com/557780044 5937 Transform: add print_smob to aid debugging - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5937 http://codereview.appspot.com/561680043 5934 remove Repeated_music::folded_music_length - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5934 http://codereview.appspot.com/561670043 5933 Minor cleanups in stencil-integral.cc - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5933 http://codereview.appspot.com/579630043 5932 Fix warnings related to po - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5932 http://codereview.appspot.com/551830043 5922 Rewrite Skyline code - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5922 http://codereview.appspot.com/547980044 5896 Use vectors rather than lists for skylines. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5896 http://codereview.appspot.com/583750043 5882 Refactor get/set_property to take the item as first argument - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5882 http://codereview.appspot.com/573670043 Review: 5923 Use a hash table for the lexer keywords - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5923 http://codereview.appspot.com/549920043 New: 5946 Use Scheme_hash_table for keyword handling - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5946 http://codereview.appspot.com/577840053 5945 Add flag to NoteColumn using Axis_group_interface. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5945 http://codereview.appspot.com/555770044 5944 Put system headers after lilypond headers throughout - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5944 http://codereview.appspot.com/577840051 5938 Thread skyline construction through stencil interpretation - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5938 http://codereview.appspot.com/581960043 5936 Build slur skyline out of segments rather than boxes. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5936 http://codereview.appspot.com/577820043 Waiting: No patches in Waiting at this time. *** Regards, James
Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend
Hello Kevin, On 27/04/2020 18:07, Kevin Barry wrote: Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? It's not work in progress no - unless someone has objections or observations, but I don't mean to circumvent the review process or anything. If there's a better way to go about this then I'm happy to follow a process. Kevin We do have a process, see: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers this will get you going. James
Ghostcript warning about LinLibertine0 during make doc
Hello, While doing some sanity tests this morning building doc (making sure everything works for me for testing with new infrastructure) I spent more time looking at the terminal window than I usually do. During the make doc part where the 'page numbers' all whiz by I noticed occasionally I'd get a line /"GPL Ghostscript 9.26: Can't embed the complete font LinLibertineO as it is too large, embedding a subset."/ also part of that log stream. I don't know if we should be worried or if we can do anything about that or something else but I thought I would mention it. I haven't noticed anything obvious in the resulting PDF - but then again I haven't looked that hard. regards James
Re: GitLab review email
Hello On 12/05/2020 13:09, Federico Bruni wrote: Il giorno mar 12 mag 2020 alle 07:40, Dan Eble ha scritto: Rietveld used to send email to lilypond-devel for all comments by default, though one could disable that when commenting. Are we satisfied with GitLab's not doing that? I think so because it is configurable per developer. As non developer, I'm satisfied :-) I'm interested in following discussions on lilypond-devel, but I use to delete 99% of the rietveld emails without even read them. Not even easy, because emails from Rietveld are not grouped by thread. One of the nice feature of GitLab is that each developer can decide the amount of emails reaching his inbox without "imposing" a single decision for everyone. I also ignored 99% of rietveld emails too mainly because I'd only care about the issues on countdown and then I'd just scan the conversation look for anything that sounded contentious or needing a decision. We always have lilypond-auto list https://lists.gnu.org/archive/html/lilypond-auto/ perhaps that could be useful for something? James
Re: labels on GitLab
On 12/05/2020 16:15, Valentin Villenave wrote: On 5/12/20, Jonas Hahnfeld wrote: I'd really hope we can discuss things before changing... And*I*’d really hope “discuss things” can amount to more than “blindly reverting everything and anything that’s been done by someone else”. It was't blind Valentin, He did explain why he reverted it. Be fair. We've all got to get used to this 'new' instance, and there will be some bumps before it is all smooth. I am sure Jonas will, once we see how it all pans out, suggest and get some doc done. Regards James
Re: labels on GitLab
Hello On 13/05/2020 07:15, Jonas Hahnfeld wrote: So I think we should just have some kind of policy where to discuss things first. OK would there be any objection to removing the 'countdown-specific' labels (i.e. new/review/countdown/push) from closed issues, or issues that have been abandoned or have duplicate by them. e.g. https://gitlab.com/lilypond/lilypond/-/issues?scope=all&utf8=%E2%9C%93&state=closed&label_name[]=Patch%3A%3Apush Later issues would not (or should not) have the push label assigned to them but just 'fixed' or 'abandoned' or 'duplicate' labels. While I know this may generate a lot of email noise, it will make things clearer for me. Ditto for those closed issues with 'review' label. James
PATCHES - Countdown for May 13th
Hello, Here is the current patch countdown list. The next countdown will be on May 15th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !18 Prevent race condition in `-dfont-ps-resdir` - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/18 !2 Issue 5965 - Make Scheme_hash_table just use the native hash table type. - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/2 !1 web: Update links from SourceForge to GitLab - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/1 Countdown: !19 ignore settings for the vscode editor - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/19 !17 Use vsize for source files - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/17 !16 Quote_iterator: use vsize for index - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/16 !15 ignore conversion warning in lexer.cc - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/15 !14 do not use depcrecated %error-verbose (bison 2013) - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/14 !13 Modify obvious incorrect types - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/13 !12 Valid declaration of unused arguments - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/12 !11 Sequential_iterator maintenance - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/11 !9 Issue 4182: avoid checking the offset of cross-staff stems too early - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/9 !8 Resolve "Remove deprecated context properties" - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/8 !7 Resolve "Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver." - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/7 !5 Enable 'relative-includes by default. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/5 Review: !4 Ensure having valid references to the position in the source file while... - Martin Neubauer https://gitlab.com/lilypond/lilypond/-/merge_requests/4 New: !22 Doc: remove now unnecessary dummy argument after lilypond -dshow-available-fonts - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/22 !21 Update CG to state Python 3 requirement - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/21 !20 Add regtest for multiple post-events wrapper behavior - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/20 !3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/3 Waiting: No patches in Waiting at this time. *** Regards, James
Re: Obstacles for using GitLab CI
On 14/05/2020 07:58, Jonas Hahnfeld wrote: Thanks for all the feedback so far, I'll then work to propose something simple that can at least get us started. Afterwards we can work from there. So for now I can just manually carry on running patchy-merge on staging as needed? James
Re: Obstacles for using GitLab CI
On a more general question, and not really understanding how this CI workflow will change 'contexturally' what we do, so apologies for if what I am about to say is ignorant, but are we still taking the 'master-must-always-be-good' / 'staging-can-be-bad-because-we-can-force-delete-not-just-revert' approach? Rather than just automate everything and if something brakes we checkin a reversion which then makes the tree not 100% compilable? I've liked that approach we take so far and it always instills a level of confidence about master. James
Re: Commit ID doesn't match with what is claimed to be pushed.
Hello On 14/05/2020 14:55, Carl Sorensen wrote: I've been verifying commits. I have found one that is problematic: https://gitab.com/lilypond/lilypond/-/issues/5531 This issue claims to have been pushed with the commit ID c24f83991b772a65c15b6290cf70d725def117bd https://codereview.appspot.com/560790043 However, this commit is not found in the repository when I search by commit. A commit with the same title, however, is found. https://github.com/lilypond/lilypond/commit/1d4717d0db37e2906915dfe95a4fc3de990e4f80 And looking through the commit, it appears that all the changes are present. I assume that the best thing to do is to put the new commit id in a comment on the issue, and then mark the issue as Status::Verified. Are there any objections to this action? Thanks, Carl This is a commit I pushed for someone way back but that I think David had some problems with when he came to do his cherry picking and had to fix it. So yes put in that new commit. See: https://lists.gnu.org/archive/html/lilypond-devel/2020-02/msg9.html James
Re: Commit ID doesn't match with what is claimed to be pushed.
Hello On 14/05/2020 14:55, Carl Sorensen wrote: I've been verifying commits. I have found one that is problematic: https://gitab.com/lilypond/lilypond/-/issues/5531 This issue claims to have been pushed with the commit ID c24f83991b772a65c15b6290cf70d725def117bd https://codereview.appspot.com/560790043 However, this commit is not found in the repository when I search by commit. A commit with the same title, however, is found. https://github.com/lilypond/lilypond/commit/1d4717d0db37e2906915dfe95a4fc3de990e4f80 And looking through the commit, it appears that all the changes are present. I assume that the best thing to do is to put the new commit id in a comment on the issue, and then mark the issue as Status::Verified. Are there any objections to this action? Thanks, Carl This is a commit I pushed for someone way back but that I think David had some problems with when he came to do his cherry picking and had to fix it. So yes put in that new commit. See: https://lists.gnu.org/archive/html/lilypond-devel/2020-02/msg9.html James
PATCHES - Countdown for May 15th
Hello, Here is the current patch countdown list. The next countdown will be on May 17th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !21 Update CG to state Python 3 requirement - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/21 !19 ignore settings for the vscode editor - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/19 !17 Use vsize for source files - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/17 !16 Quote_iterator: use vsize for index - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/16 !15 ignore conversion warning in lexer.cc - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/15 !14 do not use depcrecated %error-verbose (bison 2013) - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/14 !13 Modify obvious incorrect types - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/13 !12 Valid declaration of unused arguments - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/12 !11 Sequential_iterator maintenance - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/11 !9 Issue 4182: avoid checking the offset of cross-staff stems too early - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/9 !8 Resolve "Remove deprecated context properties" - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/8 !7 Resolve "Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver." - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/7 !5 Enable 'relative-includes by default. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/5 Countdown: !37 Fix #5234: Segfault when music is empty and only MIDI file is generated - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/37 !32 Percent_repeat_iterator: stop gratuitous use of std::string - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/32 !31 Lilymidy: open midi files in binary mode - Martin Neubauer https://gitlab.com/lilypond/lilypond/-/merge_requests/31 !30 Remove break-visibility handling in tablature ties - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/30 !29 Comment fixes for offset_directed - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/29 !28 Resolve "Use a callback for Percent_repeat_iterator's repeat action" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/28 !27 Use `-dfont-ps-resdir` for make doc - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/27 !26 Split glyph contours in up/down segments for skylines - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/26 !24 Cache the name => index lookup in Open_type_font - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/24 !20 Add regtest for multiple post-events wrapper behavior - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/20 !3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/3 Review: !34 Normal output to stdout - Jaap de Wolff https://gitlab.com/lilypond/lilypond/-/merge_requests/34 !22 Doc: remove now unnecessary dummy argument after lilypond -dshow-available-fonts - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/22 !4 Ensure having valid references to the position in the source file while... - Martin Neubauer https://gitlab.com/lilypond/lilypond/-/merge_requests/4 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Re: PATCHES - Countdown for May 15th
On 15/05/2020 14:16, Jonas Hahnfeld wrote: Am Freitag, den 15.05.2020, 13:44 +0100 schrieb James: Hello, Here is the current patch countdown list. The next countdown will be on May 17th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: To push patches and automatically close the merge request, GitLab needs to know about the rebased commits. This is easiest if you click "Rebase" in the UI, but doing so locally and force-pushing the branch is also fine. Afterwards you can either click "Merge" (I verified that all target staging instead of master) or just push the identical set of commits to staging. The second part only works if you are a member of the group on GitLab. If not, you need somebody from the team to merge for you. Still the commits need to be rebased (and possibly squashed). This is easiest if you give us permission to do so, which is documented here: https://docs.gitlab.com/ee/user/project/merge_requests/allow_collaboration.html Otherwise we'll probably need to go through multiple iterations of you rebasing and us trying to merge until it is fast-forward... Regards Jonas So what Jaap is doing and triggering re-instatement of Patch::label is a mistake? I've just got a lot of 'push' patches back to 'new'. James
Re: PATCHES - Countdown for May 15th
Hello, On 15/05/2020 15:05, lilyp...@de-wolff.org wrote: I did a rebase, that triggered it OK Jonas, that might be the first 'wrinkle' for me in the process. To save me blindly re-testing a 'new patch' labelled issue. I cannot really tell easily a real new patch and one that is rebased ready for pushing. What do you think? James
Re: PATCHES - Countdown for May 15th
On 15/05/2020 15:25, Jonas Hahnfeld wrote: I cannot really tell easily a real new patch and one that is rebased ready for pushing. What do you think? That the script is doing exactly what I told it to do: The diff between the previous and the rebased commit is not empty. Therefore it adds the Patch::new label, removing Patch::push. While correct in theory (new diff = new testing), I think we should ignore updates once in Patch::push. If the author changes something which was not in previous versions of the patch, we need to reset to Patch::new manually. Does this sound acceptable? Jonas I'll let you and the developers figure that out, I can work with whatever I need to do. If it means I occasionally retest a patch twice, then so be it. No big deal. James
Re: Markup vertical alignment
Hello, On 20/05/2020 19:36, Valentin Villenave wrote: By the way, isn’t it time to retire \null? Or at least change its oh-so-deceptive name. (\point might be confusing in another way, though; I’m open to suggestions.) Cheers, -- V. A bit like this (still open) issue? https://sourceforge.net/p/testlilyissues/issues/1322/ ;) Mind you I was sure there was some discussion in dev-lilypond a few years ago about /null - whether to keep it or change it or something (!?) - but I am having a hard time finding it in the archives (I may be mis-remembering but there was some big(ish) patch around /null and spacing and there was a similar discussion about renaming it with regard to related 'null-ish' tricks s1*0 and <> I'll keep hunting to see if I can find it (in case it saves some time re-hashing old ground). James
PATCHES - Countdown for May 21st
Hello, Here is the current patch countdown list. The next countdown will be on May 23rd A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !58 Doc typos: remove double backslash in `@code{}` - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/58 !54 Some documentation cleanups - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/54 !52 Optimize text replacement - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/52 !50 Remove some ancient long-unused cruft - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/50 !49 Remove operator= from Scheme_hash_table - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/49 !43 Issue #5234: Avoid writing a MIDI file when there is no music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/43 !42 Resolve "(*location*) returning no valid value while parsing embedded scheme" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/42 !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/38 Countdown: !64 fixcc.py: update for python3 - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/64 !59 Doc: use \new and \context more consistently (fix #1322) - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/59 !44 Change ly_chain_assoc_get to use eq? - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/44 Review: !65 musicxml2ly: support multiple elements - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/65 !57 Enable GitLab CI - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/57 !53 Allow CSS-style colors anywhere - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/53 !48 skyline: minor performance tweaks - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/48 !47 Stop smobifying Transform - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/47 New: !67 Doc: update NR 1.8.2.3 Text alignment - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/67 !63 Fix #967: add a --svg command line option. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/63 !60 WIP: Resolve "Use templates for lots of conversions to SCM and back" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/60 Waiting: No patches in Waiting at this time. *** Regards, James
Re: [RFC] Enabling GitLab CI
On 21/05/2020 12:02, Han-Wen Nienhuys wrote: so a next step might be making the countdown process more continuous. What does that mean - even conceptually? The countdown is specifically to allow everyone some time to breathe and digest patches submitted without the fear of having to be always-on and missing anything. I understand the 'jam' on countdown days, but honestly how is having a countdown every day (or continuously) going to change that? I think this was touched on before, when you came back into the development group didn't seem to get the point of what my role was for in regard to countdowns. I know that other developers have been frustrated with the countdown as well (at least at first) and while I appreciate that not all patches need that much of a review, it has been evident even in these these last few weeks that some things you have felt trivial or self-evident has lead to much discussion and debate. Also note that I currently do a 2 day countdown now (mainly because I have the scope working from home), the original idea of the countdown was for 4 days as that was felt to give enough time for everyone to see a submitted patch AND give it consideration AND continue to develop at the same time. We have more devlopers and many more patches than then and we're alreadyt working on a shorter countdown. So please remember the point of countdown, it's a deliberate braking system to stop rushing things through that some might want to care about. That doesn't mean I need to do it, but neither does it mean we need 'continuous' countdown (whatever that means). Thanks. James
PATCHES - Countdown for May 25th
Hello, Here is the current patch countdown list. The next countdown will be on May 27th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !65 musicxml2ly: support multiple elements - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/65 !63 Fix #967: add a --svg command line option. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/63 !48 skyline: minor performance tweaks - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/48 Countdown: !79 Rational: trade set_infinite () for infinity () - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/79 !78 Resolve "With `title = ""` SVG output differs from PDF output" - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/78 !77 Remove old .css link before installing new one - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/77 !75 Clarify Moment math in the C++ code - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/75 !74 Issue 5262: LM: incorrect staff-staff-spacing example (regression) - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/74 !73 Handle round-filled-box with infinity in arguments - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/73 !70 random cleanups in the output framework - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/70 !68 Resolve "Keys won't display as text in saxophone diagram" - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/68 !60 Resolve "Use templates for lots of conversions to SCM and back" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/60 Review: !82 Enable debug checks in CI - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/82 !81 Add CFF font name cache to get_postscript_name () - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/81 !76 cleanups related to break-visibility handling - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/76 !72 Move skylines_from_stencil out of the Stencil class - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/72 !69 ps-to-png: use GhostScript's DownScaleFactor for antialiasing - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/69 !53 Allow CSS-style colors anywhere - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/53 !47 Stop smobifying Transform - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/47 New: !86 Use exist_ok=True instead of checking os.path.isdir() first - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/86 !84 WIP: rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 !83 doc build cleanups - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/83 !71 Fix input/regression/skyline-grob-rotation.ly - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/71 Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for June 2nd
Hello, Here is the current patch countdown list. The next countdown will be on June 4th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !110 Doc: clarify what’s an “articulation” in NR appendix. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/110 !105 cleanups in (translated) docs. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/105 !102 Doc: clarify and expand \defineBarLine NR documentation - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/102 !101 test-file-path.cc: fix undefined behavior - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/101 !97 Remove obsolete and inadequate logging functions - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/97 !96 Doc: add TMPDIR in Usage (fix #5993) - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/96 !67 Doc: update NR 1.8.2.3 Text alignment - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/67 Countdown: !117 unify logic for CLI and API access to GS - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/117 !116 Music_iterator: run_always → eager - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/116 !115 Declare music iterator classes "final" when applicable - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/115 !114 compute_foo → calc_foo - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/114 !113 Set GS page size in device properties - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/113 !112 Resolve "Fix mixups of Drul_array and Interval_t" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/112 !111 Copy the device when using the Ghostscript API - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/111 !109 Update syntax & behavior for fingerings & string numbers - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/109 !106 Inline musicxml make templates - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/106 !104 misc cleanups in lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/104 !103 Fixes for GS API mode - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/103 !98 fix rounded corner skylines - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/98 !72 Move skylines_from_stencil out of the Stencil class - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/72 !56 Break substitution cleanup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/56 Review: !94 Support C++ range-for iteration of SCM lists - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/94 !80 Resolve "fingeringOrientations don't deal properly with omitted Fingering-stencils" - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/80 New: !91 Doc: expand NR 1.6.2.3 Hiding staves - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/91 Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for June 16th
Hello, Here is the current patch countdown list. The next countdown will be on June 18th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !168 Doc: improve NR 3.4.2 skipTypesetting subsec. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/168 !154 Inline MIDI templates into input/regression/midi/GNUmakefile - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/154 !151 Remove sponsors from webpage - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/151 !149 Augment predicate documentation, fix primary/secondary distinction - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/149 !125 Drop lily-git - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/125 Countdown: !166 parser: use %api.pure instead of deprecated %pure-parser - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/166 !165 Website post-processing: Reindent to < 80 cols - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/165 !162 Remove unused file python/safeeval.py - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/162 !159 Spanner::fast_substitute_grob_array: fix int/vsize confusion - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/159 !158 Various Scheme cleanups - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/158 !156 Disable Perl's hash randomization - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/156 !152 Make Transform more visible to Scheme - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/152 !148 Fixes for release build with GUB - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/148 !147 Avoid scm_append_x for property values - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/147 !145 Add PDF bookmark support & multi-level TOC outline ability. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/145 !99 Use common pitchnames and glyphs alist for non-standard notations - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/99 Review: !161 bracketify-stencil: refuse to add brackets to empty stencil - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/161 !157 Janitorial work: fix/update/add copyright headers. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/157 New: !167 Cast away type warning for Paper_column::rank - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/167 !164 Use cp to create out/ files from source - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/164 !138 footnote engraver fixes - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/138 Waiting: !155 Make CI test one file without GS API - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/155 *** Regards, James
PATCHES - Countdown for June 18th
Hello, Here is the current patch countdown list. The next countdown will be on June 20th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !166 parser: use %api.pure instead of deprecated %pure-parser - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/166 !165 Website post-processing: Reindent to < 80 cols - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/165 !162 Remove unused file python/safeeval.py - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/162 !159 Spanner::fast_substitute_grob_array: fix int/vsize confusion - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/159 !158 Various Scheme cleanups - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/158 !156 Disable Perl's hash randomization - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/156 !152 Make Transform more visible to Scheme - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/152 !149 Augment predicate documentation, fix primary/secondary distinction - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/149 !147 Avoid scm_append_x for property values - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/147 !145 Add PDF bookmark support & multi-level TOC outline ability. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/145 !99 Use common pitchnames and glyphs alist for non-standard notations - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/99 Countdown: !172 MacPorts fixes - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/172 !171 texi2html: Simplify print_navigation - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/171 !169 texi2html: Move translations to lang.init - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/169 !167 Cast away type warning for Paper_column::rank - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/167 !155 Make CI test one file without GS API - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/155 !138 footnote engraver fixes - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/138 Review: !170 Doc: Remove AJAX search - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/170 !164 Use cp to create out/ files from source - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/164 !161 bracketify-stencil: refuse to add brackets to empty stencil - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/161 !157 Janitorial work: fix/update/add copyright headers. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/157 New: !100 Write output files atomically - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/100 Waiting: No patches in Waiting at this time. *** Regards, James
Re: LilyPond | Pipeline #156017999 has failed for dev/hanwen/doc-build | 47b263b1 in !84
On 18/06/2020 09:18, Jonas Hahnfeld via Discussions on LilyPond development wrote: Another things to consider (if you build docs locally) if to remove extractpdfmark. It is extremely slow. Ack. Yes but let's not do that for the PDFs we eventually use for the website. The size savings are worth it for users - at least from the feedback we had when Hosoda-san came up with this. Maybe, if it is so slow (and I guess that is a relative term), he can improve it? James
Re: [RFC] Use GitLab Milestones
Hello On 22/06/2020 18:33, Jonas Hahnfeld wrote: In short, I'd like to propose that we replace the labels Fixed_x_y_z with milestones x.y.z and use these to track which issues were fixed for a particular release. Just so you know I have just gone through all the 'Fixed_' labels this morning and they are all consistent now. The form is Fixed_X_XX_XX e.g Fixed _2_04_01 or Fixed_2_19_01 There was no consistency for single digit or version 'zero' builds so I made sure they always had 2 numerals even they were '00' just in case this helps with find/replace. This has the advantage of a) less labels which makes the drop-downs more usable and b) the possibility to close milestones. After all, we're not going to fix bugs in already released versions and they don't need to be available for new issues. This topic already surfaced right after the migration to GitLab, but now I finally had the chance to look into this with more detail. In particular we now seem to have a common naming for the labels in question (great work by James!) which makes scripting much more feasible. I've already started to write scripts to create the 328 milestones (that's what they tell me) and automatically assign 3662 issues which have exactly one label of the form mentioned above. Additionally, my scripts think that there are 277 issues with two or more labels (attached to this message). Most are instances of "fix was backported to a stable version", but I'd like to check them manually. Also deleting the labels stays manual to make sure that the scripts correctly assigned the milestones and did not miss any. Help on this part would be appreciated after running the scripts 😉 The bad news is that both creating and assigning a milestone induce notifications. We likely don't want to receive 4000 emails when running the scripts, so we should disable notifications of the lilypond project for that time frame. This means contributions during that period (~30 minutes?) might stay under the radar at first, but that's probably acceptable. That's a good idea. Perhaps block all access for that period (can you do that easily and informatively?). Let me know what you think! There is one thing that I find with the labels (and I don't care either way) its those of the form Type::XXX vs just a normal string e.g. Type::Maintainabilty vs just Maintainability. You cannot have two labels of Type::XXX on the same issue. So an issue that was labelled 'Font' AND 'Scripts' in the past, for instance, could not be both Type::Font AND Type::Scripts. One replaces the other (at least when I tested it manually). Is this XXX:: what they call 'scoping'? Anyway, we're a few 'non-scoped' labels out there and I wonder (apart from the 'Patch::' labels) what the pros and cons of having a XXX:: label vs just a string. James
Re: [RFC] Use GitLab Milestones
On 23/06/2020 20:47, Jonas Hahnfeld wrote: Never understood the difference between Started and Accepted either. While we have definitions in the CG as Carl pointed out the context of this was, if I remember correctly, to a make sure developers could see clearly if a tracker issue entered had been at least checked by someone who knew LP against the issue and that the issue itself that it was 'valid' than perhaps a duplicate of something else, or was fixed in a later (unstable) versions, or that the issue 'needed evidence' or 'examples of real-world scores' before they were considered worth working on. It's the equivalent of 'Verified' but for newly entered issues. A LP developer who created an issue with a patch/fix would simply jump to 'started'. This was something else that a 'non-developer' could contribute to the LP project so developers could get on with fixing issues. Regards James
PATCHES - Countdown for June 26th
Hello, Here is the current patch countdown list. The next countdown will be on June 28th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !193 Fixes for recent makeinfo - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/193 !189 Web: new italian mailing list - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/189 !180 DOC: Changes to the documentation on using Make with LilyPond - Fr. Samuel Springuel https://gitlab.com/lilypond/lilypond/-/merge_requests/180 !157 Janitorial work: add copyright headers. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/157 !100 Write output files atomically - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/100 !93 Rational: avoid testing values that invoke undefined behavior - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/93 Countdown: !199 Allow building with texi2html-5.0 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/199 !197 Remove i18n support from fontextract.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/197 !195 changes.tely: Use \lilyTitlePage{} - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/195 !190 lilylib cleanup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/190 !188 doc rewrite preliminaries - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/188 !161 bracketify-stencil: refuse to add brackets to empty stencil - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/161 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Re: failing CI builds
Jonas On 26/06/2020 22:36, Jonas Hahnfeld wrote: Hi all, at least the following two MRs experience strange failures in CI: https://gitlab.com/lilypond/lilypond/-/merge_requests/191 https://gitlab.com/lilypond/lilypond/-/merge_requests/201 The latter one is mine and I can reproduce this on my own runner, which means I can get the log files easily and even connect from the host with gdb and get a bracktrace (see attached files). It's failing somewhere deep inside libguile.so - any ideas? When comparing the build artifacts, I noticed that the output files in mf/ are not reproducible. I'm not sure if that is related, but the lilypond binary itself is reproducible and the container image is for sure, so it has to be something else. I tried to build everything (as I used to) but using manual step-by-step. After make/make test-baseline from current master, I then applied MR 191 (which applied OK) and then after runing a config -recheck and touching config.h the next step in my 'full' build process is to make sure that the makelsr snippets works (I do this to cover any patches that include changes to snippets new, if the patch doesn't then it is just a few more seconds wasted nothing more. However during a makelsr run I am seeing this .. makelsr.py: writing Documentation/snippets/modifying-tuplet-bracket-length.ly Traceback (most recent call last): File "build/out/bin/convert-ly", line 65, in import lilylib as ly ModuleNotFoundError: No module named 'lilylib' .. for some snippets. But the script completes. Then I make clean test-clean and doc-clean and start a new make, make check and make doc (with the patch applied). It all completes without any problems. James Jonas
PATCHES - Countdown for June 28th
Hello, Here is the current patch countdown list. The next countdown will be on June 30th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !199 Allow building with texi2html-5.0 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/199 !197 Remove i18n support from fontextract.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/197 !195 changes.tely: Use \lilyTitlePage{} - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/195 !189 Web: new italian mailing list - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/189 !180 DOC: Changes to the documentation on using Make with LilyPond - Fr. Samuel Springuel https://gitlab.com/lilypond/lilypond/-/merge_requests/180 !161 bracketify-stencil: refuse to add brackets to empty stencil - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/161 !157 Janitorial work: add copyright headers. - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/157 Countdown: No patches in Countdown at this time. Review: No patches in Review at this time. New: !205 CI: enable UBSan, error on printf format problems - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/205 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !203 Use error expression arg of check_scheme_arg more often - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/203 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !198 to_scm and from_scm improvements - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/198 !190 lilylib cleanup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/190 !188 doc rewrite preliminaries - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/188 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 Waiting: !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for June 30th
Hello, Here is the current patch countdown list. The next countdown will be on July 2nd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !189 Web: new italian mailing list - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/189 Countdown: !207 langdefs: remove unused double_punct_char_sep - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/207 !205 CI: enable UBSan, error on printf format problems - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/205 !203 Use error expression arg of check_scheme_arg more often - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/203 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !201 Fix external refs with texi2html-5.0 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/201 !198 to_scm and from_scm improvements - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/198 !190 lilylib cleanup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/190 !188 doc rewrite preliminaries - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/188 Review: !209 DOC: Changes to the documentation on using Make with LilyPond - Fr. Samuel Springuel https://gitlab.com/lilypond/lilypond/-/merge_requests/209 New: !211 Make duration parsed as music arg sets default duration - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/211 !210 Doc-Usage: Small fixes and clarifications regarding lilypond-book usage with texinfo - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/210 Waiting: !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 8th
Hello, Here is the current patch countdown list. The next countdown will be on July 10th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !224 Quote_iterator: use C++11 default member initialization - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/224 !221 aclocal: use include for the in-place build too - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/221 !220 Add Ghostscript commands to debug message if `-dgs-api=#f` - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/220 !219 Return SCM_UNSPECIFIED rather than SCM_UNDEFINED - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/219 !218 Fix `-dgs-never-embed-fonts` - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/218 !217 Stepmake: Fix uninstall process - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/217 Countdown: !229 Various internal renaming (C++) - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/229 !228 Remove unneeded files from build artifacts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/228 !227 doc preliminaries - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/227 !226 Fix autogen.sh CFLAGS="foo bar" - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/226 !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/38 Review: No patches in Review at this time. New: !230 musicxml2ly: Bar check only before first note - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/230 Waiting: !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 10th
Hello, Here is the current patch countdown list. The next countdown will be on July 12th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !229 Various internal renaming (C++) - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/229 !228 Remove unneeded files from build artifacts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/228 !227 doc preliminaries - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/227 !226 Fix autogen.sh CFLAGS="foo bar" - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/226 !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/38 Countdown: !233 Emmentaler-brace: do not write temporary afm files - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/233 !232 doc: Fix index entries with `@sortas` if used with recent `texinfo.tex` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/232 !231 Update authors.itexi - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/231 !230 musicxml2ly: Bar check only before first note - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/230 Review: No patches in Review at this time. New: !234 lilypond-book: Allow spaces in directory name - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/234 Waiting: !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 14th
Hello, Here is the current patch countdown list. The next countdown will be on July 16th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !238 doc: Fix @funindex entries with both `foo` and `\foo` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/238 !234 lilypond-book: Allow spaces in directory name - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/234 !233 Emmentaler-brace: do not write temporary afm files - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/233 Countdown: !240 Music_iterator: get_own_context and set_own_context - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/240 !237 extract_texi_filenames: remove warning about non-existent directories - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/237 !236 Build website from Gitlab CI. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/236 Review: !241 Add media{} macro - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/241 New: !246 Fix HTML docs with Perl 5.10 in GUB - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/246 !245 Allow "make dist" for in-tree builds - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/245 !242 Fix Ghostscript command for selecting a device - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/242 Waiting: !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 16th
Hello, Here is the current patch countdown list. The next countdown will be on July 18th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !240 Music_iterator: get_own_context and set_own_context - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/240 Countdown: !246 Fix HTML docs with Perl 5.10 in GUB - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/246 !242 Fix Ghostscript command for selecting a device - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/242 Review: !250 Avoid calling configuration_length with zero force twice - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/250 !249 Scheme-based implementation of the new grob DurationLine - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/249 !241 Add staticFile{} macro - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/241 !237 extract_texi_filenames: remove warning about non-existent directories - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/237 !236 Build website from Gitlab CI. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/236 !225 Fixes for Guile compilation - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/225 New: !245 Allow "make dist" for in-tree builds - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/245 Waiting: !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 20th
Hello, Here is the current patch countdown list. The next countdown will be on July 22nd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !250 Avoid calling configuration_length with zero force twice - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/250 !241 Add staticFile{} macro - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/241 !236 Build website from Gitlab CI. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/236 !225 Fixes for Guile compilation - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/225 Countdown: !254 make temp file creation more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/254 !253 Reformat all Python files - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/253 !249 Scheme-based implementation of the new grob DurationLine - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/249 !245 Allow "make dist" for in-tree builds - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/245 !237 extract_texi_filenames: remove warning about non-existent directories - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/237 !191 Use URW fonts instead of TeX Gyre as the default - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/191 Review: !260 Reinstate --error-limit=0 for texi2html 1.82 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/260 !259 Tuplet_iterator: defer reading a context property - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/259 !258 Clean up outdated web pages - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/258 !257 framework-ps.scm: Remove `pngresolution` paper variable. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/257 !256 scm: avoid string-match in notehead printing function - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/256 !255 scm: remove unused check-memory - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/255 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 New: No patches in New at this time. Waiting: !251 Big Python coding style cleanup - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/251 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 22nd
Hello, Here is the current patch countdown list. The next countdown will be on July 24th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !254 make temp file creation more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/254 !253 Reformat all Python files - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/253 !237 extract_texi_filenames: remove warning about non-existent directories - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/237 !236 Build website from Gitlab CI. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/236 !191 Use URW fonts instead of TeX Gyre as the default - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/191 Countdown: !260 Reinstate --error-limit=0 for texi2html 1.82 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/260 !259 Tuplet_iterator: defer reading a context property - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/259 !258 Clean up outdated web pages - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/258 !257 framework-ps.scm: Remove `pngresolution` paper variable. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/257 !256 scm: avoid string-match in notehead printing function - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/256 !255 scm: remove unused check-memory - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/255 Review: !265 scm: disable embedded-ps and embedded-svg in -dsafe mode - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/265 !264 Cleanup annotation and font-size - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/264 !263 website_post: remove Google Analytics support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/263 !262 langdefs: capitalize language definitions - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/262 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 New: No patches in New at this time. Waiting: !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 !251 Big Python coding style cleanup - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/251 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
PATCHES - Countdown for July 24th
Hello, Here is the current patch countdown list. The next countdown will be on July 26th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !262 langdefs: capitalize language definitions - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/262 !260 Reinstate --error-limit=0 for texi2html 1.82 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/260 !259 Tuplet_iterator: defer reading a context property - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/259 !258 Clean up outdated web pages - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/258 !257 framework-ps.scm: Remove `pngresolution` paper variable. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/257 !256 scm: avoid string-match in notehead printing function - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/256 !255 scm: remove unused check-memory - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/255 !237 extract_texi_filenames: remove warning about non-existent directories - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/237 !236 Build website from Gitlab CI. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/236 Countdown: !267 Revert "Issue 4182: avoid checking the offset of cross-staff stems too early" - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/267 !266 Add .setsafe for Ghostscript command - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/266 !265 scm: disable embedded-ps and embedded-svg in -dsafe mode - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/265 !264 Cleanup annotation and font-size - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/264 !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 Review: !268 Update documentation for font changes - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/268 !263 website_post: remove Google Analytics support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/263 !251 Big Python coding style cleanup - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/251 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 New: !271 Simultaneous_music_iterator: avoid use after GC - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/271 !269 Some cleanups in fret-diagrams.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/269 Waiting: !270 Tweak outside-staff-placement-directive regression test - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/270 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 !191 Use URW fonts instead of TeX Gyre as the default - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/191 *** Regards, James
Re: GSoC 2020: Shape-note notehead encoding
On 24/07/2020 01:17, Aaron Hill wrote: On 2020-07-23 4:28 pm, Owen Lamb wrote: (It starts to get confusing to keep track of diagonal directions after a while, so for the sake of clarity, I'll be talking about diamonds with thick NE and SW sides as Calimaine, and those with thick NW and SE sides as Florington, after the states roughly in the corresponding corners of the continental U.S. A bit fanciful, but the portmanteaus are easier to distinguish than jumbles of capital letters.) Hmm... "Calimaine" sounds like a lotion. But why not "Washida"? While we have our problems up here in the Pacific Northwest, I am mildly displeased at having to be associated with Florida in the first place and more so with them getting top billing. :P (For the record, I am a Washingtonian who lived in Florida for several years, so I have experience with both states, notwithstanding a childhood spent in Kansas, Misery [sic], and briefly New Jersey. There are few US stereotypes I have not yet had to contend with.) I've been working for an FLA based company for the past 20 years and have visited the state many times for work, I've yet to discover what the FLA stereotype is, as no one I know actually _comes_ from Florida. Hmm ... maybe *that's* the stereotype?!. :D James
PATCHES - Countdown for July 28th
Hello, I notice there are more and more patches on 'Waiting' now, I assume the majority of these are waiting on MR 84 (doc cleanup) but it is not always evident to me? Here is the current patch countdown list. The next countdown will be on July 28th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !265 scm: disable embedded-ps and embedded-svg in -dsafe mode - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/265 !258 Clean up outdated web pages - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/258 Countdown: !271 Simultaneous_music_iterator: avoid use after GC - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/271 !269 Some cleanups in fret-diagrams.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/269 !266 Add .setsafe for Ghostscript command - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/266 !263 website fixes for cross checking !84 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/263 !251 Big Python coding style cleanup - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/251 Review: !275 Derive Part_combine_iterator from Simultaneous_music_iterator - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/275 !273 Add regression test for horizontal beams - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/273 !264 Cleanup annotation and font-size - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/264 New: !276 Context: revise now_mom () and get_output_def () - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/276 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 Waiting: !270 Tweak outside-staff-placement-directive regression test - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/270 !268 Update documentation for font changes - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/268 !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 !191 Use URW fonts instead of TeX Gyre as the default - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/191 *** Regards, James
Make doc and ghostscript warnings - cannot find TexGyre/Emmentaler
Hello, I thought I'd do a full make/make doc since the last set of merges about 5 mins ago (just because I have time) using verbose logging and I noticed a slew of these --snip-- ... GPL Ghostscript 9.50 (2019-10-15) Copyright (C) 2019 Artifex Software, Inc. All rights reserved. This software is supplied under the GNU AGPLv3 and comes with NO WARRANTY: see the file COPYING for details. Processing pages 1 through 7. Page 1 Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/Emmentaler-20. Loading Emmentaler-20 font from /home/james/lilypond-git/build/out-fonts/Font/Emmentaler-20... 5100336 3637215 3402856 2011823 4 done. Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/TeXGyreSchola-Regular. Loading TeXGyreSchola-Regular font from /home/james/lilypond-git/build/out-fonts/Font/TeXGyreSchola-Regular... 5108784 3665960 3764912 2366929 4 done. Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/Emmentaler-26. Loading Emmentaler-26 font from /home/james/lilypond-git/build/out-fonts/Font/Emmentaler-26... 5108784 3679071 4175000 2777437 4 done. Page 2 Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/Emmentaler-20. Loading Emmentaler-20 font from /home/james/lilypond-git/build/out-fonts/Font/Emmentaler-20... 5170536 3762651 3483656 2100164 4 done. Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/TeXGyreSchola-Italic. Loading TeXGyreSchola-Italic font from /home/james/lilypond-git/build/out-fonts/Font/TeXGyreSchola-Italic... 5170536 3769477 3865912 2465135 4 done. Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/TeXGyreSchola-Regular. Loading TeXGyreSchola-Regular font from /home/james/lilypond-git/build/out-fonts/Font/TeXGyreSchola-Regular... 5190736 3782870 4328968 2911320 4 done. Can't find (or can't open) font file /usr/share/ghostscript/9.50/Resource/Font/Emmentaler-11. Loading Emmentaler-11 font from /home/james/lilypond-git/build/out-fonts/Font/Emmentaler-11... 5231520 3819735 4746112 3321875 4 done. Page 3 ... --snip-- I don't seem to recall these before (but I haven't really done much looking with make doc for a few weeks now). Sorry if this is noise but should we be concerned? James
PATCHES - Countdown for July 30th
Hello, Here is the current patch countdown list. The next countdown will be on August 2nd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !276 Context: revise now_mom () and get_output_def () - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/276 !275 Derive Part_combine_iterator from Simultaneous_music_iterator - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/275 Countdown: !285 Define color names and procedures as safe - Tim Starling https://gitlab.com/lilypond/lilypond/-/merge_requests/285 !282 Fix and unify relocation of Python scripts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/282 !279 Use configured LaTeX for tests of lilypond-book - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/279 !278 makefile: simplify checking for a test baseline - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/278 !277 Redefine rweb and rwebnamed for the web document - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/277 Review: !288 Major cleanup in fret-diagrams.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/288 !287 Make all the lily-library constants "safe" - Tim Starling https://gitlab.com/lilypond/lilypond/-/merge_requests/287 !286 Fix lilypond-book on Windows - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/286 !284 Copy markup lists when concatenating - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/284 !270 Tweak outside-staff-placement-directive regression test - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/270 !268 Update documentation for font changes - Daniel Benjamin Miller https://gitlab.com/lilypond/lilypond/-/merge_requests/268 !264 Cleanup annotation and font-size - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/264 !84 Rewrite doc build - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/84 New: !290 authors.itexi: list self as developer - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/290 Waiting: !263 website fixes for cross checking !84 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/263 !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 !200 Add snippet translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/200 *** Regards, James
Re: `make all` too verbose after merge #84
Werner On 05/08/2020 04:37, Werner LEMBERG wrote: If I now execute `make doc -j4`, I get zillions lines Page 53 Page 1 Page 2 Page 235 ... emitted by gs, and which are completely useless and clutter the terminal output. I let the above command run overnight so that I can check it in the morning; however, inspite of having a really large scrolling buffer of 1 lines, this was not sufficient to scroll up to the more interesting information. Please fix this. Did you not get this before !84? I am pretty sure I have been seeing these page counts for a while. James
Re: `make all` too verbose after merge #84
Hello On 05/08/2020 11:01, Federico Bruni wrote: On Wed, 5 Aug, 2020 at 07:53, James wrote: I am pretty sure I have been seeing these page counts for a while. Me too. I think it happens when you have extractpdfmark installed. yes that is correct - I remember now. You can uninstall it if you don't need it, it is not mandatory for make doc. Else you'll need to ask Hosoda-san to see if it can be 'turned' off? Perhaps be included in our VERBOSE=X setting so that it can be silenced? It has nothing to do with !84 after all. James
Re: `make all` too verbose after merge #84
Werner On 05/08/2020 12:35, Werner LEMBERG wrote: Nope, IIRC. Only warnings that 'font foo is too large to be included as a subfont' or something similar. I've just tried to compile 2.20 and I get those same Page xx message back then. Hmm. Go check out b39b2e652 for instance (that is the 2.20 'bump welcome' commit that Phil does for a release), and make doc. I've just checked out commit 3eef6cf7 (from July 14th) for a complete doc build – this is a commit that that I've tested previously doing the same. Attached you can find my various log files (containing console output redirected with `&>`); I configured with ./autogen.sh \ --disable-optimising \ --with-texgyre-dir=... \ --with-urwotf-dir=... then built with make all -j4 make doc -j4 As you can see, there are no such page messages. AND I have extractpdftex installed! extractpdfmark not tex (I assume that comment was a typo?) anyway with it installed you will get those messages, without you won't (or at least I did not). and it has been a thing for me for a lot longer than 3 weeks. James
PATCHES - Countdown for August 6th
Hello, Here is the current patch countdown list. The next countdown will be on August 8th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !299 Ensure string for ps-quote in dump-pdf-bookmarks - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/299 !297 Remove "socket" backend - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/297 !296 lily.scm: reformat `-dhelp` output - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/296 !295 musicxml2ly: Enable the '--no-rest-positions' option - John Lemcke https://gitlab.com/lilypond/lilypond/-/merge_requests/295 Countdown: !302 Improve the part combiner's silence analysis - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/302 Review: !304 output-distance.py: detect a new grob - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/304 !301 WIP: fix interaction between dynamics and cross-staff Stems - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/301 New: !309 Update CG for new website setup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/309 !308 Sort src-wildcard results - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/308 !307 Fix draw-thick-zero-fret in fret-diagrams.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/307 !305 Use -q for extractpdfmark GS run - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/305 !300 Drop profile measurements from regtests - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/300 !280 Refactor output backend API for faster eval with guile 2.2 - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/280 Waiting: !292 Separate iterator creation from context creation - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/292 !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 !202 Fix xrefs in learning manual - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 *** Regards, James
Re: collision \breathe with accidentals
On 07/08/2020 10:37, Werner LEMBERG wrote: As the attached images show, the breathing sign *sometimes* collides with accidentals. Looks like a bug. Attached I've added some more tests. LilyPond's behaviour w.r.t. accidentals looks very erratical... Werner Is this another manifestation of that age-old dotted rest problem that plagued the reg tests for years that was fixed end of last year (but I forget by who - Thomas?) where the dot would move sometimes and sometimes not affecting random reg tests? James
PATCHES - Countdown for August 12th
Hello, Here is the current patch countdown list. The next countdown will be on August 14th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !313 website: document Perl fixups in GNUmakefile.in - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/313 !308 Sort src-wildcard results - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/308 !305 Use -q for extractpdfmark GS run - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/305 !300 Drop profile measurements from regtests - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/300 !202 Fix capitalization of anchor - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/202 Countdown: !324 Build input/regression/ as doc-build dependency - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/324 !317 Fix info install - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/317 !314 Midi_stream: Use POSIX call to open temporary file - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/314 !312 website: Symlink foo.en.html => foo.html - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/312 !292 Separate iterator creation from context creation - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/292 !261 doc: Fixes for info file installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/261 Review: !310 seccomp based sandbox. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/310 New: No patches in New at this time. Waiting: !318 WIP: trim texinfo templates - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/318 !223 Clean up and annotate postprocess_html.py - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/223 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
PATCHES - Countdown for August 18th
Hello, Here is the current patch countdown list. The next countdown will be on August 20th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !313 website: document Perl fixups in GNUmakefile.in - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/313 Countdown: !332 WIP: new command line options `-dpng-width` and `-dpng-height` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/332 !327 Excise set-debug-cell-accesses! calls - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/327 !321 fix translation tool invocations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/321 !318 Miscellaneous build system cleanups. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/318 !309 Update CG for new website setup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/309 Review: No patches in Review at this time. New: !328 Avoid X-offset callbacks when getting pure Y aligned side - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/328 Waiting: !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
PATCHES - Countdown for August 20th
Hello, Here is the current patch countdown list. The next countdown will be on August 22nd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !318 Miscellaneous build system cleanups. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/318 !309 Update CG for new website setup - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/309 Countdown: !334 Documentation cleanups - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/334 !328 Avoid X-offset callbacks when getting pure Y aligned side - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/328 Review: !338 Fold WWW-1 and WWW-2 targets together - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/338 !336 Remove dependency on netpbm, use ImageMagick - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/336 !335 Option `anti-alias-factor' only takes positive integers <=8 - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/335 !332 new command line options `-dpng-width` and `-dpng-height` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/332 New: !339 Simultaneous_music_iterator: remove dead code - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/339 Waiting: !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
PATCHES - Countdown for August 24th
Hello, Here is the current patch countdown list. The next countdown will be on August 26th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !342 Fix doc/ja/customized-drum-notation-in-printed-and-midi-output - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/342 !339 Simultaneous_music_iterator: remove dead code - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/339 !335 Option `anti-alias-factor' only takes positive integers <=8 - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/335 Countdown: !343 fix xref deps for translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/343 !340 webserver: Make en the default language - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/340 !338 Fold WWW-1 and WWW-2 targets together - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/338 !336 Remove dependency on netpbm, use ImageMagick - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/336 !332 new command line options `-dpng-width` and `-dpng-height` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/332 Review: !348 lilypond-book: replace reduce() call with list concatenation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/348 !347 doc: qualify snippet paths - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/347 !346 Update documentation of requirements - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/346 !345 extract_texi_filenames: fail on not finding include - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/345 !136 Forbid items from taking spanners as X_AXIS parents. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/136 !45 Clarify System break_into_pieces/break substitution interaction - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/45 New: No patches in New at this time. Waiting: !344 WIP: fully qualify doc includes. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/344 !341 Revise gittxt generation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/341 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
PATCHES - Countdown for August 26th
Hello, Here is the current patch countdown list. The next countdown will be on August 28th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !343 fix xref deps for translations - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/343 !340 webserver: Make en the default language - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/340 !338 Fold WWW-1 and WWW-2 targets together - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/338 !336 Remove dependency on netpbm, use ImageMagick - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/336 !332 new command line options `-dpng-width` and `-dpng-height` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/332 Countdown: !350 Handle an empty volta body more robustly - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/350 !349 Fix missing repeat sign after grace note - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/349 !346 Update documentation of requirements - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/346 !345 extract_texi_filenames: fail on not finding include - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/345 !45 Clarify System break_into_pieces/break substitution interaction - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/45 Review: !351 NR: document peculiar 'Nr.' ligature in URW fonts - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/351 !136 Forbid items from taking spanners as X_AXIS parents. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/136 New: !352 web: Remove links to missing binary packages - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/352 !348 lilypond-book: replace reduce() call with list concatenation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/348 Waiting: !344 WIP: fully qualify doc includes. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/344 !341 Revise gittxt generation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/341 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
PATCHES - Countdown for September 3rd
Hello, Here is the current patch countdown list. The next countdown will be on September 5th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !364 help2man: Don't use locale - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/364 !363 Resolve "convert-ly rule for tocItem" - Joram https://gitlab.com/lilypond/lilypond/-/merge_requests/363 !362 Fix opening files in Python - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/362 !361 NR: Fix broken Cyrillic output in PDFs. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/361 !347 doc: qualify snippet paths - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/347 !341 Revise gittxt generation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/341 !273 Add regression test for horizontal beams - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/273 Countdown: !368 Additional fixes for the doc build - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/368 !367 lilypond book cleanups. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/367 !365 More fixes to convertrules for Python 3 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/365 !356 Merge duplicate numbers on multi-measure rests - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/356 Review: !354 doc: exempt web from .xref-map dependency - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/354 New: !370 lilypond-book: fix --filter option - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/370 Waiting: !344 WIP: fully qualify doc includes. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/344 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
Re: Use of ly:expect-warning in regtests
Hello On 02/10/2020 14:34, Michael Käppler wrote: Maybe James can tell us, why running the regtests with 'warning-as-error #t was never realized. I cannot. I was never part of those decisions. Sorry. James
PATCHES - Countdown for October 13th
Hello, Here is the current patch countdown list. The next countdown will be on October 15th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !450 Regression test for clash between opposite stems from different staves - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/450 !438 Revise handling of "no music in score" scenarios - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/438 !418 CG: Revise Git documentation - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/418 Review: !457 Dev/dak/text replacements recursive - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/457 !456 Let \shape work on scaled values - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/456 !455 Emit logging messages during installation - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/455 !451 Define notehead attachment points separately - Owen Lamb https://gitlab.com/lilypond/lilypond/-/merge_requests/451 !435 Text replacements are not recursive (fixes #6050) - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/435 New: No patches in New at this time. Waiting: !449 Stepmake / po-targets: Various cleanups - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/449 !447 RFC: Rethink horizontal alignment of mid-staff bar numbers - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/447 !344 doc: fully qualify doc includes. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/344 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
Re: Thread about development on -user
On 19/10/2020 08:59, Jean Abou Samra wrote: Just for the record, Jacques started a very general thread about LilyPond development: https://lists.gnu.org/archive/html/lilypond-user/2020-10/msg00420.html I think it was accidentally (?) sent to -user instead of -devel. Anyway, let's keep it there to avoid splitting the discussion. I just wanted to make sure that developers had seen it. Best, Jean I don't monitor the user list (in case that matters to whatever this thread is about) and I am not sure all the other developers do either, so you might not get input from all developers if they are not subscribed to the user list. If this is really a discussion about development and should be on this list, I'd recommend it was 'moved' over to the correct email list, if only to discourage this becoming the norm. James
PATCHES - Countdown for October 29th
Hello, Here is the current patch countdown list. The next countdown will be on October 31st. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !482 lilypond-init.el: Correct auto-mode-alist entries for LilyPond-mode - Martin Joerg https://gitlab.com/lilypond/lilypond/-/merge_requests/482 !481 lilypond-mode.el: Make LilyPond-info point to correct info file - Martin Joerg https://gitlab.com/lilypond/lilypond/-/merge_requests/481 !479 Change directory to $(outdir) for lilypond-book - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/479 !478 Make sign public - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/478 !476 PO: fetch translations from the FTP - Jean-Charles Malahieude https://gitlab.com/lilypond/lilypond/-/merge_requests/476 Countdown: !486 Formalize indefinite-length music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/486 !483 Fix ly:bar-line::calc-anchor - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/483 !477 Resolve more warnings from Clang - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/477 !473 Implement BendSpanner-grob - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/473 !449 Stepmake / po-targets: Various cleanups - Michael K▒ppler https://gitlab.com/lilypond/lilypond/-/merge_requests/449 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: !451 Define notehead attachment points separately - Owen Lamb https://gitlab.com/lilypond/lilypond/-/merge_requests/451 !344 doc: fully qualify doc includes. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/344 !204 Move parallel processing to lilypond-book - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/204 *** Regards, James
Laptop 'broken' - make check no possible at this time
Hello, Last night my laptop's CPU fan stopped working (in quite spectacular and noisy fashion!). I still tried to make check and even using a single CPU Job was too much for it and I got a ton of 'CPU excess heat' messages reported. I really don't want to risk overheating those 8 cores, and have a new fan on order but it will take ~week or so to arrive. That means I cannot do any MR checks at this time, although I can do the countdown as normal. So I'll need someone to step in for now, or you'll have to wait until the replacement arrives. Very sorry for the inconvenience. James
Re: Laptop 'broken' - make check no possible at this time
Hello, On 11/11/2020 17:38, Jonas Hahnfeld wrote: Hi James, all, Am Mittwoch, den 11.11.2020, 10:48 + schrieb James: Hello, Last night my laptop's CPU fan stopped working (in quite spectacular and noisy fashion!). Looks like I am back in action - the replacement part arrived today and seems to be doing its job well. Regards James
PATCHES - Countdown for November 24th
Hello, Here is the current patch countdown list. The next countdown will be on November 26th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !518 Fix inclusion problems - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/518 !510 Various font setup improvements - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/510 Countdown: !516 Doc: Document debug-{slur,beam,tie}-scoring - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/516 !386 Add \volta i,j,k command to mark volta-specific music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/386 Review: !522 Copy Balloon stencil before modifying - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/522 !520 doc: Generate Cyrillic TeX metric files in advance - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/520 New: No patches in New at this time. Waiting: !511 compile.itexi: Update requirements - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/511 *** Regards, James
Re: Advancing to Patch::review
Hello, On 02/12/2020 20:57, Michael Käppler wrote: Am 02.12.2020 um 18:16 schrieb Jonas Hahnfeld: [snip] Circling back to my original proposal: My gut feeling is that this should be somebody else than the MR author Do I interpret your actions that you disagree with this? To elaborate a bit, this tries to keep the pleasant effect that somebody else at least opens your MR and nobody is tempted to change labels because "I'm sure this will pass testing". Well, I agree that it is better to have at least four eyes look at the test results, but since you wrote "You're not sold on this" I thought it would be okay for you if I check the tests myself. I did not include visual screenshots, sorry for that. Do you have any other 'actions' in mind? I assume that checking the results for !533 and setting it to 'review' was ok? If we decide to have the policy "Do not set your own MRs to 'review'", I'm also fine with that. OTOH, I would also trust the developers that they do not set MRs to 'review' without looking at the tests. I'm not sure, however, if it does work well to distribute the job of setting patches from 'new' to 'review', because the frequency of somebody 'passing by' can vary to a great extent and sometimes shared responsibility is noone's responsibility :) Yes the classic 'Bystander Effect' problem. James, what is your opinion on that? Would you still be willing to do this job? Testing Patches was always orthogonal to managing the countdown (which was the original point of the 'Patch Meister' role). I only fell into the testing patches because at the time we had limited resources (hardware was not what it is now) and only a few really active LP dev team members. We were missing a lot of fly-by patches, and some patches were being left to 'die' because no one was reviewing them. I was already doing doc patches and didn't mind stepping in to help the LP team with the testing. The countdown was being done by another volunteer at the time and I only took that on because he decided he didn't want to do it any more and left. I was worried that we'd lose patches or the current devs would not want to be bothered with the managing of all these disparate diff files and git-formatted patches flying about in emails and in reitveld. So I ended up with two roles. Testing and Patch Meister. 'Meistering' patches is trivial because I can do it in a few minutes and on a regular schedule (more or less) and this seems to be working OK - I have no 'skin' in the game as I am not a developer and I hope I bring a sense of fairness to the countdown for patches that are more contentious than others. As for Testing? I am more than happy to 'let go' of the Patch testing frankly, I don't mind doing it, but it does seem silly that this should not be fully automated now. Also I still have to 'look' at the MR for the countdown process, and if somehow we could post the 'URL link' for the diff in the MR thread automatically (rather than go and hunt around for it by clicking icons etc) then that would remove a lot of friction but I think that is not easy/possible to do. I also realise that reg tests are critical to what LP stands for and we do need that human eye on them, but even so... I think we should see how it goes (i.e. fully automated and any other dev can check the diff from now) and trust that the devs will not abuse the system and actually check something than just move on the patch. But as far as I understand it the make-check passing will put the review label on the MR right? Perhaps we need to add a 'step' before we release a new version to the world, by running a full reg test suite and posting it somewhere - I seem to recall that we used to do that in the past, I think Phil had some hacked script he did on his own website that showed diffs between various significant versions. Is something we could do - I don't know enough about what we can and cannot do in Gitlab that we could 'post' somewhere or even view in the repo (even if it was binary output like a PDF)? James Cheers, Michael
Re: Advancing to Patch::review
On 03/12/2020 11:46, Michael Käppler wrote: What do you mean with "full reg test suite"? Additional examples that are not in the normal reg test suite? Well in the 'olden days' we'd have a set of tests on the website - here is an old URL that no longer works (http://lilypond.org/test/v2.13.51-1/compare-v2.13.50-1/index.html <http://lilypond.org/test/v2.13.51-1/compare-v2.13.50-1/index.html>) - and as this was autogenerated as part of the website build, it was quick and easy to see if there were any changes that had altered between, say, last unstable or between current unstable and previous stable. I think comparisons between several versions are of limited usefulness, because it can be difficult to see if changes are intended, not intended, or even occuring at random. Quite, but if you do this 'check' as part of the workflow for the next official release (Phil may already, I don't know and I don't want to necessarily make more work for anyone) then at least we aren't in for any shocks and also, anything that is intended should be in the changes.tely file, so this also helps us keep that up to date. But I am not sure how complex this is to set up again and if it is worth the work or not. In my opinion the current test suite has conceptual problems that go beyond that discussion. E.g. that we don't compare actual output, but grob positions and extents, AFAIK. That lead to problems in Harm's MR: https://gitlab.com/lilypond/lilypond/-/merge_requests/497 Also issues like https://gitlab.com/lilypond/lilypond/-/issues/720 that affect specific backends cannot be tested (or it would require hacks) Yes that is beyond the scope of what I am talking about, but fundamentally it might be useful to someone ('perfect enemy of good' and all that). James
Re: Advancing to Patch::review
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manually in the order of make, make-testbaseline, make check, make doc. In that order. If any of them failed before make doc then I wouldn't bother doing make doc. But it is technically feasible for make doc to fail but make check to work (and vice versa). This is why patches that have not started, not yet completed or have failed make doc are filtered out when I run the useful 'countdown' script Jonas did for us (me) that I use to generate the countdown email and also to see which patches I needed to test. James
Re: Advancing to Patch::review
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manually in the order of make, make-testbaseline, make check, make doc. In that order. If any of them failed before make doc then I wouldn't bother doing make doc. But it is technically feasible for make doc to fail but make check to work (and vice versa). This is why patches that have not started, not yet completed or have failed make doc are filtered out when I run the useful 'countdown' script Jonas did for us (me) that I use to generate the countdown email and also to see which patches I needed to test. James
PATCHES - Countdown for December 4th
Hello, Here is the current patch countdown list. The next countdown will be on December 6th A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !530 Add function to generate different values based on a grob's break direction - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/530 Countdown: !533 Fix and enhance print-gittxt.sh - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/533 !532 Recompute the length of filtered or mapped music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/532 Review: !536 Overload Text_interface to return Stencil by value - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/536 !535 Inline implementations from std-vector.hh - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/535 !534 Preserve line style when creating dashed brackets - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/534 !529 Issue 6060: limit unproductive page spacing checks - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/529 New: !531 Implement FingerGlideSpanner - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/531 Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for December 10th
Hello, Here is the current patch countdown list. The next countdown will be on December 12th A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !541 mf: Generate reproducible fonts - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/541 !540 Fix off-by-one error for slur skylines - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/540 !531 Implement FingerGlideSpanner - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/531 !529 Issue 6060: limit unproductive page spacing checks - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/529 Countdown: !542 Implement semi-transparency for the PS / PDF backend - Knut Petersen https://gitlab.com/lilypond/lilypond/-/merge_requests/542 Review: !535 Inline implementations from std-vector.hh - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/535 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for December 22nd
Hello, Here is the current patch countdown list. The next countdown will be on December 24th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !547 measureStartNow context property and related clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/547 !546 CI enhancements - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/546 !545 Doc: Move search-box.ihtml to Documentation/en - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/545 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - A Christmas Countdown for December 24th
Hello, Here is the current patch countdown list. The next countdown will be on December 26th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !547 measureStartNow context property and related clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/547 !546 CI enhancements - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/546 !545 Doc: Move search-box.ihtml to Documentation/en - Federico Bruni https://gitlab.com/lilypond/lilypond/-/merge_requests/545 Countdown: !551 Auto_beam_engraver: reduce new/delete - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/551 !549 Bend_engraver: avoid mid-measure barlines - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/549 Review: No patches in Review at this time. New: !552 Clean up break-alignable processing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/552 !550 Add metadata of source files embedded in PDFs. - Knut Petersen https://gitlab.com/lilypond/lilypond/-/merge_requests/550 !548 Fix GC crashes during System construction - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/548 Waiting: No patches in Waiting at this time. *** Regards and Happy Christmas everyone! James
PATCHES - Countdown for December 26th
Hello, Here is the current patch countdown list. The next countdown will be on December 28th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !551 Auto_beam_engraver: reduce new/delete - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/551 !549 Bend_engraver: avoid mid-measure barlines - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/549 Countdown: !557 Fix colors for parenthesized/inverted dots in fret-diagrams.scm - Thomas Morleyhttps://gitlab.com/lilypond/lilypond/-/merge_requests/557 !555 Remove unused scm/standalone.scm - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/555 !554 Bar_engraver: reduce property access - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/554 !550 Add metadata of source files embedded in PDFs. - Knut Petersen https://gitlab.com/lilypond/lilypond/-/merge_requests/550 !548 Fix GC crashes during System construction - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/548 !501 Add a regression test for colored dots in fret diagrams - Thomas Morleyhttps://gitlab.com/lilypond/lilypond/-/merge_requests/501 Review: !558 Grob_info: miscellaneous clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/558 !552 Clean up break-alignable processing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/552 New: !559 HOWTO.index: Updated. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/559 Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for December 28th
Hello, Here is the current patch countdown list. The next countdown will be on December 30th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !557 Fix colors for parenthesized/inverted dots in fret-diagrams.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/557 !555 Remove unused scm/standalone.scm - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/555 !554 Bar_engraver: reduce property access - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/554 !552 Clean up break-alignable processing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/552 !548 Fix GC crashes during System construction - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/548 !501 Add a regression test for colored dots in fret diagrams - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/501 Countdown: !562 Extend CG with a remark about deleting remote local branches - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/562 !561 Custos_engraver: avoid reading whichBar - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/561 !560 Melody_engraver: respect mid-measure barlines - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/560 !559 HOWTO.index: Updated. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/559 !558 Grob_info: miscellaneous clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/558 Review: !564 Auto_beam_engraver: clean up the use of whichBar - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/564 !563 backend-library.scm: Sort font definitions in output. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/563 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for December 30th
Hello, Here is the current patch countdown list. The next countdown will be on January 1st. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !562 Extend CG with a remark about deleting remote local branches - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/562 !561 Custos_engraver: avoid reading whichBar - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/561 !560 Melody_engraver: respect mid-measure barlines - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/560 !559 HOWTO.index: Updated. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/559 !558 Grob_info: miscellaneous clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/558 Countdown: !566 Engraver/Performer: remove unused code and virtuality - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/566 !565 Encoding fixes for Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/565 !564 Auto_beam_engraver: clean up the use of whichBar - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/564 !563 backend-library.scm: Sort font definitions in output. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/563 Review: !576 Bar_number_engraver: fix order dependence - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/576 !575 Timing_translator: measureStartNow and \partial - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/575 !574 Add ly:smob-counts, a histogram of live smob types - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/574 !573 Remove separate CSS files for Internet Explorer - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/573 !571 Add option -ddebug-eval - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/571 !570 Remove -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/570 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 1st.
Hello and Happy New Year to everyone! Here is the current patch countdown list. The next countdown will be on January 3rd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !566 Engraver/Performer: remove unused code and virtuality - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/566 !565 Encoding fixes for Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/565 !564 Auto_beam_engraver: clean up the use of whichBar - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/564 !563 backend-library.scm: Sort font definitions in output. - Werner Lemberghttps://gitlab.com/lilypond/lilypond/-/merge_requests/563 Countdown: !577 Open_type_font: use std::unordered_map bbox table - Han-Wen Nienhuyshttps://gitlab.com/lilypond/lilypond/-/merge_requests/577 !576 Bar_number_engraver: fix order dependence - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/576 !575 Timing_translator: measureStartNow and \partial - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/575 !574 Add ly:smob-counts, a histogram of live smob types - Han-Wen Nienhuyshttps://gitlab.com/lilypond/lilypond/-/merge_requests/574 !573 Remove separate CSS files for Internet Explorer - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/573 !571 Add option -ddebug-eval - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/571 !570 Remove -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/570 Review: !589 Volta repeat cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/589 !588 Improve doc-markup-function-properties from document-markup.scm - Thomas Morleyhttps://gitlab.com/lilypond/lilypond/-/merge_requests/588 !587 Remove unused functions from general-scheme.cc - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/587 !586 Correct interfaces in multi-measure-rest-reminder.ly - Jonas Hahnfeldhttps://gitlab.com/lilypond/lilypond/-/merge_requests/586 !581 Add markup-list-command string-lines - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/581 New: No patches in New at this time. Waiting: No patches in Waiting at this time.*** Regards, James
Re: state of the ’Pond for earnest tadpoles
On 02/01/2021 12:20, Thomas Morley wrote: A full `make doc` takes hours for me, even if invoked with `make doc -j5 CPU_COUNT=5` Thus I hardly do so, but use the CG-documented methods: Hours? Really? Perhaps 'an hour' if you were using some very, very old CPU - but even using a single CPU on an 'old' i5 Intel system a full make doc for me took less than 50 mins. That last time it took longer than an hour was when I had an old (8+ years ago) iMac running make doc in a linux VM. James
Re: state of the ’Pond for earnest tadpoles
Hello On 02/01/2021 14:07, Trevor wrote: James wrote 02/01/2021 13:41:06 On 02/01/2021 12:20, Thomas Morley wrote: A full `make doc` takes hours for me, even if invoked with `make doc -j5 CPU_COUNT=5` Thus I hardly do so, but use the CG-documented methods: Hours? Really? Perhaps 'an hour' if you were using some very, very old CPU - but even using a single CPU on an 'old' i5 Intel system a full make doc for me took less than 50 mins. That last time it took longer than an hour was when I had an old (8+ years ago) iMac running make doc in a linux VM. When I had an old laptop with compromised cooling many years ago, a full build used to take several hours, presumably because my cpu was automatically clocked down to keep it from overheating. That was what triggered me to write the original versions (later improved by I forget who) of scripts/auxiliar/doc-section.sh MANUAL SECTION, as I was writing a lot of text for the manuals at the time, and needed to validate my contributions before pushing. Right but that was 'many years ago' those scripts were there when I started (and that was ~2010), but even so, on 1 CPU, my Mother's old laptop (Dell circa 2014 - mid range i3 I think), doing a make doc took only 55 mins tops. I understand that people might still have old hardware, but being worried that make doc takes 'hours' is no longer really true on any reasonable laptop hardware made within the last 5 or 6 years I'd say (using multiple Jobs or not to compile). James
Re: state of the ’Pond for earnest tadpoles
On 02/01/2021 15:38, Kieren MacMillan wrote: I’m using an 11-year old iMac, running LilyDev in a Linux VM. =) Oh .. OK. Yeah. Don't make doc. %^) James
PATCHES - Countdown for January 3rd
Hello, Here is the current patch countdown list. The next countdown will be on January 5th A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !577 Open_type_font: use std::unordered_map bbox table - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/577 !576 Bar_number_engraver: fix order dependence - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/576 !575 Timing_translator: measureStartNow and \partial - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/575 !573 Remove separate CSS files for Internet Explorer - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/573 !571 Add option -ddebug-eval - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/571 !570 Remove -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/570 Countdown: !589 Volta repeat cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/589 !587 Remove unused functions from general-scheme.cc - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/587 !586 Correct interfaces in multi-measure-rest-reminder.ly - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/586 !581 Add markup-list-command string-lines - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/581 !578 Restore '[FILENAME' progress indicator when opening .ly file - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/578 Review: !590 Type-specific C++ grob acknowledgers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/590 !588 Improve doc-markup-function-properties from document-markup.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/588 !583 Support -ddump-signatures in EPS backend - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/583 !580 Remove ly:parser-lexer. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/580 !574 Add ly:smob-counts, a histogram of live smob types - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/574 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Re: state of the ’Pond for earnest tadpoles
Hello On 02/01/2021 16:58, Thomas Morley wrote: Am Sa., 2. Jan. 2021 um 14:41 Uhr schrieb James : On 02/01/2021 12:20, Thomas Morley wrote: A full `make doc` takes hours for me, even if invoked with `make doc -j5 CPU_COUNT=5` Thus I hardly do so, but use the CG-documented methods: Hours? Really? Perhaps 'an hour' if you were using some very, very old CPU - but even using a single CPU on an 'old' i5 Intel system a full make doc for me took less than 50 mins. That last time it took longer than an hour was when I had an old (8+ years ago) iMac running make doc in a linux VM. James time make doc -j5 CPU_COUNT=5 -> real77m53,168s user204m51,501s sys28m57,342s Ok, hours was not exactly correct, but significant more than one hour Cheers, Harm I don't mean to flog this dead horse, but I was curious. I did a make doc with one cpu on my laptop (it has an i7 7700HQ CPU - circa 2017) and while I don't have the exact numbers to hand, as I am currently at work, it was something like real: 45m user:55m (cannot recall sys values), my desktop before that was from 2013 (i5 something) and I was getting sub hour make doc times even then but using 3 CPUs. So you having those timings while using a -j5 option ... wow! I am obviously inhabiting some technological bubble that I wasn't aware I was in. :D James
PATCHES - Countdown for January 5th
Hello, Here is the current patch countdown list. The next countdown will be on January 7th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !589 Volta repeat cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/589 !587 Remove unused functions from general-scheme.cc - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/587 !586 Correct interfaces in multi-measure-rest-reminder.ly - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/586 !581 Add markup-list-command string-lines - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/581 Countdown: !583 Support -ddump-signatures in EPS backend - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/583 !580 Remove ly:parser-lexer. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/580 Review: !597 convert-ly rule for nested define-music-function calls - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/597 !596 Minor regtest warning cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/596 !595 Fix Japanese Noto Serif font name - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/595 !593 Fix leaks in handling Pango fonts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/593 !591 Fix memory leak across files caused by session reuse. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/591 !590 Type-specific C++ grob acknowledgers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/590 !588 Improve doc-markup-function-properties from document-markup.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/588 !574 Add ly:smob-counts, a histogram of live smob types - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/574 New: No patches in New at this time. Waiting: !592 Speed up -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 *** Regards, James
PATCHES - Countdown for January 7th
Hello, Here is the current patch countdown list. The next countdown will be on January 9th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !590 Type-specific C++ grob acknowledgers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/590 !588 Improve doc-markup-function-properties from document-markup.scm - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/588 !583 Support -ddump-signatures in EPS backend - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/583 !580 Remove ly:parser-lexer. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/580 Countdown: !597 convert-ly rule for nested define-music-function calls - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/597 !596 Minor regtest warning cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/596 !595 Fix Japanese Noto Serif font name - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/595 !593 Fix leaks in handling Pango fonts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/593 !591 Fix memory leak across files caused by session reuse. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/591 !574 Add ly:smob-counts, a histogram of live smob types - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/574 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: !592 Speed up -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 *** Regards, James
PATCHES - Countdown for January 9th
Hello, Here is the current patch countdown list. The next countdown will be on January 11th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !597 convert-ly rule for nested define-music-function calls - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/597 !596 Minor regtest warning cleanup - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/596 !595 Fix Japanese Noto Serif font name - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/595 !593 Fix leaks in handling Pango fonts - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/593 !591 Fix memory leak across files caused by session reuse. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/591 Countdown: No patches in Countdown at this time. Review: !600 Trim unnecessary calls of ly_reexport_module() - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/600 !599 Avoid redundant unsmobbing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/599 New: No patches in New at this time. Waiting: !592 Speed up -ddebug-gc-assert-parsed-dead - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 *** Regards, James
PATCHES - Countdown for January 11th
Hello, Here is the current patch countdown list. The next countdown will be on January 13th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !601 Improve left-edge spacing of magnified staves - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/601 !600 Trim unnecessary calls of ly_reexport_module() - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/600 !599 Avoid redundant unsmobbing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/599 Review: !604 Reduce dynamic_cast in ancient ligature engravers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/604 !602 Tuplet_engraver: fix crash due to MMR script - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/602 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 13th
Hello, Here is the current patch countdown list. The next countdown will be on January 15th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !601 Improve left-edge spacing of magnified staves - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/601 !600 Trim unnecessary calls of ly_reexport_module() - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/600 !599 Avoid redundant unsmobbing - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/599 Countdown: !605 Fix documentation of option `-dcrop`. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/605 !604 Reduce dynamic_cast in ancient ligature engravers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/604 !602 Tuplet_engraver: fix crash due to MMR script - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/602 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Pop up from Gitlab about Job artifacts expiring
Hello, I suddenly started getting this pop up when looking at reg tests from our CI system. I can see the date is from last year, so I don't know the significance of me seeing this 'today' - after all, I've been looking at CI reg tests for a while now and not seen this before. So in case this means something to someone or it matters, I thought I'd mention it. James
PATCHES - Countdown for January 15th
Hello, Here is the current patch countdown list. The next countdown will be on January 17th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !605 Fix documentation of option `-dcrop`. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/605 !604 Reduce dynamic_cast in ancient ligature engravers - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/604 !602 Tuplet_engraver: fix crash due to MMR script - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/602 !600 Trim unnecessary calls of ly_reexport_module() - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/600 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 Countdown: !594 Bar numbers should not change with visibility - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/594 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Re: Pop up from Gitlab about Job artifacts expiring
OK, I guess the inline attachments didn't work. Sorry, Here is the text verbatim. --snip-- Important changes to default expiration dates for job meta data and artifacts took effect on June 22, 2020. As part of this change expiration dates have been applied to job artifacts that were created without them. Find out more details and why this benefits all @gitlab <https://gitlab.com/gitlab> users via our blog <https://about.gitlab.com/blog/2020/06/18/job-artifact-meta-data-expiration-change/>. --snip-- On 15/01/2021 09:07, James wrote: Hello, I suddenly started getting this pop up when looking at reg tests from our CI system. I can see the date is from last year, so I don't know the significance of me seeing this 'today' - after all, I've been looking at CI reg tests for a while now and not seen this before. So in case this means something to someone or it matters, I thought I'd mention it. James
PATCHES - Countdown for January 17th
Hello, Here is the current patch countdown list. The next countdown will be on January 19th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !594 Bar numbers should not change with visibility - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/594 Countdown: !607 Require unsmob - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/607 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 Review: !608 Paper_column_engraver clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/608 !606 latex-book: Fix path separator for Windows - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/606 !369 lilypond-book: Fix and improve regular expressions to parse input - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/369 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 19th
Hello, Here is the current patch countdown list. The next countdown will be on January 21st. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !607 Require unsmob - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/607 Countdown: !611 Rational: r.is_infinity () -> isinf (r) - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/611 !610 NR: irregular measures in unmetered music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/610 !609 Remove dead code and declarations - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/609 !608 Paper_column_engraver clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/608 !606 latex-book: Fix path separator for Windows - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/606 !369 lilypond-book: Fix and improve regular expressions to parse input - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/369 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 21st
Hello, Here is the current patch countdown list. The next countdown will be on January 23rd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !611 Rational: r.is_infinity () -> isinf (r) - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/611 !610 NR: irregular measures in unmetered music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/610 !609 Remove dead code and declarations - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/609 !608 Paper_column_engraver clean-up - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/608 !606 latex-book: Fix path separator for Windows - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/606 !369 lilypond-book: Fix and improve regular expressions to parse input - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/369 Countdown: No patches in Countdown at this time. Review: !538 Allow hairpin endpoints to be aligned to NoteColumn directions - David Stephen Grant https://gitlab.com/lilypond/lilypond/-/merge_requests/538 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 23rd
Hello, Here is the current patch countdown list. The next countdown will be on January 25th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !613 Revisions to reduce line length - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/613 !612 Fix handling of file names with non-ASCII characters for Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/612 !538 Allow hairpin endpoints to be aligned to NoteColumn directions - David Stephen Grant https://gitlab.com/lilypond/lilypond/-/merge_requests/538 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 25th
Hello, Here is the current patch countdown list. The next countdown will be on January 27th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !613 Revisions to reduce line length - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/613 !612 Fix handling of file names with non-ASCII characters for Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/612 Countdown: !538 Allow hairpin endpoints to be aligned to NoteColumn directions - David Stephen Grant https://gitlab.com/lilypond/lilypond/-/merge_requests/538 Review: !617 Allow \alternative {...} inside a repeat body - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/617 !616 Reset modules after each file with Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/616 !614 Extend test figured-bass-continuation-center.ly - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/614 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 27th.
Hello, Here is the current patch countdown list. The next countdown will be on January 29th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !618 NR: s/gregorian/Gregorian/ in index - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/618 Countdown: !617 Allow \alternative {...} inside a repeat body - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/617 !616 Reset modules after each file with Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/616 !614 Extend test figured-bass-continuation-center.ly - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/614 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 !538 Allow hairpin endpoints to be aligned to NoteColumn directions - David Stephen Grant https://gitlab.com/lilypond/lilypond/-/merge_requests/538 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 29th.
Hello, Here is the current patch countdown list. The next countdown will be on January 31st. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !617 Allow \alternative {...} inside a repeat body - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/617 !616 Reset modules after each file with Guile 2.x - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/616 !614 Extend test figured-bass-continuation-center.ly - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/614 !592 Make -ddebug-gc-assert-parsed-dead more robust. - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/592 !538 Allow hairpin endpoints to be aligned to NoteColumn directions - David Stephen Grant https://gitlab.com/lilypond/lilypond/-/merge_requests/538 Countdown: !620 Release aftermath - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/620 !619 Improve documentation of \whiteout and related stuff. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/619 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for January 31st
Hello, Here is the current patch countdown list. The next countdown will be on February 2nd. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !620 Release aftermath - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/620 !619 Improve documentation of \whiteout and related stuff. - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/619 Countdown: No patches in Countdown at this time. Review: !624 Fix compilation for mingw - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/624 !623 Fixes for Autoconf 2.70 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/623 !621 Fix warning about 'debug-gc-object-lifetimes - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/621 !451 Define notehead attachment points separately - Owen Lamb https://gitlab.com/lilypond/lilypond/-/merge_requests/451 New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James
Re: who needs script `update-patch-version`?
On 01/02/2021 15:06, Werner LEMBERG wrote: Unfortunately, this is next to impossible since there are so many changes. I will provide a PDF that holds the changed pages so that you and others can simply read what's written there, comparing it with the current version of the Contributor guide if necessary. It was this condition (to provide small incremental changes) that made me abandon editing the docs many years ago. At the time I was part-way through a major reorganisation of 2.1 Vocal Music which I had to abandon as it was simply impossible to do it incrementally. Since then the docs have virtually stagnated. Hope you're able to work this out better than I was able to do, Werner. Well, I revise the stuff, I don't rewrite it, so it's definitely easier, I guess. The main thing is that these extra steps take a significant amount of time, which I think are not really justified for documentation changes (in contrast to code changes) and could be invested into more useful things. Well if you are planning lots of these, I understand how frustrating it can be, as I've done a fair amount of re-writing sections myself (maybe not quite on the scale of Trevor's work but I have done a lot of 're-org' type checkins). However that all said, one man's 'significant amount of time' is another man's 'time well spent'. Why not just see/illustrate/prove how painful it really is (if it actually is after all with our new CI/Gitlab interface) and then afterwards we can all see how we could perhaps improve or bypass some/all countdown steps. The main concern is that things get deleted (either deliberately or accidentally) which was always Graham P's concerns when I did large doc edits. So staging them as section moves and then rewrites is just safe even if it takes a bit longer. Where it becomes tedious is the (IMHO) bike shedding or digressions about things that were not supposed to be the focus of said doc edit like grammar and spelling/punctuation for things not specifically listed in our style guide. When everyone is a doc editor, no one is a doc editor right? James
PATCHES - Countdown for February 2nd
Hello, Here is the current patch countdown list. The next countdown will be on February 4th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !630 NR: \alternative, \volta, \unfolded - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/630 !626 Update ROADMAP file - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/626 !625 Fix line-breaking FingerGlideSpanner for stub-styles - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/625 !624 Fix compilation for mingw - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/624 !623 Fixes for Autoconf 2.70 - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/623 !621 Fix warning about 'debug-gc-object-lifetimes - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/621 !451 Define notehead attachment points separately - Owen Lamb https://gitlab.com/lilypond/lilypond/-/merge_requests/451 Review: !631 Doc-CG: Update information about 'graphviz' - Michael Käppler https://gitlab.com/lilypond/lilypond/-/merge_requests/631 !629 Fix 6092 scripts in percussion-style should be strings - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/629 !628 Minor cleanups of session mechanism - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/628 !627 Revisit rest-markup-commands - Thomas Morley https://gitlab.com/lilypond/lilypond/-/merge_requests/627 New: !632 CG: programming-work.itexi: revised - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/632 Waiting: No patches in Waiting at this time. *** Regards, James