moving figured bass properties to `Score` context

2022-07-10 Thread Werner LEMBERG


Right now, only

```
figuredBassFormatter = #format-bass-figure
```

is set in the definition of `Score` (in file `engraver-init.ly`).
Listening to Jean I think it's best to move all other figured bass
context properties to that location, too.  These properties are

  figuredBassLargeNumberAlignment (default: CENTER)
  figuredBassAlterationDirection (default: #f)
  figuredBassPlusDirection (default: #f)

There will be one more (`figuredBassPlusStrokedAlist`) that I need for
my new figured bass symbols in MR 1460...

WDYT?


Werner



Re: moving figured bass properties to `Score` context

2022-07-10 Thread Jean Abou Samra




Le 10/07/2022 à 15:07, Werner LEMBERG a écrit :

Right now, only

```
figuredBassFormatter = #format-bass-figure
```

is set in the definition of `Score` (in file `engraver-init.ly`).
Listening to Jean I think it's best to move all other figured bass
context properties to that location, too.



For context, the discussion is
https://lists.gnu.org/archive/html/lilypond-user/2022-07/msg00114.html



These properties are

   figuredBassLargeNumberAlignment (default: CENTER)
   figuredBassAlterationDirection (default: #f)
   figuredBassPlusDirection (default: #f)

There will be one more (`figuredBassPlusStrokedAlist`) that I need for
my new figured bass symbols in MR 1460...

WDYT?



For these, the difference is not enormous (it only really matters for 
properties of list type), but why not.


Jean




Re: \fine, pre-process-in-final-translation-timestep & co.

2022-07-10 Thread Jean Abou Samra




Le 09/07/2022 à 19:51, Jean Abou Samra a écrit :

Repeats are complicated and I didn’t give this much thought, so it might make 
no sense, but you see the basic idea: \unfoldRepeats would be able to unfold 
the music in a way that doesn’t need interrupting translation with an event in 
the middle. In the above, which … an event at the point of fine was entered in 
determines whether it is included at the unfolded end.




The currently recommended syntax for DS al fine
repeats is

\repeat segno 2 {
  c'1 1 1 1
  \volta 2 \fine
  c'1 1 1 1
}

This seems to work just as well, though:

\repeat segno 2 {
  c'1 1 1 1
  \volta 2 \fine
  \volta 1 { c'1 1 1 1 }
}

Do you see downsides with that syntax?


If not, how about recommending it and letting \fine no
longer abort translation outside of a folded repeat?

The old syntax will be broken in \unfoldRepeats, but we
could make \fine emit a warning if it appears before the
normal end and outside of a folded repeat so that this
won't go unnoticed.

Jean




Re: moving figured bass properties to `Score` context

2022-07-10 Thread Werner LEMBERG
>> These properties are
>>
>>figuredBassLargeNumberAlignment (default: CENTER)
>>figuredBassAlterationDirection (default: #f)
>>figuredBassPlusDirection (default: #f)
>>
>> There will be one more (`figuredBassPlusStrokedAlist`) that I need for
>> my new figured bass symbols in MR 1460...
>>
>> WDYT?
> 
> 
> For these, the difference is not enormous (it only really matters
> for properties of list type), but why not.

Done, thanks.  I think that MR 1460 is now ready for final reviews.


Werner