Re: music function to be included somewhere in scm/*
I'd advocate to keep minimum-length. I second the vote for collapse-length. Ok, next try: s/minimum-length/length-limit-or-forced-length/g (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if possible.") I still have one problem: \score { %\displayMusic << \new Voice = "singleVoice" { \relative { a'4 a a a \repeat volta 3 { b4 b b b } c4 c c c } } \displayMusic \new Lyrics \lyricsto "singleVoice" { Not re -- peat -- ed. << { The first time words.} \new Lyrics { \set associatedVoice = "singleVoice" Sec -- ond time words. #(make-music (quote CompletizeExtenderEvent)) } \new Lyrics { \set associatedVoice = "singleVoice" The third time words. #(make-music (quote CompletizeExtenderEvent)) } >> } >> } I would like to see a CompletizeExtenderEvent automatically generated at the places indicated above ... I think that this could be possible in the add-lyrics code defined at the end of scm/ly-syntax-constructors.scm. Any ideas how to change the code there? cu, Knut ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: music function to be included somewhere in scm/*
>> I second the vote for collapse-length. > > Ok, next try: > > s/minimum-length/length-limit-or-forced-length/g > > (length-limit-or-forced-length ,ly:dimension? "An automatically > generated lyric extender is suppressed if it would be shorter than > this length. A forced lyric extender is given this length if > possible.") Sorry, but I strongly dislike collapsing two properties into one, even if the values for the two properties are always the same. So please use `collapse-length' (`suppress-threshold', etc.) and `forced-length'. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: music function to be included somewhere in scm/*
Hi Werner! (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if possible.") Sorry, but I strongly dislike collapsing two properties into one, even if the values for the two properties are always the same. So please use `collapse-length' (`suppress-threshold', etc.) and `forced-length'. I'll implement whatever the majority agrees upon. Nevertheless: two parameters would obfuscate the fact that the internal logic would always decide to use only one of those lengths and to ignore the other. For the case of two parameters I like best: (forced-length ,ly:dimension? "A forced lyric extender is given this length if possible.") (collapse-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length.") Paul? cu, Knut ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: music function to be included somewhere in scm/*
> Nevertheless: two parameters would obfuscate the fact that the > internal logic would always decide to use only one of those lengths > and to ignore the other. You could add something like This parameter is mutually exclusive with @code{forced-length}. to make this more visible. > For the case of two parameters I like best: > > (forced-length ,ly:dimension? "A forced lyric extender > is given this length if possible.") > (collapse-length ,ly:dimension? "An automatically generated > lyric extender is suppressed if it would be shorter than > this length.") LGTM, thanks. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: music function to be included somewhere in scm/*
On Dec 20, 2016, at 08:23 , Werner LEMBERG wrote: > Sorry, but I strongly dislike collapsing two properties into one, even > if the values for the two properties are always the same. So please > use `collapse-length' (`suppress-threshold', etc.) and > `forced-length'. This is wise. — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: music function to be included somewhere in scm/*
Hi Knut, Werner, Alexander, and everyone, On 12/20/2016 08:47 AM, Knut Petersen wrote: Hi Werner! (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if possible.") Sorry, but I strongly dislike collapsing two properties into one, even if the values for the two properties are always the same. So please use `collapse-length' (`suppress-threshold', etc.) and `forced-length'. I'll implement whatever the majority agrees upon. Nevertheless: two parameters would obfuscate the fact that the internal logic would always decide to use only one of those lengths and to ignore the other. For the case of two parameters I like best: (forced-length ,ly:dimension? "A forced lyric extender is given this length if possible.") (collapse-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length.") Paul? I'm fine with using two properties, as Werner prefers, and as in this suggestion from Knut. When I suggested using fewer properties I didn't fully understand all the details. (The music I typeset rarely involves lyric extenders.) Alexander's explanation and further discussions have helped me get it, but I hadn't had a chance to reply sooner. Thanks again for working on this, -Paul ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
[PATCH] remove www from lilypond.org URL
Hi all I think that this is trivial enough that can skip the usual review. I was fixing the italian translation of macros.itexi when I noticed that we forgot to remove a www.lilypond.org link from the documentation (see commit 9580a231b3d3f912f46066009114a2929ecbb16a). The attached patch is based on current translation branch, because I've already fixed the italian file and pushed to translation. I've run make doc after the change to Documentation/it/macros.itexi and the result was ok. But I'm not confident at all with texinfo, so... >From 34bf6fe9584dc559125bb24aa9113baa872f8f97 Mon Sep 17 00:00:00 2001 From: Federico Bruni Date: Tue, 20 Dec 2016 16:33:58 +0100 Subject: [PATCH] Doc: remove www from lilypond.org URL I've used this command: git grep -l "@uref{http://@/www@/.lilypond@/.org/}"; | xargs sed -i "s|http://@/www@/.lilypond@/.org/|http://@/lilypond@/.org/|g" --- Documentation/ca/macros.itexi | 2 +- Documentation/cs/learning.tely | 2 +- Documentation/cs/macros.itexi | 2 +- Documentation/de/learning.tely | 2 +- Documentation/de/macros.itexi | 2 +- Documentation/es/macros.itexi | 2 +- Documentation/fr/macros.itexi | 2 +- Documentation/hu/macros.itexi | 2 +- Documentation/ja/macros.itexi | 2 +- Documentation/macros.itexi | 2 +- Documentation/nl/macros.itexi | 2 +- Documentation/zh/macros.itexi | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/ca/macros.itexi b/Documentation/ca/macros.itexi index 2fe43ab..2b09cf9 100644 --- a/Documentation/ca/macros.itexi +++ b/Documentation/ca/macros.itexi @@ -105,7 +105,7 @@ relaciona amb la resta de la documentació, o per llegir aquest manual en altres formats, consulteu @rweb{Manuals}. Si us falta algun manual, trobareu tota la documentació a -@w{@uref{http://@/www@/.lilypond@/.org/}}. +@w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro diff --git a/Documentation/cs/learning.tely b/Documentation/cs/learning.tely index a40230b..20470b3 100644 --- a/Documentation/cs/learning.tely +++ b/Documentation/cs/learning.tely @@ -67,7 +67,7 @@ se podÃvejte na @ref{O dokumentaci}. @cindex URL VÃce informacà lze najÃt na -@uref{http://@/www@/.lilypond@/.org/}. Na internetových stránkách +@uref{http://@/lilypond@/.org/}. Na internetových stránkách naleznete kopii tohoto a dalÅ¡Ãch souborů s dokumentacÃ. @end ignore diff --git a/Documentation/cs/macros.itexi b/Documentation/cs/macros.itexi index 85be1a1..7fc74f9 100644 --- a/Documentation/cs/macros.itexi +++ b/Documentation/cs/macros.itexi @@ -64,7 +64,7 @@ pÅÃruÄkami, nebo kvůli Ätenà této pÅÃruÄky v jiném formátu, navÅ¡tivte, prosÃm, @rweb{Manuals}. Pokud vám pÅÃruÄky chybÃ, naleznete celou dokumentaci -pod @w{@uref{http://@/www@/.lilypond@/.org/}}. +pod @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro diff --git a/Documentation/de/learning.tely b/Documentation/de/learning.tely index 30ff306..75d44d3 100644 --- a/Documentation/de/learning.tely +++ b/Documentation/de/learning.tely @@ -74,7 +74,7 @@ dieses Handbuchs siehe @ref{Ãber die Dokumentation}. @cindex URL Mehr Information unter -@uref{http://@/www@/.lilypond@/.org/}. Auf der Internetseite +@uref{http://@/lilypond@/.org/}. Auf der Internetseite finden sich Kopien dieser und anderer Dokumentationsdateien. @end ignore diff --git a/Documentation/de/macros.itexi b/Documentation/de/macros.itexi index df1a8c3..9ebcdc0 100644 --- a/Documentation/de/macros.itexi +++ b/Documentation/de/macros.itexi @@ -95,7 +95,7 @@ positioniert, oder um dieses Handbuch in einem anderen Format zu lesen, besuchen Sie bitte @rweb{Manuals}. Wenn Ihnen Handbücher fehlen, finden Sie die gesamte Dokumentation -unter @w{@uref{http://@/www@/.lilypond@/.org/}}. +unter @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro diff --git a/Documentation/es/macros.itexi b/Documentation/es/macros.itexi index eeba208..6b7cff2 100644 --- a/Documentation/es/macros.itexi +++ b/Documentation/es/macros.itexi @@ -104,7 +104,7 @@ con el resto de la documentación, o para leer este manual en otros formatos, consulte @rweb{Manuales}. Si le falta algún manual, encontrará toda la documentación en -@w{@uref{http://@/www@/.lilypond@/.org/}}. +@w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro diff --git a/Documentation/fr/macros.itexi b/Documentation/fr/macros.itexi index 31bb17f..76abecc 100644 --- a/Documentation/fr/macros.itexi +++ b/Documentation/fr/macros.itexi @@ -120,7 +120,7 @@ Pour connaître la place qu'occupe ce manuel dans la documentation, consultez la page @rweb{Manuels}. Si vous ne disposez pas de certains manuels, la documentation complète -se trouve sur @w{@uref{http://@/www@/.lilypond@/.org/}}. +se trouve sur @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro diff --git a/Documentation/hu/macros.itexi b/Documentation/hu/macros.itexi index 44c6191..bab4352 100644 --- a/Documentation/hu/
Re: [PATCH] remove www from lilypond.org URL
Suggest you start a review as normal, so that patchy can test that there's nothing broken. Providing that passes OK, push straight to staging. -- Phil Holmes - Original Message - From: "Federico Bruni" To: Sent: Tuesday, December 20, 2016 3:48 PM Subject: [PATCH] remove www from lilypond.org URL Hi all I think that this is trivial enough that can skip the usual review. I was fixing the italian translation of macros.itexi when I noticed that we forgot to remove a www.lilypond.org link from the documentation (see commit 9580a231b3d3f912f46066009114a2929ecbb16a). The attached patch is based on current translation branch, because I've already fixed the italian file and pushed to translation. I've run make doc after the change to Documentation/it/macros.itexi and the result was ok. But I'm not confident at all with texinfo, so... ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Doc: remove www from lilypond.org URL (issue 312190043 by fedel...@gmail.com)
Reviewers: , Message: I've not included the italian file, because it's already fixed in the translation branch. Description: Doc: remove www from lilypond.org URL I've used this command: git grep -l "@uref{http://@/www@/.lilypond@/.org/}"; | xargs sed -i "s|http://@/www@/.lilypond@/.org/|http://@/lilypond@/.org/|g" Please review this at https://codereview.appspot.com/312190043/ Affected files (+12, -12 lines): M Documentation/ca/macros.itexi M Documentation/cs/learning.tely M Documentation/cs/macros.itexi M Documentation/de/learning.tely M Documentation/de/macros.itexi M Documentation/es/macros.itexi M Documentation/fr/macros.itexi M Documentation/hu/macros.itexi M Documentation/ja/macros.itexi M Documentation/macros.itexi M Documentation/nl/macros.itexi M Documentation/zh/macros.itexi Index: Documentation/ca/macros.itexi diff --git a/Documentation/ca/macros.itexi b/Documentation/ca/macros.itexi index 2fe43ab603d58d0ce26fc7015e89021aff37be12..2b09cf9c67f4ab8e49237870032fb752ab7effdc 100644 --- a/Documentation/ca/macros.itexi +++ b/Documentation/ca/macros.itexi @@ -105,7 +105,7 @@ relaciona amb la resta de la documentació, o per llegir aquest manual en altres formats, consulteu @rweb{Manuals}. Si us falta algun manual, trobareu tota la documentació a -@w{@uref{http://@/www@/.lilypond@/.org/}}. +@w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro Index: Documentation/cs/learning.tely diff --git a/Documentation/cs/learning.tely b/Documentation/cs/learning.tely index a40230bf3675679521daa97298f23bf6f09014ad..20470b369c745c6232922232d953d74b315c7f4b 100644 --- a/Documentation/cs/learning.tely +++ b/Documentation/cs/learning.tely @@ -67,7 +67,7 @@ se podívejte na @ref{O dokumentaci}. @cindex URL Více informací lze najít na -@uref{http://@/www@/.lilypond@/.org/}. Na internetových stránkách +@uref{http://@/lilypond@/.org/}. Na internetových stránkách naleznete kopii tohoto a dalších souborů s dokumentací. @end ignore Index: Documentation/cs/macros.itexi diff --git a/Documentation/cs/macros.itexi b/Documentation/cs/macros.itexi index 85be1a1404e8eb14897eee3edc2d3b55b4234006..7fc74f92cfdc475974e5c08b7fafe4fd8e20387f 100644 --- a/Documentation/cs/macros.itexi +++ b/Documentation/cs/macros.itexi @@ -64,7 +64,7 @@ příručkami, nebo kvůli čtení této příručky v jiném formátu, navštivte, prosím, @rweb{Manuals}. Pokud vám příručky chybí, naleznete celou dokumentaci -pod @w{@uref{http://@/www@/.lilypond@/.org/}}. +pod @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro Index: Documentation/de/learning.tely diff --git a/Documentation/de/learning.tely b/Documentation/de/learning.tely index 30ff306960e3f831dc0895b9e098fe65f3d143d7..75d44d3bf139889c555958cb4717d119f2e08342 100644 --- a/Documentation/de/learning.tely +++ b/Documentation/de/learning.tely @@ -74,7 +74,7 @@ dieses Handbuchs siehe @ref{Über die Dokumentation}. @cindex URL Mehr Information unter -@uref{http://@/www@/.lilypond@/.org/}. Auf der Internetseite +@uref{http://@/lilypond@/.org/}. Auf der Internetseite finden sich Kopien dieser und anderer Dokumentationsdateien. @end ignore Index: Documentation/de/macros.itexi diff --git a/Documentation/de/macros.itexi b/Documentation/de/macros.itexi index df1a8c3f1c42074cd36daeee08cb7da3197474d3..9ebcdc02e501375279c9fddf70d195e7ea99e8ad 100644 --- a/Documentation/de/macros.itexi +++ b/Documentation/de/macros.itexi @@ -95,7 +95,7 @@ positioniert, oder um dieses Handbuch in einem anderen Format zu lesen, besuchen Sie bitte @rweb{Manuals}. Wenn Ihnen Handbücher fehlen, finden Sie die gesamte Dokumentation -unter @w{@uref{http://@/www@/.lilypond@/.org/}}. +unter @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro Index: Documentation/es/macros.itexi diff --git a/Documentation/es/macros.itexi b/Documentation/es/macros.itexi index eeba20876c565c8133921edddbf5ff4bd098d97f..6b7cff2d4bc8b6e8eb570a386cceda7eb8de8c87 100644 --- a/Documentation/es/macros.itexi +++ b/Documentation/es/macros.itexi @@ -104,7 +104,7 @@ con el resto de la documentación, o para leer este manual en otros formatos, consulte @rweb{Manuales}. Si le falta algún manual, encontrará toda la documentación en -@w{@uref{http://@/www@/.lilypond@/.org/}}. +@w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro Index: Documentation/fr/macros.itexi diff --git a/Documentation/fr/macros.itexi b/Documentation/fr/macros.itexi index 31bb17fe03190cfe4128373c6256e64af4255539..76abecce7ffd575fcbe838153c5b7d24a8278cd8 100644 --- a/Documentation/fr/macros.itexi +++ b/Documentation/fr/macros.itexi @@ -120,7 +120,7 @@ Pour connaître la place qu'occupe ce manuel dans la documentation, consultez la page @rweb{Manuels}. Si vous ne disposez pas de certains manuels, la documentation complète -se trouve sur @w{@uref{http://@/www@/.lilypond@/.org/}}. +se trouve sur @w{@uref{http://@/lilypond@/.org/}}. @end cartouche @end macro Index
Re: music function to be included somewhere in scm/*
On Tue, Dec 20, 2016 at 7:41 AM, Paul wrote: > Hi Knut, Werner, Alexander, and everyone, > > On 12/20/2016 08:47 AM, Knut Petersen wrote: > >> Hi Werner! >> >>> (length-limit-or-forced-length ,ly:dimension? "An automatically generated lyric extender is suppressed if it would be shorter than this length. A forced lyric extender is given this length if possible.") >>> Sorry, but I strongly dislike collapsing two properties into one, even >>> if the values for the two properties are always the same. So please >>> use `collapse-length' (`suppress-threshold', etc.) and >>> `forced-length'. >>> >> >> I'll implement whatever the majority agrees upon. >> >> Nevertheless: two parameters would obfuscate the fact that >> the internal logic would always decide to use only one of those >> lengths and to ignore the other. >> >> For the case of two parameters I like best: >> >> (forced-length ,ly:dimension? "A forced lyric extender >> is given this length if possible.") >> (collapse-length ,ly:dimension? "An automatically generated >> lyric extender is suppressed if it would be shorter than >> this length.") >> >> Paul? >> > > I'm fine with using two properties, as Werner prefers, and as in this > suggestion from Knut. > > When I suggested using fewer properties I didn't fully understand all the > details. (The music I typeset rarely involves lyric extenders.) > Alexander's explanation and further discussions have helped me get it, but > I hadn't had a chance to reply sooner. > > Thanks again for working on this, > Yes, thanks for making this possible! It will be a great addition. One question I have about having the two properties is how will the two be reconciled in actual use? In other words, if collapse-length is larger than forced-length, will there still be the same amount of space between syllables even without the extender (to the amount of forced-length)? Maybe the question I really have is this: what does "given this length _if possible_" mean and what governs this possibility? I can totally understand how they work individually, I'm just trying to understand how I can use them well together since it seems that forced-length contradicts collapse-length. Thanks, Abraham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Point to \resetRelativeOctave in NR 1.1.1.b (issue 312210043 by simon.albre...@mail.de)
Some nitpicks, otherwise LGTM https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely#newcode302 Documentation/notation/pitches.itely:302: done using \resetRelativeOctave: Change to: @code{\resetRelativeOctave} Add at appropriate place: @funindex \resetRelativeOctave https://codereview.appspot.com/312210043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel