Re: Document Kievan ligature engraver (issue 7382060)

2013-02-28 Thread Trevor Daniels

aleksandr.andreev wrote Wednesday, February 27, 2013 2:49 PM

> I think it makes sense to push this patch first and then I will upload
> another patch that changes the syntax across the manual. That way it is
> cleaner in the commit history.

Fine by me.
 
> There is also Issue 1287. I could try to work on improving the ancient
> notation chapter, though I am no expert in Gregorian chant.

That would be very welcome indeed!

Trevor
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: texinfo_document.po files encoding

2013-02-28 Thread Jean-Charles Malahieude

Le 28/02/2013 07:45, Federico Bruni disait :

I've received the texinfo_document.po file from the Translation Project.
While looking at other languages po files to understand what to
translate and what to leave untraslated, I've noticed some strange
characters. Probably because these files are saved as ASCII instead of
UTF-8?


$ file texinfo_document-5.0.fr.po
texinfo_document-5.0.fr.po: GNU gettext message catalogue, ASCII text

For example: Forme Sp@'eciale

http://translationproject.org/domain/texinfo_document.html



It is because the files are in US-ASCII and not in UTF-8.
I have to admit it has been a pain for me having to type "@'a" instead 
of just "à" or "@ " for a non breakable space like in the old times of 
LaTeX (or even lyrics in LilyPond 1.3.84).


I've got an old macro for Emacs that transformed html<->ASCII when LP's 
site was in full html, and should add all those new cases.


Sorry not to be so helpfull,
Jean-Charles


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Uses only unpure-pure containers to articulate unpure-pure relationships. (issue 7377046)

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 06:48, d...@gnu.org wrote:

> On 2013/02/27 23:00:48, mike7 wrote:
>> On 27 févr. 2013, at 19:06, mailto:d...@gnu.org wrote:
> 
>> >
>> >
> 
> https://codereview.appspot.com/7377046/diff/17001/input/regression/scheme-text-spanner.ly
>> > File input/regression/scheme-text-spanner.ly (right):
>> >
>> >
> 
> https://codereview.appspot.com/7377046/diff/17001/input/regression/scheme-text-spanner.ly#newcode129
>> > input/regression/scheme-text-spanner.ly:129:
>> > side-position-interface::y-aligned-side)
>> > I really don't understand why you ask on the developer list about
>> > gratuitous prefix changes because of a different implementation
> language
>> > when you propose such changes right afterwards.
>> >
> 
>> In my e-mail, I stated:
>> "I'd prefer if all native Scheme functions did not have the ly: prefix
> - it
>> helps to know what things are where."
> 
> So why do you ask when you ignore the answer?
> 
>> side-position-interface::y-aligned-side above is a native Scheme
> function that
>> does not have the ly: prefix.
> 
> You remove the prefix in this patch set.

Sorry, but I still don't understand what you mean.
ly:side-position-interface::y-aligned-side is defined in 
side-position-interface.cc
side-position-interface::y-aligned-side is defined in output-lib.scm
The function defined in C++ has the ly: prefix, whereas the function defined in 
Scheme doesn't.

> 
>> > https://codereview.appspot.com/7377046/diff/17001/lily/grob.cc
>> > File lily/grob.cc (right):
>> >
>> >
> https://codereview.appspot.com/7377046/diff/17001/lily/grob.cc#newcode866
>> > lily/grob.cc:866: if (to_boolean (scm_object_property
>> > (me->get_property_data ("stencil"), ly_symbol2scm ("ly:stencil?"
>> > Where is this object property being set?
> 
>> In define-grobs.scm.
> 
> I've looked very thoroughly without success.  I can't find a setting
> of the ly:stencil? object property in your patch set, and I can't find
> it in the current code base, either.
> 
> Care for a line number?

Ah, OK, I misunderstood your question.
In your reasking it, I now see (a) exactly what you mean; and (b) that I 
screwed up this test.  I fixed the test and posted a new patch set.

Cheers,
MS


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread Werner LEMBERG

> I think that at the current point of time, we should try getting
> along with a flat namespace approach.  That might imply renaming
> properties like "padding" to "side-padding" if we can't achieve
> reasonable results otherwise.  Not sure about that.

I support that.  Renaming properties which do something differently is
the way to go IMHO.


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org

On 28 févr. 2013, at 12:16, Werner LEMBERG  wrote:

> 
>> I think that at the current point of time, we should try getting
>> along with a flat namespace approach.  That might imply renaming
>> properties like "padding" to "side-padding" if we can't achieve
>> reasonable results otherwise.  Not sure about that.
> 
> I support that.  Renaming properties which do something differently is
> the way to go IMHO.
> 
> 

Then the first step is finding all properties that are defined in multiple 
interfaces and changing their names.  This'll be one heck of a convert-ly 
rule...

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread Werner LEMBERG

>> Renaming properties which do something differently is the way to go
>> IMHO.
> 
> Then the first step is finding all properties that are defined in
> multiple interfaces and changing their names.

Maybe a naïve question: Are there many?


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 12:40, Werner LEMBERG  wrote:

> 
>>> Renaming properties which do something differently is the way to go
>>> IMHO.
>> 
>> Then the first step is finding all properties that are defined in
>> multiple interfaces and changing their names.
> 
> Maybe a naïve question: Are there many?
> 


I'd guess between 10 and 20.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread David Kastrup
"m...@mikesolomon.org"  writes:

> On 28 févr. 2013, at 12:40, Werner LEMBERG  wrote:
>
>> 
 Renaming properties which do something differently is the way to go
 IMHO.
>>> 
>>> Then the first step is finding all properties that are defined in
>>> multiple interfaces and changing their names.
>> 
>> Maybe a naïve question: Are there many?
>> 
>
>
> I'd guess between 10 and 20.

One can probably boil the set actually causing conflicts down.

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org

On 28 févr. 2013, at 12:47, David Kastrup  wrote:

> "m...@mikesolomon.org"  writes:
> 
>> On 28 févr. 2013, at 12:40, Werner LEMBERG  wrote:
>> 
>>> 
> Renaming properties which do something differently is the way to go
> IMHO.
 
 Then the first step is finding all properties that are defined in
 multiple interfaces and changing their names.
>>> 
>>> Maybe a naïve question: Are there many?
>>> 
>> 
>> 
>> I'd guess between 10 and 20.
> 
> One can probably boil the set actually causing conflicts down.
> 

Absolutely, but the goal should be to eliminate this sort of thing entirely. 
Conflicts can easily be caused if people use different overrides than the 
habitual ones.

Cheers,
MS


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: texinfo_document.po files encoding

2013-02-28 Thread Federico Bruni
2013/2/28 Jean-Charles Malahieude 

> It is because the files are in US-ASCII and not in UTF-8.
> I have to admit it has been a pain for me having to type "@'a" instead of
> just "à" or "@ " for a non breakable space like in the old times of LaTeX
> (or even lyrics in LilyPond 1.3.84).
>

Do you mean they _have to_ be ASCII? It looks weird... why not using UTF-8?

The italian file is UTF-8, for example.
Why french and german are ASCII?
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: texinfo_document.po files encoding

2013-02-28 Thread Jean-Charles Malahieude

Le 28/02/2013 13:11, Federico Bruni disait :

2013/2/28 Jean-Charles Malahieude 


It is because the files are in US-ASCII and not in UTF-8.
I have to admit it has been a pain for me having to type "@'a" instead of
just "à" or "@ " for a non breakable space like in the old times of LaTeX
(or even lyrics in LilyPond 1.3.84).



Do you mean they _have to_ be ASCII? It looks weird... why not using UTF-8?

The italian file is UTF-8, for example.
Why french and german are ASCII?

As well as Norwegian, Portuguese (European and Brazilian), Spanish, 
which makes 6 out of 10 available languages.


I don't have any idea about this. Might be worth asking Patrice Dumas 
why only certain files are US-ASCII and other UTF-8, even if both 
languages do contain accented characters or ligatures.


Cheers,
Jean-Charles


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread n . puttock


https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly
File input/regression/repeat-slur.ly (right):

https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly#newcode14
input/regression/repeat-slur.ly:14: \alternative { { a' ) b' \set
breakSlurAtBarLine = ##t c' ( d' }
Can't you use 'to-barline for this?

https://codereview.appspot.com/7424049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 21:30, n.putt...@gmail.com wrote:

> 
> https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly
> File input/regression/repeat-slur.ly (right):
> 
> https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly#newcode14
> input/regression/repeat-slur.ly:14: \alternative { { a' ) b' \set
> breakSlurAtBarLine = ##t c' ( d' }
> Can't you use 'to-barline for this?
> 
> https://codereview.appspot.com/7424049/
> 


You're right, but I've opted for the breaking behavior in the most recent 
patch-set (\breakSlurHere).  Otherwise, slurs wouldn't be able to span only one 
musical moment.

We miss you!  Come back!

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread Neil Puttock
On Feb 28, 2013 8:37 PM, "m...@mikesolomon.org" 
wrote:

> You're right, but I've opted for the breaking behavior in the most recent
patch-set (\breakSlurHere).  Otherwise, slurs wouldn't be able to span only
one musical moment.

Ok, so how about using an event of class break-span-event (like
\breakDynamicSpan)?

> We miss you!  Come back!

Thanks. :-)

I can feel the itch returning, but really need to get a laptop first unless
I can commandeer our new iMac when it arrives next month and work out how
to do things iOS fashion.

Cheers,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread m...@mikesolomon.org

On 28 févr. 2013, at 22:29, Neil Puttock  wrote:

> 
> On Feb 28, 2013 8:37 PM, "m...@mikesolomon.org"  wrote:
> 
> > You're right, but I've opted for the breaking behavior in the most recent 
> > patch-set (\breakSlurHere).  Otherwise, slurs wouldn't be able to span only 
> > one musical moment.
> 
> Ok, so how about using an event of class break-span-event (like 
> \breakDynamicSpan)?
> 
> 

Brilliant!  Done.

> > We miss you!  Come back!
> 
> Thanks. :-)
> 
> I can feel the itch returning, but really need to get a laptop first unless I 
> can commandeer our new iMac when it arrives next month and work out how to do 
> things iOS fashion.
> 
> 

Good deal.  I'm a Mac user but I do all my development in a virtual box to keep 
from messing up my OS.

Looking forward to more of your contributions and reviews!

Cheers,
MS

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Fwd: 2.17.13 fails to build with texinfo 5.0 installed (texinfo 4.13 works)

2013-02-28 Thread Colin Hall

Please see the report from Hanspeter, below, about a problem building
Lilypond.

Cheers,
Colin.

Hanspeter Niederstrasser writes:

> When texinfo 5.0 is installed, the build fails with this error:
>
> 
> /sw/build.build/lilypond-devel-2.17.13-1/lilypond-2.17.13/scripts/build/out/
> run-and-check "LANG= makeinfo --enable-encoding --error-limit=0 -I /sw/build.
> build/lilypond-devel-2.17.13-1/lilypond-2.17.13/Documentation -I. -I./out --
> output=out/lilypond-usage.info out/usage.texi"  "usage.makeinfo.log"
>
> Please check the logfile usage.makeinfo.log for errors
> 
>
> Documentation/usage.makeinfo.log contains the following:
> ***START***
> out/common-macros.texi:190: warning: @end ifset should only appear at a line 
> beginning
> out/usage/running.texi:31: warning: @vindex should only appear at a line 
> beginning (possibly involving @rlearning)
> out/usage/running.texi:48: warning: @vindex should only appear at a line 
> beginning (possibly involving @rweb)
> out/usage/running.texi:952: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> out/usage/running.texi:956: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> out/usage/running.texi:1125: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> out/usage/lilypond-book.texi:32: warning: @vindex should only appear at a 
> line beginning (possibly involving @rweb)
> out/usage/lilypond-book.texi:32: warning: @vindex should only appear at a 
> line beginning (possibly involving @rweb)
> out/usage/lilypond-book.texi:1177: @itemx must follow @item
> out/usage/lilypond-book.texi:1181: @itemx must follow @item
> out/usage/lilypond-book.texi:1185: @itemx must follow @item
> out/usage/lilypond-book.texi:1190: @itemx must follow @item
> out/usage/lilypond-book.texi:1199: @itemx must follow @item
> out/usage/lilypond-book.texi:1203: @itemx must follow @item
> out/usage/lilypond-book.texi:1208: @itemx must follow @item
> out/usage/lilypond-book.texi:1231: @itemx must follow @item
> out/usage/external.texi:274: warning: @vindex should only appear at a line 
> beginning (possibly involving @rweb)
> out/usage/external.texi:323: warning: @vindex should only appear at a line 
> beginning (possibly involving @rinternals)
> out/usage/external.texi:324: warning: @vindex should only appear at a line 
> beginning (possibly involving @rinternals)
> out/usage/external.texi:587: warning: @vindex should only appear at a line 
> beginning (possibly involving @rweb)
> out/usage/external.texi:607: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> out/usage/suggestions.texi:68: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> out/usage/suggestions.texi:119: warning: @vindex should only appear at a line 
> beginning (possibly involving @ruser)
> ***END***
>
> As mentioned in the summary, if texinfo is downgraded to 4.13, the build
> succeeds.  Issues 1000 and 1557 are possibly related but they deal with
> texi2html 5.0 and not texinfo.
>
> Other possibly relevant software installed:
>
> texi2html: 1.82
> dblatex: 0.2.12
> texlive: 20110705
>
>
>
> ___
> bug-lilypond mailing list
> bug-lilyp...@gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-lilypond


-- 
Colin Hall

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.17.13 fails to build with texinfo 5.0 installed (texinfo 4.13 works)

2013-02-28 Thread James
Hello,

On 28 February 2013 22:13, Colin Hall  wrote:

>
> Please see the report from Hanspeter, below, about a problem building
> Lilypond.
>
> Cheers,
> Colin.
>
> Hanspeter Niederstrasser writes:
>
> > When texinfo 5.0 is installed, the build fails with this error:
> >
> > 
> #
>

See this thread

http://lists.gnu.org/archive/html/lilypond-devel/2012-11/msg00268.html

James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread lemzwerg

Very nice, and thanks a lot!  From visual inspection only, LGTM.

Just curious: You apparently like the word `junk', however, I find it
not optimal.  Can you replace this with `discard' or `cut' within the
command names?



https://codereview.appspot.com/7424049/diff/3002/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/7424049/diff/3002/scm/define-music-types.scm#newcode122
scm/define-music-types.scm:122: . ((description . "End a slur here.")
-> "End a phrasing slur here."

https://codereview.appspot.com/7424049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: changes.tely: deal with \transposition and instrumentTransposition changes (issue 7404046)

2013-02-28 Thread graham

LGTM

https://codereview.appspot.com/7404046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Document Kievan ligature engraver (issue 7382060)

2013-02-28 Thread graham

LGTM

https://codereview.appspot.com/7382060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


segfault when making grob in scheme engraver

2013-02-28 Thread rekado rekado
Hi list,

Attached is a minimal score containing a scheme engraver that adds a
grob in the `stop-translation-timestep` function. This results in a
segfault when the score is to be rendered.

I'm using Lilypond 2.16.1.


segfault.ly
Description: Binary data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread lemzwerg

Much better, thanks!

https://codereview.appspot.com/7424049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel