Re: first instance of lyrics in LM could look better
2008/11/7 Trevor Daniels <[EMAIL PROTECTED]>: > so, as \addlyrics is the principal > technique introduced in the Learning Manual, I'll change it > as you suggest. I've seen it. Why to omit hyphenation such as twin -- kle etc? -- Francisco Vila. Badajoz (Spain) http://www.paconet.org ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: first instance of lyrics in LM could look better
Francisco Vila wrote Saturday, November 08, 2008 10:50 AM 2008/11/7 Trevor Daniels <[EMAIL PROTECTED]>: so, as \addlyrics is the principal technique introduced in the Learning Manual, I'll change it as you suggest. I've seen it. Why to omit hyphenation such as twin -- kle etc? I didn't leave out the hyphenation deliberately - it wasn't in the original nor in Mark's suggestion, and I simply hadn't noticed. Hyphenation makes little visual difference in this simple example, but I suppose it should be included for correctness. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
systemSeparatorMarkup in paper block
A few times ago, "printallheaders" has been renamed in "print-all-headers". By the same way, should not be "systemSeparatorMarkup" renamed in "system-separator-markup" ? Gilles ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: * Allow for nested contexts of any depth.
On Fri, Nov 7, 2008 at 9:10 PM, <[EMAIL PROTECTED]> wrote: >> http://codereview.appspot.com/7261/diff/1/2 >> File lily/context-def.cc (right): >> >> http://codereview.appspot.com/7261/diff/1/2#newcode215 >> Line 215: seen = new set (); >> Can you make a wrapper function that does >> >> set<..> seen; >> path_to (.. , &seen) >> >> instead? > > I've tried, but I'm completely stumped. :) > > I barely understand how this works, so I'm a bit out of my depth > unfortunately. > > Are you suggesting a recursive call? No, this call is already recursive; I suggest creating another function which allocates the set<> and does the outer call of the recursive function. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCHES] Re: Remarks about the building process
2008/11/5 John Mandereau <[EMAIL PROTECTED]>:
>
> See also the other attached patch.
>
+#define EPSNULL 1e-12
static void
print_buildings (list const &b)
@@ -215,6 +216,9 @@ Skyline::internal_merge_skyline (list
*s1, list *s2,
if (end >= s1->front ().end_)
s1->pop_front ();
+ if (abs (end - x) < EPSNULL)
+ break;
+
this looks fishy. Why another EPS value? Joe?
if (ties_conf
&& ties_conf->size () == 1)
+do
{
this looks like a serious bug, if we forgot the do for the while();
Can you check if you can make a regtest case?
+ if ((where
+ && current_reps == SCM_EOL) || scm_is_pair (current_reps))
{
current_reps = scm_cons (what, current_reps);
where->set_property (reps, current_reps);
this is wrong. In your version, where can be NULL if current_reps is
a pair, which lead to a crash. Please double check all of the changes
that may seem cosmetic.
--
Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
* Fix DynamicTextSpanner left alignment.
Reviewers: Neil Puttock, Description: * Fix DynamicTextSpanner left alignment. When a DynamicTextSpanner follows a DynamicScript, padding is required to ensure the 'left 'text doesn't collide with the dynamic sign. Unfortunately, this default value skews the spanner's left bound to the right when no dynamic script is present. This patch caters for both situations by resetting 'left 'padding as required, adding extra padding read from the script property 'right-padding. Additionally, two minor changes have been made to 'bound-details: - vertical alignment for the left stencil is improved by using 'stencil-align-dir-y instead of 'stencil-offset; - some padding is inserted between the stencil and the line, matching the right bound. Please review this at http://codereview.appspot.com/7763 Affected files: A input/regression/dynamics-text-left-text-alignment.ly M input/regression/dynamics-text-spanner-abs-dynamic.ly M lily/new-dynamic-engraver.cc M lily/script-interface.cc M scm/define-grobs.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCHES] Re: Remarks about the building process
On Sat, 2008-11-08 at 16:59 -0200, Han-Wen Nienhuys wrote: > 2008/11/5 John Mandereau <[EMAIL PROTECTED]>: > > > > > See also the other attached patch. > > > > > +#define EPSNULL 1e-12 > > static void > print_buildings (list const &b) > @@ -215,6 +216,9 @@ Skyline::internal_merge_skyline (list > *s1, list *s2, >if (end >= s1->front ().end_) > s1->pop_front (); > > + if (abs (end - x) < EPSNULL) > + break; > + > > this looks fishy. Why another EPS value? Joe? Is this some leftover code from our 80-bit floating point days? It doesn't look right to me, but it looks identical to this patch from May: http://www.nabble.com/Infinite-loop-with-GCC-4.3-td17303650.html Joe ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
