Re: Perl's Win32::API on MSYS

2013-10-02 Thread Aldo Calpini 

On 10/02/2013 08:37 AM, bulk 88 wrote:

The commit looks very broken. var $dlib becomes an undeclared  global. I did 
test Win32::API with
Visual C Perl 5.6 with



also, defined(&SUPER::cflags) is SUPER::broken :-)

a better approach could be:

  my $dlib = eval {$self->SUPER::cflags(@_) };
  # eventually warn or do something different if $@

this way $dlib either contains the correct cflags or is left undefined.

cheers,
Aldo

Re: Perl's Win32::API on MSYS

2013-10-02 Thread Sebastian Schuberth 
On Wed, Oct 2, 2013 at 8:37 AM, bulk 88  wrote:

>> can anyone have a look at this pull request
>> from Sebastian for Win32::API?
>>
>> It is about cygwin support AFAICS.

It's not about Cygwin support, but MSYS support.

> The commit looks very broken. var $dlib becomes an undeclared  global. I did 
> test Win32::API with
> Visual C Perl 5.6 with

I know, the commit is broken indeed, which is why I marked it as
"work-in-progress" and "not ready to be merged" ;-)

> How old is the MakeMaker your Msys Perl is using? What compiler and what 
> version was Msys Perl
>  made with? Its GCC something probably but what version?

MSYS Perl currently ships with MakeMaker 6.30, GCC 3.4.4 and Perl 5.8.8.

-- 
Sebastian Schuberth

Re: Perl's Win32::API on MSYS

2013-10-02 Thread Sebastian Schuberth 
On Wed, Oct 2, 2013 at 10:02 AM, Aldo Calpini  wrote:

> a better approach could be:
>
>   my $dlib = eval {$self->SUPER::cflags(@_) };
>   # eventually warn or do something different if $@

I've updated my pull request with this approch, please see:

https://github.com/cosimo/perl5-win32-api/pull/10/commits

Also, I've added a commit that fixes a bug in substr length calculation.

-- 
Sebastian Schuberth