Re: [PATCH 2/6] maint: consolidate Introductions of README and README.alpha.
Hi Gary, * Gary V. Vaughan wrote on Sun, Sep 19, 2010 at 04:49:34AM CEST: > In due course, I'd rather try to encourage people to install > autobuild, and submit results there, than waste time maintaining a > parallel list in PLATFORMS manually. But I won't have time to get to > that for a while, nor is it urgent while our autobuild support in the > libtool tree is still incomplete. I agree that autobuild should not be optional. I think a good idea is to let bootstrap install autobuild.m4 (from gnulib, once you've converted it that way). I'll try to finish the mode setting patch by then. Cheers, Ralf
Re: [PATCH 2/6] maint: consolidate Introductions of README and README.alpha.
On 19 Sep 2010, at 14:34, Ralf Wildenhues wrote: > Hi Gary, Hallo Ralf, > * Gary V. Vaughan wrote on Sun, Sep 19, 2010 at 04:49:34AM CEST: >> In due course, I'd rather try to encourage people to install >> autobuild, and submit results there, than waste time maintaining a >> parallel list in PLATFORMS manually. But I won't have time to get to >> that for a while, nor is it urgent while our autobuild support in the >> libtool tree is still incomplete. > > I agree that autobuild should not be optional. I think a good idea is > to let bootstrap install autobuild.m4 (from gnulib, once you've > converted it that way). That patch is done already, although it is later in the queue than the bootstrap import from gnulib, which I'm almost done rewriting. However, the queue is becoming rather long, so I'll drip feed the patches to the list starting right after the release, to leave me with the flexiblity to edit and rebase the remainder as we progress. > I'll try to finish the mode setting patch by then. Cool. Thanks =)O| Cheers, -- Gary V. Vaughan (g...@gnu.org) PGP.sig Description: This is a digitally signed message part
[PATCH] tests: Import items from liba1 for MSVC.
Hi!
tests/lt_dlexit.at turned out to be trival to fix for MSVC.
Ok to push? No rush for the release though, it's only the
testsuite...
Cheers,
Peter
>From f05840852938b904ac81502f7162e19525206f59 Mon Sep 17 00:00:00 2001
From: Peter Rosin
Date: Sun, 19 Sep 2010 14:14:21 +0200
Subject: [PATCH] tests: Import items from liba1 for MSVC.
* tests/lt_dlexit.at (b1.c) [MSVC]: Import function f1 and
variable v1 from liba1 when using them from modb1. Makes the
test pass on MSVC.
Signed-off-by: Peter Rosin
---
ChangeLog |7 +++
tests/lt_dlexit.at | 11 +--
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 946f8d7..78d3e48 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-09-19 Peter Rosin
+
+ tests: Import items from liba1 for MSVC.
+ * tests/lt_dlexit.at (b1.c) [MSVC]: Import function f1 and
+ variable v1 from liba1 when using them from modb1. Makes the
+ test pass on MSVC.
+
2010-09-18 Ralf Wildenhues
tests: avoid distcheck failure with --disable-ltdl-install.
diff --git a/tests/lt_dlexit.at b/tests/lt_dlexit.at
index 8d0b728..c80c1eb 100644
--- a/tests/lt_dlexit.at
+++ b/tests/lt_dlexit.at
@@ -1,6 +1,6 @@
# lt_dlexit.at -- test libltdl functionality -*- Autotest -*-
#
-# Copyright (C) 2007, 2008 Free Software Foundation, Inc.
+# Copyright (C) 2007, 2008, 2010 Free Software Foundation, Inc.
# Written by Dave Brolley & Ralf Wildenhues, 2007
#
# This file is part of GNU Libtool.
@@ -117,7 +117,14 @@ AT_DATA([b1.c],
[[#ifdef __cplusplus
extern "C" {
#endif
-extern int f1 (int), v1;
+#if defined DLL_EXPORT && defined _WIN32 && defined _MSC_VER
+# define LIBA1_SCOPE extern __declspec (dllimport)
+#endif
+#if !defined LIBA1_SCOPE
+# define LIBA1_SCOPE extern
+#endif
+LIBA1_SCOPE int f1 (int);
+LIBA1_SCOPE v1;
int fb1 (int x) { return f1 (v1) + x - 3; }
int vb1 = 3;
#ifdef __cplusplus
--
1.7.1
Re: [PATCH] tests: Import items from liba1 for MSVC.
Hi Peter, * Peter Rosin wrote on Sun, Sep 19, 2010 at 04:05:06PM CEST: > tests/lt_dlexit.at turned out to be trival to fix for MSVC. > Ok to push? No rush for the release though, it's only the > testsuite... Okay if the test still passes with GCC on Cygwin and MinGW. Thanks! Ralf > Subject: [PATCH] tests: Import items from liba1 for MSVC. > > * tests/lt_dlexit.at (b1.c) [MSVC]: Import function f1 and > variable v1 from liba1 when using them from modb1. Makes the > test pass on MSVC.
Re: [PATCH] tests: Import items from liba1 for MSVC.
Hi Ralf, Den 2010-09-19 16:16 skrev Ralf Wildenhues: > * Peter Rosin wrote on Sun, Sep 19, 2010 at 04:05:06PM CEST: >> tests/lt_dlexit.at turned out to be trival to fix for MSVC. >> Ok to push? No rush for the release though, it's only the >> testsuite... > > Okay if the test still passes with GCC on Cygwin and MinGW. It does. Pushed, and thanks! Cheers, Peter
