Fix ltmain.sh
I'm a contributor to GNU Libtool, and proud of it! Please find attached a patch fixing a critical bug. Don't forget to credit me in THANKS ;) 0001-Fix-copyright-notice.patch Description: Binary data
Avoid accidental disastrous space cleanups
I have been bitten by this :( 0001-Beware-of-editor-white-space-cleanups.patch Description: Binary data
Re: Fix ltmain.sh
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Akim Demaille on 12/19/2008 3:47 AM:
> I'm a contributor to GNU Libtool, and proud of it!
Indeed, with copyright assignment since 2001!
> Please find attached
> a patch fixing a critical bug.
Can you convince your mailer to send patches with a text MIME type,
instead of application/octet-stream? It makes reviewing a lot easier when
patches can be read inline, instead of having to save them off to another
file.
> Don't forget to credit me in THANKS ;)
You are already there ;)
At any rate, this patch looks sensible, except that while we are adjusting
the line, we might as well wrap to fit in 80 columns. And we need a
ChangeLog entry. I'm pushing this:
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAklLnT0ACgkQ84KuGfSFAYAo/QCgiW1fexO8gShA7IRA3ANH+f18
rhoAniE5mBflzJdrx6y+lzJJOK3Zndfh
=FeoZ
-END PGP SIGNATURE-
>From 756f95dd608704d2327929412a9a023ca822a079 Mon Sep 17 00:00:00 2001
From: Akim Demaille
Date: Fri, 19 Dec 2008 11:45:05 +0100
Subject: [PATCH] Fix copyright notice.
* libltdl/config/ltmain.m4sh: Add missing comma.
Signed-off-by: Eric Blake
---
ChangeLog |5 +
libltdl/config/ltmain.m4sh |5 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ce3b324..65eef10 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-12-19 Akim Demaille
+
+ Fix copyright notice.
+* libltdl/config/ltmain.m4sh: Add missing comma.
+
2008-12-17 Ralf Wildenhues
Add cache variables to link tests.
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 2769149..20ca07b 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -4,7 +4,8 @@ m4_divert_push([SCRIPT])# @configure_input@
# libtool (GNU @PACKAGE@@TIMESTAMP@) @VERSION@
# Written by Gordon Matzigkeit , 1996
-# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006,
2007 2008 Free Software Foundation, Inc.
+# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005,
+# 2006, 2007, 2008 Free Software Foundation, Inc.
# This is free software; see the source for copying conditions. There is NO
# warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
@@ -455,7 +456,7 @@ $opt_help || {
# determined imposters.
func_lalib_p ()
{
-test -f "$1" &&
+test -f "$1" &&
$SED -e 4q "$1" 2>/dev/null \
| $GREP "^# Generated by .*$PACKAGE" > /dev/null 2>&1
}
--
1.6.0.4
Re: Avoid accidental disastrous space cleanups
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Akim Demaille on 12/19/2008 5:08 AM: > I have been bitten by this :( So has autoconf, which is why all m4sugar scripts currently start with the shorter: IFS=" ""$as_nl" Which makes me wonder - do we even need this patch, or is it sufficient to entirely delete libtool's IFS initialization in favor of m4sugar's, thanks to Paolo's recent cleanups to use m4sugar as documented? - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAklLoSEACgkQ84KuGfSFAYBFpACeMe4+YwoXImZuDLLtsyMkxkyy xGoAoK0rT/yqomsxLpKkqYFMtZEy7WMS =hGph -END PGP SIGNATURE-
Re: Fix ltmain.sh
Le 19 déc. 08 à 14:10, Eric Blake a écrit : Please find attached a patch fixing a critical bug. Can you convince your mailer to send patches with a text MIME type, instead of application/octet-stream? It makes reviewing a lot easier when patches can be read inline, instead of having to save them off to another file. I think I'll have to rename them as *.txt to this end. Will do, sorry. Don't forget to credit me in THANKS ;) You are already there ;) At any rate, this patch looks sensible, except that while we are adjusting the line, we might as well wrap to fit in 80 columns. Bummer, I really hesitated but decided against since it was obviously not done before :( My first patch in year is a miserable failure : ( I should go back hacking on Windows, that all I'm worth doing today :(
Re: Avoid accidental disastrous space cleanups
Hello Eric, Akim, * Eric Blake wrote on Fri, Dec 19, 2008 at 02:26:57PM CET: > According to Akim Demaille on 12/19/2008 5:08 AM: > > I have been bitten by this :( > > So has autoconf, which is why all m4sugar scripts currently start with the > shorter: > > IFS=" "" $as_nl" > > Which makes me wonder - do we even need this patch, or is it sufficient to > entirely delete libtool's IFS initialization in favor of m4sugar's, thanks > to Paolo's recent cleanups to use m4sugar as documented? Libtool aims and needs to work with Autoconf 2.59. So much for "recent". And no, this requirement won't change for a while. As to over-eager editors: please turn those automatisms off. Now that we have git, history is a lot easier to search, but still I would like cleanup patches to be separate from functional patches, please. Of course not introducing new issues to clean up is a good thing. Thanks, Ralf
Re: Fix ltmain.sh
Den 2008-12-19 14:10 skrev Eric Blake: *snipped* > + Fix copyright notice. > +* libltdl/config/ltmain.m4sh: Add missing comma. Oooaa, excellent (and while we are all nitpicking), a whitespace cleanup patch that adds whitespace mistakes (should be a tab before the asterisk)... Cheers, Peter
Re: Fix ltmain.sh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Peter Rosin on 12/19/2008 6:45 AM: > Den 2008-12-19 14:10 skrev Eric Blake: > *snipped* > >> +Fix copyright notice. >> +* libltdl/config/ltmain.m4sh: Add missing comma. > > Oooaa, excellent (and while we are all nitpicking), a whitespace > cleanup patch that adds whitespace mistakes (should be a tab > before the asterisk)... Blah. So much for me copying and pasting from the terminal's 'git log' display into my editor. Now fixed. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAklLpqMACgkQ84KuGfSFAYASzACbBJCIeOvZEfqoe0YJxrfT3CV5 NHMAnj2UHr5/qkzUGp6GXHlC3M3EGJ7H =svbX -END PGP SIGNATURE-
