Re: [RFC] any critical patches for a release this weekend?

2014-10-24 Thread Nick Bowler
On 2014-10-23 20:10 +0100, Gary V. Vaughan wrote:
> I plan to roll a release based off the v2.4.2 tag, incorporating fixes
> for version mismatches against Mac OS Yosemite this weekend - in
> consideration of the fact that there are still known regressions in
> master.
> 
> If there's anything else I should include, or suggestions for a better
> revision to base the release from, please reply ASAP :-)

Would be nice to see da30ce4dc955 ("libtool: speed up ltwrapper_script
detection in execute mode")[1] in a release.

[1] 
http://git.savannah.gnu.org/cgit/libtool.git/commit/?id=da30ce4dc9554c80f1931600af2b8bbab486476e

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)

___
https://lists.gnu.org/mailman/listinfo/libtool


Re: [RFC] any critical patches for a release this weekend?

2014-10-24 Thread Richard PALO
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le 23/10/14 21:10, Gary V. Vaughan a écrit :
> I plan to roll a release based off the v2.4.2 tag, incorporating
> fixes for version mismatches against Mac OS Yosemite this weekend -
> in consideration of the fact that there are still known regressions
> in master.
> 
> If there's anything else I should include, or suggestions for a
> better revision to base the release from, please reply ASAP :-)
> 
> Cheers,
> 

I'd like to see two patches committed:

1. the attached SunOS g++ shared library patch, in pkgsrc, has been
tested and running in production here since over half a year, and I
understand Joyent is using it in their local branch.

2 I vote that the '-fstack-protector*' patch be committed as well
(attached). This has been somewhat discussed in the thread labelled
(and notably dating from 02/06/2010):
> Re: Bug: linking shared libraries on Cygwin results in undefined 
> references to __stack_chck_guard for code compiled with
> -fstack-protector
In particular, passing through '-fstack-protector*' is where n°1
really makes a difference.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJUSx9XAAoJECAB22fHtp27CUcH/3zuStnYT+lR9IiUlGPS7mjN
l1+OIjA5CwvxNwbHrjSAJbbWAupmLeplQsYpQL3Fsz3gNX7ljjaPCziRX/tHXOHW
XCorR3ewFNU1D4TIiHqV045pRq6TuNIcnVsMPkfJvGBCwJqMm2FOetrukDnplSAW
VeUHduPUT3PTpBLsWRrVyyV8u7gAEjudUI1NFEFlVOS9sQDS19NivWiXRWABHM1g
XkenuitcAE3PxQiHiG6TaYeQGtivtYT23stx8vrpTeagg8YBl6GhKeqo8q5yZdvH
X2qjmkJ04ZtY1OuD6s/fn/o5q9XlFSBdUSpi9CpOMLQHKjBcnbMhtgC2MZXbkHE=
=ugbL
-END PGP SIGNATURE-
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 900b172..7b99402 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -6860,9 +6860,9 @@ if test yes != "$_lt_caught_CXX_error"; then
 	if test yes,no = "$GXX,$with_gnu_ld"; then
 	  _LT_TAGVAR(no_undefined_flag, $1)=' $wl-z ${wl}defs'
 	  if $CC --version | $GREP -v '^2\.7' > /dev/null; then
-	_LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag -nostdlib $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags $wl-h $wl$soname -o $lib'
+	_LT_TAGVAR(archive_cmds, $1)='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-h $wl$soname -o $lib'
 	_LT_TAGVAR(archive_expsym_cmds, $1)='echo "{ global:" > $lib.exp~cat $export_symbols | $SED -e "s/\(.*\)/\1;/" >> $lib.exp~echo "local: *; };" >> $lib.exp~
-  $CC -shared $pic_flag -nostdlib $wl-M $wl$lib.exp $wl-h $wl$soname -o $lib $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags~$RM $lib.exp'
+  $CC -shared $pic_flag $wl-M $wl$lib.exp $wl-h $wl$soname -o $lib $libobjs $deplibs $compiler_flags~$RM $lib.exp'
 
 	# Commands to make compiler produce verbose output that lists
 	# what "hidden" libraries, object files and flags are used when
@@ -6871,9 +6871,9 @@ if test yes != "$_lt_caught_CXX_error"; then
 	  else
 	# g++ 2.7 appears to require '-G' NOT '-shared' on this
 	# platform.
-	_LT_TAGVAR(archive_cmds, $1)='$CC -G -nostdlib $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags $wl-h $wl$soname -o $lib'
+	_LT_TAGVAR(archive_cmds, $1)='$CC -G $libobjs $deplibs $compiler_flags $wl-h $wl$soname -o $lib'
 	_LT_TAGVAR(archive_expsym_cmds, $1)='echo "{ global:" > $lib.exp~cat $export_symbols | $SED -e "s/\(.*\)/\1;/" >> $lib.exp~echo "local: *; };" >> $lib.exp~
-  $CC -G -nostdlib $wl-M $wl$lib.exp $wl-h $wl$soname -o $lib $predep_objects $libobjs $deplibs $postdep_objects $compiler_flags~$RM $lib.exp'
+  $CC -G $wl-M $wl$lib.exp $wl-h $wl$soname -o $lib $libobjs $deplibs $compiler_flags~$RM $lib.exp'
 
 	# Commands to make compiler produce verbose output that lists
 	# what "hidden" libraries, object files and flags are used when
--- Begin Message ---
On Sat, 15 May 2010 09:07:49 +0200
Bart Van Assche  wrote:
> This behavior has been observed with libtool version 2.2.6.

Bug confirmed.  When code is compiled with -fstack-protector{,-all},
GCC "emits extra code to check for buffer overflows, such as stack
smashing attacks".  This extra code uses symbols from libssp, and
therefore (at least) Cygwin's GCC specs contain:

*link_ssp:
%{fstack-protector|fstack-protector-all:-lssp_nonshared -lssp}

Therefore, when libtool fails to pass -fstack-protector{,-all} at link
stage, the link fails.

Patch attached.  (Yes, I have a copyright assignment on file.)


Yaakov
Cygwin/X
>From b79f4e117b6f73cc461a2e232063e08481d33300 Mon Sep 17 00:00:00 2001
From: Yaakov Selkowitz 
Date: Tue, 1 Jun 2010 22:18:51 -0500
Subject: [PATCH] Fix linking with -fstack-protector

* libltdl/config/ltmain.m4sh (func_mode_link): Pass -fstack-protector*
to the linker as it is required at link time to resolve libssp symbols.

Signed-off-by: Yaakov Selkowitz 
---
 libltdl/config/ltmain.m4sh |4 +++-
 1 files changed, 3 inserti